[I] [Python]change "class_" suffix to "type_" in metashare [fury]

2025-06-03 Thread via GitHub
urlyy opened a new issue, #2289: URL: https://github.com/apache/fury/issues/2289 ### Feature Request _No response_ ### Is your feature request related to a problem? Please describe _No response_ ### Describe the solution you'd like _No response_ ### D

Re: [PR] feat(python): support xlang metashare (WIP) [fury]

2025-06-03 Thread via GitHub
urlyy commented on PR #2278: URL: https://github.com/apache/fury/pull/2278#issuecomment-2934316097 > It would be great if we could change all class_ prefix to type_, like class_info -> type_info, class_resolver -> type_resolver. This will make the code more clean. How about opening another

Re: [PR] feat(java): add log downgrade configuration [fury]

2025-06-03 Thread via GitHub
ZhiQiang-Tiger closed pull request #2284: feat(java): add log downgrade configuration URL: https://github.com/apache/fury/pull/2284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] feat(python): support xlang metashare (WIP) [fury]

2025-06-03 Thread via GitHub
chaokunyang commented on PR #2278: URL: https://github.com/apache/fury/pull/2278#issuecomment-2934175550 It would be great if we could change all class_ prefix to type_, like class_info -> type_info, class_resolver -> type_resolver. This will make the code more clean. How about opening anot

Re: [PR] feat(python): support xlang metashare (WIP) [fury]

2025-06-03 Thread via GitHub
chaokunyang commented on code in PR #2278: URL: https://github.com/apache/fury/pull/2278#discussion_r2123150501 ## python/pyfory/meta/meta_share.py: ## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] fix(java): raise exception when registering invalid serializer for Map/List [fury]

2025-06-03 Thread via GitHub
chaokunyang commented on PR #2271: URL: https://github.com/apache/fury/pull/2271#issuecomment-2934126934 @OmCheeLin Please don't remove .idea directory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[PR] feat(java): add log downgrade configurationFeature/log level [fury]

2025-06-03 Thread via GitHub
ZhiQiang-Tiger opened a new pull request, #2288: URL: https://github.com/apache/fury/pull/2288 ## What does this PR do? Users can choose the level of error messages to be printed. ## Related issues Deserialize big object using Fury frequently, triggering a Full GC whe

Re: [PR] add log downgrade configuration [fury]

2025-06-03 Thread via GitHub
chaokunyang commented on code in PR #2284: URL: https://github.com/apache/fury/pull/2284#discussion_r2122756611 ## java/fury-core/pom.xml: ## @@ -51,7 +51,16 @@ 8 ${basedir}/.. - + Review Comment: Please remove this -- This is an automated message from

Re: [I] [Python][C++] Upgrade bazel 6 to bazel 8 [fury]

2025-06-03 Thread via GitHub
chaokunyang commented on issue #2279: URL: https://github.com/apache/fury/issues/2279#issuecomment-2933758088 https://github.com/grpc/grpc/pull/38254 This can be taken as a reference -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] feat(java): add log downgrade configuration [fury]

2025-06-03 Thread via GitHub
ZhiQiang-Tiger commented on code in PR #2284: URL: https://github.com/apache/fury/pull/2284#discussion_r2122999140 ## java/fury-core/src/main/java/org/apache/fury/Fury.java: ## @@ -1679,6 +1681,13 @@ public boolean compressLong() { return config.compressLong(); } + pu

[I] [Java] Support codegen for xlang serialization in java [fury]

2025-06-03 Thread via GitHub
chaokunyang opened a new issue, #2286: URL: https://github.com/apache/fury/issues/2286 ### Feature Request Currently all xlang serialization don't support codegen: ```java @Data public static class Foo { public Integer f1; public String f2; public

Re: [PR] feat(java): add log downgrade configuration [fury]

2025-06-03 Thread via GitHub
chaokunyang commented on code in PR #2284: URL: https://github.com/apache/fury/pull/2284#discussion_r2122964933 ## java/fury-core/src/main/java/org/apache/fury/util/ExceptionUtils.java: ## @@ -57,15 +59,35 @@ public static StackOverflowError trySetStackOverflowErrorMessage(

Re: [PR] feat(java): add log downgrade configuration [fury]

2025-06-03 Thread via GitHub
chaokunyang commented on code in PR #2284: URL: https://github.com/apache/fury/pull/2284#discussion_r2122963815 ## java/fury-core/src/main/java/org/apache/fury/Fury.java: ## @@ -1679,6 +1681,13 @@ public boolean compressLong() { return config.compressLong(); } + publi

Re: [PR] feat(java): add log downgrade configuration [fury]

2025-06-03 Thread via GitHub
chaokunyang commented on code in PR #2284: URL: https://github.com/apache/fury/pull/2284#discussion_r2122959672 ## java/fury-core/src/main/java/org/apache/fury/Fury.java: ## @@ -1679,6 +1681,13 @@ public boolean compressLong() { return config.compressLong(); } + publi

Re: [I] [Java] Support codegen for xlang serialization in java for strict mode [fury]

2025-06-03 Thread via GitHub
chaokunyang commented on issue #2286: URL: https://github.com/apache/fury/issues/2286#issuecomment-2933815857 @Hen1ng Assigned to you! Looking forward to your contribution -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [I] [Java] Support codegen for xlang serialization in java for strict mode [fury]

2025-06-03 Thread via GitHub
Hen1ng commented on issue #2286: URL: https://github.com/apache/fury/issues/2286#issuecomment-2933809758 @chaokunyang I am very interested in this issue, could you please assign it to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[I] [Java] Support codegen for xlang serialization in java for compatible mode [fury]

2025-06-03 Thread via GitHub
chaokunyang opened a new issue, #2287: URL: https://github.com/apache/fury/issues/2287 ### Feature Request ### Feature Request Currently all xlang serialization don't support codegen: ```java @Data public static class Foo { public Integer f1; publi

[I] [Python][C++] support bazel module [fury]

2025-06-02 Thread via GitHub
chaokunyang opened a new issue, #2285: URL: https://github.com/apache/fury/issues/2285 ### Feature Request Currently we use bazel workspace to manage the c++ build. We need to use bazel module, and it's the way we use nanobind in the future. ### Is your feature request related

Re: [PR] add log downgrade configuration [fury]

2025-06-02 Thread via GitHub
chaokunyang commented on code in PR #2284: URL: https://github.com/apache/fury/pull/2284#discussion_r2122850500 ## java/fury-core/src/main/java/org/apache/fury/util/ExceptionUtils.java: ## @@ -57,15 +59,36 @@ public static StackOverflowError trySetStackOverflowErrorMessage(

Re: [I] [Python][C++] Upgrade bazel 6 to bazel 8 [fury]

2025-06-02 Thread via GitHub
chaokunyang commented on issue #2279: URL: https://github.com/apache/fury/issues/2279#issuecomment-2933752774 > Can I work on this? Sure, welcome! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [Python][C++] Upgrade bazel 6 to bazel 8 [fury]

2025-06-02 Thread via GitHub
XueSongTap commented on issue #2279: URL: https://github.com/apache/fury/issues/2279#issuecomment-2933738460 Can I work on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] add log downgrade configuration [fury]

2025-06-02 Thread via GitHub
chaokunyang commented on PR #2284: URL: https://github.com/apache/fury/pull/2284#issuecomment-2933716782 Please check branch from latest main branch, we renamed fury to fory in #2263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] add log downgrade configuration [fury]

2025-06-02 Thread via GitHub
ZhiQiang-Tiger commented on code in PR #2284: URL: https://github.com/apache/fury/pull/2284#discussion_r2122814350 ## java/fury-core/src/main/java/org/apache/fury/config/ExceptionLogMode.java: ## @@ -0,0 +1,7 @@ +package org.apache.fury.config; Review Comment: > The newly ad

Re: [PR] add log downgrade configuration [fury]

2025-06-02 Thread via GitHub
LiangliangSui commented on code in PR #2284: URL: https://github.com/apache/fury/pull/2284#discussion_r2122806990 ## java/fury-core/src/main/java/org/apache/fury/config/ExceptionLogMode.java: ## @@ -0,0 +1,7 @@ +package org.apache.fury.config; Review Comment: The newly added

Re: [PR] add log downgrade configuration [fury]

2025-06-02 Thread via GitHub
ZhiQiang-Tiger commented on code in PR #2284: URL: https://github.com/apache/fury/pull/2284#discussion_r2122803670 ## java/fury-core/src/main/java/org/apache/fury/util/ExceptionUtils.java: ## @@ -57,15 +59,36 @@ public static StackOverflowError trySetStackOverflowErrorMessage(

Re: [PR] add log downgrade configuration [fury]

2025-06-02 Thread via GitHub
chaokunyang commented on code in PR #2284: URL: https://github.com/apache/fury/pull/2284#discussion_r2122781395 ## java/fury-core/src/main/java/org/apache/fury/config/FuryBuilder.java: ## @@ -142,6 +145,20 @@ public FuryBuilder serializeEnumByName(boolean serializeEnumByName) {

Re: [PR] add log downgrade configuration [fury]

2025-06-02 Thread via GitHub
chaokunyang commented on code in PR #2284: URL: https://github.com/apache/fury/pull/2284#discussion_r2122781395 ## java/fury-core/src/main/java/org/apache/fury/config/FuryBuilder.java: ## @@ -142,6 +145,20 @@ public FuryBuilder serializeEnumByName(boolean serializeEnumByName) {

Re: [PR] add log downgrade configuration [fury]

2025-06-02 Thread via GitHub
chaokunyang commented on code in PR #2284: URL: https://github.com/apache/fury/pull/2284#discussion_r2122758916 ## java/fury-core/src/main/java/org/apache/fury/Fury.java: ## @@ -19,47 +19,18 @@ package org.apache.fury; -import java.io.ByteArrayOutputStream; -import java.io.

Re: [PR] add log downgrade configuration [fury]

2025-06-02 Thread via GitHub
chaokunyang commented on code in PR #2284: URL: https://github.com/apache/fury/pull/2284#discussion_r2122773852 ## java/fury-core/src/main/java/org/apache/fury/util/ExceptionUtils.java: ## @@ -57,15 +59,36 @@ public static StackOverflowError trySetStackOverflowErrorMessage(

Re: [PR] add log downgrade configuration [fury]

2025-06-02 Thread via GitHub
chaokunyang commented on code in PR #2284: URL: https://github.com/apache/fury/pull/2284#discussion_r2122766374 ## java/fury-core/src/test/java/org/apache/fury/LogDowngradeTest.java: ## @@ -0,0 +1,48 @@ +package org.apache.fury; + + +import org.apache.fury.config.ExceptionLogMod

[PR] add log downgrade configuration [fury]

2025-06-02 Thread via GitHub
ZhiQiang-Tiger opened a new pull request, #2284: URL: https://github.com/apache/fury/pull/2284 ## What does this PR do? Users can choose the level of error messages to be printed. ## Related issues Deserialize big object using Fury frequently, triggering a Ful

Re: [PR] chore(java): fix xlang test skip in the case where there is no Python at all [fury]

2025-06-02 Thread via GitHub
chaokunyang merged PR #2280: URL: https://github.com/apache/fury/pull/2280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury.apac

[I] [Python] unifiy ComplexObjectSerializer and DataClassSerializer [fury]

2025-06-02 Thread via GitHub
chaokunyang opened a new issue, #2283: URL: https://github.com/apache/fury/issues/2283 ### Feature Request unifiy ComplexObjectSerializer and DataClassSerializer: - remove ComplexObjectSerializer - Make DataClassSerializer support both python native and xlang serializaiton

Re: [PR] fix(java): descriptors for beans should not include static methods [fury]

2025-06-02 Thread via GitHub
chaokunyang merged PR #2281: URL: https://github.com/apache/fury/pull/2281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury.apac

Re: [PR] chore(java): gitignore test-output from integration_tests as well as java [fury]

2025-06-02 Thread via GitHub
chaokunyang merged PR #2282: URL: https://github.com/apache/fury/pull/2282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury.apac

[PR] chore(java): gitignore test-output from integration_tests as well as java [fury]

2025-06-02 Thread via GitHub
stevenschlansker opened a new pull request, #2282: URL: https://github.com/apache/fury/pull/2282 right now, running integration tests makes your checkout not clean -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[PR] fix(java): descriptors for beans should not include static methods [fury]

2025-06-02 Thread via GitHub
stevenschlansker opened a new pull request, #2281: URL: https://github.com/apache/fury/pull/2281 ## What does this PR do? Bean interface method descriptor discovery incorrectly includes static methods like `static Builder builder()` -- This is an automated message from the Apache G

[PR] chore(java): fix xlang test skip in the case where there is no Python at all [fury]

2025-06-02 Thread via GitHub
stevenschlansker opened a new pull request, #2280: URL: https://github.com/apache/fury/pull/2280 existing code works if python is installed but not pyfory, but on Mac the default name for Python is `python3` and there is no `python` at all by default -- This is an automated message fr

[I] [Python][C++] Upgrade bazel 6 to bazel 8 [fury]

2025-06-02 Thread via GitHub
chaokunyang opened a new issue, #2279: URL: https://github.com/apache/fury/issues/2279 ### Feature Request Upgrade bazel 6 to bazel 8 to use bazel module to manage dependencies. ### Is your feature request related to a problem? Please describe _No response_ ### Des

Re: [I] [Java] Fury occasionally encounters deserialization exceptions, ClassCastException and ArrayIndexOutOfBoundsException [fury]

2025-06-02 Thread via GitHub
CherishCai closed issue #2253: [Java] Fury occasionally encounters deserialization exceptions, ClassCastException and ArrayIndexOutOfBoundsException URL: https://github.com/apache/fury/issues/2253 -- This is an automated message from the Apache Git Service. To respond to the message, please

[PR] feat(python): support xlang metashare [fury]

2025-06-02 Thread via GitHub
urlyy opened a new pull request, #2278: URL: https://github.com/apache/fury/pull/2278 ## What does this PR do? Prepare to implement xlang metashare encode&decode in pyfory. Now finish `field_info` and `type_info(TypeDef)`. And I will continue to finish type_resolver for registry.

Re: [PR] chore(java): Use `crossLanguage` instead of `language` in Fory [fury]

2025-06-02 Thread via GitHub
chaokunyang merged PR #2274: URL: https://github.com/apache/fury/pull/2274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury.apac

Re: [PR] feat(java): support meta shared serialization for xlang in java [fury]

2025-06-02 Thread via GitHub
chaokunyang merged PR #2276: URL: https://github.com/apache/fury/pull/2276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury.apac

Re: [I] Deserialization with custom serializer occurs error [fury]

2025-06-02 Thread via GitHub
chaokunyang commented on issue #2275: URL: https://github.com/apache/fury/issues/2275#issuecomment-2929252915 Without the reproduction code, it's basically impossible to find out what happened for the stack trace. Maybe join could try latest code in main branch, And see whether the issue

Re: [I] Deserialization with custom serializer occurs error [fury]

2025-06-02 Thread via GitHub
IPECTER commented on issue #2275: URL: https://github.com/apache/fury/issues/2275#issuecomment-2929210003 > Hi @IPECTER , could you provide reproduction code? It will help trouble shooting issues much more easily Understood. However, since my code is third-party code from another program,

Re: [PR] chore(java): Use `crossLanguage` instead of `language` in Fory [fury]

2025-06-02 Thread via GitHub
chaokunyang commented on PR #2274: URL: https://github.com/apache/fury/pull/2274#issuecomment-2929201449 > Additionally, the field 'peerLanguage' in the Fory class currently not needed. Will it have any future use? Perhaps it will be used for log printing? This will be used in future,

[I] [Java] support multi-dimensional array field serialization in xlang meta shared mode [fury]

2025-06-02 Thread via GitHub
chaokunyang opened a new issue, #2277: URL: https://github.com/apache/fury/issues/2277 ### Feature Request Currently we don't support multi-dimensional array field serialization in xlang meta shared mode If we serialize such fields, we will get exception: ```java @Test

[PR] feat(java): support meta shared serialization for xlang in java [fury]

2025-06-01 Thread via GitHub
chaokunyang opened a new pull request, #2276: URL: https://github.com/apache/fury/pull/2276 ## What does this PR do? ## Related issues #2197 ## Does this PR introduce any user-facing change? - [ ] Does this PR introduce any public API chang

Re: [I] [Question] Future-proofing serialized data [fury]

2025-06-01 Thread via GitHub
drse closed issue #2273: [Question] Future-proofing serialized data URL: https://github.com/apache/fury/issues/2273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [I] Deserialization with custom serializer occurs error [fury]

2025-06-01 Thread via GitHub
chaokunyang commented on issue #2275: URL: https://github.com/apache/fury/issues/2275#issuecomment-2928892120 Hi @IPECTER , could you provide reproduction code? It will help trouble shooting issues much more easily -- This is an automated message from the Apache Git Service. To respond to

[I] Deserialization with custom serializer occurs error [fury]

2025-06-01 Thread via GitHub
IPECTER opened a new issue, #2275: URL: https://github.com/apache/fury/issues/2275 ### Search before asking - [x] I had searched in the [issues](https://github.com/apache/fory/issues) and found no similar issues. ### Version Fury Version: 1.10.3 JDK: OpenJDK 21.0.

Re: [PR] chore(java): Use `crossLanguage` instead of `language` in Fory [fury]

2025-06-01 Thread via GitHub
CherishCai commented on PR #2274: URL: https://github.com/apache/fury/pull/2274#issuecomment-2928718901 Additionally, the field 'peerLanguage' in the Fory class currently not needed. Will it have any future use? Perhaps it will be used for log printing? -- This is an automated message fro

Re: [I] [OSPP][Go] Implement type forward/backward compatibility for Fury Go [fury]

2025-06-01 Thread via GitHub
junjiexh commented on issue #2192: URL: https://github.com/apache/fury/issues/2192#issuecomment-2928714995 @chaokunyang Hi, chaokun. I've carefully read the description and have a couple of points I'd like to seek your clarification on. This would be very helpful for me or anyone who might

[PR] chore(java): Use `crossLanguage` instead of `language` in Fory [fury]

2025-06-01 Thread via GitHub
CherishCai opened a new pull request, #2274: URL: https://github.com/apache/fury/pull/2274 ## What does this PR do? The Fory class fields `language` and `crossLanguage` are redundant and can be quickly determined using `crossLanguage` without the need for `language`. -- This is an auto

Re: [PR] fix(java): raise exception when registering invalid serializer for Map/List [fury]

2025-06-01 Thread via GitHub
chaokunyang commented on PR #2271: URL: https://github.com/apache/fury/pull/2271#issuecomment-2927371613 You can take a look at failed tests, it's because they registered a special serializer for those classes: ```java @Test(dataProvider = "foryCopyConfig") public void testJ

Re: [PR] fix(java): raise exception when registering invalid serializer for Map/List [fury]

2025-06-01 Thread via GitHub
chaokunyang commented on PR #2271: URL: https://github.com/apache/fury/pull/2271#issuecomment-2927367669 Serializer for ConcurrentHashMap is [ConcurrentHashMapSerializer](https://github.com/apache/fury/blob/0d47fb847da558a444f8a35ab1073e80c9f3ad7b/java/fory-core/src/main/java/org/apache

Re: [PR] fix(java): raise exception when registering invalid serializer for Map/List [fury]

2025-06-01 Thread via GitHub
OmCheeLin commented on PR #2271: URL: https://github.com/apache/fury/pull/2271#issuecomment-2927323063 @chaokunyang I have modified the code as per your request. But there is a question here: failures in `ObjectStreamSerializerTest.java` and `ReplaceResolveSerializerTest.java` d

Re: [I] [Question] Future-proofing serialized data [fury]

2025-06-01 Thread via GitHub
pandalee99 commented on issue #2273: URL: https://github.com/apache/fury/issues/2273#issuecomment-2927214843 It makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] fix(java): raise exception when registering invalid serializer for Map/List [fury]

2025-05-31 Thread via GitHub
chaokunyang commented on code in PR #2271: URL: https://github.com/apache/fury/pull/2271#discussion_r2118613288 ## java/fory-core/src/main/java/org/apache/fory/Fory.java: ## @@ -242,6 +279,8 @@ public void registerSerializer(Class type, Serializer serializer) { @Override

Re: [I] [Question] Future-proofing serialized data [fury]

2025-05-31 Thread via GitHub
chaokunyang commented on issue #2273: URL: https://github.com/apache/fury/issues/2273#issuecomment-2926468935 This should work! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [I] [Question] Future-proofing serialized data [fury]

2025-05-31 Thread via GitHub
drse commented on issue #2273: URL: https://github.com/apache/fury/issues/2273#issuecomment-2926453618 That is why I'm including the version in the first 3 bytes of the header. The version data would be used to instantiate the appropriate shaded fury version, and the flags would then be app

Re: [PR] fix(java): raise exception when registering invalid serializer for Map/List [fury]

2025-05-31 Thread via GitHub
OmCheeLin commented on code in PR #2271: URL: https://github.com/apache/fury/pull/2271#discussion_r2118643838 ## .gitignore: ## @@ -25,6 +25,7 @@ java/**/test-output **/*.html **/target .idea/ +.vscode/ Review Comment: Got it. -- This is an automated message from the

Re: [PR] chore(java): skip xlang tests when pyfory is not available [fury]

2025-05-31 Thread via GitHub
chaokunyang merged PR #2266: URL: https://github.com/apache/fury/pull/2266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury.apac

Re: [PR] fix(java): raise exception when registering invalid serializer for Map/List [fury]

2025-05-31 Thread via GitHub
chaokunyang commented on code in PR #2271: URL: https://github.com/apache/fury/pull/2271#discussion_r2118614083 ## java/fory-core/src/main/java/org/apache/fory/Fory.java: ## @@ -222,8 +226,40 @@ public void register(Class cls, String namespace, String typeName) { } }

Re: [I] [Question] Future-proofing serialized data [fury]

2025-05-31 Thread via GitHub
chaokunyang commented on issue #2273: URL: https://github.com/apache/fury/issues/2273#issuecomment-2926372176 Even those flags are exactly the same, the data serialized by fury of one version, may not be deserialized by another version of fury. Fury don't provide binary compatibility

Re: [I] [Java] Add explanatory message to Config when checking for metaShare enabled or compatible mode [fury]

2025-05-31 Thread via GitHub
chaokunyang commented on issue #2272: URL: https://github.com/apache/fury/issues/2272#issuecomment-2926366788 Hi @drse , thanks for reporting this issue, would you like to submit a PR to add some explanatory message when check failed? -- This is an automated message from the Apache Git Se

Re: [PR] fix(java): raise exception when registering invalid serializer for Map/List [fury]

2025-05-31 Thread via GitHub
chaokunyang commented on code in PR #2271: URL: https://github.com/apache/fury/pull/2271#discussion_r2118615132 ## java/fory-core/src/main/java/org/apache/fory/Fory.java: ## @@ -222,8 +226,40 @@ public void register(Class cls, String namespace, String typeName) { } }

Re: [PR] fix(java): raise exception when registering invalid serializer for Map/List [fury]

2025-05-31 Thread via GitHub
chaokunyang commented on code in PR #2271: URL: https://github.com/apache/fury/pull/2271#discussion_r2118614308 ## java/fory-core/src/main/java/org/apache/fory/Fory.java: ## @@ -233,6 +269,7 @@ public void registerSerializer(Class type, Class se @Override public void re

Re: [PR] fix(java): raise exception when registering invalid serializer for Map/List [fury]

2025-05-31 Thread via GitHub
chaokunyang commented on code in PR #2271: URL: https://github.com/apache/fury/pull/2271#discussion_r2118613318 ## java/fory-core/src/test/java/org/apache/fory/ForyTest.java: ## @@ -554,6 +561,163 @@ public void testRegisterPrivateSerializer() { serDeCheckSerializer(fory, o

Re: [PR] fix(java): raise exception when registering invalid serializer for Map/List [fury]

2025-05-31 Thread via GitHub
chaokunyang commented on PR #2271: URL: https://github.com/apache/fury/pull/2271#issuecomment-2926350721 Could you restore all files in .vscode and .idea -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] fix(java): raise exception when registering invalid serializer for Map/List [fury]

2025-05-31 Thread via GitHub
chaokunyang commented on code in PR #2271: URL: https://github.com/apache/fury/pull/2271#discussion_r2118613138 ## .gitignore: ## @@ -25,6 +25,7 @@ java/**/test-output **/*.html **/target .idea/ +.vscode/ Review Comment: please don't ignore this, launch.json is used for d

[I] [Question] Future-proofing serialized data [fury]

2025-05-31 Thread via GitHub
drse opened a new issue, #2273: URL: https://github.com/apache/fury/issues/2273 ### Question I decided to use Fury as the serialization mechanism for both data in motion and data at rest across the entire application, and I'm wondering what would be the safest approach to future proo

[I] [Java] Add explanatory message to Config when checking for metaShare enabled or compatible mode [fury]

2025-05-31 Thread via GitHub
drse opened a new issue, #2272: URL: https://github.com/apache/fury/issues/2272 ### Feature Request in `Config.java:95`, there is a check to make sure either meta share mode is enabled or the compatibility mode is `COMPATIBLE`, however, when it is triggered, only an `IllegalArgumentE

Re: [PR] fix(java): raise exception when registering invalid serializer for Map/List [fury]

2025-05-31 Thread via GitHub
OmCheeLin commented on PR #2271: URL: https://github.com/apache/fury/pull/2271#issuecomment-2924948271 Should we exclude class under `java.util`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[PR] fix(java): raise exception when registering invalid serializer for Map/List [fury]

2025-05-31 Thread via GitHub
OmCheeLin opened a new pull request, #2271: URL: https://github.com/apache/fury/pull/2271 ## What does this PR do? raise an exception with error message when when registering serializer for Map/List. ## Related issues - #2251 - #2270 ## Does this PR introduce any u

Re: [I] [Python] Support meta share for type forward/backward compatibility [fury]

2025-05-31 Thread via GitHub
chaokunyang commented on issue #2160: URL: https://github.com/apache/fury/issues/2160#issuecomment-2924730914 We plan to transition to `type` gradually -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [I] [Python] Support meta share for type forward/backward compatibility [fury]

2025-05-31 Thread via GitHub
urlyy commented on issue #2160: URL: https://github.com/apache/fury/issues/2160#issuecomment-2924725387 In pyfury, sometimes it's "class" and sometimes it's "type". Are there any naming conventions? I often confused about naming now. -- This is an automated message from the Apache Git Ser

Re: [I] [Java] raise an exception with error message when when registering serializer for Map/List [fury]

2025-05-30 Thread via GitHub
chaokunyang commented on issue #2270: URL: https://github.com/apache/fury/issues/2270#issuecomment-2924424008 cc @OmCheeLin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] [Java] raise an exception with error message when when registering serializer for Map/List [fury]

2025-05-30 Thread via GitHub
OmCheeLin commented on issue #2270: URL: https://github.com/apache/fury/issues/2270#issuecomment-2924443282 @chaokunyang ok, got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[I] [Java] raise an exception with error message when when registering serializer for Map/List [fury]

2025-05-30 Thread via GitHub
chaokunyang opened a new issue, #2270: URL: https://github.com/apache/fury/issues/2270 ### Feature Request When registering serializer for Map/List, one should extend `AbstractMapSerializer/AbstractListSerializer`. If the customized serializer class extend `Serializer` directly. Whe

Re: [I] [Java] Customized serializer for a `Collection` causes `ClassCastException` [fury]

2025-05-30 Thread via GitHub
OmCheeLin commented on issue #2251: URL: https://github.com/apache/fury/issues/2251#issuecomment-2924317713 I have reproduced this issue on the main branch and found some differences. ```java public static final class EmptyList extends AbstractList { @Override public Object ge

Re: [PR] fix(go): fix metastringbytes inconsistency issue [fury]

2025-05-30 Thread via GitHub
pandalee99 merged PR #2269: URL: https://github.com/apache/fury/pull/2269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury.apach

Re: [I] [go] The byte results generated by using MetaStringResolver are inconsistent [fury]

2025-05-30 Thread via GitHub
pandalee99 closed issue #2268: [go] The byte results generated by using MetaStringResolver are inconsistent URL: https://github.com/apache/fury/issues/2268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] fix(go): fix metastringbytes inconsistency issue [fury]

2025-05-30 Thread via GitHub
lzaeh commented on code in PR #2269: URL: https://github.com/apache/fury/pull/2269#discussion_r2116061412 ## go/fory/metastring_resolver_test.go: ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See t

Re: [PR] fix(go): fix metastringbytes inconsistency issue [fury]

2025-05-30 Thread via GitHub
lzaeh commented on code in PR #2269: URL: https://github.com/apache/fury/pull/2269#discussion_r2116061022 ## python/pyfory/tests/test_metastring_resolver.py: ## @@ -23,14 +23,44 @@ def test_metastring_resolver(): resolver = MetaStringResolver() encoder = MetaStringEnc

Re: [I] [Java] Customized serializer for a `Collection` causes `ClassCastException` [fury]

2025-05-30 Thread via GitHub
OmCheeLin commented on issue #2251: URL: https://github.com/apache/fury/issues/2251#issuecomment-2922582186 @chaokunyang Please asign it to me, I would like to submit a pr for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] Update doc cleanup [fury-site]

2025-05-30 Thread via GitHub
chaokunyang merged PR #229: URL: https://github.com/apache/fury-site/pull/229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury.a

Re: [PR] fix(go): fix metastringbytes inconsistency issue [fury]

2025-05-30 Thread via GitHub
pandalee99 commented on code in PR #2269: URL: https://github.com/apache/fury/pull/2269#discussion_r2116031493 ## python/pyfory/tests/test_metastring_resolver.py: ## @@ -23,14 +23,44 @@ def test_metastring_resolver(): resolver = MetaStringResolver() encoder = MetaStri

[PR] fix(go): fix metastringbytes inconsistency issue [fury]

2025-05-30 Thread via GitHub
lzaeh opened a new pull request, #2269: URL: https://github.com/apache/fury/pull/2269 ## What does this PR do? **Summary:** Fixes inconsistencies between the Go implementation of `MetaStringResolver` and the reference Cython implementation. Specifically, it corrects encoding

Re: [I] [Scala] Class deserialization returns null until serialize is called [fury]

2025-05-30 Thread via GitHub
chaokunyang closed issue #2249: [Scala] Class deserialization returns null until serialize is called URL: https://github.com/apache/fury/issues/2249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] fix ci error [fury-site]

2025-05-30 Thread via GitHub
LiangliangSui merged PR #230: URL: https://github.com/apache/fury-site/pull/230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury

[PR] fix ci error [fury-site]

2025-05-30 Thread via GitHub
LiangliangSui opened a new pull request, #230: URL: https://github.com/apache/fury-site/pull/230 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[PR] Update doc cleanup [fury-site]

2025-05-30 Thread via GitHub
LiangliangSui opened a new pull request, #229: URL: https://github.com/apache/fury-site/pull/229 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [I] [go] The byte results generated by using MetaStringResolver are inconsistent [fury]

2025-05-30 Thread via GitHub
lzaeh commented on issue #2268: URL: https://github.com/apache/fury/issues/2268#issuecomment-2921840865 I've been exploring fury-go recently and noticed some inconsistencies in the meta string resolver compared to the Python version. After running a few tests, I'd like to offer to work on t

Re: [I] [go] The byte results generated by using MetaStringResolver are inconsistent [fury]

2025-05-30 Thread via GitHub
pandalee99 commented on issue #2268: URL: https://github.com/apache/fury/issues/2268#issuecomment-2921847574 > I've been exploring fury-go recently and noticed some inconsistencies in the meta string resolver compared to the Python version. After running a few tests, I'd like to offer to wo

[I] [go] The byte results generated by using MetaStringResolver are inconsistent [fury]

2025-05-30 Thread via GitHub
pandalee99 opened a new issue, #2268: URL: https://github.com/apache/fury/issues/2268 ### Search before asking - [x] I had searched in the [issues](https://github.com/apache/fory/issues) and found no similar issues. ### Version 0.10.3 ### Component(s) G

Re: [PR] fix(scala): Ensure singleton classes are initialized before reading [fury]

2025-05-29 Thread via GitHub
chaokunyang merged PR #2267: URL: https://github.com/apache/fury/pull/2267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fury.apac

[PR] fix(scala): Ensure singleton classes are initialized before reading [fury]

2025-05-29 Thread via GitHub
creddy opened a new pull request, #2267: URL: https://github.com/apache/fury/pull/2267 ## What does this PR do? This PR fixes an issue in Scala. Since Scala object's are lazy, the singleton instance doesn't exist or it does exist, but its value is `null` so when `S

Re: [I] [Scala] Class deserialization returns null until serialize is called [fury]

2025-05-29 Thread via GitHub
creddy commented on issue #2249: URL: https://github.com/apache/fury/issues/2249#issuecomment-2920036364 Thank you @chaokunyang I opened https://github.com/apache/fury/pull/2267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] chore(java): move xlang tests to it [fury]

2025-05-29 Thread via GitHub
chaokunyang commented on PR #2266: URL: https://github.com/apache/fury/pull/2266#issuecomment-2919943976 I prefer to keep it in fury-format module, but skip it if pyfory is not installed, or we can use a env variable to skip it, and enable the tests in ci via this env variable -- This is

  1   2   3   4   5   6   7   8   9   10   >