Repository: geode Updated Branches: refs/heads/feature/GEODE-2980 7c7b577eb -> f7396e4c7 (forced update)
http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/redis/internal/Executor.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/redis/internal/Executor.java b/geode-core/src/main/java/org/apache/geode/redis/internal/Executor.java index 7698535..55bc132 100755 --- a/geode-core/src/main/java/org/apache/geode/redis/internal/Executor.java +++ b/geode-core/src/main/java/org/apache/geode/redis/internal/Executor.java @@ -29,6 +29,6 @@ public interface Executor { * @param command The command to be executed * @param context The execution context by which this command is to be executed */ - public void executeCommand(Command command, ExecutionHandlerContext context); + void executeCommand(Command command, ExecutionHandlerContext context); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/redis/internal/Extendable.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/redis/internal/Extendable.java b/geode-core/src/main/java/org/apache/geode/redis/internal/Extendable.java index ed36030..8da78e5 100644 --- a/geode-core/src/main/java/org/apache/geode/redis/internal/Extendable.java +++ b/geode-core/src/main/java/org/apache/geode/redis/internal/Extendable.java @@ -26,6 +26,6 @@ public interface Extendable { * * @return Error string */ - public String getArgsError(); + String getArgsError(); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java ---------------------------------------------------------------------- diff --git a/geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java b/geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java index 6b0675a..6e05600 100644 --- a/geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java +++ b/geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java @@ -48,14 +48,13 @@ public interface AuthInitialize extends CacheCallback { * @deprecated since Geode 1.0, use init() */ @Deprecated - public void init(LogWriter systemLogger, LogWriter securityLogger) - throws AuthenticationFailedException; + void init(LogWriter systemLogger, LogWriter securityLogger) throws AuthenticationFailedException; /** * @since Geode 1.0. implement this method instead of init with logwriters. Implementation should * use log4j instead of these loggers. */ - public default void init() { + default void init() { InternalCache cache = GemFireCacheImpl.getInstance(); init(cache.getLogger(), cache.getSecurityLogger()); } @@ -86,8 +85,8 @@ public interface AuthInitialize extends CacheCallback { * all members, peer/client will use the same credentials. */ @Deprecated - public Properties getCredentials(Properties securityProps, DistributedMember server, - boolean isPeer) throws AuthenticationFailedException; + Properties getCredentials(Properties securityProps, DistributedMember server, boolean isPeer) + throws AuthenticationFailedException; /** * Implement this since Geode1.0 http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/test/java/org/apache/geode/cache/management/ResourceManagerDUnitTest.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/cache/management/ResourceManagerDUnitTest.java b/geode-core/src/test/java/org/apache/geode/cache/management/ResourceManagerDUnitTest.java index 13643ec..6aec6d6 100644 --- a/geode-core/src/test/java/org/apache/geode/cache/management/ResourceManagerDUnitTest.java +++ b/geode-core/src/test/java/org/apache/geode/cache/management/ResourceManagerDUnitTest.java @@ -754,8 +754,8 @@ public class ResourceManagerDUnitTest extends JUnit4CacheTestCase { } } - private static interface OpDuringBucketRemove extends java.io.Serializable { - public void runit(PartitionedRegion pr, Object key, Object value); + private interface OpDuringBucketRemove extends java.io.Serializable { + void runit(PartitionedRegion pr, Object key, Object value); } private void doOpDuringBucketRemove(final OpDuringBucketRemove op) { http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/test/java/org/apache/geode/cache/query/functional/GroupByTestInterface.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/cache/query/functional/GroupByTestInterface.java b/geode-core/src/test/java/org/apache/geode/cache/query/functional/GroupByTestInterface.java index ee64693..437a6c4 100644 --- a/geode-core/src/test/java/org/apache/geode/cache/query/functional/GroupByTestInterface.java +++ b/geode-core/src/test/java/org/apache/geode/cache/query/functional/GroupByTestInterface.java @@ -17,42 +17,42 @@ package org.apache.geode.cache.query.functional; public interface GroupByTestInterface { - public void testConvertibleGroupByQuery_1() throws Exception; + void testConvertibleGroupByQuery_1() throws Exception; - public void testConvertibleGroupByQuery_refer_column() throws Exception; + void testConvertibleGroupByQuery_refer_column() throws Exception; - public void testConvertibleGroupByQuery_refer_column_alias_Bug520141() throws Exception; + void testConvertibleGroupByQuery_refer_column_alias_Bug520141() throws Exception; - public void testAggregateFuncCountStar() throws Exception; + void testAggregateFuncCountStar() throws Exception; - public void testAggregateFuncCountDistinctStar_1() throws Exception; + void testAggregateFuncCountDistinctStar_1() throws Exception; - public void testAggregateFuncCountDistinctStar_2() throws Exception; + void testAggregateFuncCountDistinctStar_2() throws Exception; - public void testAggregateFuncSum() throws Exception; + void testAggregateFuncSum() throws Exception; - public void testAggregateFuncSumDistinct() throws Exception; + void testAggregateFuncSumDistinct() throws Exception; - public void testAggregateFuncNoGroupBy() throws Exception; + void testAggregateFuncNoGroupBy() throws Exception; - public void testAggregateFuncAvg() throws Exception; + void testAggregateFuncAvg() throws Exception; - public void testAggregateFuncAvgDistinct() throws Exception; + void testAggregateFuncAvgDistinct() throws Exception; - public void testAggregateFuncWithOrderBy() throws Exception; + void testAggregateFuncWithOrderBy() throws Exception; - public void testComplexValueAggregateFuncAvgDistinct() throws Exception; + void testComplexValueAggregateFuncAvgDistinct() throws Exception; - public void testAggregateFuncMax() throws Exception; + void testAggregateFuncMax() throws Exception; - public void testSumWithMultiColumnGroupBy() throws Exception; + void testSumWithMultiColumnGroupBy() throws Exception; - public void testAggregateFuncMin() throws Exception; + void testAggregateFuncMin() throws Exception; - public void testCompactRangeIndex() throws Exception; + void testCompactRangeIndex() throws Exception; - public void testDistinctCountWithoutGroupBy() throws Exception; + void testDistinctCountWithoutGroupBy() throws Exception; - public void testLimitWithGroupBy() throws Exception; + void testLimitWithGroupBy() throws Exception; } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/test/java/org/apache/geode/internal/ClassNotFoundExceptionDUnitTest.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/internal/ClassNotFoundExceptionDUnitTest.java b/geode-core/src/test/java/org/apache/geode/internal/ClassNotFoundExceptionDUnitTest.java index ac61687..28ca482 100644 --- a/geode-core/src/test/java/org/apache/geode/internal/ClassNotFoundExceptionDUnitTest.java +++ b/geode-core/src/test/java/org/apache/geode/internal/ClassNotFoundExceptionDUnitTest.java @@ -255,8 +255,8 @@ public class ClassNotFoundExceptionDUnitTest extends JUnit4CacheTestCase { } } - private static interface ObjectFactory extends Serializable { - public Object get(); + private interface ObjectFactory extends Serializable { + Object get(); } } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/test/java/org/apache/geode/internal/cache/DeltaSizingDUnitTest.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/internal/cache/DeltaSizingDUnitTest.java b/geode-core/src/test/java/org/apache/geode/internal/cache/DeltaSizingDUnitTest.java index be21fa3..76310b4 100644 --- a/geode-core/src/test/java/org/apache/geode/internal/cache/DeltaSizingDUnitTest.java +++ b/geode-core/src/test/java/org/apache/geode/internal/cache/DeltaSizingDUnitTest.java @@ -270,7 +270,7 @@ public class DeltaSizingDUnitTest extends JUnit4CacheTestCase { return ((Long) size).longValue(); } - private static interface AccessorFactory extends Serializable { + private interface AccessorFactory extends Serializable { Region<Integer, TestDelta> createRegion(Host host, Cache cache, int port1, int port2); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/test/java/org/apache/geode/internal/cache/MockCacheService.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/internal/cache/MockCacheService.java b/geode-core/src/test/java/org/apache/geode/internal/cache/MockCacheService.java index 69d3ec5..22e5795 100644 --- a/geode-core/src/test/java/org/apache/geode/internal/cache/MockCacheService.java +++ b/geode-core/src/test/java/org/apache/geode/internal/cache/MockCacheService.java @@ -18,5 +18,5 @@ import org.apache.geode.cache.Cache; public interface MockCacheService extends CacheService { - public Cache getCache(); + Cache getCache(); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/test/java/org/apache/geode/internal/cache/control/RebalanceOperationDUnitTest.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/internal/cache/control/RebalanceOperationDUnitTest.java b/geode-core/src/test/java/org/apache/geode/internal/cache/control/RebalanceOperationDUnitTest.java index ec59bf9..3bfe649 100644 --- a/geode-core/src/test/java/org/apache/geode/internal/cache/control/RebalanceOperationDUnitTest.java +++ b/geode-core/src/test/java/org/apache/geode/internal/cache/control/RebalanceOperationDUnitTest.java @@ -3430,7 +3430,7 @@ public class RebalanceOperationDUnitTest extends JUnit4CacheTestCase { } } - private static interface Operation { + private interface Operation { void execute(Region region, Integer key); http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/test/java/org/apache/geode/internal/cache/extension/SimpleExtensionPointJUnitTest.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/internal/cache/extension/SimpleExtensionPointJUnitTest.java b/geode-core/src/test/java/org/apache/geode/internal/cache/extension/SimpleExtensionPointJUnitTest.java index f11d2d5..513ad0f 100644 --- a/geode-core/src/test/java/org/apache/geode/internal/cache/extension/SimpleExtensionPointJUnitTest.java +++ b/geode-core/src/test/java/org/apache/geode/internal/cache/extension/SimpleExtensionPointJUnitTest.java @@ -206,7 +206,7 @@ public class SimpleExtensionPointJUnitTest { } private interface MockInterface { - public void method1(); + void method1(); } private static class MockImpl implements MockInterface, Extensible<MockInterface> { http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/test/java/org/apache/geode/internal/cache/lru/LRUClockJUnitTest.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/internal/cache/lru/LRUClockJUnitTest.java b/geode-core/src/test/java/org/apache/geode/internal/cache/lru/LRUClockJUnitTest.java index 39759f4..6bc181d 100755 --- a/geode-core/src/test/java/org/apache/geode/internal/cache/lru/LRUClockJUnitTest.java +++ b/geode-core/src/test/java/org/apache/geode/internal/cache/lru/LRUClockJUnitTest.java @@ -247,7 +247,7 @@ public class LRUClockJUnitTest { } private interface LRUTestEntry extends LRUClockNode { - public int id(); + int id(); } /** test implementation of an LRUClockNode */ http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/test/java/org/apache/geode/internal/logging/LoggingPerformanceTestCase.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/internal/logging/LoggingPerformanceTestCase.java b/geode-core/src/test/java/org/apache/geode/internal/logging/LoggingPerformanceTestCase.java index c9d507f..da54e95 100644 --- a/geode-core/src/test/java/org/apache/geode/internal/logging/LoggingPerformanceTestCase.java +++ b/geode-core/src/test/java/org/apache/geode/internal/logging/LoggingPerformanceTestCase.java @@ -193,9 +193,9 @@ public abstract class LoggingPerformanceTestCase { assertTrue(this.logFile.exists()); } - public static interface PerformanceLogger { - public void log(final String message); + public interface PerformanceLogger { + void log(final String message); - public boolean isEnabled(); + boolean isEnabled(); } } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/test/java/org/apache/geode/internal/process/mbean/ProcessMBean.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/internal/process/mbean/ProcessMBean.java b/geode-core/src/test/java/org/apache/geode/internal/process/mbean/ProcessMBean.java index 6cebaf3..3bd4bd0 100644 --- a/geode-core/src/test/java/org/apache/geode/internal/process/mbean/ProcessMBean.java +++ b/geode-core/src/test/java/org/apache/geode/internal/process/mbean/ProcessMBean.java @@ -19,9 +19,9 @@ package org.apache.geode.internal.process.mbean; * */ public interface ProcessMBean { - public int getPid(); + int getPid(); - public boolean isProcess(); + boolean isProcess(); - public void stop(); + void stop(); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/test/java/org/apache/geode/internal/util/Valuable.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/internal/util/Valuable.java b/geode-core/src/test/java/org/apache/geode/internal/util/Valuable.java index 5c6b2db..cacc3fd 100644 --- a/geode-core/src/test/java/org/apache/geode/internal/util/Valuable.java +++ b/geode-core/src/test/java/org/apache/geode/internal/util/Valuable.java @@ -25,11 +25,11 @@ public interface Valuable { /** * Returns the value associated with this object */ - public Object getValue(); + Object getValue(); /** * Sets the value associated with this object */ - public void setValue(Object value); + void setValue(Object value); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/test/java/org/apache/geode/management/CompositeTestMXBean.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/management/CompositeTestMXBean.java b/geode-core/src/test/java/org/apache/geode/management/CompositeTestMXBean.java index bcbc441..0931d6e 100644 --- a/geode-core/src/test/java/org/apache/geode/management/CompositeTestMXBean.java +++ b/geode-core/src/test/java/org/apache/geode/management/CompositeTestMXBean.java @@ -19,13 +19,13 @@ import java.util.Map; public interface CompositeTestMXBean { // [A] MBean Attributes // 0. Basic - public CompositeStats getCompositeStats(); + CompositeStats getCompositeStats(); - public CompositeStats listCompositeStats(); + CompositeStats listCompositeStats(); - public Map<String, Integer> getMap(); + Map<String, Integer> getMap(); - public Integer[] getIntegerArray(); + Integer[] getIntegerArray(); - public CompositeStats[] getCompositeArray(); + CompositeStats[] getCompositeArray(); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/test/java/org/apache/geode/management/CustomMXBean.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/management/CustomMXBean.java b/geode-core/src/test/java/org/apache/geode/management/CustomMXBean.java index 73b45a3..f10ec6e 100644 --- a/geode-core/src/test/java/org/apache/geode/management/CustomMXBean.java +++ b/geode-core/src/test/java/org/apache/geode/management/CustomMXBean.java @@ -20,16 +20,16 @@ package org.apache.geode.management; */ public interface CustomMXBean { - public long getSystemTime(); + long getSystemTime(); - public void setSystemTime(long systemTime); + void setSystemTime(long systemTime); - public String getName(); + String getName(); - public void setName(String staticField); + void setName(String staticField); - public String fetchName(); + String fetchName(); - public void writeName(String staticField); + void writeName(String staticField); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/test/java/org/apache/geode/security/ClientAuthorizationTestCase.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/security/ClientAuthorizationTestCase.java b/geode-core/src/test/java/org/apache/geode/security/ClientAuthorizationTestCase.java index 9d3f721..bbc428b 100644 --- a/geode-core/src/test/java/org/apache/geode/security/ClientAuthorizationTestCase.java +++ b/geode-core/src/test/java/org/apache/geode/security/ClientAuthorizationTestCase.java @@ -1309,20 +1309,20 @@ public abstract class ClientAuthorizationTestCase extends JUnit4DistributedTestC * Get allowed credentials for the given set of operations in the given regions and indices of * KEYS in the <code>KEYS</code> array */ - public Properties getAllowedCredentials(OperationCode[] opCodes, String[] regionNames, + Properties getAllowedCredentials(OperationCode[] opCodes, String[] regionNames, int[] keyIndices, int num); /** * Get disallowed credentials for the given set of operations in the given regions and indices * of KEYS in the <code>KEYS</code> array */ - public Properties getDisallowedCredentials(OperationCode[] opCodes, String[] regionNames, + Properties getDisallowedCredentials(OperationCode[] opCodes, String[] regionNames, int[] keyIndices, int num); /** * Get the {@link CredentialGenerator} if any. */ - public CredentialGenerator getCredentialGenerator(); + CredentialGenerator getCredentialGenerator(); } /** http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/test/java/org/apache/geode/sequence/LineMapper.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/sequence/LineMapper.java b/geode-core/src/test/java/org/apache/geode/sequence/LineMapper.java index 6e4d27e..2536988 100644 --- a/geode-core/src/test/java/org/apache/geode/sequence/LineMapper.java +++ b/geode-core/src/test/java/org/apache/geode/sequence/LineMapper.java @@ -28,6 +28,6 @@ public interface LineMapper { /** * Return the short name for this lifeline. */ - public String getShortNameForLine(String lineName); + String getShortNameForLine(String lineName); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/test/java/org/apache/geode/sequence/SelectGraphDialog.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/sequence/SelectGraphDialog.java b/geode-core/src/test/java/org/apache/geode/sequence/SelectGraphDialog.java index f18d00c..0667572 100644 --- a/geode-core/src/test/java/org/apache/geode/sequence/SelectGraphDialog.java +++ b/geode-core/src/test/java/org/apache/geode/sequence/SelectGraphDialog.java @@ -113,7 +113,7 @@ public class SelectGraphDialog extends JDialog { /** * A listener for changes to the graph selections */ - public static interface SelectionListener { + public interface SelectionListener { void selectionChanged(List<GraphID> selectedIds); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/test/java/org/apache/geode/test/dunit/RepeatableRunnable.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/test/dunit/RepeatableRunnable.java b/geode-core/src/test/java/org/apache/geode/test/dunit/RepeatableRunnable.java index 3403aa2..dad6d91 100644 --- a/geode-core/src/test/java/org/apache/geode/test/dunit/RepeatableRunnable.java +++ b/geode-core/src/test/java/org/apache/geode/test/dunit/RepeatableRunnable.java @@ -23,6 +23,6 @@ package org.apache.geode.test.dunit; @Deprecated public interface RepeatableRunnable { - public void runRepeatingIfNecessary(long repeatTimeoutMs); + void runRepeatingIfNecessary(long repeatTimeoutMs); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/test/java/org/apache/geode/test/dunit/SerializableRunnableIF.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/test/dunit/SerializableRunnableIF.java b/geode-core/src/test/java/org/apache/geode/test/dunit/SerializableRunnableIF.java index a26730e..d4cd007 100644 --- a/geode-core/src/test/java/org/apache/geode/test/dunit/SerializableRunnableIF.java +++ b/geode-core/src/test/java/org/apache/geode/test/dunit/SerializableRunnableIF.java @@ -20,5 +20,5 @@ import java.io.Serializable; * Interface for {@link SerializableRunnable} to enable use with lambdas. */ public interface SerializableRunnableIF extends Serializable { - public void run() throws Exception; + void run() throws Exception; } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/test/java/org/apache/geode/test/dunit/StoppableWaitCriterion.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/test/dunit/StoppableWaitCriterion.java b/geode-core/src/test/java/org/apache/geode/test/dunit/StoppableWaitCriterion.java index 775584f..d23433b 100755 --- a/geode-core/src/test/java/org/apache/geode/test/dunit/StoppableWaitCriterion.java +++ b/geode-core/src/test/java/org/apache/geode/test/dunit/StoppableWaitCriterion.java @@ -27,6 +27,6 @@ public interface StoppableWaitCriterion extends WaitCriterion { * If this method returns true then quit waiting even if we are not done. This allows a wait to * fail early. */ - public boolean stopWaiting(); + boolean stopWaiting(); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/test/java/org/apache/geode/test/dunit/WaitCriterion.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/test/dunit/WaitCriterion.java b/geode-core/src/test/java/org/apache/geode/test/dunit/WaitCriterion.java index 3f95c0f..68c45630 100755 --- a/geode-core/src/test/java/org/apache/geode/test/dunit/WaitCriterion.java +++ b/geode-core/src/test/java/org/apache/geode/test/dunit/WaitCriterion.java @@ -32,8 +32,8 @@ package org.apache.geode.test.dunit; */ public interface WaitCriterion { - public boolean done(); + boolean done(); - public String description(); + String description(); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/test/java/org/apache/geode/test/dunit/cache/internal/CacheTestFixture.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/test/dunit/cache/internal/CacheTestFixture.java b/geode-core/src/test/java/org/apache/geode/test/dunit/cache/internal/CacheTestFixture.java index b785434..053604d 100644 --- a/geode-core/src/test/java/org/apache/geode/test/dunit/cache/internal/CacheTestFixture.java +++ b/geode-core/src/test/java/org/apache/geode/test/dunit/cache/internal/CacheTestFixture.java @@ -28,7 +28,7 @@ public interface CacheTestFixture extends DistributedTestFixture { * <p> * Override this as needed. Default implementation is empty. */ - public void preTearDownCacheTestCase() throws Exception; + void preTearDownCacheTestCase() throws Exception; /** * {@code postTearDownCacheTestCase()} is invoked after @@ -37,6 +37,6 @@ public interface CacheTestFixture extends DistributedTestFixture { * <p> * Override this as needed. Default implementation is empty. */ - public void postTearDownCacheTestCase() throws Exception; + void postTearDownCacheTestCase() throws Exception; } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/test/java/org/apache/geode/test/dunit/internal/DistributedTestFixture.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/test/dunit/internal/DistributedTestFixture.java b/geode-core/src/test/java/org/apache/geode/test/dunit/internal/DistributedTestFixture.java index 4175e81..b372696 100755 --- a/geode-core/src/test/java/org/apache/geode/test/dunit/internal/DistributedTestFixture.java +++ b/geode-core/src/test/java/org/apache/geode/test/dunit/internal/DistributedTestFixture.java @@ -28,7 +28,7 @@ public interface DistributedTestFixture extends Serializable { * <p> * Override this as needed. Default implementation is empty. */ - public void preSetUp() throws Exception; + void preSetUp() throws Exception; /** * {@code postSetUp()} is invoked after {@code DistributedTestCase#setUp()}. @@ -36,7 +36,7 @@ public interface DistributedTestFixture extends Serializable { * <p> * Override this as needed. Default implementation is empty. */ - public void postSetUp() throws Exception; + void postSetUp() throws Exception; /** * {@code preTearDown()} is invoked before {@code DistributedTestCase#tearDown()}. @@ -44,7 +44,7 @@ public interface DistributedTestFixture extends Serializable { * <p> * Override this as needed. Default implementation is empty. */ - public void preTearDown() throws Exception; + void preTearDown() throws Exception; /** * {@code postTearDown()} is invoked after {@code DistributedTestCase#tearDown()}. @@ -52,7 +52,7 @@ public interface DistributedTestFixture extends Serializable { * <p> * Override this as needed. Default implementation is empty. */ - public void postTearDown() throws Exception; + void postTearDown() throws Exception; /** * {@code preTearDownAssertions()} is invoked before any tear down methods have been invoked. If @@ -61,7 +61,7 @@ public interface DistributedTestFixture extends Serializable { * <p> * Override this as needed. Default implementation is empty. */ - public void preTearDownAssertions() throws Exception; + void preTearDownAssertions() throws Exception; /** * {@code postTearDownAssertions()} is invoked after all tear down methods have completed. This @@ -70,7 +70,7 @@ public interface DistributedTestFixture extends Serializable { * <p> * Override this as needed. Default implementation is empty. */ - public void postTearDownAssertions() throws Exception; + void postTearDownAssertions() throws Exception; /** * Returns the {@code Properties} used to define the {@code DistributedSystem}. @@ -79,11 +79,11 @@ public interface DistributedTestFixture extends Serializable { * Override this as needed. This method is called by various {@code getSystem} methods in * {@code DistributedTestCase}. */ - public Properties getDistributedSystemProperties(); + Properties getDistributedSystemProperties(); /** * Returns the {@code name} of the test method being executed. */ - public String getName(); + String getName(); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java b/geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java index b35270e..049f6cb5 100644 --- a/geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java +++ b/geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java @@ -391,15 +391,15 @@ public class DUnitLauncher { public interface MasterRemote extends Remote { - public int getLocatorPort() throws RemoteException; + int getLocatorPort() throws RemoteException; - public void signalVMReady() throws RemoteException; + void signalVMReady() throws RemoteException; - public void ping() throws RemoteException; + void ping() throws RemoteException; - public BounceResult bounce(int pid) throws RemoteException; + BounceResult bounce(int pid) throws RemoteException; - public BounceResult bounce(String version, int pid) throws RemoteException; + BounceResult bounce(String version, int pid) throws RemoteException; } public static class Master extends UnicastRemoteObject implements MasterRemote { http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-core/src/test/java/org/apache/geode/test/golden/ExecutableProcess.java ---------------------------------------------------------------------- diff --git a/geode-core/src/test/java/org/apache/geode/test/golden/ExecutableProcess.java b/geode-core/src/test/java/org/apache/geode/test/golden/ExecutableProcess.java index b108465..57efd5f 100755 --- a/geode-core/src/test/java/org/apache/geode/test/golden/ExecutableProcess.java +++ b/geode-core/src/test/java/org/apache/geode/test/golden/ExecutableProcess.java @@ -18,5 +18,5 @@ package org.apache.geode.test.golden; * Defines the work that is executed within a remote process. */ public interface ExecutableProcess { - public void executeInProcess() throws Exception; + void executeInProcess() throws Exception; } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-json/src/main/java/org/json/JSONString.java ---------------------------------------------------------------------- diff --git a/geode-json/src/main/java/org/json/JSONString.java b/geode-json/src/main/java/org/json/JSONString.java index 4a09d89..9c6c8d2 100755 --- a/geode-json/src/main/java/org/json/JSONString.java +++ b/geode-json/src/main/java/org/json/JSONString.java @@ -13,5 +13,5 @@ public interface JSONString { * * @return A strictly syntactically correct JSON text. */ - public String toJSONString(); + String toJSONString(); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-junit/src/main/java/org/apache/geode/test/junit/Repeat.java ---------------------------------------------------------------------- diff --git a/geode-junit/src/main/java/org/apache/geode/test/junit/Repeat.java b/geode-junit/src/main/java/org/apache/geode/test/junit/Repeat.java index c65823f..87cdb5f 100755 --- a/geode-junit/src/main/java/org/apache/geode/test/junit/Repeat.java +++ b/geode-junit/src/main/java/org/apache/geode/test/junit/Repeat.java @@ -32,7 +32,7 @@ import java.lang.annotation.Target; @SuppressWarnings("unused") public @interface Repeat { - public static int DEFAULT = 1; + int DEFAULT = 1; int value() default DEFAULT; http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-junit/src/main/java/org/apache/geode/test/junit/Retry.java ---------------------------------------------------------------------- diff --git a/geode-junit/src/main/java/org/apache/geode/test/junit/Retry.java b/geode-junit/src/main/java/org/apache/geode/test/junit/Retry.java index 7e6315e..8652f03 100755 --- a/geode-junit/src/main/java/org/apache/geode/test/junit/Retry.java +++ b/geode-junit/src/main/java/org/apache/geode/test/junit/Retry.java @@ -29,7 +29,7 @@ import java.lang.annotation.Target; @Target({ElementType.METHOD}) public @interface Retry { - public static int DEFAULT = 1; + int DEFAULT = 1; int value() default DEFAULT; http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-junit/src/main/java/org/apache/geode/test/junit/rules/serializable/FieldsOfTemporaryFolder.java ---------------------------------------------------------------------- diff --git a/geode-junit/src/main/java/org/apache/geode/test/junit/rules/serializable/FieldsOfTemporaryFolder.java b/geode-junit/src/main/java/org/apache/geode/test/junit/rules/serializable/FieldsOfTemporaryFolder.java index 3a6d66c..e55c9ae 100755 --- a/geode-junit/src/main/java/org/apache/geode/test/junit/rules/serializable/FieldsOfTemporaryFolder.java +++ b/geode-junit/src/main/java/org/apache/geode/test/junit/rules/serializable/FieldsOfTemporaryFolder.java @@ -18,7 +18,7 @@ package org.apache.geode.test.junit.rules.serializable; * Names of member fields in {@link org.junit.rules.TemporaryFolder}. */ interface FieldsOfTemporaryFolder { - static final String FIELD_PARENT_FOLDER = "parentFolder"; // java.io.File - static final String FIELD_ASSURE_DELETION = "assureDeletion"; // boolean (since JUnit 4.13) - static final String FIELD_FOLDER = "folder"; // java.io.File + String FIELD_PARENT_FOLDER = "parentFolder"; // java.io.File + String FIELD_ASSURE_DELETION = "assureDeletion"; // boolean (since JUnit 4.13) + String FIELD_FOLDER = "folder"; // java.io.File } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-junit/src/main/java/org/apache/geode/test/junit/rules/serializable/FieldsOfTestName.java ---------------------------------------------------------------------- diff --git a/geode-junit/src/main/java/org/apache/geode/test/junit/rules/serializable/FieldsOfTestName.java b/geode-junit/src/main/java/org/apache/geode/test/junit/rules/serializable/FieldsOfTestName.java index 541a98a..ffe340f 100755 --- a/geode-junit/src/main/java/org/apache/geode/test/junit/rules/serializable/FieldsOfTestName.java +++ b/geode-junit/src/main/java/org/apache/geode/test/junit/rules/serializable/FieldsOfTestName.java @@ -18,5 +18,5 @@ package org.apache.geode.test.junit.rules.serializable; * Names of member fields in {@link org.junit.rules.TestName}. */ interface FieldsOfTestName { - static final String FIELD_NAME = "name"; // String + String FIELD_NAME = "name"; // String } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-junit/src/main/java/org/apache/geode/test/junit/rules/serializable/FieldsOfTimeout.java ---------------------------------------------------------------------- diff --git a/geode-junit/src/main/java/org/apache/geode/test/junit/rules/serializable/FieldsOfTimeout.java b/geode-junit/src/main/java/org/apache/geode/test/junit/rules/serializable/FieldsOfTimeout.java index c6f8568..d79f942 100755 --- a/geode-junit/src/main/java/org/apache/geode/test/junit/rules/serializable/FieldsOfTimeout.java +++ b/geode-junit/src/main/java/org/apache/geode/test/junit/rules/serializable/FieldsOfTimeout.java @@ -18,7 +18,7 @@ package org.apache.geode.test.junit.rules.serializable; * Names of member fields in {@link org.junit.rules.Timeout}. */ interface FieldsOfTimeout { - static final String FIELD_TIMEOUT = "timeout"; // long - static final String FIELD_TIME_UNIT = "timeUnit"; // java.util.concurrent.TimeUnit - static final String FIELD_LOOK_FOR_STUCK_THREAD = "lookForStuckThread"; // boolean + String FIELD_TIMEOUT = "timeout"; // long + String FIELD_TIME_UNIT = "timeUnit"; // java.util.concurrent.TimeUnit + String FIELD_LOOK_FOR_STUCK_THREAD = "lookForStuckThread"; // boolean } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneIndex.java ---------------------------------------------------------------------- diff --git a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneIndex.java b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneIndex.java index 07b5c89..beec0cc 100644 --- a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneIndex.java +++ b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneIndex.java @@ -49,7 +49,7 @@ public interface LuceneIndex { * * @return Name of the LuceneIndex */ - public String getName(); + String getName(); /** * Returns the path of the region on which the LuceneIndex was created. The region name is @@ -57,7 +57,7 @@ public interface LuceneIndex { * * @return Path of the region */ - public String getRegionPath(); + String getRegionPath(); /** * Returns a string array containing the fields on which the LuceneIndex was created. These fields @@ -66,7 +66,7 @@ public interface LuceneIndex { * * @return String array containing the field names */ - public String[] getFieldNames(); + String[] getFieldNames(); /** * Returns a map containing the field name and the {@link Analyzer} used to tokenize the field. @@ -76,6 +76,6 @@ public interface LuceneIndex { * @return a map containing pairs of the indexed field name and the corresponding {@link Analyzer} * being used on each indexed field. */ - public Map<String, Analyzer> getFieldAnalyzers(); + Map<String, Analyzer> getFieldAnalyzers(); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQuery.java ---------------------------------------------------------------------- diff --git a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQuery.java b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQuery.java index cbee23f..cd28b0b 100644 --- a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQuery.java +++ b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQuery.java @@ -56,7 +56,7 @@ public interface LuceneQuery<K, V> { * Lucene query goes offline. * @throws CancelException if a cancel is in progress while the Lucene query was being executed. */ - public Collection<K> findKeys() throws LuceneQueryException; + Collection<K> findKeys() throws LuceneQueryException; /** * Execute the query and return the region values that match this query, up to the limit specified @@ -71,7 +71,7 @@ public interface LuceneQuery<K, V> { * Lucene query goes offline. * @throws CancelException if a cancel is in progress while the Lucene query was being executed. */ - public Collection<V> findValues() throws LuceneQueryException; + Collection<V> findValues() throws LuceneQueryException; /** * Execute the query and return a list of {@link LuceneResultStruct}s that match this query, up to @@ -87,7 +87,7 @@ public interface LuceneQuery<K, V> { * Lucene query goes offline. * @throws CancelException if a cancel is in progress while the Lucene query was being executed. */ - public List<LuceneResultStruct<K, V>> findResults() throws LuceneQueryException; + List<LuceneResultStruct<K, V>> findResults() throws LuceneQueryException; /** * Execute the query and get a {@link PageableLuceneQueryResults}. The @@ -103,7 +103,7 @@ public interface LuceneQuery<K, V> { * Lucene query goes offline. * @throws CancelException if a cancel is in progress while the Lucene query was being executed. */ - public PageableLuceneQueryResults<K, V> findPages() throws LuceneQueryException; + PageableLuceneQueryResults<K, V> findPages() throws LuceneQueryException; /** * Gets the page size setting of current query. This page size is set while creating @@ -111,7 +111,7 @@ public interface LuceneQuery<K, V> { * * @return int value representing the page size of the current query */ - public int getPageSize(); + int getPageSize(); /** * Get limit size setting of current query. This value is the maximum number of results that can @@ -120,6 +120,6 @@ public interface LuceneQuery<K, V> { * * @return int value representing the limit of the current query */ - public int getLimit(); + int getLimit(); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQueryFactory.java ---------------------------------------------------------------------- diff --git a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQueryFactory.java b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQueryFactory.java index 6236d12..38ab983 100644 --- a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQueryFactory.java +++ b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQueryFactory.java @@ -33,12 +33,12 @@ public interface LuceneQueryFactory { /** * Default query result limit is 100 */ - public static final int DEFAULT_LIMIT = 100; + int DEFAULT_LIMIT = 100; /** * Default page size of result is 0, which means no pagination */ - public static final int DEFAULT_PAGESIZE = 0; + int DEFAULT_PAGESIZE = 0; /** * Set page size for a query result. The default page size is 0 which means no pagination. @@ -73,7 +73,7 @@ public interface LuceneQueryFactory { * @param <V> the value type in the query results * @return LuceneQuery object */ - public <K, V> LuceneQuery<K, V> create(String indexName, String regionName, String queryString, + <K, V> LuceneQuery<K, V> create(String indexName, String regionName, String queryString, String defaultField); /** @@ -104,6 +104,6 @@ public interface LuceneQueryFactory { * @param <V> the value type in the query results * @return LuceneQuery object */ - public <K, V> LuceneQuery<K, V> create(String indexName, String regionName, + <K, V> LuceneQuery<K, V> create(String indexName, String regionName, LuceneQueryProvider provider); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQueryProvider.java ---------------------------------------------------------------------- diff --git a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQueryProvider.java b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQueryProvider.java index 2f8a1ed..214adc4 100644 --- a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQueryProvider.java +++ b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneQueryProvider.java @@ -40,6 +40,6 @@ public interface LuceneQueryProvider extends Serializable { * propagated to callers of the {@link LuceneQuery} find methods. */ - public Query getQuery(LuceneIndex index) throws LuceneQueryException; + Query getQuery(LuceneIndex index) throws LuceneQueryException; } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneResultStruct.java ---------------------------------------------------------------------- diff --git a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneResultStruct.java b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneResultStruct.java index dfb8162..71b4b41 100644 --- a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneResultStruct.java +++ b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneResultStruct.java @@ -27,7 +27,7 @@ public interface LuceneResultStruct<K, V> { * @return The region key of the entry matching the query * */ - public K getKey(); + K getKey(); /** * Returns the Apache Geode region key of the result matching the Lucene Query @@ -35,7 +35,7 @@ public interface LuceneResultStruct<K, V> { * @return the region value of the entry matching the query. * */ - public V getValue(); + V getValue(); /** * Return score the score of the entry matching the query. Scores are computed by Lucene based on @@ -44,6 +44,6 @@ public interface LuceneResultStruct<K, V> { * @return float value representing the score of the entry obtained as a result of executing the * Lucene query. */ - public float getScore(); + float getScore(); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneService.java ---------------------------------------------------------------------- diff --git a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneService.java b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneService.java index 31447f1..c4a2c27 100644 --- a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneService.java +++ b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneService.java @@ -100,12 +100,12 @@ public interface LuceneService { * only work if the region value is a String or Number, in which case a Lucene document will be * created with a single field with this name. */ - public String REGION_VALUE_FIELD = "__REGION_VALUE_FIELD"; + String REGION_VALUE_FIELD = "__REGION_VALUE_FIELD"; /** * Get a factory for creating a Lucene index on this member. */ - public LuceneIndexFactory createIndexFactory(); + LuceneIndexFactory createIndexFactory(); /** * Destroy the Lucene index @@ -113,14 +113,14 @@ public interface LuceneService { * @param indexName the name of the index to destroy * @param regionPath the path of the region whose index to destroy */ - public void destroyIndex(String indexName, String regionPath); + void destroyIndex(String indexName, String regionPath); /** * Destroy all the Lucene indexes for the region * * @param regionPath The path of the region on which to destroy the indexes */ - public void destroyIndexes(String regionPath); + void destroyIndexes(String regionPath); /** * Get the Lucene index object specified by region name and index name @@ -129,26 +129,26 @@ public interface LuceneService { * @param regionPath region name * @return LuceneIndex object */ - public LuceneIndex getIndex(String indexName, String regionPath); + LuceneIndex getIndex(String indexName, String regionPath); /** * get all the Lucene indexes. * * @return all index objects in a Collection */ - public Collection<LuceneIndex> getAllIndexes(); + Collection<LuceneIndex> getAllIndexes(); /** * Create a factory for building a Lucene query. */ - public LuceneQueryFactory createLuceneQueryFactory(); + LuceneQueryFactory createLuceneQueryFactory(); /** * returns the cache to which the LuceneService belongs * * @return Cache */ - public Cache getCache(); + Cache getCache(); /** @@ -170,6 +170,6 @@ public interface LuceneService { * * @return true if entries are flushed within timeout, false if the timeout has elapsed */ - public boolean waitUntilFlushed(String indexName, String regionPath, long timeout, TimeUnit unit) + boolean waitUntilFlushed(String indexName, String regionPath, long timeout, TimeUnit unit) throws InterruptedException; } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-lucene/src/main/java/org/apache/geode/cache/lucene/PageableLuceneQueryResults.java ---------------------------------------------------------------------- diff --git a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/PageableLuceneQueryResults.java b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/PageableLuceneQueryResults.java index 2d4ea8c..dba4724 100644 --- a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/PageableLuceneQueryResults.java +++ b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/PageableLuceneQueryResults.java @@ -38,26 +38,26 @@ public interface PageableLuceneQueryResults<K, V> extends Iterator<List<LuceneRe * * @return int value representing total number of hits for this query across all pages. */ - public int size(); + int size(); /** * Returns the maximum score value across all pages. * * @return float value representing the maximum score across all the Lucene result pages. */ - public float getMaxScore(); + float getMaxScore(); /** * Get the next page of results. * * @return a page of results, or null if there are no more pages */ - public List<LuceneResultStruct<K, V>> next(); + List<LuceneResultStruct<K, V>> next(); /** * True if there is another page of results in PageableLuceneQueryResults. * * @return boolean value, true if another Lucene result page is present, false otherwise. */ - public boolean hasNext(); + boolean hasNext(); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexListener.java ---------------------------------------------------------------------- diff --git a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexListener.java b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexListener.java index 0c2c1c7..49de993 100644 --- a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexListener.java +++ b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexListener.java @@ -21,12 +21,12 @@ import java.util.Map; public interface IndexListener { - public void beforeIndexCreated(final String indexName, String regionPath, final Analyzer analyzer, + void beforeIndexCreated(final String indexName, String regionPath, final Analyzer analyzer, final Map<String, Analyzer> fieldAnalyzers, final String... fields); - public void afterIndexCreated(LuceneIndex index); + void afterIndexCreated(LuceneIndex index); - public void beforeIndexDestroyed(LuceneIndex index); + void beforeIndexDestroyed(LuceneIndex index); - public void afterIndexDestroyed(LuceneIndex index); + void afterIndexDestroyed(LuceneIndex index); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/InternalLuceneIndex.java ---------------------------------------------------------------------- diff --git a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/InternalLuceneIndex.java b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/InternalLuceneIndex.java index c28fcdc..9d3bac1 100644 --- a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/InternalLuceneIndex.java +++ b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/InternalLuceneIndex.java @@ -20,16 +20,16 @@ import org.apache.geode.cache.lucene.internal.repository.RepositoryManager; public interface InternalLuceneIndex extends LuceneIndex { - public RepositoryManager getRepositoryManager(); + RepositoryManager getRepositoryManager(); /** * Dump the files for this index to the given directory. */ - public void dumpFiles(String directory); + void dumpFiles(String directory); /** * Destroy the index */ - public void destroy(boolean initiator); + void destroy(boolean initiator); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepository.java ---------------------------------------------------------------------- diff --git a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepository.java b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepository.java index 7323aa0..90d9f33 100644 --- a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepository.java +++ b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepository.java @@ -58,7 +58,7 @@ public interface IndexRepository { * * @throws IOException */ - public void query(Query query, int limit, IndexResultCollector collector) throws IOException; + void query(Query query, int limit, IndexResultCollector collector) throws IOException; /** * Commit the changes to all lucene index @@ -74,7 +74,7 @@ public interface IndexRepository { * * @return true if this repository is closed. */ - public boolean isClosed(); + boolean isClosed(); /** * For debugging purposes, return the underlying IndexWriter http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexResultCollector.java ---------------------------------------------------------------------- diff --git a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexResultCollector.java b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexResultCollector.java index 05b0eda..8f3acf4 100644 --- a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexResultCollector.java +++ b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexResultCollector.java @@ -31,14 +31,14 @@ public interface IndexResultCollector { * * @return Name/identifier of this collector */ - public String getName(); + String getName(); /** * Returns the number of Lucene query results that are being stored in the IndexResultCollector * * @return number of results collected by this collector */ - public int size(); + int size(); /** * Collects a corresponding pair of Apache Geode key and Lucene score assigned to the document http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-lucene/src/main/java/org/apache/geode/cache/lucene/management/LuceneServiceMXBean.java ---------------------------------------------------------------------- diff --git a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/management/LuceneServiceMXBean.java b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/management/LuceneServiceMXBean.java index 80ad575..cea187d 100644 --- a/geode-lucene/src/main/java/org/apache/geode/cache/lucene/management/LuceneServiceMXBean.java +++ b/geode-lucene/src/main/java/org/apache/geode/cache/lucene/management/LuceneServiceMXBean.java @@ -30,7 +30,7 @@ public interface LuceneServiceMXBean { * * @return an array of LuceneIndexMetrics for the LuceneIndexes defined in this member */ - public LuceneIndexMetrics[] listIndexMetrics(); + LuceneIndexMetrics[] listIndexMetrics(); /** * Returns an array of {@link LuceneIndexMetrics} for the @@ -42,7 +42,7 @@ public interface LuceneServiceMXBean { * @return an array of LuceneIndexMetrics for the LuceneIndex instances defined on the input * region in this member */ - public LuceneIndexMetrics[] listIndexMetrics(String regionPath); + LuceneIndexMetrics[] listIndexMetrics(String regionPath); /** * Returns a {@link LuceneIndexMetrics} for the {@link org.apache.geode.cache.lucene.LuceneIndex} @@ -54,5 +54,5 @@ public interface LuceneServiceMXBean { * @return a LuceneIndexMetrics for the LuceneIndex with the input index name defined on the input * region in this member. */ - public LuceneIndexMetrics listIndexMetrics(String regionPath, String indexName); + LuceneIndexMetrics listIndexMetrics(String regionPath, String indexName); } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImplPerformanceTest.java ---------------------------------------------------------------------- diff --git a/geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImplPerformanceTest.java b/geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImplPerformanceTest.java index 46425b9..68b6a97 100644 --- a/geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImplPerformanceTest.java +++ b/geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImplPerformanceTest.java @@ -422,17 +422,17 @@ public class IndexRepositoryImplPerformanceTest { } private interface TestCallbacks { - public void init() throws Exception; + void init() throws Exception; - public int query(Query query) throws Exception; + int query(Query query) throws Exception; - public void addObject(String key, String text) throws Exception; + void addObject(String key, String text) throws Exception; - public void commit() throws Exception; + void commit() throws Exception; - public void waitForAsync() throws Exception; + void waitForAsync() throws Exception; - public void cleanup() throws Exception; + void cleanup() throws Exception; } private static class Results { http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-web-api/src/main/java/org/apache/geode/rest/internal/web/http/converter/CustomMappingJackson2HttpMessageConverter.java ---------------------------------------------------------------------- diff --git a/geode-web-api/src/main/java/org/apache/geode/rest/internal/web/http/converter/CustomMappingJackson2HttpMessageConverter.java b/geode-web-api/src/main/java/org/apache/geode/rest/internal/web/http/converter/CustomMappingJackson2HttpMessageConverter.java index 2db68c7..5787adf 100644 --- a/geode-web-api/src/main/java/org/apache/geode/rest/internal/web/http/converter/CustomMappingJackson2HttpMessageConverter.java +++ b/geode-web-api/src/main/java/org/apache/geode/rest/internal/web/http/converter/CustomMappingJackson2HttpMessageConverter.java @@ -118,9 +118,9 @@ public class CustomMappingJackson2HttpMessageConverter extends MappingJackson2Ht protected interface HttpOutputMessageWrapper extends HttpOutputMessage { - public long getContentLength(); + long getContentLength(); - public void flush() throws IOException; + void flush() throws IOException; } http://git-wip-us.apache.org/repos/asf/geode/blob/f7396e4c/geode-web/src/test/java/org/apache/geode/management/internal/web/http/ClientHttpRequestJUnitTest.java ---------------------------------------------------------------------- diff --git a/geode-web/src/test/java/org/apache/geode/management/internal/web/http/ClientHttpRequestJUnitTest.java b/geode-web/src/test/java/org/apache/geode/management/internal/web/http/ClientHttpRequestJUnitTest.java index a95a58e..39954b9 100644 --- a/geode-web/src/test/java/org/apache/geode/management/internal/web/http/ClientHttpRequestJUnitTest.java +++ b/geode-web/src/test/java/org/apache/geode/management/internal/web/http/ClientHttpRequestJUnitTest.java @@ -538,19 +538,19 @@ public class ClientHttpRequestJUnitTest extends AbstractWebTestCase { } @SuppressWarnings("unused") - private static interface Library { - public String getName(); + private interface Library { + String getName(); } @SuppressWarnings("unused") - private static interface Book { - public String getAuthor(); + private interface Book { + String getAuthor(); - public String getIsbn(); + String getIsbn(); - public String getTitle(); + String getTitle(); - public Integer getYear(); + Integer getYear(); } }