[geode-native] branch develop updated: GEODE-4278: Use int8_t for byte to match server byte. (#210)

[jbarrett]

This is an automated email from the ASF dual-hosted git repository.

jbarrett pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode-native.git


The following commit(s) were added to refs/heads/develop by this push:
     new 0fbe93e  GEODE-4278: Use int8_t for byte to match server byte. (#210)
0fbe93e is described below

commit 0fbe93e9f3ac33d143d7d614d8977b9060664804
Author: Jacob Barrett <jbarr...@pivotal.io>
AuthorDate: Tue Feb 6 13:57:59 2018 -0800

    GEODE-4278: Use int8_t for byte to match server byte. (#210)
---
 cppcache/include/geode/CacheableBuiltins.hpp | 4 ++--
 cppcache/test/CacheableKeyCreateTests.cpp    | 4 ++--
 cppcache/test/SerializableCreateTests.cpp    | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/cppcache/include/geode/CacheableBuiltins.hpp 
b/cppcache/include/geode/CacheableBuiltins.hpp
index 11479b6..29be0c3 100644
--- a/cppcache/include/geode/CacheableBuiltins.hpp
+++ b/cppcache/include/geode/CacheableBuiltins.hpp
@@ -439,12 +439,12 @@ _GEODE_CACHEABLE_KEY_TYPE_DEF_(bool, CacheableBoolean, 3);
  */
 _GEODE_CACHEABLE_KEY_TYPE_(bool, CacheableBoolean, 3);
 
-_GEODE_CACHEABLE_KEY_TYPE_DEF_(uint8_t, CacheableByte, 15);
+_GEODE_CACHEABLE_KEY_TYPE_DEF_(int8_t, CacheableByte, 15);
 /**
  * An immutable wrapper for bytes that can serve as
  * a distributable key object for caching.
  */
-_GEODE_CACHEABLE_KEY_TYPE_(uint8_t, CacheableByte, 15);
+_GEODE_CACHEABLE_KEY_TYPE_(int8_t, CacheableByte, 15);
 
 _GEODE_CACHEABLE_KEY_TYPE_DEF_(double, CacheableDouble, 63);
 /**
diff --git a/cppcache/test/CacheableKeyCreateTests.cpp 
b/cppcache/test/CacheableKeyCreateTests.cpp
index a14c46a..5a1aea6 100644
--- a/cppcache/test/CacheableKeyCreateTests.cpp
+++ b/cppcache/test/CacheableKeyCreateTests.cpp
@@ -73,8 +73,8 @@ TEST(CacheableKeyCreateTests, forArrayOf_wchar_t) {
   EXPECT_EQ(cacheableString->value(), "test");
 }
 
-TEST(CacheableKeyCreateTests, for_uint8_t) {
-  const auto cacheableKey = CacheableKey::create(static_cast<uint8_t>(1));
+TEST(CacheableKeyCreateTests, for_int8_t) {
+  const auto cacheableKey = CacheableKey::create(static_cast<int8_t>(1));
   ASSERT_TRUE(nullptr != cacheableKey);
   auto&& cacheableByte = 
std::dynamic_pointer_cast<CacheableByte>(cacheableKey);
   ASSERT_TRUE(nullptr != cacheableByte);
diff --git a/cppcache/test/SerializableCreateTests.cpp 
b/cppcache/test/SerializableCreateTests.cpp
index d85fddd..37fb162 100644
--- a/cppcache/test/SerializableCreateTests.cpp
+++ b/cppcache/test/SerializableCreateTests.cpp
@@ -72,8 +72,8 @@ TEST(SerializableCreateTests, forArrayOf_wchar_t) {
   ASSERT_EQ(cacheableString->value(), "test");
 }
 
-TEST(SerializableCreateTests, for_uint8_t) {
-  const auto serializable = Serializable::create(static_cast<uint8_t>(1));
+TEST(SerializableCreateTests, for_int8_t) {
+  const auto serializable = Serializable::create(static_cast<int8_t>(1));
   ASSERT_TRUE(nullptr != serializable);
   auto&& cacheableByte = 
std::dynamic_pointer_cast<CacheableByte>(serializable);
   ASSERT_TRUE(nullptr != cacheableByte);

-- 
To stop receiving notification emails like this one, please contact
jbarr...@apache.org.