(grails-data-hibernate6) 02/03: Fixed handling associations inside of closures

2025-04-25 Thread borinquenkid
This is an automated email from the ASF dual-hosted git repository. borinquenkid pushed a commit to branch hibernate6 in repository https://gitbox.apache.org/repos/asf/grails-data-hibernate6.git commit 7f258cce1cef84b33b3e36330e27c94130dd76e3 Author: Walter Duque de Estrada AuthorDate: Thu Apr 1

(grails-data-hibernate6) branch hibernate6 updated (930808ed -> 9c0adf3d)

2025-04-25 Thread borinquenkid
This is an automated email from the ASF dual-hosted git repository. borinquenkid pushed a change to branch hibernate6 in repository https://gitbox.apache.org/repos/asf/grails-data-hibernate6.git from 930808ed code fixes new 205e5c2a Fixed handling associations inside of closures ne

(grails-data-hibernate6) 03/03: More comments

2025-04-25 Thread borinquenkid
This is an automated email from the ASF dual-hosted git repository. borinquenkid pushed a commit to branch hibernate6 in repository https://gitbox.apache.org/repos/asf/grails-data-hibernate6.git commit 9c0adf3d3feb2f733e7aac00a9f9467a3ba66cd5 Author: Walter Duque de Estrada AuthorDate: Fri Apr 2

(grails-data-hibernate6) 01/03: Fixed handling associations inside of closures

2025-04-25 Thread borinquenkid
This is an automated email from the ASF dual-hosted git repository. borinquenkid pushed a commit to branch hibernate6 in repository https://gitbox.apache.org/repos/asf/grails-data-hibernate6.git commit 205e5c2a4be8fe1954475988cf1043aab500ecf6 Author: Walter Duque de Estrada AuthorDate: Sun Apr 1

Re: [PR] Working towards reproducible builds [grails-core]

2025-04-25 Thread via GitHub
jdaugherty commented on PR #14670: URL: https://github.com/apache/grails-core/pull/14670#issuecomment-2831562368 @jamesfredley @matrei I think we should merge this PR (assuming tests pass) and then create a ticket to track this in the long run. If we have any volunteers to dig into the dom

Re: [PR] Working towards reproducible builds [grails-core]

2025-04-25 Thread via GitHub
jdaugherty commented on PR #14670: URL: https://github.com/apache/grails-core/pull/14670#issuecomment-2831561402 I have not done any research on gson / markup / gsp differences. Some projects ship with gsps, so we'll need to also investigate those. -- This is an automated message from the

Re: [PR] Working towards reproducible builds [grails-core]

2025-04-25 Thread via GitHub
jdaugherty commented on PR #14670: URL: https://github.com/apache/grails-core/pull/14670#issuecomment-2831560525 ### Jars with Differences grails-async/core/build/libs/grails-async-core-7.0.0-SNAPSHOT-javadoc.jar grails-cache/build/libs/grails-cache-7.0.0-

Re: [PR] Working towards reproducible builds [grails-core]

2025-04-25 Thread via GitHub
jdaugherty commented on PR #14670: URL: https://github.com/apache/grails-core/pull/14670#issuecomment-2831362071 One of my discoveries with this change is that the Gorm transforms expect to alternate; that is if you have the following nodes to visit: ClassNode BookServi

(grails-core) branch use-webjar-jquery-bootstrap deleted (was 666642acbe)

2025-04-25 Thread jamesfredley
This is an automated email from the ASF dual-hosted git repository. jamesfredley pushed a change to branch use-webjar-jquery-bootstrap in repository https://gitbox.apache.org/repos/asf/grails-core.git was 42acbe Merge branch '7.0.x' into use-webjar-jquery-bootstrap The revisions that w

Re: [PR] use webjars dependencies to provide jquery and bootstrap js libraries [grails-core]

2025-04-25 Thread via GitHub
jamesfredley merged PR #14671: URL: https://github.com/apache/grails-core/pull/14671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

(grails-core) branch use-webjar-jquery-bootstrap updated (2e443a2351 -> 666642acbe)

2025-04-25 Thread jamesfredley
This is an automated email from the ASF dual-hosted git repository. jamesfredley pushed a change to branch use-webjar-jquery-bootstrap in repository https://gitbox.apache.org/repos/asf/grails-core.git from 2e443a2351 rename webjar-asset-pipeline-config.gradle to test-webjar-asset-config.gra

(grails-core) 01/01: Merge pull request #14671 from apache/use-webjar-jquery-bootstrap

2025-04-25 Thread jamesfredley
This is an automated email from the ASF dual-hosted git repository. jamesfredley pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/grails-core.git commit b9a61f37aed43163dc9f8109122e7bc5c52d546a Merge: 1897bf11a2 42acbe Author: James Fredley AuthorDate: Fri Ap

(grails-core) branch 7.0.x updated (1897bf11a2 -> b9a61f37ae)

2025-04-25 Thread jamesfredley
This is an automated email from the ASF dual-hosted git repository. jamesfredley pushed a change to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/grails-core.git from 1897bf11a2 Merge pull request #14668 from matrei/custom-timestamp-test add 4261287203 remove jquery and

Re: [PR] CI, Build and Test updates [grails-core]

2025-04-25 Thread via GitHub
matrei merged PR #14668: URL: https://github.com/apache/grails-core/pull/14668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@grail

(grails-core) 01/01: Merge pull request #14668 from matrei/custom-timestamp-test

2025-04-25 Thread matrei
This is an automated email from the ASF dual-hosted git repository. matrei pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/grails-core.git commit 1897bf11a29cf3dbab90dad1826ebe240c0b3634 Merge: 4e2a5850ce 2d860b2347 Author: Mattias Reichel AuthorDate: Fri Apr 25

(grails-core) branch 7.0.x updated (4e2a5850ce -> 1897bf11a2)

2025-04-25 Thread matrei
This is an automated email from the ASF dual-hosted git repository. matrei pushed a change to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/grails-core.git from 4e2a5850ce Revert "Revert "Revert "reproducible builds""" add 5f0ac50303 test: stabilize flaky `CustomAutoTim

Re: [PR] CI, Build and Test updates [grails-core]

2025-04-25 Thread via GitHub
jdaugherty commented on code in PR #14668: URL: https://github.com/apache/grails-core/pull/14668#discussion_r2060670907 ## grails-datamapping-core-test/src/test/groovy/org/grails/datastore/gorm/CustomAutoTimestampSpec.groovy: ## @@ -22,15 +22,9 @@ import grails.gorm.annotation.A

Re: [PR] Update `SimpleDataBinder.groovy` reference [grails-core]

2025-04-25 Thread via GitHub
emmanuel-ferdman commented on PR #14669: URL: https://github.com/apache/grails-core/pull/14669#issuecomment-2831002959 @matrei should be good now, thanks for the review :smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [I] Basic Contribution Requirements [grails-core]

2025-04-25 Thread via GitHub
jamesfredley commented on issue #13754: URL: https://github.com/apache/grails-core/issues/13754#issuecomment-2830713282 grails-forge enforces checkstyle and spotless on build and CI. It's config might be worth reviewing, although grails-core can be configured however makes the most sense.

(grails-core) branch add-licence-header-css-js updated (84f9b6e801 -> 2104cd8c13)

2025-04-25 Thread jamesfredley
This is an automated email from the ASF dual-hosted git repository. jamesfredley pushed a change to branch add-licence-header-css-js in repository https://gitbox.apache.org/repos/asf/grails-core.git from 84f9b6e801 Remove license on sdkmanrc since it has been added to exclude add 2e443

Re: [I] Basic Contribution Requirements [grails-core]

2025-04-25 Thread via GitHub
jamesfredley commented on issue #13754: URL: https://github.com/apache/grails-core/issues/13754#issuecomment-2830718301 Timing wise, we should have two more projects merged into grails-core (grails-wrapper and grails-profiles) and have license headers wrapped up next week and then it would

Re: [PR] use webjars dependencies to provide jquery and bootstrap js libraries [grails-core]

2025-04-25 Thread via GitHub
jamesfredley commented on code in PR #14671: URL: https://github.com/apache/grails-core/pull/14671#discussion_r2060410418 ## grails-data-neo4j/examples/grails3-neo4j-hibernate/build.gradle: ## @@ -80,3 +84,7 @@ webdriverBinaries { geckodriver "$geckodriverVersion"

(grails-core) branch use-webjar-jquery-bootstrap updated (a27666be8f -> 2e443a2351)

2025-04-25 Thread jamesfredley
This is an automated email from the ASF dual-hosted git repository. jamesfredley pushed a change to branch use-webjar-jquery-bootstrap in repository https://gitbox.apache.org/repos/asf/grails-core.git from a27666be8f Merge branch '7.0.x' into use-webjar-jquery-bootstrap add 2e443a2351 r

Re: [PR] use webjars dependencies to provide jquery and bootstrap js libraries [grails-core]

2025-04-25 Thread via GitHub
jamesfredley commented on code in PR #14671: URL: https://github.com/apache/grails-core/pull/14671#discussion_r2060426714 ## gradle/webjar-asset-pipeline-config.gradle: ## Review Comment: I guess we could check if the plugin has been applied, though. -- This is an autom

Re: [PR] use webjars dependencies to provide jquery and bootstrap js libraries [grails-core]

2025-04-25 Thread via GitHub
jamesfredley commented on code in PR #14671: URL: https://github.com/apache/grails-core/pull/14671#discussion_r2060424803 ## gradle/webjar-asset-pipeline-config.gradle: ## Review Comment: Also if we put this on all functional tests, we would have to add the `asset-pipeline

Re: [PR] use webjars dependencies to provide jquery and bootstrap js libraries [grails-core]

2025-04-25 Thread via GitHub
jamesfredley commented on code in PR #14671: URL: https://github.com/apache/grails-core/pull/14671#discussion_r2060426714 ## gradle/webjar-asset-pipeline-config.gradle: ## Review Comment: I guess we could check that though. -- This is an automated message from the Apa

Re: [PR] use webjars dependencies to provide jquery and bootstrap js libraries [grails-core]

2025-04-25 Thread via GitHub
jamesfredley commented on code in PR #14671: URL: https://github.com/apache/grails-core/pull/14671#discussion_r2060413465 ## gradle/webjar-asset-pipeline-config.gradle: ## Review Comment: Glad to update the name. It is only used in functional tests and those two in grails

Re: [PR] use webjars dependencies to provide jquery and bootstrap js libraries [grails-core]

2025-04-25 Thread via GitHub
jamesfredley commented on code in PR #14671: URL: https://github.com/apache/grails-core/pull/14671#discussion_r2060410418 ## grails-data-neo4j/examples/grails3-neo4j-hibernate/build.gradle: ## @@ -80,3 +84,7 @@ webdriverBinaries { geckodriver "$geckodriverVersion"

Re: [PR] CI, Build and Test updates [grails-core]

2025-04-25 Thread via GitHub
jdaugherty commented on code in PR #14668: URL: https://github.com/apache/grails-core/pull/14668#discussion_r2060160659 ## grails-gradle/plugins/src/e2eTest/resources/publish-projects/legacy-apply/child-project-with-unrelated-parent/build.gradle: ## @@ -20,6 +20,7 @@ buildscrip

Re: [PR] CI, Build and Test updates [grails-core]

2025-04-25 Thread via GitHub
matrei commented on code in PR #14668: URL: https://github.com/apache/grails-core/pull/14668#discussion_r2059619650 ## grails-datamapping-core-test/src/test/groovy/org/grails/datastore/gorm/CustomAutoTimestampSpec.groovy: ## @@ -22,15 +22,9 @@ import grails.gorm.annotation.AutoT