[2/2] guacamole-server git commit: GUACAMOLE-623: Merge include dependencies of Kubernetes support in Docker image build.
GUACAMOLE-623: Merge include dependencies of Kubernetes support in Docker image build. Project: http://git-wip-us.apache.org/repos/asf/guacamole-server/repo Commit: http://git-wip-us.apache.org/repos/asf/guacamole-server/commit/356dcef9 Tree: http://git-wip-us.apache.org/repos/asf/guacamole-server/tree/356dcef9 Diff: http://git-wip-us.apache.org/repos/asf/guacamole-server/diff/356dcef9 Branch: refs/heads/master Commit: 356dcef9e80ff68f1bd19d0563132c567c2dd5c6 Parents: 7352d66 64b1572 Author: Nick Couchman Authored: Thu Sep 27 21:25:30 2018 -0400 Committer: Nick Couchman Committed: Thu Sep 27 21:25:30 2018 -0400 -- Dockerfile | 1 + 1 file changed, 1 insertion(+) --
[1/2] guacamole-server git commit: GUACAMOLE-623: Include dependences of Kubernetes support in Docker image build.
Repository: guacamole-server Updated Branches: refs/heads/master 7352d6681 -> 356dcef9e GUACAMOLE-623: Include dependences of Kubernetes support in Docker image build. Project: http://git-wip-us.apache.org/repos/asf/guacamole-server/repo Commit: http://git-wip-us.apache.org/repos/asf/guacamole-server/commit/64b1572d Tree: http://git-wip-us.apache.org/repos/asf/guacamole-server/tree/64b1572d Diff: http://git-wip-us.apache.org/repos/asf/guacamole-server/diff/64b1572d Branch: refs/heads/master Commit: 64b1572d13f573b310c5b60d8e83f760a473cb54 Parents: b0be808 Author: Michael Jumper Authored: Wed Sep 26 19:36:55 2018 -0700 Committer: Michael Jumper Committed: Thu Sep 27 09:34:53 2018 -0700 -- Dockerfile | 1 + 1 file changed, 1 insertion(+) -- http://git-wip-us.apache.org/repos/asf/guacamole-server/blob/64b1572d/Dockerfile -- diff --git a/Dockerfile b/Dockerfile index 4d463a3..d903c4a 100644 --- a/Dockerfile +++ b/Dockerfile @@ -49,6 +49,7 @@ ARG BUILD_DEPENDENCIES=" \ libtelnet-dev \ libtool \ libvncserver-dev \ +libwebsockets-dev \ libwebp-dev \ make"
[1/2] guacamole-server git commit: GUACAMOLE-623: Start terminal once Kubernetes connection is ready (necessary since merge of GUACAMOLE-622).
Repository: guacamole-server
Updated Branches:
refs/heads/master b0be80803 -> 7352d6681
GUACAMOLE-623: Start terminal once Kubernetes connection is ready (necessary
since merge of GUACAMOLE-622).
Project: http://git-wip-us.apache.org/repos/asf/guacamole-server/repo
Commit: http://git-wip-us.apache.org/repos/asf/guacamole-server/commit/7374b293
Tree: http://git-wip-us.apache.org/repos/asf/guacamole-server/tree/7374b293
Diff: http://git-wip-us.apache.org/repos/asf/guacamole-server/diff/7374b293
Branch: refs/heads/master
Commit: 7374b29364a1d4e9d095843b014ce0ea19add0b9
Parents: b0be808
Author: Michael Jumper
Authored: Wed Sep 26 22:05:46 2018 -0700
Committer: Michael Jumper
Committed: Thu Sep 27 09:33:31 2018 -0700
--
src/protocols/kubernetes/kubernetes.c | 5 +
1 file changed, 5 insertions(+)
--
http://git-wip-us.apache.org/repos/asf/guacamole-server/blob/7374b293/src/protocols/kubernetes/kubernetes.c
--
diff --git a/src/protocols/kubernetes/kubernetes.c
b/src/protocols/kubernetes/kubernetes.c
index e115fc5..7c22c42 100644
--- a/src/protocols/kubernetes/kubernetes.c
+++ b/src/protocols/kubernetes/kubernetes.c
@@ -64,6 +64,8 @@ static int guac_kubernetes_lws_callback(struct lws* wsi,
void* in, size_t length) {
guac_client* client = guac_kubernetes_lws_current_client;
+guac_kubernetes_client* kubernetes_client =
+(guac_kubernetes_client*) client->data;
/* Do not handle any further events if connection is closing */
if (client->state != GUAC_CLIENT_RUNNING) {
@@ -94,6 +96,9 @@ static int guac_kubernetes_lws_callback(struct lws* wsi,
guac_client_log(client, GUAC_LOG_INFO,
"Kubernetes connection successful.");
+/* Allow terminal to render */
+guac_terminal_start(kubernetes_client->term);
+
/* Schedule check for pending messages in case messages were added
* to the outbound message buffer prior to the connection being
* fully established */
[jira] [Created] (GUACAMOLE-633) Error: /lib64/libavutil.a(eval.o): undefined reference to symbol 'acos@@GLIBC_2.2.5
ImCylon created GUACAMOLE-633: - Summary: Error: /lib64/libavutil.a(eval.o): undefined reference to symbol 'acos@@GLIBC_2.2.5 Key: GUACAMOLE-633 URL: https://issues.apache.org/jira/browse/GUACAMOLE-633 Project: Guacamole Issue Type: Bug Components: guacenc Affects Versions: 1.0.0 Environment: Slackware 14.2_64 x86_64 Intel(R) Core(TM) i5-2500 CPU @ 3.30GHz GenuineIntel GNU/Linux ffmpeg version 3.4.2 NVIDIA Driver Version: 340.107 gcc (GCC) 7.3.0 Reporter: ImCylon $make -j3 (tail output) /usr/bin/ld: /usr/lib64/gcc/x86_64-slackware-linux/7.3.0/../../../../lib64/libavutil.a(eval.o): undefined reference to symbol 'acos@@GLIBC_2.2.5' /lib64/libm.so.6: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status make[2]: *** [Makefile:584: guacenc] Error 1 make[2]: Leaving directory '/home/setup/programs/geral/guacamole-0.9.14/guacamole-server-master/src/guacenc' make[1]: *** [Makefile:513: all-recursive] Error 1 make[1]: Leaving directory '/home/setup/programs/geral/guacamole-0.9.14/guacamole-server-master' make: *** [Makefile:435: all] Error 2 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (GUACAMOLE-633) Error: /lib64/libavutil.a(eval.o): undefined reference to symbol 'acos@@GLIBC_2.2.5
[ https://issues.apache.org/jira/browse/GUACAMOLE-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Jumper closed GUACAMOLE-633. Resolution: Invalid > Error: /lib64/libavutil.a(eval.o): undefined reference to symbol > 'acos@@GLIBC_2.2.5 > --- > > Key: GUACAMOLE-633 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-633 > Project: Guacamole > Issue Type: Bug > Components: guacenc >Affects Versions: 1.0.0 > Environment: Slackware 14.2_64 > x86_64 Intel(R) Core(TM) i5-2500 CPU @ 3.30GHz GenuineIntel GNU/Linux > ffmpeg version 3.4.2 > NVIDIA Driver Version: 340.107 > gcc (GCC) 7.3.0 >Reporter: ImCylon >Priority: Major > Labels: build > Original Estimate: 24h > Remaining Estimate: 24h > > $make -j3 (tail output) > /usr/bin/ld: > /usr/lib64/gcc/x86_64-slackware-linux/7.3.0/../../../../lib64/libavutil.a(eval.o): > undefined reference to symbol 'acos@@GLIBC_2.2.5' > /lib64/libm.so.6: error adding symbols: DSO missing from command line > collect2: error: ld returned 1 exit status > make[2]: *** [Makefile:584: guacenc] Error 1 > make[2]: Leaving directory > '/home/setup/programs/geral/guacamole-0.9.14/guacamole-server-master/src/guacenc' > > make[1]: *** [Makefile:513: all-recursive] Error 1 > make[1]: Leaving directory > '/home/setup/programs/geral/guacamole-0.9.14/guacamole-server-master' > make: *** [Makefile:435: all] Error 2 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GUACAMOLE-633) Error: /lib64/libavutil.a(eval.o): undefined reference to symbol 'acos@@GLIBC_2.2.5
[
https://issues.apache.org/jira/browse/GUACAMOLE-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629847#comment-16629847
]
Michael Jumper commented on GUACAMOLE-633:
--
Your libavutil was packaged/built incorrectly and should have been linked
against libm at build time. Built in this way, software that links against
libavutil will not work unless that software happens to link against libm on
its own.
You can work around this by setting {{LDFLAGS=-lm}} for now, but I suggest
reporting this to the package maintainer of your libavutil package. This may be
a bug in your libavutil package, or it may be a bug in libavutil, but this is
not a bug in Guacamole.
> Error: /lib64/libavutil.a(eval.o): undefined reference to symbol
> 'acos@@GLIBC_2.2.5
> ---
>
> Key: GUACAMOLE-633
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-633
> Project: Guacamole
> Issue Type: Bug
> Components: guacenc
>Affects Versions: 1.0.0
> Environment: Slackware 14.2_64
> x86_64 Intel(R) Core(TM) i5-2500 CPU @ 3.30GHz GenuineIntel GNU/Linux
> ffmpeg version 3.4.2
> NVIDIA Driver Version: 340.107
> gcc (GCC) 7.3.0
>Reporter: ImCylon
>Priority: Major
> Labels: build
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> $make -j3 (tail output)
> /usr/bin/ld:
> /usr/lib64/gcc/x86_64-slackware-linux/7.3.0/../../../../lib64/libavutil.a(eval.o):
> undefined reference to symbol 'acos@@GLIBC_2.2.5'
> /lib64/libm.so.6: error adding symbols: DSO missing from command line
> collect2: error: ld returned 1 exit status
> make[2]: *** [Makefile:584: guacenc] Error 1
> make[2]: Leaving directory
> '/home/setup/programs/geral/guacamole-0.9.14/guacamole-server-master/src/guacenc'
>
> make[1]: *** [Makefile:513: all-recursive] Error 1
> make[1]: Leaving directory
> '/home/setup/programs/geral/guacamole-0.9.14/guacamole-server-master'
> make: *** [Makefile:435: all] Error 2
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[5/6] guacamole-server git commit: GUACAMOLE-623: Kill connection if libwebsockets is destroying the underlying WebSocket.
GUACAMOLE-623: Kill connection if libwebsockets is destroying the underlying WebSocket. Older versions of libwebsockets will not necessarily invoke close events under all circumstances, and will instead sometimes summarily destroy the WebSocket. Thankfully there is another event for that, and newer versions of libwebsockets continue to define that event. We can hook into both to handle disconnect. Project: http://git-wip-us.apache.org/repos/asf/guacamole-server/repo Commit: http://git-wip-us.apache.org/repos/asf/guacamole-server/commit/9c593bde Tree: http://git-wip-us.apache.org/repos/asf/guacamole-server/tree/9c593bde Diff: http://git-wip-us.apache.org/repos/asf/guacamole-server/diff/9c593bde Branch: refs/heads/master Commit: 9c593bde89891522324fe84034e4a9bd415aae2c Parents: 44d3433 Author: Michael Jumper Authored: Wed Sep 26 22:30:08 2018 -0700 Committer: Michael Jumper Committed: Wed Sep 26 22:31:25 2018 -0700 -- src/protocols/kubernetes/kubernetes.c | 1 + 1 file changed, 1 insertion(+) -- http://git-wip-us.apache.org/repos/asf/guacamole-server/blob/9c593bde/src/protocols/kubernetes/kubernetes.c -- diff --git a/src/protocols/kubernetes/kubernetes.c b/src/protocols/kubernetes/kubernetes.c index 66fc27d..e115fc5 100644 --- a/src/protocols/kubernetes/kubernetes.c +++ b/src/protocols/kubernetes/kubernetes.c @@ -120,6 +120,7 @@ static int guac_kubernetes_lws_callback(struct lws* wsi, #endif /* Connection closed */ +case LWS_CALLBACK_WSI_DESTROY: case LWS_CALLBACK_CLOSED: guac_client_stop(client); guac_client_log(client, GUAC_LOG_DEBUG, "WebSocket connection to "
[2/6] guacamole-server git commit: GUACAMOLE-623: Use libwebsockets' dummy callback only if defined.
GUACAMOLE-623: Use libwebsockets' dummy callback only if defined.
Project: http://git-wip-us.apache.org/repos/asf/guacamole-server/repo
Commit: http://git-wip-us.apache.org/repos/asf/guacamole-server/commit/b48a1b3a
Tree: http://git-wip-us.apache.org/repos/asf/guacamole-server/tree/b48a1b3a
Diff: http://git-wip-us.apache.org/repos/asf/guacamole-server/diff/b48a1b3a
Branch: refs/heads/master
Commit: b48a1b3a5d15e6c95fa64222342033eb584dc0a3
Parents: d8618b0
Author: Michael Jumper
Authored: Wed Sep 26 21:51:07 2018 -0700
Committer: Michael Jumper
Committed: Wed Sep 26 21:51:07 2018 -0700
--
configure.ac | 8
src/protocols/kubernetes/kubernetes.c | 11 ++-
2 files changed, 18 insertions(+), 1 deletion(-)
--
http://git-wip-us.apache.org/repos/asf/guacamole-server/blob/b48a1b3a/configure.ac
--
diff --git a/configure.ac b/configure.ac
index bb23f62..672d19e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1224,6 +1224,14 @@ then
[Whether LCCSCF_USE_SSL is defined])],,
[#include ])
+# Older versions of libwebsockets do not define a dummy callback which
+# must be invoked after the main event callback is invoked; the main event
+# callback must instead manually return zero
+AC_CHECK_DECL([lws_callback_http_dummy],
+[AC_DEFINE([HAVE_LWS_CALLBACK_HTTP_DUMMY],,
+ [Whether lws_callback_http_dummy() is defined])],,
+[#include ])
+
fi
AM_CONDITIONAL([ENABLE_WEBSOCKETS],
http://git-wip-us.apache.org/repos/asf/guacamole-server/blob/b48a1b3a/src/protocols/kubernetes/kubernetes.c
--
diff --git a/src/protocols/kubernetes/kubernetes.c
b/src/protocols/kubernetes/kubernetes.c
index 9cb0b13..fb38d68 100644
--- a/src/protocols/kubernetes/kubernetes.c
+++ b/src/protocols/kubernetes/kubernetes.c
@@ -66,8 +66,13 @@ static int guac_kubernetes_lws_callback(struct lws* wsi,
guac_client* client = guac_kubernetes_lws_current_client;
/* Do not handle any further events if connection is closing */
-if (client->state != GUAC_CLIENT_RUNNING)
+if (client->state != GUAC_CLIENT_RUNNING) {
+#ifdef HAVE_LWS_CALLBACK_HTTP_DUMMY
return lws_callback_http_dummy(wsi, reason, user, in, length);
+#else
+return 0;
+#endif
+}
switch (reason) {
@@ -127,7 +132,11 @@ static int guac_kubernetes_lws_callback(struct lws* wsi,
}
+#ifdef HAVE_LWS_CALLBACK_HTTP_DUMMY
return lws_callback_http_dummy(wsi, reason, user, in, length);
+#else
+return 0;
+#endif
}
[1/6] guacamole-server git commit: GUACAMOLE-623: Support older libwebsockets SSL initialization.
Repository: guacamole-server
Updated Branches:
refs/heads/master af93cfb32 -> b0be80803
GUACAMOLE-623: Support older libwebsockets SSL initialization.
Project: http://git-wip-us.apache.org/repos/asf/guacamole-server/repo
Commit: http://git-wip-us.apache.org/repos/asf/guacamole-server/commit/d8618b06
Tree: http://git-wip-us.apache.org/repos/asf/guacamole-server/tree/d8618b06
Diff: http://git-wip-us.apache.org/repos/asf/guacamole-server/diff/d8618b06
Branch: refs/heads/master
Commit: d8618b0682e69ca5c99f0608368f21188d16fce3
Parents: af93cfb
Author: Michael Jumper
Authored: Wed Sep 26 21:50:19 2018 -0700
Committer: Michael Jumper
Committed: Wed Sep 26 21:50:19 2018 -0700
--
configure.ac | 22 --
src/protocols/kubernetes/kubernetes.c | 6 ++
2 files changed, 26 insertions(+), 2 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/guacamole-server/blob/d8618b06/configure.ac
--
diff --git a/configure.ac b/configure.ac
index d26db39..bb23f62 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1198,14 +1198,32 @@ then
have_libwebsockets=no])
fi
-# Check for client-specific closed event, which must be used in favor of the
-# generic closed event if libwebsockets is recent enough to provide this
if test "x$with_websockets" != "xno"
then
+
+# Check for client-specific closed event, which must be used in favor of
+# the generic closed event if libwebsockets is recent enough to provide
+# this
AC_CHECK_DECL([LWS_CALLBACK_CLIENT_CLOSED],
[AC_DEFINE([HAVE_LWS_CALLBACK_CLIENT_CLOSED],,
[Whether LWS_CALLBACK_CLIENT_CLOSED is defined])],,
[#include ])
+
+# Older versions of libwebsockets may not define a flag for requesting
+# global initialization of OpenSSL, instead performing that initialization
+# by default
+AC_CHECK_DECL([LWS_SERVER_OPTION_DO_SSL_GLOBAL_INIT],
+[AC_DEFINE([HAVE_LWS_SERVER_OPTION_DO_SSL_GLOBAL_INIT],,
+ [Whether LWS_SERVER_OPTION_DO_SSL_GLOBAL_INIT is
defined])],,
+[#include ])
+
+# Older versions of libwebsockets do not define special macros for SSL
+# connection flags, instead relying on documented integer values
+AC_CHECK_DECL([LCCSCF_USE_SSL],
+[AC_DEFINE([HAVE_LCCSCF_USE_SSL],,
+ [Whether LCCSCF_USE_SSL is defined])],,
+[#include ])
+
fi
AM_CONDITIONAL([ENABLE_WEBSOCKETS],
http://git-wip-us.apache.org/repos/asf/guacamole-server/blob/d8618b06/src/protocols/kubernetes/kubernetes.c
--
diff --git a/src/protocols/kubernetes/kubernetes.c
b/src/protocols/kubernetes/kubernetes.c
index f314c59..9cb0b13 100644
--- a/src/protocols/kubernetes/kubernetes.c
+++ b/src/protocols/kubernetes/kubernetes.c
@@ -268,9 +268,15 @@ void* guac_kubernetes_client_thread(void* data) {
* do our own validation - libwebsockets does not validate properly if
* IP addresses are used. */
if (settings->use_ssl) {
+#ifdef HAVE_LWS_SERVER_OPTION_DO_SSL_GLOBAL_INIT
context_info.options = LWS_SERVER_OPTION_DO_SSL_GLOBAL_INIT;
+#endif
+#ifdef HAVE_LCCSCF_USE_SSL
connection_info.ssl_connection = LCCSCF_USE_SSL
| LCCSCF_SKIP_SERVER_CERT_HOSTNAME_CHECK;
+#else
+connection_info.ssl_connection = 2; /* SSL + no hostname check */
+#endif
}
/* Create libwebsockets context */
[4/6] guacamole-server git commit: GUACAMOLE-623: Explicitly bypass certificate checks if requested.
GUACAMOLE-623: Explicitly bypass certificate checks if requested.
For older versions of libwebsockets, simply requesting that OpenSSL
ignore the verification result is insufficient, as libwebsockets
manually checks and confirms the verification result, producing an error
in all but specific cases.
Project: http://git-wip-us.apache.org/repos/asf/guacamole-server/repo
Commit: http://git-wip-us.apache.org/repos/asf/guacamole-server/commit/44d3433e
Tree: http://git-wip-us.apache.org/repos/asf/guacamole-server/tree/44d3433e
Diff: http://git-wip-us.apache.org/repos/asf/guacamole-server/diff/44d3433e
Branch: refs/heads/master
Commit: 44d3433ea92de6de7d127f93335c0a5be47c735c
Parents: 7ee6248
Author: Michael Jumper
Authored: Wed Sep 26 22:01:43 2018 -0700
Committer: Michael Jumper
Committed: Wed Sep 26 22:01:46 2018 -0700
--
src/protocols/kubernetes/ssl.c | 28 ++--
1 file changed, 26 insertions(+), 2 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/guacamole-server/blob/44d3433e/src/protocols/kubernetes/ssl.c
--
diff --git a/src/protocols/kubernetes/ssl.c b/src/protocols/kubernetes/ssl.c
index 6ebafc6..520ce8c 100644
--- a/src/protocols/kubernetes/ssl.c
+++ b/src/protocols/kubernetes/ssl.c
@@ -110,6 +110,27 @@ static EVP_PKEY* guac_kubernetes_read_key(char* pem) {
}
+/**
+ * OpenSSL certificate verification callback which universally accepts all
+ * certificates without performing any verification at all.
+ *
+ * @param x509_ctx
+ * The current context of the certificate verification process. This
+ * parameter is ignored by this particular implementation of the callback.
+ *
+ * @param arg
+ * The arbitrary value passed to SSL_CTX_set_cert_verify_callback(). This
+ * parameter is ignored by this particular implementation of the callback.
+ *
+ * @return
+ * Strictly 0 if certificate verification fails, 1 if the certificate is
+ * verified. No other values are legal return values for this callback as
+ * documented by OpenSSL.
+ */
+static int guac_kubernetes_assume_cert_ok(X509_STORE_CTX* x509_ctx, void* arg)
{
+return 1;
+}
+
void guac_kubernetes_init_ssl(guac_client* client, SSL_CTX* context) {
guac_kubernetes_client* kubernetes_client =
@@ -118,8 +139,11 @@ void guac_kubernetes_init_ssl(guac_client* client,
SSL_CTX* context) {
guac_kubernetes_settings* settings = kubernetes_client->settings;
/* Bypass certificate checks if requested */
-if (settings->ignore_cert)
-SSL_CTX_set_verify(context, SSL_VERIFY_NONE, NULL);
+if (settings->ignore_cert) {
+SSL_CTX_set_verify(context, SSL_VERIFY_PEER, NULL);
+SSL_CTX_set_cert_verify_callback(context,
+guac_kubernetes_assume_cert_ok, NULL);
+}
/* Otherwise use the given CA certificate to validate (if any) */
else if (settings->ca_cert != NULL) {
[3/6] guacamole-server git commit: GUACAMOLE-623: Remove unnecessary initialization of pwsi.
GUACAMOLE-623: Remove unnecessary initialization of pwsi.
The pwsi member was previously used to ensure the lws structure was made
available to invocations of the event callback early in the connection
lifecycle such that the underlyin guac_client could always be retrieved.
Since the migration to guac_kubernetes_lws_current_client, this is not
necessary, and isn't supported in older versions of libwebsockets
anyway.
Project: http://git-wip-us.apache.org/repos/asf/guacamole-server/repo
Commit: http://git-wip-us.apache.org/repos/asf/guacamole-server/commit/7ee62484
Tree: http://git-wip-us.apache.org/repos/asf/guacamole-server/tree/7ee62484
Diff: http://git-wip-us.apache.org/repos/asf/guacamole-server/diff/7ee62484
Branch: refs/heads/master
Commit: 7ee624844a2ef577bfd5af6c9559919e1ba77846
Parents: b48a1b3
Author: Michael Jumper
Authored: Wed Sep 26 21:51:46 2018 -0700
Committer: Michael Jumper
Committed: Wed Sep 26 21:52:53 2018 -0700
--
src/protocols/kubernetes/kubernetes.c | 1 -
1 file changed, 1 deletion(-)
--
http://git-wip-us.apache.org/repos/asf/guacamole-server/blob/7ee62484/src/protocols/kubernetes/kubernetes.c
--
diff --git a/src/protocols/kubernetes/kubernetes.c
b/src/protocols/kubernetes/kubernetes.c
index fb38d68..66fc27d 100644
--- a/src/protocols/kubernetes/kubernetes.c
+++ b/src/protocols/kubernetes/kubernetes.c
@@ -268,7 +268,6 @@ void* guac_kubernetes_client_thread(void* data) {
.origin = settings->hostname,
.port = settings->port,
.protocol = GUAC_KUBERNETES_LWS_PROTOCOL,
-.pwsi = _client->wsi,
.userdata = client
};
[jira] [Updated] (GUACAMOLE-300) Support posixGroup in LDAP Authentication and Group-based Session Admission
[ https://issues.apache.org/jira/browse/GUACAMOLE-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Couchman updated GUACAMOLE-300: Fix Version/s: (was: 1.0.0) > Support posixGroup in LDAP Authentication and Group-based Session Admission > --- > > Key: GUACAMOLE-300 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-300 > Project: Guacamole > Issue Type: Improvement > Components: guacamole-auth-ldap > Environment: Oracle Solaris 11.3.19.5.0, Apache Tomcat 8.5.9, > OpenLDAP 2.4.30, LDAP users are organized using the posixGroup scheme. >Reporter: Steffen Moser >Priority: Minor > Attachments: LDAP-posixGroup-support_SteffenMoser-20170514.patch > > > Recently, the auth-ldap module was extended by the ability to grant access to > remote terminal connections based on existing LDAP groups using the seeAlso > attribute in Guacamole's LDAP-based configuration settings. This is a great > feature if you've to manage a lot of users which are already organized in > LDAP groups. It works well as long as the groups are of the scheme > groupOfNames. As we have decided for posixGroup (due to other tools' > requirements), we currently cannot use the feature and still have to list all > users individually in the Guacamole remote service configuration. While this > could be scripted easily, it is still a work-around which makes the > administration work unnecessarily complex. > A better solution would be to support both schemes, posixGroup and > groupOfNames. > The attached patch will extend the user lookup code by the ability to search > not only through the groupOfNames but also through the posixGroup scheme. The > piece of code seems to work with both schemes in my tests successfully, I am > not sure if there are any pitfalls when just combining the possible results. > Maybe introducing a configuration flag to choose whether searching posixGroup > or groupOfNames would be a better approach. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GUACAMOLE-619) No keyboard input from new Firefox V63 ( Beta )
[ https://issues.apache.org/jira/browse/GUACAMOLE-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16630132#comment-16630132 ] Alain Degreffe commented on GUACAMOLE-619: -- I confirm that it is linked to window.event Newest code will be disabled by default in future Beta63 using a preference. ( dom.window.event.enabled ) https://bugzilla.mozilla.org/show_bug.cgi?id=1493869#c10 On Nightly build, the pref is already present and enabled by default but if the dom.window.event.enabled is set to false, all works Tested new Guacamole 1.0 branch with new clipboard and it is just pefect ! > No keyboard input from new Firefox V63 ( Beta ) > > > Key: GUACAMOLE-619 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-619 > Project: Guacamole > Issue Type: Bug >Affects Versions: 0.9.14 >Reporter: Alain Degreffe >Priority: Minor > > Using the latest FF browser, I'm not able to use any connections.. mouse > event works, clipboard as well, but keyboard input don't. > > I'm not sure about the origin of this issue... Firefox, Guacamole ? I suspect > FF but my fear is that if FF release v63 as-is, no guacamole server will > works anymore -- This message was sent by Atlassian JIRA (v7.6.3#76005)
