[2/7] guacamole-server git commit: GUACAMOLE-662: Add utility script for automatically generating CUnit test runners.
GUACAMOLE-662: Add utility script for automatically generating CUnit test
runners.
Project: http://git-wip-us.apache.org/repos/asf/guacamole-server/repo
Commit: http://git-wip-us.apache.org/repos/asf/guacamole-server/commit/d7118fda
Tree: http://git-wip-us.apache.org/repos/asf/guacamole-server/tree/d7118fda
Diff: http://git-wip-us.apache.org/repos/asf/guacamole-server/diff/d7118fda
Branch: refs/heads/master
Commit: d7118fda707cf888eede291d547aee5aa5e293c1
Parents: 2827af3
Author: Michael Jumper
Authored: Tue Nov 13 13:24:23 2018 -0800
Committer: Michael Jumper
Committed: Fri Nov 16 22:23:55 2018 -0800
--
Makefile.am | 19 ++---
util/generate-test-runner.pl | 146 ++
2 files changed, 156 insertions(+), 9 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/guacamole-server/blob/d7118fda/Makefile.am
--
diff --git a/Makefile.am b/Makefile.am
index 6926474..cbfea85 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -91,13 +91,14 @@ if ENABLE_GUACLOG
SUBDIRS += src/guaclog
endif
-EXTRA_DIST = \
-.dockerignore\
-CONTRIBUTING \
-Dockerfile \
-LICENSE \
-NOTICE \
-bin/guacctl \
-doc/Doxyfile.in \
-src/guacd-docker
+EXTRA_DIST = \
+.dockerignore\
+CONTRIBUTING \
+Dockerfile \
+LICENSE \
+NOTICE \
+bin/guacctl \
+doc/Doxyfile.in \
+src/guacd-docker \
+util/generate-test-runner.pl
http://git-wip-us.apache.org/repos/asf/guacamole-server/blob/d7118fda/util/generate-test-runner.pl
--
diff --git a/util/generate-test-runner.pl b/util/generate-test-runner.pl
new file mode 100755
index 000..c32ec0c
--- /dev/null
+++ b/util/generate-test-runner.pl
@@ -0,0 +1,146 @@
+#!/usr/bin/perl
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+#
+# generate-test-runner.pl
+#
+# Generates a test runner for the .c files given on the command line. Each .c
+# file may declare any number of tests so long as each test uses CUnit and is
+# declared with the following convention:
+#
+# void test_SUITENAME__TESTNAME() {
+# ...
+# }
+#
+# where TESTNAME is the arbitrary name of the test and SUITENAME is the
+# arbitrary name of the test suite that this test belongs to.
+#
+# Absolutely all tests MUST follow the above convention if they are to be
+# picked up by this script. Functions which are not tests MUST NOT follow
+# the above convention.
+#
+
+use strict;
+
+# Parse all test declarations from given file
+my %test_suites = ();
+while (<>) {
+if ((my $suite_name, my $test_name) = m/^void\s+test_(\w+)__(\w+)/) {
+$test_suites{$suite_name} //= ();
+push @{$test_suites{$suite_name}}, $test_name;
+}
+}
+
+#
+# Common test runner header
+#
+
+print <<'END';
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include
+#include
+END
+
+#
+# Prototypes for all test functions
+#
+
+while ((my $suite_name, my $test_names) = each (%test_suites)) {
+print "\n/* Automatically-generated prototypes for the
[5/7] guacamole-server git commit: GUACAMOLE-662: Migrate tests to test runners generated by new convenience script. Remove unnecessary test runners.
http://git-wip-us.apache.org/repos/asf/guacamole-server/blob/476b4310/tests/client/client_suite.h
--
diff --git a/tests/client/client_suite.h b/tests/client/client_suite.h
deleted file mode 100644
index da1bc22..000
--- a/tests/client/client_suite.h
+++ /dev/null
@@ -1,32 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-
-#ifndef _GUAC_TEST_CLIENT_SUITE_H
-#define _GUAC_TEST_CLIENT_SUITE_H
-
-#include "config.h"
-
-int register_client_suite();
-
-void test_layer_pool();
-void test_buffer_pool();
-
-#endif
-
http://git-wip-us.apache.org/repos/asf/guacamole-server/blob/476b4310/tests/client/layer_pool.c
--
diff --git a/tests/client/layer_pool.c b/tests/client/layer_pool.c
deleted file mode 100644
index 8b61c86..000
--- a/tests/client/layer_pool.c
+++ /dev/null
@@ -1,73 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-#include "config.h"
-
-#include "client_suite.h"
-
-#include
-#include
-#include
-
-void test_layer_pool() {
-
-guac_client* client;
-
-int i;
-int seen[GUAC_BUFFER_POOL_INITIAL_SIZE] = {0};
-
-guac_layer* layer;
-
-/* Get client */
-client = guac_client_alloc();
-CU_ASSERT_PTR_NOT_NULL_FATAL(client);
-
-/* Fill pool */
-for (i=0; iindex > 0);
-CU_ASSERT_FATAL(layer->index <= GUAC_BUFFER_POOL_INITIAL_SIZE);
-
-/* This should be a layer we have not seen yet */
-CU_ASSERT_FALSE(seen[layer->index - 1]);
-seen[layer->index - 1] = 1;
-
-guac_client_free_layer(client, layer);
-
-}
-
-/* Now that pool is filled, we should get a previously seen layer */
-layer = guac_client_alloc_layer(client);
-
-CU_ASSERT_FATAL(layer->index > 0);
-CU_ASSERT_FATAL(layer->index <= GUAC_BUFFER_POOL_INITIAL_SIZE);
-CU_ASSERT_TRUE(seen[layer->index - 1]);
-
-/* Free client */
-guac_client_free(client);
-
-}
-
http://git-wip-us.apache.org/repos/asf/guacamole-server/blob/476b4310/tests/common/common_suite.c
--
diff --git a/tests/common/common_suite.c b/tests/common/common_suite.c
deleted file mode 100644
index 58ca799..000
--- a/tests/common/common_suite.c
+++ /dev/null
@@ -1,57 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-#include "config.h"
-
-#include "common_suite.h"
-
-#include
-
-int common_suite_init() {
-return 0;
-}
-
-int common_suite_cleanup() {
-return 0;
-}
-
-int register_common_suite() {
-
-/* Add common test suite */
-CU_pSuite suite =
[4/7] guacamole-server git commit: GUACAMOLE-662: Log test output in TAP format.
GUACAMOLE-662: Log test output in TAP format.
Project: http://git-wip-us.apache.org/repos/asf/guacamole-server/repo
Commit: http://git-wip-us.apache.org/repos/asf/guacamole-server/commit/ca4009c9
Tree: http://git-wip-us.apache.org/repos/asf/guacamole-server/tree/ca4009c9
Diff: http://git-wip-us.apache.org/repos/asf/guacamole-server/diff/ca4009c9
Branch: refs/heads/master
Commit: ca4009c9824b26af9c2785fc847dfe7f9f14bc1d
Parents: d7118fd
Author: Michael Jumper
Authored: Tue Nov 13 19:55:06 2018 -0800
Committer: Michael Jumper
Committed: Sat Nov 17 12:41:48 2018 -0800
--
util/generate-test-runner.pl | 56 ---
1 file changed, 52 insertions(+), 4 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/guacamole-server/blob/ca4009c9/util/generate-test-runner.pl
--
diff --git a/util/generate-test-runner.pl b/util/generate-test-runner.pl
index c32ec0c..a121a07 100755
--- a/util/generate-test-runner.pl
+++ b/util/generate-test-runner.pl
@@ -39,15 +39,23 @@
use strict;
-# Parse all test declarations from given file
+my $num_tests = 0;
my %test_suites = ();
+
+# Parse all test declarations from given file
while (<>) {
if ((my $suite_name, my $test_name) = m/^void\s+test_(\w+)__(\w+)/) {
+$num_tests++;
$test_suites{$suite_name} //= ();
push @{$test_suites{$suite_name}}, $test_name;
}
}
+# Bail out if there's nothing to write
+if ($num_tests == 0) {
+die "No unit tests... :(\n";
+}
+
#
# Common test runner header
#
@@ -73,7 +81,44 @@ print <<'END';
*/
#include
-#include
+#include
+
+/**
+ * The current test number, as required by the TAP format. This value is
+ * automatically incremented by tap_log_test_completed() after each test is
+ * run.
+ */
+int tap_test_number = 1;
+
+/**
+ * Logs the status of a CUnit test which just completed. This implementation
+ * logs test completion in TAP format.
+ *
+ * @param test
+ * The CUnit test which just completed.
+ *
+ * @param suite
+ * The CUnit test suite associated with the test.
+ *
+ * @param failure
+ * The head element of the test failure list, or NULL if the test passed.
+ */
+static void tap_log_test_completed(const CU_pTest test,
+const CU_pSuite suite, const CU_pFailureRecord failure) {
+
+/* Log success/failure in TAP format */
+if (failure == NULL)
+printf("ok %i - [%s] %s: OK\n",
+tap_test_number, suite->pName, test->pName);
+else
+printf("not ok %i - [%s] %s: Assertion failed on %s:%i: %s\n",
+tap_test_number, suite->pName, test->pName,
+failure->strFileName, failure->uiLineNumber,
+failure->strCondition);
+
+tap_test_number++;
+
+}
END
#
@@ -132,9 +177,12 @@ while ((my $suite_name, my $test_names) = each
(%test_suites)) {
print <<"END";
+/* Write TAP header */
+printf("1..$num_tests\\n");
+
/* Run all tests in all suites */
-CU_basic_set_mode(CU_BRM_VERBOSE);
-CU_basic_run_tests();
+CU_set_test_complete_handler(tap_log_test_completed);
+CU_run_all_tests();
cleanup:
/* Tests complete */
[jira] [Commented] (GUACAMOLE-688) Docker Version ldap-user-search-filter is missing
[ https://issues.apache.org/jira/browse/GUACAMOLE-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16735334#comment-16735334 ] Harald Fielker commented on GUACAMOLE-688: -- Thank you for your answer. I will consider this. > Docker Version ldap-user-search-filter is missing > - > > Key: GUACAMOLE-688 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-688 > Project: Guacamole > Issue Type: Improvement > Components: guacamole-docker >Affects Versions: 0.9.14 >Reporter: Harald Fielker >Priority: Minor > > "ldap-user-search-filter" is missing as Enviormnent Variable in > > [https://github.com/apache/guacamole-client/blob/78f1ae1b4eac25501d532ddee94fd1d8588e56dc/guacamole-docker/bin/start.sh] > > Please add this to the section in the start.sh file > set_optional_property \ > "ldap-user-search-filter" \ > "$LDAP_USER_SEARCH_FILTER" > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GUACAMOLE-688) Docker Version ldap-user-search-filter is missing
[
https://issues.apache.org/jira/browse/GUACAMOLE-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16735333#comment-16735333
]
Michael Jumper commented on GUACAMOLE-688:
--
[~HaraldFielker], if you would like to contribute, please open a pull request.
From [https://github.com/apache/guacamole-client/blob/master/CONTRIBUTING]:
{quote}
{code:none}
...
2) Make and test your changes locally
The Guacamole source is maintained in git repositories hosted on GitHub:
https://github.com/apache/guacamole-client
https://github.com/apache/guacamole-manual
https://github.com/apache/guacamole-server
https://github.com/apache/guacamole-website
To make your changes, fork the applicable repositories and make commits
to a topic branch in your fork. Commits should be made in logical units
and must reference the JIRA issue number:
$ git commit -m "GUACAMOLE-123: High-level message describing the changes."
Avoid commits which cover multiple, distinct goals that could (and should)
be handled separately.
If you do not already have an account on GitHub, you will need to create
one before making your changes.
3) Submit your changes via a pull request on GitHub
Once your changes are ready, submit them by creating a pull request for
the corresponding topic branch you created when you began working on your
changes.
The Guacamole team will then review your changes and, if they pass review,
your changes will be merged.
{code}
{quote}
> Docker Version ldap-user-search-filter is missing
> -
>
> Key: GUACAMOLE-688
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-688
> Project: Guacamole
> Issue Type: Improvement
> Components: guacamole-docker
>Affects Versions: 0.9.14
>Reporter: Harald Fielker
>Priority: Minor
>
> "ldap-user-search-filter" is missing as Enviormnent Variable in
>
> [https://github.com/apache/guacamole-client/blob/78f1ae1b4eac25501d532ddee94fd1d8588e56dc/guacamole-docker/bin/start.sh]
>
> Please add this to the section in the start.sh file
> set_optional_property \
> "ldap-user-search-filter" \
> "$LDAP_USER_SEARCH_FILTER"
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (GUACAMOLE-601) VNC segfault when VNC server restarted
[
https://issues.apache.org/jira/browse/GUACAMOLE-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Jumper updated GUACAMOLE-601:
-
Fix Version/s: (was: 1.0.0)
> VNC segfault when VNC server restarted
> --
>
> Key: GUACAMOLE-601
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-601
> Project: Guacamole
> Issue Type: Bug
> Components: VNC
>Affects Versions: 0.9.14
>Reporter: KokHooi Chew
>Priority: Minor
> Attachments: syslog.3
>
>
> While viewing, try to restart the VNC server, unable to reconnect back to the
> VNC then, continuously getting segfault until restart guacamole server in
> order to solve it
> {code:none}
> Jul 27 21:05:08 TDF-Jasper guacd[1354]: Creating new client for protocol "vnc"
> Jul 27 21:05:08 TDF-Jasper guacd[1354]: Connection ID is
> "$3c02e097-a5a4-4a78-9d75-72531046877d"
> Jul 27 21:05:09 TDF-Jasper guacd[6539]: Cursor rendering: local
> Jul 27 21:05:09 TDF-Jasper guacd[6539]: User
> "@ecba697e-1195-41d4-9b99-71525c58952e" joined connection
> "$3c02e097-a5a4-4a78-9d75-72531046877d" (1 users now present)
> Jul 27 21:05:14 TDF-Jasper guacd[6539]: Connected to VNC repeater, using
> protocol version 0.0
> Jul 27 21:05:15 TDF-Jasper guacd[6539]: VNC server supports protocol version
> 3.8 (viewer 3.8)
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: We have 1 security types to read
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 0) Received security type 1
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: Selecting security type 1 (0/1 in the
> list)
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: Selected Security Scheme 1
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: No authentication needed
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: VNC authentication succeeded
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: Desktop name "Remote control"
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: Connected to VNC server, using
> protocol version 3.8
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: VNC server default format:
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 32 bits per pixel.
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: Least significant byte first in each
> pixel.
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: TRUE colour: max red 255 green 255
> blue 255, shift red 0 green 8 blue 16
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: client2server supported messages (bit
> flags)
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 00: 00ff 0081 -
>
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 08: -
>
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 10: -
>
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 18: -
>
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: server2client supported messages (bit
> flags)
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 00: 001f 0080 -
>
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 08: -
>
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 10: -
>
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 18: -
>
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: Connected to Server "unknown
> (LibVNCServer 0.9.11)"
> Jul 27 21:05:38 TDF-Jasper guacd[1354]: Creating new client for protocol "vnc"
> Jul 27 21:05:38 TDF-Jasper guacd[1354]: Connection ID is
> "$f7648af9-9126-4e69-a6ef-a8b9ac3b7fc3"
> Jul 27 21:05:38 TDF-Jasper guacd[6573]: Cursor rendering: local
> Jul 27 21:05:38 TDF-Jasper guacd[6573]: User
> "@1446482b-becb-495a-9763-a151f6d6079f" joined connection
> "$f7648af9-9126-4e69-a6ef-a8b9ac3b7fc3" (1 users now present)
> Jul 27 21:05:38 TDF-Jasper guacd[6573]: Connected to VNC repeater, using
> protocol version 0.0
> Jul 27 21:05:39 TDF-Jasper guacd[6573]: VNC server closed connection
> Jul 27 21:05:39 TDF-Jasper guacd[6573]: Unable to connect to VNC server.
> Jul 27 21:05:39 TDF-Jasper kernel: [18008.137457] show_signal_msg: 42
> callbacks suppressed
> Jul 27 21:05:39 TDF-Jasper kernel: [18008.137462] guacd[6576]: segfault at 10
> ip 7f3cdcc64f32 sp 7f3cdde71d10 error 4 in
> libguac-client-vnc.so.0.0.0[7f3cdcc5c000+14000]
> Jul 27 21:05:40 TDF-Jasper guacd[6539]: User is not responding.
> Jul 27 21:05:40 TDF-Jasper guacd[6539]: User
> "@ecba697e-1195-41d4-9b99-71525c58952e" disconnected (0 users remain)
> Jul 27 21:05:40 TDF-Jasper guacd[6539]: Last user of connection
> "$3c02e097-a5a4-4a78-9d75-72531046877d" disconnected
> Jul 27 21:05:40 TDF-Jasper guacd[1354]: Connection
> "$f7648af9-9126-4e69-a6ef-a8b9ac3b7fc3" removed.
> Jul 27 21:07:19 TDF-Jasper guacd[1354]: Creating new client for protocol "vnc"
> Jul 27 21:07:19 TDF-Jasper guacd[1354]: Connection ID is
> "$ff22eac4-80d1-4225-a87f-73537e7b569d"
> Jul 27 21:07:19 TDF-Jasper
[jira] [Commented] (GUACAMOLE-688) Docker Version ldap-user-search-filter is missing
[ https://issues.apache.org/jira/browse/GUACAMOLE-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16735329#comment-16735329 ] Harald Fielker commented on GUACAMOLE-688: -- Add to line 318 in start.sh set_optional_property \ "ldap-user-search-filter" \ "$LDAP_USER_SEARCH_FILTER" > Docker Version ldap-user-search-filter is missing > - > > Key: GUACAMOLE-688 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-688 > Project: Guacamole > Issue Type: Improvement > Components: guacamole-docker >Affects Versions: 0.9.14 >Reporter: Harald Fielker >Priority: Minor > > "ldap-user-search-filter" is missing as Enviormnent Variable in > > [https://github.com/apache/guacamole-client/blob/78f1ae1b4eac25501d532ddee94fd1d8588e56dc/guacamole-docker/bin/start.sh] > > Please add this to the section in the start.sh file > set_optional_property \ > "ldap-user-search-filter" \ > "$LDAP_USER_SEARCH_FILTER" > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (GUACAMOLE-601) VNC segfault when VNC server restarted
[
https://issues.apache.org/jira/browse/GUACAMOLE-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Jumper reopened GUACAMOLE-601:
--
> VNC segfault when VNC server restarted
> --
>
> Key: GUACAMOLE-601
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-601
> Project: Guacamole
> Issue Type: Bug
> Components: VNC
>Affects Versions: 0.9.14
>Reporter: KokHooi Chew
>Priority: Minor
> Fix For: 1.0.0
>
> Attachments: syslog.3
>
>
> While viewing, try to restart the VNC server, unable to reconnect back to the
> VNC then, continuously getting segfault until restart guacamole server in
> order to solve it
> {code:none}
> Jul 27 21:05:08 TDF-Jasper guacd[1354]: Creating new client for protocol "vnc"
> Jul 27 21:05:08 TDF-Jasper guacd[1354]: Connection ID is
> "$3c02e097-a5a4-4a78-9d75-72531046877d"
> Jul 27 21:05:09 TDF-Jasper guacd[6539]: Cursor rendering: local
> Jul 27 21:05:09 TDF-Jasper guacd[6539]: User
> "@ecba697e-1195-41d4-9b99-71525c58952e" joined connection
> "$3c02e097-a5a4-4a78-9d75-72531046877d" (1 users now present)
> Jul 27 21:05:14 TDF-Jasper guacd[6539]: Connected to VNC repeater, using
> protocol version 0.0
> Jul 27 21:05:15 TDF-Jasper guacd[6539]: VNC server supports protocol version
> 3.8 (viewer 3.8)
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: We have 1 security types to read
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 0) Received security type 1
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: Selecting security type 1 (0/1 in the
> list)
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: Selected Security Scheme 1
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: No authentication needed
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: VNC authentication succeeded
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: Desktop name "Remote control"
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: Connected to VNC server, using
> protocol version 3.8
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: VNC server default format:
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 32 bits per pixel.
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: Least significant byte first in each
> pixel.
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: TRUE colour: max red 255 green 255
> blue 255, shift red 0 green 8 blue 16
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: client2server supported messages (bit
> flags)
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 00: 00ff 0081 -
>
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 08: -
>
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 10: -
>
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 18: -
>
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: server2client supported messages (bit
> flags)
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 00: 001f 0080 -
>
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 08: -
>
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 10: -
>
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 18: -
>
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: Connected to Server "unknown
> (LibVNCServer 0.9.11)"
> Jul 27 21:05:38 TDF-Jasper guacd[1354]: Creating new client for protocol "vnc"
> Jul 27 21:05:38 TDF-Jasper guacd[1354]: Connection ID is
> "$f7648af9-9126-4e69-a6ef-a8b9ac3b7fc3"
> Jul 27 21:05:38 TDF-Jasper guacd[6573]: Cursor rendering: local
> Jul 27 21:05:38 TDF-Jasper guacd[6573]: User
> "@1446482b-becb-495a-9763-a151f6d6079f" joined connection
> "$f7648af9-9126-4e69-a6ef-a8b9ac3b7fc3" (1 users now present)
> Jul 27 21:05:38 TDF-Jasper guacd[6573]: Connected to VNC repeater, using
> protocol version 0.0
> Jul 27 21:05:39 TDF-Jasper guacd[6573]: VNC server closed connection
> Jul 27 21:05:39 TDF-Jasper guacd[6573]: Unable to connect to VNC server.
> Jul 27 21:05:39 TDF-Jasper kernel: [18008.137457] show_signal_msg: 42
> callbacks suppressed
> Jul 27 21:05:39 TDF-Jasper kernel: [18008.137462] guacd[6576]: segfault at 10
> ip 7f3cdcc64f32 sp 7f3cdde71d10 error 4 in
> libguac-client-vnc.so.0.0.0[7f3cdcc5c000+14000]
> Jul 27 21:05:40 TDF-Jasper guacd[6539]: User is not responding.
> Jul 27 21:05:40 TDF-Jasper guacd[6539]: User
> "@ecba697e-1195-41d4-9b99-71525c58952e" disconnected (0 users remain)
> Jul 27 21:05:40 TDF-Jasper guacd[6539]: Last user of connection
> "$3c02e097-a5a4-4a78-9d75-72531046877d" disconnected
> Jul 27 21:05:40 TDF-Jasper guacd[1354]: Connection
> "$f7648af9-9126-4e69-a6ef-a8b9ac3b7fc3" removed.
> Jul 27 21:07:19 TDF-Jasper guacd[1354]: Creating new client for protocol "vnc"
> Jul 27 21:07:19 TDF-Jasper guacd[1354]: Connection ID is
> "$ff22eac4-80d1-4225-a87f-73537e7b569d"
> Jul 27 21:07:19 TDF-Jasper
[jira] [Commented] (GUACAMOLE-601) VNC segfault when VNC server restarted
[
https://issues.apache.org/jira/browse/GUACAMOLE-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16735325#comment-16735325
]
Michael Jumper commented on GUACAMOLE-601:
--
If this is fixed on master and staging/1.0.0, I suspect this is another
instance of GUACAMOLE-424.
Though the title and description of GUACAMOLE-424 specifically mention
incorrect VNC passwords, the underlying problem was much more generic and would
have affected any VNC connection that terminates early enough and abnormally.
> VNC segfault when VNC server restarted
> --
>
> Key: GUACAMOLE-601
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-601
> Project: Guacamole
> Issue Type: Bug
> Components: VNC
>Affects Versions: 0.9.14
>Reporter: KokHooi Chew
>Priority: Minor
> Fix For: 1.0.0
>
> Attachments: syslog.3
>
>
> While viewing, try to restart the VNC server, unable to reconnect back to the
> VNC then, continuously getting segfault until restart guacamole server in
> order to solve it
> {code:none}
> Jul 27 21:05:08 TDF-Jasper guacd[1354]: Creating new client for protocol "vnc"
> Jul 27 21:05:08 TDF-Jasper guacd[1354]: Connection ID is
> "$3c02e097-a5a4-4a78-9d75-72531046877d"
> Jul 27 21:05:09 TDF-Jasper guacd[6539]: Cursor rendering: local
> Jul 27 21:05:09 TDF-Jasper guacd[6539]: User
> "@ecba697e-1195-41d4-9b99-71525c58952e" joined connection
> "$3c02e097-a5a4-4a78-9d75-72531046877d" (1 users now present)
> Jul 27 21:05:14 TDF-Jasper guacd[6539]: Connected to VNC repeater, using
> protocol version 0.0
> Jul 27 21:05:15 TDF-Jasper guacd[6539]: VNC server supports protocol version
> 3.8 (viewer 3.8)
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: We have 1 security types to read
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 0) Received security type 1
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: Selecting security type 1 (0/1 in the
> list)
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: Selected Security Scheme 1
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: No authentication needed
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: VNC authentication succeeded
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: Desktop name "Remote control"
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: Connected to VNC server, using
> protocol version 3.8
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: VNC server default format:
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 32 bits per pixel.
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: Least significant byte first in each
> pixel.
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: TRUE colour: max red 255 green 255
> blue 255, shift red 0 green 8 blue 16
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: client2server supported messages (bit
> flags)
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 00: 00ff 0081 -
>
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 08: -
>
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 10: -
>
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 18: -
>
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: server2client supported messages (bit
> flags)
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 00: 001f 0080 -
>
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 08: -
>
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 10: -
>
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: 18: -
>
> Jul 27 21:05:16 TDF-Jasper guacd[6539]: Connected to Server "unknown
> (LibVNCServer 0.9.11)"
> Jul 27 21:05:38 TDF-Jasper guacd[1354]: Creating new client for protocol "vnc"
> Jul 27 21:05:38 TDF-Jasper guacd[1354]: Connection ID is
> "$f7648af9-9126-4e69-a6ef-a8b9ac3b7fc3"
> Jul 27 21:05:38 TDF-Jasper guacd[6573]: Cursor rendering: local
> Jul 27 21:05:38 TDF-Jasper guacd[6573]: User
> "@1446482b-becb-495a-9763-a151f6d6079f" joined connection
> "$f7648af9-9126-4e69-a6ef-a8b9ac3b7fc3" (1 users now present)
> Jul 27 21:05:38 TDF-Jasper guacd[6573]: Connected to VNC repeater, using
> protocol version 0.0
> Jul 27 21:05:39 TDF-Jasper guacd[6573]: VNC server closed connection
> Jul 27 21:05:39 TDF-Jasper guacd[6573]: Unable to connect to VNC server.
> Jul 27 21:05:39 TDF-Jasper kernel: [18008.137457] show_signal_msg: 42
> callbacks suppressed
> Jul 27 21:05:39 TDF-Jasper kernel: [18008.137462] guacd[6576]: segfault at 10
> ip 7f3cdcc64f32 sp 7f3cdde71d10 error 4 in
> libguac-client-vnc.so.0.0.0[7f3cdcc5c000+14000]
> Jul 27 21:05:40 TDF-Jasper guacd[6539]: User is not responding.
> Jul 27 21:05:40 TDF-Jasper guacd[6539]: User
> "@ecba697e-1195-41d4-9b99-71525c58952e" disconnected (0 users remain)
> Jul 27 21:05:40 TDF-Jasper guacd[6539]: Last user of connection
>
[jira] [Updated] (GUACAMOLE-688) Docker Version ldap-user-search-filter is missing
[ https://issues.apache.org/jira/browse/GUACAMOLE-688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Jumper updated GUACAMOLE-688: - Remaining Estimate: (was: 20m) Original Estimate: (was: 20m) > Docker Version ldap-user-search-filter is missing > - > > Key: GUACAMOLE-688 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-688 > Project: Guacamole > Issue Type: Improvement > Components: guacamole-docker >Affects Versions: 0.9.14 >Reporter: Harald Fielker >Priority: Minor > > "ldap-user-search-filter" is missing as Enviormnent Variable in > > [https://github.com/apache/guacamole-client/blob/78f1ae1b4eac25501d532ddee94fd1d8588e56dc/guacamole-docker/bin/start.sh] > > Please add this to the section in the start.sh file > set_optional_property \ > "ldap-user-search-filter" \ > "$LDAP_USER_SEARCH_FILTER" > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GUACAMOLE-688) Docker Version ldap-user-search-filter is missing
[ https://issues.apache.org/jira/browse/GUACAMOLE-688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Couchman updated GUACAMOLE-688: Priority: Minor (was: Major) > Docker Version ldap-user-search-filter is missing > - > > Key: GUACAMOLE-688 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-688 > Project: Guacamole > Issue Type: Improvement > Components: guacamole-docker >Affects Versions: 0.9.14 >Reporter: Harald Fielker >Priority: Minor > Original Estimate: 20m > Remaining Estimate: 20m > > "ldap-user-search-filter" is missing as Enviormnent Variable in > > [https://github.com/apache/guacamole-client/blob/78f1ae1b4eac25501d532ddee94fd1d8588e56dc/guacamole-docker/bin/start.sh] > > Please add this to the section in the start.sh file > set_optional_property \ > "ldap-user-search-filter" \ > "$LDAP_USER_SEARCH_FILTER" > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GUACAMOLE-688) Docker Version ldap-user-search-filter is missing
[ https://issues.apache.org/jira/browse/GUACAMOLE-688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harald Fielker updated GUACAMOLE-688: - Description: "ldap-user-search-filter" is missing as Enviormnent Variable in [https://github.com/apache/guacamole-client/blob/78f1ae1b4eac25501d532ddee94fd1d8588e56dc/guacamole-docker/bin/start.sh] Please add this to the section in the start.sh file set_optional_property \ "ldap-user-search-filter" \ "$LDAP_USER_SEARCH_FILTER" was: "ldap-user-search-filter" is missing as Enviormnent Variable in [https://github.com/apache/guacamole-client/blob/78f1ae1b4eac25501d532ddee94fd1d8588e56dc/guacamole-docker/bin/start.sh] Please add this. > Docker Version ldap-user-search-filter is missing > - > > Key: GUACAMOLE-688 > URL: https://issues.apache.org/jira/browse/GUACAMOLE-688 > Project: Guacamole > Issue Type: Improvement > Components: guacamole-docker >Affects Versions: 0.9.14 >Reporter: Harald Fielker >Priority: Major > Original Estimate: 20m > Remaining Estimate: 20m > > "ldap-user-search-filter" is missing as Enviormnent Variable in > > [https://github.com/apache/guacamole-client/blob/78f1ae1b4eac25501d532ddee94fd1d8588e56dc/guacamole-docker/bin/start.sh] > > Please add this to the section in the start.sh file > set_optional_property \ > "ldap-user-search-filter" \ > "$LDAP_USER_SEARCH_FILTER" > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GUACAMOLE-688) Docker Version ldap-user-search-filter is missing
Harald Fielker created GUACAMOLE-688: Summary: Docker Version ldap-user-search-filter is missing Key: GUACAMOLE-688 URL: https://issues.apache.org/jira/browse/GUACAMOLE-688 Project: Guacamole Issue Type: Improvement Components: guacamole-docker Affects Versions: 0.9.14 Reporter: Harald Fielker "ldap-user-search-filter" is missing as Enviormnent Variable in [https://github.com/apache/guacamole-client/blob/78f1ae1b4eac25501d532ddee94fd1d8588e56dc/guacamole-docker/bin/start.sh] Please add this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
