HBASE-20052 TestRegionOpen#testNonExistentRegionReplica fails due to NPE
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/8bc84fdc Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/8bc84fdc Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/8bc84fdc Branch: refs/heads/branch-1.3 Commit: 8bc84fdc1b67ce2b28a2a8774defe669dfca1501 Parents: 453935f Author: tedyu <yuzhih...@gmail.com> Authored: Thu Feb 22 12:41:13 2018 -0800 Committer: Andrew Purtell <apurt...@apache.org> Committed: Wed Dec 12 18:08:18 2018 -0800 ---------------------------------------------------------------------- .../org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java | 3 +-- .../java/org/apache/hadoop/hbase/regionserver/TestRegionOpen.java | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/8bc84fdc/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java index 7672204..ba5249b 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java @@ -906,12 +906,11 @@ public class HRegionFileSystem { // Write HRI to a file in case we need to recover hbase:meta regionFs.writeRegionInfoOnFilesystem(false); - return regionFs; } else { if (LOG.isDebugEnabled()) LOG.debug("Skipping creation of .regioninfo file for " + regionInfo); } - return null; + return regionFs; } /** http://git-wip-us.apache.org/repos/asf/hbase/blob/8bc84fdc/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionOpen.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionOpen.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionOpen.java index 62aabce..f45df18 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionOpen.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionOpen.java @@ -47,7 +47,6 @@ import org.apache.hadoop.hbase.util.Bytes; import org.apache.hadoop.hbase.util.FSUtils; import org.junit.AfterClass; import org.junit.BeforeClass; -import org.junit.Ignore; import org.junit.Rule; import org.junit.Test; import org.junit.experimental.categories.Category; @@ -98,7 +97,6 @@ public class TestRegionOpen { assertEquals(2, exec.getCompletedTaskCount()); } - @Ignore // Needs rewrite since HBASE-19391 which returns null out of createRegionOnFileSystem @Test public void testNonExistentRegionReplica() throws Exception { final TableName tableName = TableName.valueOf(name.getMethodName());