http://git-wip-us.apache.org/repos/asf/hbase-site/blob/804782f0/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.html ---------------------------------------------------------------------- diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.html b/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.html index dd41a30..624224f 100644 --- a/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.html +++ b/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.html @@ -90,768 +90,758 @@ <span class="sourceLineNo">082</span> extends AbstractStateMachineTableProcedure<MergeTableRegionsState> {<a name="line.82"></a> <span class="sourceLineNo">083</span> private static final Logger LOG = LoggerFactory.getLogger(MergeTableRegionsProcedure.class);<a name="line.83"></a> <span class="sourceLineNo">084</span> private Boolean traceEnabled;<a name="line.84"></a> -<span class="sourceLineNo">085</span> private volatile boolean lock = false;<a name="line.85"></a> -<span class="sourceLineNo">086</span> private ServerName regionLocation;<a name="line.86"></a> -<span class="sourceLineNo">087</span> private RegionInfo[] regionsToMerge;<a name="line.87"></a> -<span class="sourceLineNo">088</span> private RegionInfo mergedRegion;<a name="line.88"></a> -<span class="sourceLineNo">089</span> private boolean forcible;<a name="line.89"></a> -<span class="sourceLineNo">090</span><a name="line.90"></a> -<span class="sourceLineNo">091</span> public MergeTableRegionsProcedure() {<a name="line.91"></a> -<span class="sourceLineNo">092</span> // Required by the Procedure framework to create the procedure on replay<a name="line.92"></a> -<span class="sourceLineNo">093</span> }<a name="line.93"></a> -<span class="sourceLineNo">094</span><a name="line.94"></a> -<span class="sourceLineNo">095</span> public MergeTableRegionsProcedure(final MasterProcedureEnv env,<a name="line.95"></a> -<span class="sourceLineNo">096</span> final RegionInfo regionToMergeA, final RegionInfo regionToMergeB) throws IOException {<a name="line.96"></a> -<span class="sourceLineNo">097</span> this(env, regionToMergeA, regionToMergeB, false);<a name="line.97"></a> -<span class="sourceLineNo">098</span> }<a name="line.98"></a> -<span class="sourceLineNo">099</span><a name="line.99"></a> -<span class="sourceLineNo">100</span> public MergeTableRegionsProcedure(final MasterProcedureEnv env,<a name="line.100"></a> -<span class="sourceLineNo">101</span> final RegionInfo regionToMergeA, final RegionInfo regionToMergeB,<a name="line.101"></a> -<span class="sourceLineNo">102</span> final boolean forcible) throws IOException {<a name="line.102"></a> -<span class="sourceLineNo">103</span> this(env, new RegionInfo[] {regionToMergeA, regionToMergeB}, forcible);<a name="line.103"></a> -<span class="sourceLineNo">104</span> }<a name="line.104"></a> -<span class="sourceLineNo">105</span><a name="line.105"></a> -<span class="sourceLineNo">106</span> public MergeTableRegionsProcedure(final MasterProcedureEnv env,<a name="line.106"></a> -<span class="sourceLineNo">107</span> final RegionInfo[] regionsToMerge, final boolean forcible)<a name="line.107"></a> -<span class="sourceLineNo">108</span> throws IOException {<a name="line.108"></a> -<span class="sourceLineNo">109</span> super(env);<a name="line.109"></a> -<span class="sourceLineNo">110</span><a name="line.110"></a> -<span class="sourceLineNo">111</span> // Check daughter regions and make sure that we have valid daughter regions<a name="line.111"></a> -<span class="sourceLineNo">112</span> // before doing the real work. This check calls the super method #checkOnline also.<a name="line.112"></a> -<span class="sourceLineNo">113</span> checkRegionsToMerge(env, regionsToMerge, forcible);<a name="line.113"></a> -<span class="sourceLineNo">114</span><a name="line.114"></a> -<span class="sourceLineNo">115</span> // WARN: make sure there is no parent region of the two merging regions in<a name="line.115"></a> -<span class="sourceLineNo">116</span> // hbase:meta If exists, fixing up daughters would cause daughter regions(we<a name="line.116"></a> -<span class="sourceLineNo">117</span> // have merged one) online again when we restart master, so we should clear<a name="line.117"></a> -<span class="sourceLineNo">118</span> // the parent region to prevent the above case<a name="line.118"></a> -<span class="sourceLineNo">119</span> // Since HBASE-7721, we don't need fix up daughters any more. so here do nothing<a name="line.119"></a> -<span class="sourceLineNo">120</span> this.regionsToMerge = regionsToMerge;<a name="line.120"></a> -<span class="sourceLineNo">121</span> this.mergedRegion = createMergedRegionInfo(regionsToMerge);<a name="line.121"></a> -<span class="sourceLineNo">122</span> preflightChecks(env, true);<a name="line.122"></a> -<span class="sourceLineNo">123</span> this.forcible = forcible;<a name="line.123"></a> -<span class="sourceLineNo">124</span> }<a name="line.124"></a> -<span class="sourceLineNo">125</span><a name="line.125"></a> -<span class="sourceLineNo">126</span> private static void checkRegionsToMerge(MasterProcedureEnv env, final RegionInfo[] regionsToMerge,<a name="line.126"></a> -<span class="sourceLineNo">127</span> final boolean forcible) throws MergeRegionException {<a name="line.127"></a> -<span class="sourceLineNo">128</span> // For now, we only merge 2 regions.<a name="line.128"></a> -<span class="sourceLineNo">129</span> // It could be extended to more than 2 regions in the future.<a name="line.129"></a> -<span class="sourceLineNo">130</span> if (regionsToMerge == null || regionsToMerge.length != 2) {<a name="line.130"></a> -<span class="sourceLineNo">131</span> throw new MergeRegionException("Expected to merge 2 regions, got: " +<a name="line.131"></a> -<span class="sourceLineNo">132</span> Arrays.toString(regionsToMerge));<a name="line.132"></a> -<span class="sourceLineNo">133</span> }<a name="line.133"></a> -<span class="sourceLineNo">134</span><a name="line.134"></a> -<span class="sourceLineNo">135</span> checkRegionsToMerge(env, regionsToMerge[0], regionsToMerge[1], forcible);<a name="line.135"></a> -<span class="sourceLineNo">136</span> }<a name="line.136"></a> -<span class="sourceLineNo">137</span><a name="line.137"></a> -<span class="sourceLineNo">138</span> /**<a name="line.138"></a> -<span class="sourceLineNo">139</span> * One time checks.<a name="line.139"></a> -<span class="sourceLineNo">140</span> */<a name="line.140"></a> -<span class="sourceLineNo">141</span> private static void checkRegionsToMerge(MasterProcedureEnv env, final RegionInfo regionToMergeA,<a name="line.141"></a> -<span class="sourceLineNo">142</span> final RegionInfo regionToMergeB, final boolean forcible) throws MergeRegionException {<a name="line.142"></a> -<span class="sourceLineNo">143</span> if (!regionToMergeA.getTable().equals(regionToMergeB.getTable())) {<a name="line.143"></a> -<span class="sourceLineNo">144</span> throw new MergeRegionException("Can't merge regions from two different tables: " +<a name="line.144"></a> -<span class="sourceLineNo">145</span> regionToMergeA + ", " + regionToMergeB);<a name="line.145"></a> -<span class="sourceLineNo">146</span> }<a name="line.146"></a> -<span class="sourceLineNo">147</span><a name="line.147"></a> -<span class="sourceLineNo">148</span> if (regionToMergeA.getReplicaId() != RegionInfo.DEFAULT_REPLICA_ID ||<a name="line.148"></a> -<span class="sourceLineNo">149</span> regionToMergeB.getReplicaId() != RegionInfo.DEFAULT_REPLICA_ID) {<a name="line.149"></a> -<span class="sourceLineNo">150</span> throw new MergeRegionException("Can't merge non-default replicas");<a name="line.150"></a> -<span class="sourceLineNo">151</span> }<a name="line.151"></a> -<span class="sourceLineNo">152</span><a name="line.152"></a> -<span class="sourceLineNo">153</span> try {<a name="line.153"></a> -<span class="sourceLineNo">154</span> checkOnline(env, regionToMergeA);<a name="line.154"></a> -<span class="sourceLineNo">155</span> checkOnline(env, regionToMergeB);<a name="line.155"></a> -<span class="sourceLineNo">156</span> } catch (DoNotRetryRegionException dnrre) {<a name="line.156"></a> -<span class="sourceLineNo">157</span> throw new MergeRegionException(dnrre);<a name="line.157"></a> -<span class="sourceLineNo">158</span> }<a name="line.158"></a> -<span class="sourceLineNo">159</span><a name="line.159"></a> -<span class="sourceLineNo">160</span> if (!RegionInfo.areAdjacent(regionToMergeA, regionToMergeB)) {<a name="line.160"></a> -<span class="sourceLineNo">161</span> String msg = "Unable to merge non-adjacent regions " + regionToMergeA.getShortNameToLog() +<a name="line.161"></a> -<span class="sourceLineNo">162</span> ", " + regionToMergeB.getShortNameToLog() + " where forcible = " + forcible;<a name="line.162"></a> -<span class="sourceLineNo">163</span> LOG.warn(msg);<a name="line.163"></a> -<span class="sourceLineNo">164</span> if (!forcible) {<a name="line.164"></a> -<span class="sourceLineNo">165</span> throw new MergeRegionException(msg);<a name="line.165"></a> -<span class="sourceLineNo">166</span> }<a name="line.166"></a> -<span class="sourceLineNo">167</span> }<a name="line.167"></a> -<span class="sourceLineNo">168</span> }<a name="line.168"></a> +<span class="sourceLineNo">085</span> private ServerName regionLocation;<a name="line.85"></a> +<span class="sourceLineNo">086</span> private RegionInfo[] regionsToMerge;<a name="line.86"></a> +<span class="sourceLineNo">087</span> private RegionInfo mergedRegion;<a name="line.87"></a> +<span class="sourceLineNo">088</span> private boolean forcible;<a name="line.88"></a> +<span class="sourceLineNo">089</span><a name="line.89"></a> +<span class="sourceLineNo">090</span> public MergeTableRegionsProcedure() {<a name="line.90"></a> +<span class="sourceLineNo">091</span> // Required by the Procedure framework to create the procedure on replay<a name="line.91"></a> +<span class="sourceLineNo">092</span> }<a name="line.92"></a> +<span class="sourceLineNo">093</span><a name="line.93"></a> +<span class="sourceLineNo">094</span> public MergeTableRegionsProcedure(final MasterProcedureEnv env,<a name="line.94"></a> +<span class="sourceLineNo">095</span> final RegionInfo regionToMergeA, final RegionInfo regionToMergeB) throws IOException {<a name="line.95"></a> +<span class="sourceLineNo">096</span> this(env, regionToMergeA, regionToMergeB, false);<a name="line.96"></a> +<span class="sourceLineNo">097</span> }<a name="line.97"></a> +<span class="sourceLineNo">098</span><a name="line.98"></a> +<span class="sourceLineNo">099</span> public MergeTableRegionsProcedure(final MasterProcedureEnv env,<a name="line.99"></a> +<span class="sourceLineNo">100</span> final RegionInfo regionToMergeA, final RegionInfo regionToMergeB,<a name="line.100"></a> +<span class="sourceLineNo">101</span> final boolean forcible) throws IOException {<a name="line.101"></a> +<span class="sourceLineNo">102</span> this(env, new RegionInfo[] {regionToMergeA, regionToMergeB}, forcible);<a name="line.102"></a> +<span class="sourceLineNo">103</span> }<a name="line.103"></a> +<span class="sourceLineNo">104</span><a name="line.104"></a> +<span class="sourceLineNo">105</span> public MergeTableRegionsProcedure(final MasterProcedureEnv env,<a name="line.105"></a> +<span class="sourceLineNo">106</span> final RegionInfo[] regionsToMerge, final boolean forcible)<a name="line.106"></a> +<span class="sourceLineNo">107</span> throws IOException {<a name="line.107"></a> +<span class="sourceLineNo">108</span> super(env);<a name="line.108"></a> +<span class="sourceLineNo">109</span><a name="line.109"></a> +<span class="sourceLineNo">110</span> // Check daughter regions and make sure that we have valid daughter regions<a name="line.110"></a> +<span class="sourceLineNo">111</span> // before doing the real work. This check calls the super method #checkOnline also.<a name="line.111"></a> +<span class="sourceLineNo">112</span> checkRegionsToMerge(env, regionsToMerge, forcible);<a name="line.112"></a> +<span class="sourceLineNo">113</span><a name="line.113"></a> +<span class="sourceLineNo">114</span> // WARN: make sure there is no parent region of the two merging regions in<a name="line.114"></a> +<span class="sourceLineNo">115</span> // hbase:meta If exists, fixing up daughters would cause daughter regions(we<a name="line.115"></a> +<span class="sourceLineNo">116</span> // have merged one) online again when we restart master, so we should clear<a name="line.116"></a> +<span class="sourceLineNo">117</span> // the parent region to prevent the above case<a name="line.117"></a> +<span class="sourceLineNo">118</span> // Since HBASE-7721, we don't need fix up daughters any more. so here do nothing<a name="line.118"></a> +<span class="sourceLineNo">119</span> this.regionsToMerge = regionsToMerge;<a name="line.119"></a> +<span class="sourceLineNo">120</span> this.mergedRegion = createMergedRegionInfo(regionsToMerge);<a name="line.120"></a> +<span class="sourceLineNo">121</span> preflightChecks(env, true);<a name="line.121"></a> +<span class="sourceLineNo">122</span> this.forcible = forcible;<a name="line.122"></a> +<span class="sourceLineNo">123</span> }<a name="line.123"></a> +<span class="sourceLineNo">124</span><a name="line.124"></a> +<span class="sourceLineNo">125</span> private static void checkRegionsToMerge(MasterProcedureEnv env, final RegionInfo[] regionsToMerge,<a name="line.125"></a> +<span class="sourceLineNo">126</span> final boolean forcible) throws MergeRegionException {<a name="line.126"></a> +<span class="sourceLineNo">127</span> // For now, we only merge 2 regions.<a name="line.127"></a> +<span class="sourceLineNo">128</span> // It could be extended to more than 2 regions in the future.<a name="line.128"></a> +<span class="sourceLineNo">129</span> if (regionsToMerge == null || regionsToMerge.length != 2) {<a name="line.129"></a> +<span class="sourceLineNo">130</span> throw new MergeRegionException("Expected to merge 2 regions, got: " +<a name="line.130"></a> +<span class="sourceLineNo">131</span> Arrays.toString(regionsToMerge));<a name="line.131"></a> +<span class="sourceLineNo">132</span> }<a name="line.132"></a> +<span class="sourceLineNo">133</span><a name="line.133"></a> +<span class="sourceLineNo">134</span> checkRegionsToMerge(env, regionsToMerge[0], regionsToMerge[1], forcible);<a name="line.134"></a> +<span class="sourceLineNo">135</span> }<a name="line.135"></a> +<span class="sourceLineNo">136</span><a name="line.136"></a> +<span class="sourceLineNo">137</span> /**<a name="line.137"></a> +<span class="sourceLineNo">138</span> * One time checks.<a name="line.138"></a> +<span class="sourceLineNo">139</span> */<a name="line.139"></a> +<span class="sourceLineNo">140</span> private static void checkRegionsToMerge(MasterProcedureEnv env, final RegionInfo regionToMergeA,<a name="line.140"></a> +<span class="sourceLineNo">141</span> final RegionInfo regionToMergeB, final boolean forcible) throws MergeRegionException {<a name="line.141"></a> +<span class="sourceLineNo">142</span> if (!regionToMergeA.getTable().equals(regionToMergeB.getTable())) {<a name="line.142"></a> +<span class="sourceLineNo">143</span> throw new MergeRegionException("Can't merge regions from two different tables: " +<a name="line.143"></a> +<span class="sourceLineNo">144</span> regionToMergeA + ", " + regionToMergeB);<a name="line.144"></a> +<span class="sourceLineNo">145</span> }<a name="line.145"></a> +<span class="sourceLineNo">146</span><a name="line.146"></a> +<span class="sourceLineNo">147</span> if (regionToMergeA.getReplicaId() != RegionInfo.DEFAULT_REPLICA_ID ||<a name="line.147"></a> +<span class="sourceLineNo">148</span> regionToMergeB.getReplicaId() != RegionInfo.DEFAULT_REPLICA_ID) {<a name="line.148"></a> +<span class="sourceLineNo">149</span> throw new MergeRegionException("Can't merge non-default replicas");<a name="line.149"></a> +<span class="sourceLineNo">150</span> }<a name="line.150"></a> +<span class="sourceLineNo">151</span><a name="line.151"></a> +<span class="sourceLineNo">152</span> try {<a name="line.152"></a> +<span class="sourceLineNo">153</span> checkOnline(env, regionToMergeA);<a name="line.153"></a> +<span class="sourceLineNo">154</span> checkOnline(env, regionToMergeB);<a name="line.154"></a> +<span class="sourceLineNo">155</span> } catch (DoNotRetryRegionException dnrre) {<a name="line.155"></a> +<span class="sourceLineNo">156</span> throw new MergeRegionException(dnrre);<a name="line.156"></a> +<span class="sourceLineNo">157</span> }<a name="line.157"></a> +<span class="sourceLineNo">158</span><a name="line.158"></a> +<span class="sourceLineNo">159</span> if (!RegionInfo.areAdjacent(regionToMergeA, regionToMergeB)) {<a name="line.159"></a> +<span class="sourceLineNo">160</span> String msg = "Unable to merge non-adjacent regions " + regionToMergeA.getShortNameToLog() +<a name="line.160"></a> +<span class="sourceLineNo">161</span> ", " + regionToMergeB.getShortNameToLog() + " where forcible = " + forcible;<a name="line.161"></a> +<span class="sourceLineNo">162</span> LOG.warn(msg);<a name="line.162"></a> +<span class="sourceLineNo">163</span> if (!forcible) {<a name="line.163"></a> +<span class="sourceLineNo">164</span> throw new MergeRegionException(msg);<a name="line.164"></a> +<span class="sourceLineNo">165</span> }<a name="line.165"></a> +<span class="sourceLineNo">166</span> }<a name="line.166"></a> +<span class="sourceLineNo">167</span> }<a name="line.167"></a> +<span class="sourceLineNo">168</span><a name="line.168"></a> <span class="sourceLineNo">169</span><a name="line.169"></a> -<span class="sourceLineNo">170</span><a name="line.170"></a> -<span class="sourceLineNo">171</span> private static RegionInfo createMergedRegionInfo(final RegionInfo[] regionsToMerge) {<a name="line.171"></a> -<span class="sourceLineNo">172</span> return createMergedRegionInfo(regionsToMerge[0], regionsToMerge[1]);<a name="line.172"></a> -<span class="sourceLineNo">173</span> }<a name="line.173"></a> -<span class="sourceLineNo">174</span><a name="line.174"></a> -<span class="sourceLineNo">175</span> /**<a name="line.175"></a> -<span class="sourceLineNo">176</span> * Create merged region info through the specified two regions<a name="line.176"></a> -<span class="sourceLineNo">177</span> */<a name="line.177"></a> -<span class="sourceLineNo">178</span> private static RegionInfo createMergedRegionInfo(final RegionInfo regionToMergeA,<a name="line.178"></a> -<span class="sourceLineNo">179</span> final RegionInfo regionToMergeB) {<a name="line.179"></a> -<span class="sourceLineNo">180</span> // Choose the smaller as start key<a name="line.180"></a> -<span class="sourceLineNo">181</span> final byte[] startKey;<a name="line.181"></a> -<span class="sourceLineNo">182</span> if (RegionInfo.COMPARATOR.compare(regionToMergeA, regionToMergeB) <= 0) {<a name="line.182"></a> -<span class="sourceLineNo">183</span> startKey = regionToMergeA.getStartKey();<a name="line.183"></a> -<span class="sourceLineNo">184</span> } else {<a name="line.184"></a> -<span class="sourceLineNo">185</span> startKey = regionToMergeB.getStartKey();<a name="line.185"></a> -<span class="sourceLineNo">186</span> }<a name="line.186"></a> -<span class="sourceLineNo">187</span><a name="line.187"></a> -<span class="sourceLineNo">188</span> // Choose the bigger as end key<a name="line.188"></a> -<span class="sourceLineNo">189</span> final byte[] endKey;<a name="line.189"></a> -<span class="sourceLineNo">190</span> if (Bytes.equals(regionToMergeA.getEndKey(), HConstants.EMPTY_BYTE_ARRAY)<a name="line.190"></a> -<span class="sourceLineNo">191</span> || (!Bytes.equals(regionToMergeB.getEndKey(), HConstants.EMPTY_BYTE_ARRAY)<a name="line.191"></a> -<span class="sourceLineNo">192</span> && Bytes.compareTo(regionToMergeA.getEndKey(), regionToMergeB.getEndKey()) > 0)) {<a name="line.192"></a> -<span class="sourceLineNo">193</span> endKey = regionToMergeA.getEndKey();<a name="line.193"></a> -<span class="sourceLineNo">194</span> } else {<a name="line.194"></a> -<span class="sourceLineNo">195</span> endKey = regionToMergeB.getEndKey();<a name="line.195"></a> -<span class="sourceLineNo">196</span> }<a name="line.196"></a> -<span class="sourceLineNo">197</span><a name="line.197"></a> -<span class="sourceLineNo">198</span> // Merged region is sorted between two merging regions in META<a name="line.198"></a> -<span class="sourceLineNo">199</span> return RegionInfoBuilder.newBuilder(regionToMergeA.getTable())<a name="line.199"></a> -<span class="sourceLineNo">200</span> .setStartKey(startKey)<a name="line.200"></a> -<span class="sourceLineNo">201</span> .setEndKey(endKey)<a name="line.201"></a> -<span class="sourceLineNo">202</span> .setSplit(false)<a name="line.202"></a> -<span class="sourceLineNo">203</span> .setRegionId(getMergedRegionIdTimestamp(regionToMergeA, regionToMergeB))<a name="line.203"></a> -<span class="sourceLineNo">204</span> .build();<a name="line.204"></a> -<span class="sourceLineNo">205</span> }<a name="line.205"></a> -<span class="sourceLineNo">206</span><a name="line.206"></a> -<span class="sourceLineNo">207</span> private static long getMergedRegionIdTimestamp(final RegionInfo regionToMergeA,<a name="line.207"></a> -<span class="sourceLineNo">208</span> final RegionInfo regionToMergeB) {<a name="line.208"></a> -<span class="sourceLineNo">209</span> long rid = EnvironmentEdgeManager.currentTime();<a name="line.209"></a> -<span class="sourceLineNo">210</span> // Region Id is a timestamp. Merged region's id can't be less than that of<a name="line.210"></a> -<span class="sourceLineNo">211</span> // merging regions else will insert at wrong location in hbase:meta (See HBASE-710).<a name="line.211"></a> -<span class="sourceLineNo">212</span> if (rid < regionToMergeA.getRegionId() || rid < regionToMergeB.getRegionId()) {<a name="line.212"></a> -<span class="sourceLineNo">213</span> LOG.warn("Clock skew; merging regions id are " + regionToMergeA.getRegionId()<a name="line.213"></a> -<span class="sourceLineNo">214</span> + " and " + regionToMergeB.getRegionId() + ", but current time here is " + rid);<a name="line.214"></a> -<span class="sourceLineNo">215</span> rid = Math.max(regionToMergeA.getRegionId(), regionToMergeB.getRegionId()) + 1;<a name="line.215"></a> -<span class="sourceLineNo">216</span> }<a name="line.216"></a> -<span class="sourceLineNo">217</span> return rid;<a name="line.217"></a> -<span class="sourceLineNo">218</span> }<a name="line.218"></a> -<span class="sourceLineNo">219</span><a name="line.219"></a> -<span class="sourceLineNo">220</span> @Override<a name="line.220"></a> -<span class="sourceLineNo">221</span> protected Flow executeFromState(final MasterProcedureEnv env,<a name="line.221"></a> -<span class="sourceLineNo">222</span> MergeTableRegionsState state) {<a name="line.222"></a> -<span class="sourceLineNo">223</span> LOG.trace("{} execute state={}", this, state);<a name="line.223"></a> -<span class="sourceLineNo">224</span> try {<a name="line.224"></a> -<span class="sourceLineNo">225</span> switch (state) {<a name="line.225"></a> -<span class="sourceLineNo">226</span> case MERGE_TABLE_REGIONS_PREPARE:<a name="line.226"></a> -<span class="sourceLineNo">227</span> if (!prepareMergeRegion(env)) {<a name="line.227"></a> -<span class="sourceLineNo">228</span> assert isFailed() : "Merge region should have an exception here";<a name="line.228"></a> -<span class="sourceLineNo">229</span> return Flow.NO_MORE_STATE;<a name="line.229"></a> -<span class="sourceLineNo">230</span> }<a name="line.230"></a> -<span class="sourceLineNo">231</span> setNextState(MergeTableRegionsState.MERGE_TABLE_REGIONS_PRE_MERGE_OPERATION);<a name="line.231"></a> -<span class="sourceLineNo">232</span> break;<a name="line.232"></a> -<span class="sourceLineNo">233</span> case MERGE_TABLE_REGIONS_PRE_MERGE_OPERATION:<a name="line.233"></a> -<span class="sourceLineNo">234</span> preMergeRegions(env);<a name="line.234"></a> -<span class="sourceLineNo">235</span> setNextState(MergeTableRegionsState.MERGE_TABLE_REGIONS_CLOSE_REGIONS);<a name="line.235"></a> -<span class="sourceLineNo">236</span> break;<a name="line.236"></a> -<span class="sourceLineNo">237</span> case MERGE_TABLE_REGIONS_CLOSE_REGIONS:<a name="line.237"></a> -<span class="sourceLineNo">238</span> addChildProcedure(createUnassignProcedures(env, getRegionReplication(env)));<a name="line.238"></a> -<span class="sourceLineNo">239</span> setNextState(MergeTableRegionsState.MERGE_TABLE_REGIONS_CHECK_CLOSED_REGIONS);<a name="line.239"></a> -<span class="sourceLineNo">240</span> break;<a name="line.240"></a> -<span class="sourceLineNo">241</span> case MERGE_TABLE_REGIONS_CHECK_CLOSED_REGIONS:<a name="line.241"></a> -<span class="sourceLineNo">242</span> checkClosedRegions(env);<a name="line.242"></a> -<span class="sourceLineNo">243</span> setNextState(MergeTableRegionsState.MERGE_TABLE_REGIONS_CREATE_MERGED_REGION);<a name="line.243"></a> -<span class="sourceLineNo">244</span> break;<a name="line.244"></a> -<span class="sourceLineNo">245</span> case MERGE_TABLE_REGIONS_CREATE_MERGED_REGION:<a name="line.245"></a> -<span class="sourceLineNo">246</span> createMergedRegion(env);<a name="line.246"></a> -<span class="sourceLineNo">247</span> setNextState(MergeTableRegionsState.MERGE_TABLE_REGIONS_WRITE_MAX_SEQUENCE_ID_FILE);<a name="line.247"></a> -<span class="sourceLineNo">248</span> break;<a name="line.248"></a> -<span class="sourceLineNo">249</span> case MERGE_TABLE_REGIONS_WRITE_MAX_SEQUENCE_ID_FILE:<a name="line.249"></a> -<span class="sourceLineNo">250</span> writeMaxSequenceIdFile(env);<a name="line.250"></a> -<span class="sourceLineNo">251</span> setNextState(MergeTableRegionsState.MERGE_TABLE_REGIONS_PRE_MERGE_COMMIT_OPERATION);<a name="line.251"></a> -<span class="sourceLineNo">252</span> break;<a name="line.252"></a> -<span class="sourceLineNo">253</span> case MERGE_TABLE_REGIONS_PRE_MERGE_COMMIT_OPERATION:<a name="line.253"></a> -<span class="sourceLineNo">254</span> preMergeRegionsCommit(env);<a name="line.254"></a> -<span class="sourceLineNo">255</span> setNextState(MergeTableRegionsState.MERGE_TABLE_REGIONS_UPDATE_META);<a name="line.255"></a> -<span class="sourceLineNo">256</span> break;<a name="line.256"></a> -<span class="sourceLineNo">257</span> case MERGE_TABLE_REGIONS_UPDATE_META:<a name="line.257"></a> -<span class="sourceLineNo">258</span> updateMetaForMergedRegions(env);<a name="line.258"></a> -<span class="sourceLineNo">259</span> setNextState(MergeTableRegionsState.MERGE_TABLE_REGIONS_POST_MERGE_COMMIT_OPERATION);<a name="line.259"></a> -<span class="sourceLineNo">260</span> break;<a name="line.260"></a> -<span class="sourceLineNo">261</span> case MERGE_TABLE_REGIONS_POST_MERGE_COMMIT_OPERATION:<a name="line.261"></a> -<span class="sourceLineNo">262</span> postMergeRegionsCommit(env);<a name="line.262"></a> -<span class="sourceLineNo">263</span> setNextState(MergeTableRegionsState.MERGE_TABLE_REGIONS_OPEN_MERGED_REGION);<a name="line.263"></a> -<span class="sourceLineNo">264</span> break;<a name="line.264"></a> -<span class="sourceLineNo">265</span> case MERGE_TABLE_REGIONS_OPEN_MERGED_REGION:<a name="line.265"></a> -<span class="sourceLineNo">266</span> addChildProcedure(createAssignProcedures(env, getRegionReplication(env)));<a name="line.266"></a> -<span class="sourceLineNo">267</span> setNextState(MergeTableRegionsState.MERGE_TABLE_REGIONS_POST_OPERATION);<a name="line.267"></a> -<span class="sourceLineNo">268</span> break;<a name="line.268"></a> -<span class="sourceLineNo">269</span> case MERGE_TABLE_REGIONS_POST_OPERATION:<a name="line.269"></a> -<span class="sourceLineNo">270</span> postCompletedMergeRegions(env);<a name="line.270"></a> -<span class="sourceLineNo">271</span> return Flow.NO_MORE_STATE;<a name="line.271"></a> -<span class="sourceLineNo">272</span> default:<a name="line.272"></a> -<span class="sourceLineNo">273</span> throw new UnsupportedOperationException(this + " unhandled state=" + state);<a name="line.273"></a> -<span class="sourceLineNo">274</span> }<a name="line.274"></a> -<span class="sourceLineNo">275</span> } catch (IOException e) {<a name="line.275"></a> -<span class="sourceLineNo">276</span> String msg = "Error trying to merge regions " +<a name="line.276"></a> -<span class="sourceLineNo">277</span> RegionInfo.getShortNameToLog(regionsToMerge) + " in the table " + getTableName() +<a name="line.277"></a> -<span class="sourceLineNo">278</span> " (in state=" + state + ")";<a name="line.278"></a> -<span class="sourceLineNo">279</span> if (!isRollbackSupported(state)) {<a name="line.279"></a> -<span class="sourceLineNo">280</span> // We reach a state that cannot be rolled back. We just need to keep retrying.<a name="line.280"></a> -<span class="sourceLineNo">281</span> LOG.warn(msg, e);<a name="line.281"></a> -<span class="sourceLineNo">282</span> } else {<a name="line.282"></a> -<span class="sourceLineNo">283</span> LOG.error(msg, e);<a name="line.283"></a> -<span class="sourceLineNo">284</span> setFailure("master-merge-regions", e);<a name="line.284"></a> -<span class="sourceLineNo">285</span> }<a name="line.285"></a> -<span class="sourceLineNo">286</span> }<a name="line.286"></a> -<span class="sourceLineNo">287</span> return Flow.HAS_MORE_STATE;<a name="line.287"></a> -<span class="sourceLineNo">288</span> }<a name="line.288"></a> -<span class="sourceLineNo">289</span><a name="line.289"></a> -<span class="sourceLineNo">290</span> /**<a name="line.290"></a> -<span class="sourceLineNo">291</span> * To rollback {@link MergeTableRegionsProcedure}, two AssignProcedures are asynchronously<a name="line.291"></a> -<span class="sourceLineNo">292</span> * submitted for each region to be merged (rollback doesn't wait on the completion of the<a name="line.292"></a> -<span class="sourceLineNo">293</span> * AssignProcedures) . This can be improved by changing rollback() to support sub-procedures.<a name="line.293"></a> -<span class="sourceLineNo">294</span> * See HBASE-19851 for details.<a name="line.294"></a> -<span class="sourceLineNo">295</span> */<a name="line.295"></a> -<span class="sourceLineNo">296</span> @Override<a name="line.296"></a> -<span class="sourceLineNo">297</span> protected void rollbackState(final MasterProcedureEnv env, final MergeTableRegionsState state)<a name="line.297"></a> -<span class="sourceLineNo">298</span> throws IOException {<a name="line.298"></a> -<span class="sourceLineNo">299</span> if (isTraceEnabled()) {<a name="line.299"></a> -<span class="sourceLineNo">300</span> LOG.trace(this + " rollback state=" + state);<a name="line.300"></a> -<span class="sourceLineNo">301</span> }<a name="line.301"></a> -<span class="sourceLineNo">302</span><a name="line.302"></a> -<span class="sourceLineNo">303</span> try {<a name="line.303"></a> -<span class="sourceLineNo">304</span> switch (state) {<a name="line.304"></a> -<span class="sourceLineNo">305</span> case MERGE_TABLE_REGIONS_POST_OPERATION:<a name="line.305"></a> -<span class="sourceLineNo">306</span> case MERGE_TABLE_REGIONS_OPEN_MERGED_REGION:<a name="line.306"></a> -<span class="sourceLineNo">307</span> case MERGE_TABLE_REGIONS_POST_MERGE_COMMIT_OPERATION:<a name="line.307"></a> -<span class="sourceLineNo">308</span> case MERGE_TABLE_REGIONS_UPDATE_META:<a name="line.308"></a> -<span class="sourceLineNo">309</span> String msg = this + " We are in the " + state + " state." +<a name="line.309"></a> -<span class="sourceLineNo">310</span> " It is complicated to rollback the merge operation that region server is working on." +<a name="line.310"></a> -<span class="sourceLineNo">311</span> " Rollback is not supported and we should let the merge operation to complete";<a name="line.311"></a> -<span class="sourceLineNo">312</span> LOG.warn(msg);<a name="line.312"></a> -<span class="sourceLineNo">313</span> // PONR<a name="line.313"></a> -<span class="sourceLineNo">314</span> throw new UnsupportedOperationException(this + " unhandled state=" + state);<a name="line.314"></a> -<span class="sourceLineNo">315</span> case MERGE_TABLE_REGIONS_PRE_MERGE_COMMIT_OPERATION:<a name="line.315"></a> -<span class="sourceLineNo">316</span> break;<a name="line.316"></a> -<span class="sourceLineNo">317</span> case MERGE_TABLE_REGIONS_CREATE_MERGED_REGION:<a name="line.317"></a> -<span class="sourceLineNo">318</span> case MERGE_TABLE_REGIONS_WRITE_MAX_SEQUENCE_ID_FILE:<a name="line.318"></a> -<span class="sourceLineNo">319</span> cleanupMergedRegion(env);<a name="line.319"></a> -<span class="sourceLineNo">320</span> break;<a name="line.320"></a> -<span class="sourceLineNo">321</span> case MERGE_TABLE_REGIONS_CHECK_CLOSED_REGIONS:<a name="line.321"></a> -<span class="sourceLineNo">322</span> break;<a name="line.322"></a> -<span class="sourceLineNo">323</span> case MERGE_TABLE_REGIONS_CLOSE_REGIONS:<a name="line.323"></a> -<span class="sourceLineNo">324</span> rollbackCloseRegionsForMerge(env);<a name="line.324"></a> -<span class="sourceLineNo">325</span> break;<a name="line.325"></a> -<span class="sourceLineNo">326</span> case MERGE_TABLE_REGIONS_PRE_MERGE_OPERATION:<a name="line.326"></a> -<span class="sourceLineNo">327</span> postRollBackMergeRegions(env);<a name="line.327"></a> -<span class="sourceLineNo">328</span> break;<a name="line.328"></a> -<span class="sourceLineNo">329</span> case MERGE_TABLE_REGIONS_PREPARE:<a name="line.329"></a> -<span class="sourceLineNo">330</span> break;<a name="line.330"></a> -<span class="sourceLineNo">331</span> default:<a name="line.331"></a> -<span class="sourceLineNo">332</span> throw new UnsupportedOperationException(this + " unhandled state=" + state);<a name="line.332"></a> -<span class="sourceLineNo">333</span> }<a name="line.333"></a> -<span class="sourceLineNo">334</span> } catch (Exception e) {<a name="line.334"></a> -<span class="sourceLineNo">335</span> // This will be retried. Unless there is a bug in the code,<a name="line.335"></a> -<span class="sourceLineNo">336</span> // this should be just a "temporary error" (e.g. network down)<a name="line.336"></a> -<span class="sourceLineNo">337</span> LOG.warn("Failed rollback attempt step " + state + " for merging the regions "<a name="line.337"></a> -<span class="sourceLineNo">338</span> + RegionInfo.getShortNameToLog(regionsToMerge) + " in table " + getTableName(), e);<a name="line.338"></a> -<span class="sourceLineNo">339</span> throw e;<a name="line.339"></a> -<span class="sourceLineNo">340</span> }<a name="line.340"></a> -<span class="sourceLineNo">341</span> }<a name="line.341"></a> -<span class="sourceLineNo">342</span><a name="line.342"></a> -<span class="sourceLineNo">343</span> /*<a name="line.343"></a> -<span class="sourceLineNo">344</span> * Check whether we are in the state that can be rolled back<a name="line.344"></a> -<span class="sourceLineNo">345</span> */<a name="line.345"></a> -<span class="sourceLineNo">346</span> @Override<a name="line.346"></a> -<span class="sourceLineNo">347</span> protected boolean isRollbackSupported(final MergeTableRegionsState state) {<a name="line.347"></a> -<span class="sourceLineNo">348</span> switch (state) {<a name="line.348"></a> -<span class="sourceLineNo">349</span> case MERGE_TABLE_REGIONS_POST_OPERATION:<a name="line.349"></a> -<span class="sourceLineNo">350</span> case MERGE_TABLE_REGIONS_OPEN_MERGED_REGION:<a name="line.350"></a> -<span class="sourceLineNo">351</span> case MERGE_TABLE_REGIONS_POST_MERGE_COMMIT_OPERATION:<a name="line.351"></a> -<span class="sourceLineNo">352</span> case MERGE_TABLE_REGIONS_UPDATE_META:<a name="line.352"></a> -<span class="sourceLineNo">353</span> // It is not safe to rollback in these states.<a name="line.353"></a> -<span class="sourceLineNo">354</span> return false;<a name="line.354"></a> -<span class="sourceLineNo">355</span> default:<a name="line.355"></a> -<span class="sourceLineNo">356</span> break;<a name="line.356"></a> -<span class="sourceLineNo">357</span> }<a name="line.357"></a> -<span class="sourceLineNo">358</span> return true;<a name="line.358"></a> -<span class="sourceLineNo">359</span> }<a name="line.359"></a> -<span class="sourceLineNo">360</span><a name="line.360"></a> -<span class="sourceLineNo">361</span> @Override<a name="line.361"></a> -<span class="sourceLineNo">362</span> protected MergeTableRegionsState getState(final int stateId) {<a name="line.362"></a> -<span class="sourceLineNo">363</span> return MergeTableRegionsState.forNumber(stateId);<a name="line.363"></a> -<span class="sourceLineNo">364</span> }<a name="line.364"></a> -<span class="sourceLineNo">365</span><a name="line.365"></a> -<span class="sourceLineNo">366</span> @Override<a name="line.366"></a> -<span class="sourceLineNo">367</span> protected int getStateId(final MergeTableRegionsState state) {<a name="line.367"></a> -<span class="sourceLineNo">368</span> return state.getNumber();<a name="line.368"></a> -<span class="sourceLineNo">369</span> }<a name="line.369"></a> -<span class="sourceLineNo">370</span><a name="line.370"></a> -<span class="sourceLineNo">371</span> @Override<a name="line.371"></a> -<span class="sourceLineNo">372</span> protected MergeTableRegionsState getInitialState() {<a name="line.372"></a> -<span class="sourceLineNo">373</span> return MergeTableRegionsState.MERGE_TABLE_REGIONS_PREPARE;<a name="line.373"></a> -<span class="sourceLineNo">374</span> }<a name="line.374"></a> -<span class="sourceLineNo">375</span><a name="line.375"></a> -<span class="sourceLineNo">376</span> @Override<a name="line.376"></a> -<span class="sourceLineNo">377</span> protected void serializeStateData(ProcedureStateSerializer serializer)<a name="line.377"></a> -<span class="sourceLineNo">378</span> throws IOException {<a name="line.378"></a> -<span class="sourceLineNo">379</span> super.serializeStateData(serializer);<a name="line.379"></a> -<span class="sourceLineNo">380</span><a name="line.380"></a> -<span class="sourceLineNo">381</span> final MasterProcedureProtos.MergeTableRegionsStateData.Builder mergeTableRegionsMsg =<a name="line.381"></a> -<span class="sourceLineNo">382</span> MasterProcedureProtos.MergeTableRegionsStateData.newBuilder()<a name="line.382"></a> -<span class="sourceLineNo">383</span> .setUserInfo(MasterProcedureUtil.toProtoUserInfo(getUser()))<a name="line.383"></a> -<span class="sourceLineNo">384</span> .setMergedRegionInfo(ProtobufUtil.toRegionInfo(mergedRegion))<a name="line.384"></a> -<span class="sourceLineNo">385</span> .setForcible(forcible);<a name="line.385"></a> -<span class="sourceLineNo">386</span> for (int i = 0; i < regionsToMerge.length; ++i) {<a name="line.386"></a> -<span class="sourceLineNo">387</span> mergeTableRegionsMsg.addRegionInfo(ProtobufUtil.toRegionInfo(regionsToMerge[i]));<a name="line.387"></a> -<span class="sourceLineNo">388</span> }<a name="line.388"></a> -<span class="sourceLineNo">389</span> serializer.serialize(mergeTableRegionsMsg.build());<a name="line.389"></a> -<span class="sourceLineNo">390</span> }<a name="line.390"></a> -<span class="sourceLineNo">391</span><a name="line.391"></a> -<span class="sourceLineNo">392</span> @Override<a name="line.392"></a> -<span class="sourceLineNo">393</span> protected void deserializeStateData(ProcedureStateSerializer serializer)<a name="line.393"></a> -<span class="sourceLineNo">394</span> throws IOException {<a name="line.394"></a> -<span class="sourceLineNo">395</span> super.deserializeStateData(serializer);<a name="line.395"></a> -<span class="sourceLineNo">396</span><a name="line.396"></a> -<span class="sourceLineNo">397</span> final MasterProcedureProtos.MergeTableRegionsStateData mergeTableRegionsMsg =<a name="line.397"></a> -<span class="sourceLineNo">398</span> serializer.deserialize(MasterProcedureProtos.MergeTableRegionsStateData.class);<a name="line.398"></a> -<span class="sourceLineNo">399</span> setUser(MasterProcedureUtil.toUserInfo(mergeTableRegionsMsg.getUserInfo()));<a name="line.399"></a> -<span class="sourceLineNo">400</span><a name="line.400"></a> -<span class="sourceLineNo">401</span> assert(mergeTableRegionsMsg.getRegionInfoCount() == 2);<a name="line.401"></a> -<span class="sourceLineNo">402</span> regionsToMerge = new RegionInfo[mergeTableRegionsMsg.getRegionInfoCount()];<a name="line.402"></a> -<span class="sourceLineNo">403</span> for (int i = 0; i < regionsToMerge.length; i++) {<a name="line.403"></a> -<span class="sourceLineNo">404</span> regionsToMerge[i] = ProtobufUtil.toRegionInfo(mergeTableRegionsMsg.getRegionInfo(i));<a name="line.404"></a> -<span class="sourceLineNo">405</span> }<a name="line.405"></a> -<span class="sourceLineNo">406</span><a name="line.406"></a> -<span class="sourceLineNo">407</span> mergedRegion = ProtobufUtil.toRegionInfo(mergeTableRegionsMsg.getMergedRegionInfo());<a name="line.407"></a> -<span class="sourceLineNo">408</span> }<a name="line.408"></a> -<span class="sourceLineNo">409</span><a name="line.409"></a> -<span class="sourceLineNo">410</span> @Override<a name="line.410"></a> -<span class="sourceLineNo">411</span> public void toStringClassDetails(StringBuilder sb) {<a name="line.411"></a> -<span class="sourceLineNo">412</span> sb.append(getClass().getSimpleName());<a name="line.412"></a> -<span class="sourceLineNo">413</span> sb.append(" table=");<a name="line.413"></a> -<span class="sourceLineNo">414</span> sb.append(getTableName());<a name="line.414"></a> -<span class="sourceLineNo">415</span> sb.append(", regions=");<a name="line.415"></a> -<span class="sourceLineNo">416</span> sb.append(RegionInfo.getShortNameToLog(regionsToMerge));<a name="line.416"></a> -<span class="sourceLineNo">417</span> sb.append(", forcibly=");<a name="line.417"></a> -<span class="sourceLineNo">418</span> sb.append(forcible);<a name="line.418"></a> -<span class="sourceLineNo">419</span> }<a name="line.419"></a> -<span class="sourceLineNo">420</span><a name="line.420"></a> -<span class="sourceLineNo">421</span> @Override<a name="line.421"></a> -<span class="sourceLineNo">422</span> protected LockState acquireLock(final MasterProcedureEnv env) {<a name="line.422"></a> -<span class="sourceLineNo">423</span> if (env.waitInitialized(this)) return LockState.LOCK_EVENT_WAIT;<a name="line.423"></a> -<span class="sourceLineNo">424</span> if (env.getProcedureScheduler().waitRegions(this, getTableName(),<a name="line.424"></a> -<span class="sourceLineNo">425</span> mergedRegion, regionsToMerge[0], regionsToMerge[1])) {<a name="line.425"></a> -<span class="sourceLineNo">426</span> try {<a name="line.426"></a> -<span class="sourceLineNo">427</span> LOG.debug(LockState.LOCK_EVENT_WAIT + " " + env.getProcedureScheduler().dumpLocks());<a name="line.427"></a> -<span class="sourceLineNo">428</span> } catch (IOException e) {<a name="line.428"></a> -<span class="sourceLineNo">429</span> // TODO Auto-generated catch block<a name="line.429"></a> -<span class="sourceLineNo">430</span> e.printStackTrace();<a name="line.430"></a> -<span class="sourceLineNo">431</span> }<a name="line.431"></a> -<span class="sourceLineNo">432</span> return LockState.LOCK_EVENT_WAIT;<a name="line.432"></a> -<span class="sourceLineNo">433</span> }<a name="line.433"></a> -<span class="sourceLineNo">434</span> this.lock = true;<a name="line.434"></a> -<span class="sourceLineNo">435</span> return LockState.LOCK_ACQUIRED;<a name="line.435"></a> -<span class="sourceLineNo">436</span> }<a name="line.436"></a> -<span class="sourceLineNo">437</span><a name="line.437"></a> -<span class="sourceLineNo">438</span> @Override<a name="line.438"></a> -<span class="sourceLineNo">439</span> protected void releaseLock(final MasterProcedureEnv env) {<a name="line.439"></a> -<span class="sourceLineNo">440</span> this.lock = false;<a name="line.440"></a> -<span class="sourceLineNo">441</span> env.getProcedureScheduler().wakeRegions(this, getTableName(),<a name="line.441"></a> -<span class="sourceLineNo">442</span> mergedRegion, regionsToMerge[0], regionsToMerge[1]);<a name="line.442"></a> +<span class="sourceLineNo">170</span> private static RegionInfo createMergedRegionInfo(final RegionInfo[] regionsToMerge) {<a name="line.170"></a> +<span class="sourceLineNo">171</span> return createMergedRegionInfo(regionsToMerge[0], regionsToMerge[1]);<a name="line.171"></a> +<span class="sourceLineNo">172</span> }<a name="line.172"></a> +<span class="sourceLineNo">173</span><a name="line.173"></a> +<span class="sourceLineNo">174</span> /**<a name="line.174"></a> +<span class="sourceLineNo">175</span> * Create merged region info through the specified two regions<a name="line.175"></a> +<span class="sourceLineNo">176</span> */<a name="line.176"></a> +<span class="sourceLineNo">177</span> private static RegionInfo createMergedRegionInfo(final RegionInfo regionToMergeA,<a name="line.177"></a> +<span class="sourceLineNo">178</span> final RegionInfo regionToMergeB) {<a name="line.178"></a> +<span class="sourceLineNo">179</span> // Choose the smaller as start key<a name="line.179"></a> +<span class="sourceLineNo">180</span> final byte[] startKey;<a name="line.180"></a> +<span class="sourceLineNo">181</span> if (RegionInfo.COMPARATOR.compare(regionToMergeA, regionToMergeB) <= 0) {<a name="line.181"></a> +<span class="sourceLineNo">182</span> startKey = regionToMergeA.getStartKey();<a name="line.182"></a> +<span class="sourceLineNo">183</span> } else {<a name="line.183"></a> +<span class="sourceLineNo">184</span> startKey = regionToMergeB.getStartKey();<a name="line.184"></a> +<span class="sourceLineNo">185</span> }<a name="line.185"></a> +<span class="sourceLineNo">186</span><a name="line.186"></a> +<span class="sourceLineNo">187</span> // Choose the bigger as end key<a name="line.187"></a> +<span class="sourceLineNo">188</span> final byte[] endKey;<a name="line.188"></a> +<span class="sourceLineNo">189</span> if (Bytes.equals(regionToMergeA.getEndKey(), HConstants.EMPTY_BYTE_ARRAY)<a name="line.189"></a> +<span class="sourceLineNo">190</span> || (!Bytes.equals(regionToMergeB.getEndKey(), HConstants.EMPTY_BYTE_ARRAY)<a name="line.190"></a> +<span class="sourceLineNo">191</span> && Bytes.compareTo(regionToMergeA.getEndKey(), regionToMergeB.getEndKey()) > 0)) {<a name="line.191"></a> +<span class="sourceLineNo">192</span> endKey = regionToMergeA.getEndKey();<a name="line.192"></a> +<span class="sourceLineNo">193</span> } else {<a name="line.193"></a> +<span class="sourceLineNo">194</span> endKey = regionToMergeB.getEndKey();<a name="line.194"></a> +<span class="sourceLineNo">195</span> }<a name="line.195"></a> +<span class="sourceLineNo">196</span><a name="line.196"></a> +<span class="sourceLineNo">197</span> // Merged region is sorted between two merging regions in META<a name="line.197"></a> +<span class="sourceLineNo">198</span> return RegionInfoBuilder.newBuilder(regionToMergeA.getTable())<a name="line.198"></a> +<span class="sourceLineNo">199</span> .setStartKey(startKey)<a name="line.199"></a> +<span class="sourceLineNo">200</span> .setEndKey(endKey)<a name="line.200"></a> +<span class="sourceLineNo">201</span> .setSplit(false)<a name="line.201"></a> +<span class="sourceLineNo">202</span> .setRegionId(getMergedRegionIdTimestamp(regionToMergeA, regionToMergeB))<a name="line.202"></a> +<span class="sourceLineNo">203</span> .build();<a name="line.203"></a> +<span class="sourceLineNo">204</span> }<a name="line.204"></a> +<span class="sourceLineNo">205</span><a name="line.205"></a> +<span class="sourceLineNo">206</span> private static long getMergedRegionIdTimestamp(final RegionInfo regionToMergeA,<a name="line.206"></a> +<span class="sourceLineNo">207</span> final RegionInfo regionToMergeB) {<a name="line.207"></a> +<span class="sourceLineNo">208</span> long rid = EnvironmentEdgeManager.currentTime();<a name="line.208"></a> +<span class="sourceLineNo">209</span> // Region Id is a timestamp. Merged region's id can't be less than that of<a name="line.209"></a> +<span class="sourceLineNo">210</span> // merging regions else will insert at wrong location in hbase:meta (See HBASE-710).<a name="line.210"></a> +<span class="sourceLineNo">211</span> if (rid < regionToMergeA.getRegionId() || rid < regionToMergeB.getRegionId()) {<a name="line.211"></a> +<span class="sourceLineNo">212</span> LOG.warn("Clock skew; merging regions id are " + regionToMergeA.getRegionId()<a name="line.212"></a> +<span class="sourceLineNo">213</span> + " and " + regionToMergeB.getRegionId() + ", but current time here is " + rid);<a name="line.213"></a> +<span class="sourceLineNo">214</span> rid = Math.max(regionToMergeA.getRegionId(), regionToMergeB.getRegionId()) + 1;<a name="line.214"></a> +<span class="sourceLineNo">215</span> }<a name="line.215"></a> +<span class="sourceLineNo">216</span> return rid;<a name="line.216"></a> +<span class="sourceLineNo">217</span> }<a name="line.217"></a> +<span class="sourceLineNo">218</span><a name="line.218"></a> +<span class="sourceLineNo">219</span> @Override<a name="line.219"></a> +<span class="sourceLineNo">220</span> protected Flow executeFromState(final MasterProcedureEnv env,<a name="line.220"></a> +<span class="sourceLineNo">221</span> MergeTableRegionsState state) {<a name="line.221"></a> +<span class="sourceLineNo">222</span> LOG.trace("{} execute state={}", this, state);<a name="line.222"></a> +<span class="sourceLineNo">223</span> try {<a name="line.223"></a> +<span class="sourceLineNo">224</span> switch (state) {<a name="line.224"></a> +<span class="sourceLineNo">225</span> case MERGE_TABLE_REGIONS_PREPARE:<a name="line.225"></a> +<span class="sourceLineNo">226</span> if (!prepareMergeRegion(env)) {<a name="line.226"></a> +<span class="sourceLineNo">227</span> assert isFailed() : "Merge region should have an exception here";<a name="line.227"></a> +<span class="sourceLineNo">228</span> return Flow.NO_MORE_STATE;<a name="line.228"></a> +<span class="sourceLineNo">229</span> }<a name="line.229"></a> +<span class="sourceLineNo">230</span> setNextState(MergeTableRegionsState.MERGE_TABLE_REGIONS_PRE_MERGE_OPERATION);<a name="line.230"></a> +<span class="sourceLineNo">231</span> break;<a name="line.231"></a> +<span class="sourceLineNo">232</span> case MERGE_TABLE_REGIONS_PRE_MERGE_OPERATION:<a name="line.232"></a> +<span class="sourceLineNo">233</span> preMergeRegions(env);<a name="line.233"></a> +<span class="sourceLineNo">234</span> setNextState(MergeTableRegionsState.MERGE_TABLE_REGIONS_CLOSE_REGIONS);<a name="line.234"></a> +<span class="sourceLineNo">235</span> break;<a name="line.235"></a> +<span class="sourceLineNo">236</span> case MERGE_TABLE_REGIONS_CLOSE_REGIONS:<a name="line.236"></a> +<span class="sourceLineNo">237</span> addChildProcedure(createUnassignProcedures(env, getRegionReplication(env)));<a name="line.237"></a> +<span class="sourceLineNo">238</span> setNextState(MergeTableRegionsState.MERGE_TABLE_REGIONS_CHECK_CLOSED_REGIONS);<a name="line.238"></a> +<span class="sourceLineNo">239</span> break;<a name="line.239"></a> +<span class="sourceLineNo">240</span> case MERGE_TABLE_REGIONS_CHECK_CLOSED_REGIONS:<a name="line.240"></a> +<span class="sourceLineNo">241</span> checkClosedRegions(env);<a name="line.241"></a> +<span class="sourceLineNo">242</span> setNextState(MergeTableRegionsState.MERGE_TABLE_REGIONS_CREATE_MERGED_REGION);<a name="line.242"></a> +<span class="sourceLineNo">243</span> break;<a name="line.243"></a> +<span class="sourceLineNo">244</span> case MERGE_TABLE_REGIONS_CREATE_MERGED_REGION:<a name="line.244"></a> +<span class="sourceLineNo">245</span> createMergedRegion(env);<a name="line.245"></a> +<span class="sourceLineNo">246</span> setNextState(MergeTableRegionsState.MERGE_TABLE_REGIONS_WRITE_MAX_SEQUENCE_ID_FILE);<a name="line.246"></a> +<span class="sourceLineNo">247</span> break;<a name="line.247"></a> +<span class="sourceLineNo">248</span> case MERGE_TABLE_REGIONS_WRITE_MAX_SEQUENCE_ID_FILE:<a name="line.248"></a> +<span class="sourceLineNo">249</span> writeMaxSequenceIdFile(env);<a name="line.249"></a> +<span class="sourceLineNo">250</span> setNextState(MergeTableRegionsState.MERGE_TABLE_REGIONS_PRE_MERGE_COMMIT_OPERATION);<a name="line.250"></a> +<span class="sourceLineNo">251</span> break;<a name="line.251"></a> +<span class="sourceLineNo">252</span> case MERGE_TABLE_REGIONS_PRE_MERGE_COMMIT_OPERATION:<a name="line.252"></a> +<span class="sourceLineNo">253</span> preMergeRegionsCommit(env);<a name="line.253"></a> +<span class="sourceLineNo">254</span> setNextState(MergeTableRegionsState.MERGE_TABLE_REGIONS_UPDATE_META);<a name="line.254"></a> +<span class="sourceLineNo">255</span> break;<a name="line.255"></a> +<span class="sourceLineNo">256</span> case MERGE_TABLE_REGIONS_UPDATE_META:<a name="line.256"></a> +<span class="sourceLineNo">257</span> updateMetaForMergedRegions(env);<a name="line.257"></a> +<span class="sourceLineNo">258</span> setNextState(MergeTableRegionsState.MERGE_TABLE_REGIONS_POST_MERGE_COMMIT_OPERATION);<a name="line.258"></a> +<span class="sourceLineNo">259</span> break;<a name="line.259"></a> +<span class="sourceLineNo">260</span> case MERGE_TABLE_REGIONS_POST_MERGE_COMMIT_OPERATION:<a name="line.260"></a> +<span class="sourceLineNo">261</span> postMergeRegionsCommit(env);<a name="line.261"></a> +<span class="sourceLineNo">262</span> setNextState(MergeTableRegionsState.MERGE_TABLE_REGIONS_OPEN_MERGED_REGION);<a name="line.262"></a> +<span class="sourceLineNo">263</span> break;<a name="line.263"></a> +<span class="sourceLineNo">264</span> case MERGE_TABLE_REGIONS_OPEN_MERGED_REGION:<a name="line.264"></a> +<span class="sourceLineNo">265</span> addChildProcedure(createAssignProcedures(env, getRegionReplication(env)));<a name="line.265"></a> +<span class="sourceLineNo">266</span> setNextState(MergeTableRegionsState.MERGE_TABLE_REGIONS_POST_OPERATION);<a name="line.266"></a> +<span class="sourceLineNo">267</span> break;<a name="line.267"></a> +<span class="sourceLineNo">268</span> case MERGE_TABLE_REGIONS_POST_OPERATION:<a name="line.268"></a> +<span class="sourceLineNo">269</span> postCompletedMergeRegions(env);<a name="line.269"></a> +<span class="sourceLineNo">270</span> return Flow.NO_MORE_STATE;<a name="line.270"></a> +<span class="sourceLineNo">271</span> default:<a name="line.271"></a> +<span class="sourceLineNo">272</span> throw new UnsupportedOperationException(this + " unhandled state=" + state);<a name="line.272"></a> +<span class="sourceLineNo">273</span> }<a name="line.273"></a> +<span class="sourceLineNo">274</span> } catch (IOException e) {<a name="line.274"></a> +<span class="sourceLineNo">275</span> String msg = "Error trying to merge regions " +<a name="line.275"></a> +<span class="sourceLineNo">276</span> RegionInfo.getShortNameToLog(regionsToMerge) + " in the table " + getTableName() +<a name="line.276"></a> +<span class="sourceLineNo">277</span> " (in state=" + state + ")";<a name="line.277"></a> +<span class="sourceLineNo">278</span> if (!isRollbackSupported(state)) {<a name="line.278"></a> +<span class="sourceLineNo">279</span> // We reach a state that cannot be rolled back. We just need to keep retrying.<a name="line.279"></a> +<span class="sourceLineNo">280</span> LOG.warn(msg, e);<a name="line.280"></a> +<span class="sourceLineNo">281</span> } else {<a name="line.281"></a> +<span class="sourceLineNo">282</span> LOG.error(msg, e);<a name="line.282"></a> +<span class="sourceLineNo">283</span> setFailure("master-merge-regions", e);<a name="line.283"></a> +<span class="sourceLineNo">284</span> }<a name="line.284"></a> +<span class="sourceLineNo">285</span> }<a name="line.285"></a> +<span class="sourceLineNo">286</span> return Flow.HAS_MORE_STATE;<a name="line.286"></a> +<span class="sourceLineNo">287</span> }<a name="line.287"></a> +<span class="sourceLineNo">288</span><a name="line.288"></a> +<span class="sourceLineNo">289</span> /**<a name="line.289"></a> +<span class="sourceLineNo">290</span> * To rollback {@link MergeTableRegionsProcedure}, two AssignProcedures are asynchronously<a name="line.290"></a> +<span class="sourceLineNo">291</span> * submitted for each region to be merged (rollback doesn't wait on the completion of the<a name="line.291"></a> +<span class="sourceLineNo">292</span> * AssignProcedures) . This can be improved by changing rollback() to support sub-procedures.<a name="line.292"></a> +<span class="sourceLineNo">293</span> * See HBASE-19851 for details.<a name="line.293"></a> +<span class="sourceLineNo">294</span> */<a name="line.294"></a> +<span class="sourceLineNo">295</span> @Override<a name="line.295"></a> +<span class="sourceLineNo">296</span> protected void rollbackState(final MasterProcedureEnv env, final MergeTableRegionsState state)<a name="line.296"></a> +<span class="sourceLineNo">297</span> throws IOException {<a name="line.297"></a> +<span class="sourceLineNo">298</span> if (isTraceEnabled()) {<a name="line.298"></a> +<span class="sourceLineNo">299</span> LOG.trace(this + " rollback state=" + state);<a name="line.299"></a> +<span class="sourceLineNo">300</span> }<a name="line.300"></a> +<span class="sourceLineNo">301</span><a name="line.301"></a> +<span class="sourceLineNo">302</span> try {<a name="line.302"></a> +<span class="sourceLineNo">303</span> switch (state) {<a name="line.303"></a> +<span class="sourceLineNo">304</span> case MERGE_TABLE_REGIONS_POST_OPERATION:<a name="line.304"></a> +<span class="sourceLineNo">305</span> case MERGE_TABLE_REGIONS_OPEN_MERGED_REGION:<a name="line.305"></a> +<span class="sourceLineNo">306</span> case MERGE_TABLE_REGIONS_POST_MERGE_COMMIT_OPERATION:<a name="line.306"></a> +<span class="sourceLineNo">307</span> case MERGE_TABLE_REGIONS_UPDATE_META:<a name="line.307"></a> +<span class="sourceLineNo">308</span> String msg = this + " We are in the " + state + " state." +<a name="line.308"></a> +<span class="sourceLineNo">309</span> " It is complicated to rollback the merge operation that region server is working on." +<a name="line.309"></a> +<span class="sourceLineNo">310</span> " Rollback is not supported and we should let the merge operation to complete";<a name="line.310"></a> +<span class="sourceLineNo">311</span> LOG.warn(msg);<a name="line.311"></a> +<span class="sourceLineNo">312</span> // PONR<a name="line.312"></a> +<span class="sourceLineNo">313</span> throw new UnsupportedOperationException(this + " unhandled state=" + state);<a name="line.313"></a> +<span class="sourceLineNo">314</span> case MERGE_TABLE_REGIONS_PRE_MERGE_COMMIT_OPERATION:<a name="line.314"></a> +<span class="sourceLineNo">315</span> break;<a name="line.315"></a> +<span class="sourceLineNo">316</span> case MERGE_TABLE_REGIONS_CREATE_MERGED_REGION:<a name="line.316"></a> +<span class="sourceLineNo">317</span> case MERGE_TABLE_REGIONS_WRITE_MAX_SEQUENCE_ID_FILE:<a name="line.317"></a> +<span class="sourceLineNo">318</span> cleanupMergedRegion(env);<a name="line.318"></a> +<span class="sourceLineNo">319</span> break;<a name="line.319"></a> +<span class="sourceLineNo">320</span> case MERGE_TABLE_REGIONS_CHECK_CLOSED_REGIONS:<a name="line.320"></a> +<span class="sourceLineNo">321</span> break;<a name="line.321"></a> +<span class="sourceLineNo">322</span> case MERGE_TABLE_REGIONS_CLOSE_REGIONS:<a name="line.322"></a> +<span class="sourceLineNo">323</span> rollbackCloseRegionsForMerge(env);<a name="line.323"></a> +<span class="sourceLineNo">324</span> break;<a name="line.324"></a> +<span class="sourceLineNo">325</span> case MERGE_TABLE_REGIONS_PRE_MERGE_OPERATION:<a name="line.325"></a> +<span class="sourceLineNo">326</span> postRollBackMergeRegions(env);<a name="line.326"></a> +<span class="sourceLineNo">327</span> break;<a name="line.327"></a> +<span class="sourceLineNo">328</span> case MERGE_TABLE_REGIONS_PREPARE:<a name="line.328"></a> +<span class="sourceLineNo">329</span> break;<a name="line.329"></a> +<span class="sourceLineNo">330</span> default:<a name="line.330"></a> +<span class="sourceLineNo">331</span> throw new UnsupportedOperationException(this + " unhandled state=" + state);<a name="line.331"></a> +<span class="sourceLineNo">332</span> }<a name="line.332"></a> +<span class="sourceLineNo">333</span> } catch (Exception e) {<a name="line.333"></a> +<span class="sourceLineNo">334</span> // This will be retried. Unless there is a bug in the code,<a name="line.334"></a> +<span class="sourceLineNo">335</span> // this should be just a "temporary error" (e.g. network down)<a name="line.335"></a> +<span class="sourceLineNo">336</span> LOG.warn("Failed rollback attempt step " + state + " for merging the regions "<a name="line.336"></a> +<span class="sourceLineNo">337</span> + RegionInfo.getShortNameToLog(regionsToMerge) + " in table " + getTableName(), e);<a name="line.337"></a> +<span class="sourceLineNo">338</span> throw e;<a name="line.338"></a> +<span class="sourceLineNo">339</span> }<a name="line.339"></a> +<span class="sourceLineNo">340</span> }<a name="line.340"></a> +<span class="sourceLineNo">341</span><a name="line.341"></a> +<span class="sourceLineNo">342</span> /*<a name="line.342"></a> +<span class="sourceLineNo">343</span> * Check whether we are in the state that can be rolled back<a name="line.343"></a> +<span class="sourceLineNo">344</span> */<a name="line.344"></a> +<span class="sourceLineNo">345</span> @Override<a name="line.345"></a> +<span class="sourceLineNo">346</span> protected boolean isRollbackSupported(final MergeTableRegionsState state) {<a name="line.346"></a> +<span class="sourceLineNo">347</span> switch (state) {<a name="line.347"></a> +<span class="sourceLineNo">348</span> case MERGE_TABLE_REGIONS_POST_OPERATION:<a name="line.348"></a> +<span class="sourceLineNo">349</span> case MERGE_TABLE_REGIONS_OPEN_MERGED_REGION:<a name="line.349"></a> +<span class="sourceLineNo">350</span> case MERGE_TABLE_REGIONS_POST_MERGE_COMMIT_OPERATION:<a name="line.350"></a> +<span class="sourceLineNo">351</span> case MERGE_TABLE_REGIONS_UPDATE_META:<a name="line.351"></a> +<span class="sourceLineNo">352</span> // It is not safe to rollback in these states.<a name="line.352"></a> +<span class="sourceLineNo">353</span> return false;<a name="line.353"></a> +<span class="sourceLineNo">354</span> default:<a name="line.354"></a> +<span class="sourceLineNo">355</span> break;<a name="line.355"></a> +<span class="sourceLineNo">356</span> }<a name="line.356"></a> +<span class="sourceLineNo">357</span> return true;<a name="line.357"></a> +<span class="sourceLineNo">358</span> }<a name="line.358"></a> +<span class="sourceLineNo">359</span><a name="line.359"></a> +<span class="sourceLineNo">360</span> @Override<a name="line.360"></a> +<span class="sourceLineNo">361</span> protected MergeTableRegionsState getState(final int stateId) {<a name="line.361"></a> +<span class="sourceLineNo">362</span> return MergeTableRegionsState.forNumber(stateId);<a name="line.362"></a> +<span class="sourceLineNo">363</span> }<a name="line.363"></a> +<span class="sourceLineNo">364</span><a name="line.364"></a> +<span class="sourceLineNo">365</span> @Override<a name="line.365"></a> +<span class="sourceLineNo">366</span> protected int getStateId(final MergeTableRegionsState state) {<a name="line.366"></a> +<span class="sourceLineNo">367</span> return state.getNumber();<a name="line.367"></a> +<span class="sourceLineNo">368</span> }<a name="line.368"></a> +<span class="sourceLineNo">369</span><a name="line.369"></a> +<span class="sourceLineNo">370</span> @Override<a name="line.370"></a> +<span class="sourceLineNo">371</span> protected MergeTableRegionsState getInitialState() {<a name="line.371"></a> +<span class="sourceLineNo">372</span> return MergeTableRegionsState.MERGE_TABLE_REGIONS_PREPARE;<a name="line.372"></a> +<span class="sourceLineNo">373</span> }<a name="line.373"></a> +<span class="sourceLineNo">374</span><a name="line.374"></a> +<span class="sourceLineNo">375</span> @Override<a name="line.375"></a> +<span class="sourceLineNo">376</span> protected void serializeStateData(ProcedureStateSerializer serializer)<a name="line.376"></a> +<span class="sourceLineNo">377</span> throws IOException {<a name="line.377"></a> +<span class="sourceLineNo">378</span> super.serializeStateData(serializer);<a name="line.378"></a> +<span class="sourceLineNo">379</span><a name="line.379"></a> +<span class="sourceLineNo">380</span> final MasterProcedureProtos.MergeTableRegionsStateData.Builder mergeTableRegionsMsg =<a name="line.380"></a> +<span class="sourceLineNo">381</span> MasterProcedureProtos.MergeTableRegionsStateData.newBuilder()<a name="line.381"></a> +<span class="sourceLineNo">382</span> .setUserInfo(MasterProcedureUtil.toProtoUserInfo(getUser()))<a name="line.382"></a> +<span class="sourceLineNo">383</span> .setMergedRegionInfo(ProtobufUtil.toRegionInfo(mergedRegion))<a name="line.383"></a> +<span class="sourceLineNo">384</span> .setForcible(forcible);<a name="line.384"></a> +<span class="sourceLineNo">385</span> for (int i = 0; i < regionsToMerge.length; ++i) {<a name="line.385"></a> +<span class="sourceLineNo">386</span> mergeTableRegionsMsg.addRegionInfo(ProtobufUtil.toRegionInfo(regionsToMerge[i]));<a name="line.386"></a> +<span class="sourceLineNo">387</span> }<a name="line.387"></a> +<span class="sourceLineNo">388</span> serializer.serialize(mergeTableRegionsMsg.build());<a name="line.388"></a> +<span class="sourceLineNo">389</span> }<a name="line.389"></a> +<span class="sourceLineNo">390</span><a name="line.390"></a> +<span class="sourceLineNo">391</span> @Override<a name="line.391"></a> +<span class="sourceLineNo">392</span> protected void deserializeStateData(ProcedureStateSerializer serializer)<a name="line.392"></a> +<span class="sourceLineNo">393</span> throws IOException {<a name="line.393"></a> +<span class="sourceLineNo">394</span> super.deserializeStateData(serializer);<a name="line.394"></a> +<span class="sourceLineNo">395</span><a name="line.395"></a> +<span class="sourceLineNo">396</span> final MasterProcedureProtos.MergeTableRegionsStateData mergeTableRegionsMsg =<a name="line.396"></a> +<span class="sourceLineNo">397</span> serializer.deserialize(MasterProcedureProtos.MergeTableRegionsStateData.class);<a name="line.397"></a> +<span class="sourceLineNo">398</span> setUser(MasterProcedureUtil.toUserInfo(mergeTableRegionsMsg.getUserInfo()));<a name="line.398"></a> +<span class="sourceLineNo">399</span><a name="line.399"></a> +<span class="sourceLineNo">400</span> assert(mergeTableRegionsMsg.getRegionInfoCount() == 2);<a name="line.400"></a> +<span class="sourceLineNo">401</span> regionsToMerge = new RegionInfo[mergeTableRegionsMsg.getRegionInfoCount()];<a name="line.401"></a> +<span class="sourceLineNo">402</span> for (int i = 0; i < regionsToMerge.length; i++) {<a name="line.402"></a> +<span class="sourceLineNo">403</span> regionsToMerge[i] = ProtobufUtil.toRegionInfo(mergeTableRegionsMsg.getRegionInfo(i));<a name="line.403"></a> +<span class="sourceLineNo">404</span> }<a name="line.404"></a> +<span class="sourceLineNo">405</span><a name="line.405"></a> +<span class="sourceLineNo">406</span> mergedRegion = ProtobufUtil.toRegionInfo(mergeTableRegionsMsg.getMergedRegionInfo());<a name="line.406"></a> +<span class="sourceLineNo">407</span> }<a name="line.407"></a> +<span class="sourceLineNo">408</span><a name="line.408"></a> +<span class="sourceLineNo">409</span> @Override<a name="line.409"></a> +<span class="sourceLineNo">410</span> public void toStringClassDetails(StringBuilder sb) {<a name="line.410"></a> +<span class="sourceLineNo">411</span> sb.append(getClass().getSimpleName());<a name="line.411"></a> +<span class="sourceLineNo">412</span> sb.append(" table=");<a name="line.412"></a> +<span class="sourceLineNo">413</span> sb.append(getTableName());<a name="line.413"></a> +<span class="sourceLineNo">414</span> sb.append(", regions=");<a name="line.414"></a> +<span class="sourceLineNo">415</span> sb.append(RegionInfo.getShortNameToLog(regionsToMerge));<a name="line.415"></a> +<span class="sourceLineNo">416</span> sb.append(", forcibly=");<a name="line.416"></a> +<span class="sourceLineNo">417</span> sb.append(forcible);<a name="line.417"></a> +<span class="sourceLineNo">418</span> }<a name="line.418"></a> +<span class="sourceLineNo">419</span><a name="line.419"></a> +<span class="sourceLineNo">420</span> @Override<a name="line.420"></a> +<span class="sourceLineNo">421</span> protected LockState acquireLock(final MasterProcedureEnv env) {<a name="line.421"></a> +<span class="sourceLineNo">422</span> if (env.getProcedureScheduler().waitRegions(this, getTableName(),<a name="line.422"></a> +<span class="sourceLineNo">423</span> mergedRegion, regionsToMerge[0], regionsToMerge[1])) {<a name="line.423"></a> +<span class="sourceLineNo">424</span> try {<a name="line.424"></a> +<span class="sourceLineNo">425</span> LOG.debug(LockState.LOCK_EVENT_WAIT + " " + env.getProcedureScheduler().dumpLocks());<a name="line.425"></a> +<span class="sourceLineNo">426</span> } catch (IOException e) {<a name="line.426"></a> +<span class="sourceLineNo">427</span> // Ignore, just for logging<a name="line.427"></a> +<span class="sourceLineNo">428</span> }<a name="line.428"></a> +<span class="sourceLineNo">429</span> return LockState.LOCK_EVENT_WAIT;<a name="line.429"></a> +<span class="sourceLineNo">430</span> }<a name="line.430"></a> +<span class="sourceLineNo">431</span> return LockState.LOCK_ACQUIRED;<a name="line.431"></a> +<span class="sourceLineNo">432</span> }<a name="line.432"></a> +<span class="sourceLineNo">433</span><a name="line.433"></a> +<span class="sourceLineNo">434</span> @Override<a name="line.434"></a> +<span class="sourceLineNo">435</span> protected void releaseLock(final MasterProcedureEnv env) {<a name="line.435"></a> +<span class="sourceLineNo">436</span> env.getProcedureScheduler().wakeRegions(this, getTableName(),<a name="line.436"></a> +<span class="sourceLineNo">437</span> mergedRegion, regionsToMerge[0], regionsToMerge[1]);<a name="line.437"></a> +<span class="sourceLineNo">438</span> }<a name="line.438"></a> +<span class="sourceLineNo">439</span><a name="line.439"></a> +<span class="sourceLineNo">440</span> @Override<a name="line.440"></a> +<span class="sourceLineNo">441</span> protected boolean holdLock(MasterProcedureEnv env) {<a name="line.441"></a> +<span class="sourceLineNo">442</span> return true;<a name="line.442"></a> <span class="sourceLineNo">443</span> }<a name="line.443"></a> <span class="sourceLineNo">444</span><a name="line.444"></a> <span class="sourceLineNo">445</span> @Override<a name="line.445"></a> -<span class="sourceLineNo">446</span> protected boolean holdLock(MasterProcedureEnv env) {<a name="line.446"></a> -<span class="sourceLineNo">447</span> return true;<a name="line.447"></a> +<span class="sourceLineNo">446</span> public TableName getTableName() {<a name="line.446"></a> +<span class="sourceLineNo">447</span> return mergedRegion.getTable();<a name="line.447"></a> <span class="sourceLineNo">448</span> }<a name="line.448"></a> <span class="sourceLineNo">449</span><a name="line.449"></a> <span class="sourceLineNo">450</span> @Override<a name="line.450"></a> -<span class="sourceLineNo">451</span> protected boolean hasLock(MasterProcedureEnv env) {<a name="line.451"></a> -<span class="sourceLineNo">452</span> return this.lock;<a name="line.452"></a> +<span class="sourceLineNo">451</span> public TableOperationType getTableOperationType() {<a name="line.451"></a> +<span class="sourceLineNo">452</span> return TableOperationType.REGION_MERGE;<a name="line.452"></a> <span class="sourceLineNo">453</span> }<a name="line.453"></a> <span class="sourceLineNo">454</span><a name="line.454"></a> <span class="sourceLineNo">455</span> @Override<a name="line.455"></a> -<span class="sourceLineNo">456</span> public TableName getTableName() {<a name="line.456"></a> -<span class="sourceLineNo">457</span> return mergedRegion.getTable();<a name="line.457"></a> +<span class="sourceLineNo">456</span> protected ProcedureMetrics getProcedureMetrics(MasterProcedureEnv env) {<a name="line.456"></a> +<span class="sourceLineNo">457</span> return env.getAssignmentManager().getAssignmentManagerMetrics().getMergeProcMetrics();<a name="line.457"></a> <span class="sourceLineNo">458</span> }<a name="line.458"></a> <span class="sourceLineNo">459</span><a name="line.459"></a> -<span class="sourceLineNo">460</span> @Override<a name="line.460"></a> -<span class="sourceLineNo">461</span> public TableOperationType getTableOperationType() {<a name="line.461"></a> -<span class="sourceLineNo">462</span> return TableOperationType.REGION_MERGE;<a name="line.462"></a> -<span class="sourceLineNo">463</span> }<a name="line.463"></a> -<span class="sourceLineNo">464</span><a name="line.464"></a> -<span class="sourceLineNo">465</span> @Override<a name="line.465"></a> -<span class="sourceLineNo">466</span> protected ProcedureMetrics getProcedureMetrics(MasterProcedureEnv env) {<a name="line.466"></a> -<span class="sourceLineNo">467</span> return env.getAssignmentManager().getAssignmentManagerMetrics().getMergeProcMetrics();<a name="line.467"></a> +<span class="sourceLineNo">460</span> /**<a name="line.460"></a> +<span class="sourceLineNo">461</span> * check the closed regions<a name="line.461"></a> +<span class="sourceLineNo">462</span> * @param env the master env<a name="line.462"></a> +<span class="sourceLineNo">463</span> * @throws IOException IOException<a name="line.463"></a> +<span class="sourceLineNo">464</span> */<a name="line.464"></a> +<span class="sourceLineNo">465</span> private void checkClosedRegions(final MasterProcedureEnv env) throws IOException {<a name="line.465"></a> +<span class="sourceLineNo">466</span> checkClosedRegion(env, regionsToMerge[0]);<a name="line.466"></a> +<span class="sourceLineNo">467</span> checkClosedRegion(env, regionsToMerge[1]);<a name="line.467"></a> <span class="sourceLineNo">468</span> }<a name="line.468"></a> <span class="sourceLineNo">469</span><a name="line.469"></a> <span class="sourceLineNo">470</span> /**<a name="line.470"></a> -<span class="sourceLineNo">471</span> * check the closed regions<a name="line.471"></a> -<span class="sourceLineNo">472</span> * @param env the master env<a name="line.472"></a> -<span class="sourceLineNo">473</span> * @throws IOException IOException<a name="line.473"></a> -<span class="sourceLineNo">474</span> */<a name="line.474"></a> -<span class="sourceLineNo">475</span> private void checkClosedRegions(final MasterProcedureEnv env) throws IOException {<a name="line.475"></a> -<span class="sourceLineNo">476</span> checkClosedRegion(env, regionsToMerge[0]);<a name="line.476"></a> -<span class="sourceLineNo">477</span> checkClosedRegion(env, regionsToMerge[1]);<a name="line.477"></a> -<span class="sourceLineNo">478</span> }<a name="line.478"></a> -<span class="sourceLineNo">479</span><a name="line.479"></a> -<span class="sourceLineNo">480</span> /**<a name="line.480"></a> -<span class="sourceLineNo">481</span> * Check whether there is recovered.edits in the closed region<a name="line.481"></a> -<span class="sourceLineNo">482</span> * If any, that means this region is not closed property, we need<a name="line.482"></a> -<span class="sourceLineNo">483</span> * to abort region merge to prevent data loss<a name="line.483"></a> -<span class="sourceLineNo">484</span> * @param env master env<a name="line.484"></a> -<span class="sourceLineNo">485</span> * @param regionInfo regioninfo<a name="line.485"></a> -<span class="sourceLineNo">486</span> * @throws IOException IOException<a name="line.486"></a> -<span class="sourceLineNo">487</span> */<a name="line.487"></a> -<span class="sourceLineNo">488</span> private void checkClosedRegion(final MasterProcedureEnv env,<a name="line.488"></a> -<span class="sourceLineNo">489</span> RegionInfo regionInfo) throws IOException {<a name="line.489"></a> -<span class="sourceLineNo">490</span> if (WALSplitter.hasRecoveredEdits(env.getMasterServices().getFileSystem(),<a name="line.490"></a> -<span class="sourceLineNo">491</span> env.getMasterConfiguration(), regionInfo)) {<a name="line.491"></a> -<span class="sourceLineNo">492</span> throw new IOException("Recovered.edits are found in Region: " + regionInfo<a name="line.492"></a> -<span class="sourceLineNo">493</span> + ", abort merge to prevent data loss");<a name="line.493"></a> -<span class="sourceLineNo">494</span> }<a name="line.494"></a> -<span class="sourceLineNo">495</span> }<a name="line.495"></a> -<span class="sourceLineNo">496</span><a name="line.496"></a> -<span class="sourceLineNo">497</span> /**<a name="line.497"></a> -<span class="sourceLineNo">498</span> * Prepare merge and do some check<a name="line.498"></a> -<span class="sourceLineNo">499</span> * @param env MasterProcedureEnv<a name="line.499"></a> -<span class="sourceLineNo">500</span> * @throws IOException<a name="line.500"></a> -<span class="sourceLineNo">501</span> */<a name="line.501"></a> -<span class="sourceLineNo">502</span> private boolean prepareMergeRegion(final MasterProcedureEnv env) throws IOException {<a name="line.502"></a> -<span class="sourceLineNo">503</span> // Note: the following logic assumes that we only have 2 regions to merge. In the future,<a name="line.503"></a> -<span class="sourceLineNo">504</span> // if we want to extend to more than 2 regions, the code needs to be modified a little bit.<a name="line.504"></a> -<span class="sourceLineNo">505</span> CatalogJanitor catalogJanitor = env.getMasterServices().getCatalogJanitor();<a name="line.505"></a> -<span class="sourceLineNo">506</span> boolean regionAHasMergeQualifier = !catalogJanitor.cleanMergeQualifier(regionsToMerge[0]);<a name="line.506"></a> -<span class="sourceLineNo">507</span> if (regionAHasMergeQualifier<a name="line.507"></a> -<span class="sourceLineNo">508</span> || !catalogJanitor.cleanMergeQualifier(regionsToMerge[1])) {<a name="line.508"></a> -<span class="sourceLineNo">509</span> String msg = "Skip merging regions " + RegionInfo.getShortNameToLog(regionsToMerge) +<a name="line.509"></a> -<span class="sourceLineNo">510</span> ", because region "<a name="line.510"></a> -<span class="sourceLineNo">511</span> + (regionAHasMergeQualifier ? regionsToMerge[0].getEncodedName() : regionsToMerge[1]<a name="line.511"></a> -<span class="sourceLineNo">512</span> .getEncodedName()) + " has merge qualifier";<a name="line.512"></a> -<span class="sourceLineNo">513</span> LOG.warn(msg);<a name="line.513"></a> -<span class="sourceLineNo">514</span> throw new MergeRegionException(msg);<a name="line.514"></a> -<span class="sourceLineNo">515</span> }<a name="line.515"></a> -<span class="sourceLineNo">516</span><a name="line.516"></a> -<span class="sourceLineNo">517</span> RegionStates regionStates = env.getAssignmentManager().getRegionStates();<a name="line.517"></a> -<span class="sourceLineNo">518</span> RegionState regionStateA = regionStates.getRegionState(regionsToMerge[0].getEncodedName());<a name="line.518"></a> -<span class="sourceLineNo">519</span> RegionState regionStateB = regionStates.getRegionState(regionsToMerge[1].getEncodedName());<a name="line.519"></a> -<span class="sourceLineNo">520</span> if (regionStateA == null || regionStateB == null) {<a name="line.520"></a> -<span class="sourceLineNo">521</span> throw new UnknownRegionException(<a name="line.521"></a> -<span class="sourceLineNo">522</span> regionStateA == null ?<a name="line.522"></a> -<span class="sourceLineNo">523</span> regionsToMerge[0].getEncodedName() : regionsToMerge[1].getEncodedName());<a name="line.523"></a> -<span class="sourceLineNo">524</span> }<a name="line.524"></a> -<span class="sourceLineNo">525</span><a name="line.525"></a> -<span class="sourceLineNo">526</span> if (!regionStateA.isOpened() || !regionStateB.isOpened()) {<a name="line.526"></a> -<span class="sourceLineNo">527</span> throw new MergeRegionException(<a name="line.527"></a> -<span class="sourceLineNo">528</span> "Unable to merge regions that are not online " + regionStateA + ", " + regionStateB);<a name="line.528"></a> -<span class="sourceLineNo">529</span> }<a name="line.529"></a> -<span class="sourceLineNo">530</span><a name="line.530"></a> -<span class="sourceLineNo">531</span> if (!env.getMasterServices().isSplitOrMergeEnabled(MasterSwitchType.MERGE)) {<a name="line.531"></a> -<span class="sourceLineNo">532</span> String regionsStr = Arrays.deepToString(regionsToMerge);<a name="line.532"></a> -<span class="sourceLineNo">533</span> LOG.warn("merge switch is off! skip merge of " + regionsStr);<a name="line.533"></a> -<span class="sourceLineNo">534</span> super.setFailure(getClass().getSimpleName(),<a name="line.534"></a> -<span class="sourceLineNo">535</span> new IOException("Merge of " + regionsStr + " failed because merge switch is off"));<a name="line.535"></a> -<span class="sourceLineNo">536</span> return false;<a name="line.536"></a> -<span class="sourceLineNo">537</span> }<a name="line.537"></a> -<span class="sourceLineNo">538</span><a name="line.538"></a> -<span class="sourceLineNo">539</span> // Ask the remote regionserver if regions are mergeable. If we get an IOE, report it<a name="line.539"></a> -<span class="sourceLineNo">540</span> // along with the failure, so we can see why regions are not mergeable at this time.<a name="line.540"></a> -<span class="sourceLineNo">541</span> IOException mergeableCheckIOE = null;<a name="line.541"></a> -<span class="sourceLineNo">542</span> boolean mergeable = false;<a name="line.542"></a> -<span class="sourceLineNo">543</span> RegionState current = regionStateA;<a name="line.543"></a> -<span class="sourceLineNo">544</span> try {<a name="line.544"></a> -<span class="sourceLineNo">545</span> mergeable = isMergeable(env, current);<a name="line.545"></a> -<span class="sourceLineNo">546</span> } catch (IOException e) {<a name="line.546"></a> -<span class="sourceLineNo">547</span> mergeableCheckIOE = e;<a name="line.547"></a> -<span class="sourceLineNo">548</span> }<a name="line.548"></a> -<span class="sourceLineNo">549</span> if (mergeable && mergeableCheckIOE == null) {<a name="line.549"></a> -<span class="sourceLineNo">550</span> current = regionStateB;<a name="line.550"></a> -<span class="sourceLineNo">551</span> try {<a name="line.551"></a> -<span class="sourceLineNo">552</span> mergeable = isMergeable(env, current);<a name="line.552"></a> -<span class="sourceLineNo">553</span> } catch (IOException e) {<a name="line.553"></a> -<span class="sourceLineNo">554</span> mergeableCheckIOE = e;<a name="line.554"></a> -<span class="sourceLineNo">555</span> }<a name="line.555"></a> -<span class="sourceLineNo">556</span> }<a name="line.556"></a> -<span class="sourceLineNo">557</span> if (!mergeable) {<a name="line.557"></a> -<span class="sourceLineNo">558</span> IOException e = new IOException(current.getRegion().getShortNameToLog() + " NOT mergeable");<a name="line.558"></a> -<span class="sourceLineNo">559</span> if (mergeableCheckIOE != null) e.initCause(mergeableCheckIOE);<a name="line.559"></a> -<span class="sourceLineNo">560</span> super.setFailure(getClass().getSimpleName(), e);<a name="line.560"></a> -<span class="sourceLineNo">561</span> return false;<a name="line.561"></a> -<span class="sourceLineNo">562</span> }<a name="line.562"></a> -<span class="sourceLineNo">563</span><a name="line.563"></a> -<span class="sourceLineNo">564</span> // Update region states to Merging<a name="line.564"></a> -<span class="sourceLineNo">565</span> setRegionStateToMerging(env);<a name="line.565"></a> -<span class="sourceLineNo">566</span> return true;<a name="line.566"></a> -<span class="sourceLineNo">567</span> }<a name="line.567"></a> -<span class="sourceLineNo">568</span><a name="line.568"></a> -<span class="sourceLineNo">569</span> private boolean isMergeable(final MasterProcedureEnv env, final RegionState rs)<a name="line.569"></a> -<span class="sourceLineNo">570</span> throws IOException {<a name="line.570"></a> -<span class="sourceLineNo">571</span> GetRegionInfoResponse response =<a name="line.571"></a> -<span class="sourceLineNo">572</span> Util.getRegionInfoResponse(env, rs.getServerName(), rs.getRegion());<a name="line.572"></a> -<span class="sourceLineNo">573</span> return response.hasMergeable() && response.getMergeable();<a name="line.573"></a> -<span class="sourceLineNo">574</span> }<a name="line.574"></a> -<span class="sourceLineNo">575</span><a name="line.575"></a> -<span class="sourceLineNo">576</span> /**<a name="line.576"></a> -<span class="sourceLineNo">577</span> * Pre merge region action<a name="line.577"></a> -<span class="sourceLineNo">578</span> * @param env MasterProcedureEnv<a name="line.578"></a> -<span class="sourceLineNo">579</span> **/<a name="line.579"></a> -<span class="sourceLineNo">580</span> private void preMergeRegions(final MasterProcedureEnv env) throws IOException {<a name="line.580"></a> -<span class="sourceLineNo">581</span> final MasterCoprocessorHost cpHost = env.getMasterCoprocessorHost();<a name="line.581"></a> -<span class="sourceLineNo">582</span> if (cpHost != null) {<a name="line.582"></a> -<span class="sourceLineNo">583</span> cpHost.preMergeRegionsAction(regionsToMerge, getUser());<a name="line.583"></a> -<span class="sourceLineNo">584</span> }<a name="line.584"></a> -<span class="sourceLineNo">585</span> // TODO: Clean up split and merge. Currently all over the place.<a name="line.585"></a> -<span class="sourceLineNo">586</span> try {<a name="line.586"></a> -<span class="sourceLineNo">587</span> env.getMasterServices().getMasterQuotaManager().onRegionMerged(this.mergedRegion);<a name="line.587"></a> -<span class="sourceLineNo">588</span> } catch (Quo
<TRUNCATED>