HBASE-18679 Add a null check around the result of getCounters() in ITBLL
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/5c6fb74b Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/5c6fb74b Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/5c6fb74b Branch: refs/heads/branch-1.2 Commit: 5c6fb74b5fd835ea20ba984cd63749d0d1c70630 Parents: 1347635 Author: Josh Elser <els...@apache.org> Authored: Thu Aug 24 17:52:13 2017 -0400 Committer: Josh Elser <els...@apache.org> Committed: Fri Aug 25 19:09:00 2017 -0400 ---------------------------------------------------------------------- .../hadoop/hbase/test/IntegrationTestBigLinkedList.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/5c6fb74b/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java ---------------------------------------------------------------------- diff --git a/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java b/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java index 91f99f1..45b0d03 100644 --- a/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java +++ b/hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java @@ -1106,7 +1106,8 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase { if (success) { Counters counters = job.getCounters(); if (null == counters) { - LOG.warn("Counters were null, cannot verify Job completion"); + LOG.warn("Counters were null, cannot verify Job completion." + + " This is commonly a result of insufficient YARN configuration."); // We don't have access to the counters to know if we have "bad" counts return 0; } @@ -1128,6 +1129,11 @@ public class IntegrationTestBigLinkedList extends IntegrationTestBase { } Counters counters = job.getCounters(); + if (counters == null) { + LOG.info("Counters object was null, write verification cannot be performed." + + " This is commonly a result of insufficient YARN configuration."); + return false; + } // Run through each check, even if we fail one early boolean success = verifyExpectedValues(expectedReferenced, counters);