[06/12] hbase git commit: HBASE-20733 QABot should run checkstyle tests if the checkstyle configs change
HBASE-20733 QABot should run checkstyle tests if the checkstyle configs change
Signed-off-by: Mike Drob
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/04db9007
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/04db9007
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/04db9007
Branch: refs/heads/HBASE-20331
Commit: 04db900772889d70836dbd733f844782fb7adecd
Parents: 0b28155
Author: Sean Busbey
Authored: Thu Jun 14 13:00:08 2018 -0500
Committer: Sean Busbey
Committed: Thu Jun 14 20:24:29 2018 -0500
--
dev-support/hbase-personality.sh | 51 +++
1 file changed, 28 insertions(+), 23 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/hbase/blob/04db9007/dev-support/hbase-personality.sh
--
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index 2c6e4a8..8004167 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -67,10 +67,12 @@ function personality_globals
# Yetus 0.7.0 enforces limits. Default proclimit is 1000.
# Up it. See HBASE-19902 for how we arrived at this number.
+ #shellcheck disable=SC2034
PROCLIMIT=1
# Set docker container to run with 20g. Default is 4g in yetus.
# See HBASE-19902 for how we arrived at 20g.
+ #shellcheck disable=SC2034
DOCKERMEMLIMIT=20g
}
@@ -106,7 +108,7 @@ function personality_modules
local repostatus=$1
local testtype=$2
local extra=""
- local MODULES=(${CHANGED_MODULES[@]})
+ local MODULES=("${CHANGED_MODULES[@]}")
yetus_info "Personality: ${repostatus} ${testtype}"
@@ -130,6 +132,11 @@ function personality_modules
MODULES=(.)
fi
+ # If the checkstyle configs change, check everything.
+ if [[ "${testtype}" == checkstyle ]] && [[ "${MODULES[*]}" =~
hbase-checkstyle ]]; then
+MODULES=(.)
+ fi
+
if [[ ${testtype} == mvninstall ]]; then
# shellcheck disable=SC2086
personality_enqueue_module . ${extra}
@@ -188,16 +195,31 @@ function personality_modules
function personality_file_tests
{
local filename=$1
+ yetus_debug "HBase specific personality_file_tests"
# If the change is to the refguide, then we don't need any builtin yetus
tests
# the refguide test (below) will suffice for coverage.
if [[ ${filename} =~ src/main/asciidoc ]] ||
[[ ${filename} =~ src/main/xslt ]]; then
yetus_debug "Skipping builtin yetus checks for ${filename}. refguide test
should pick it up."
- # fallback to checking which tests based on what yetus would do by default
- elif declare -f "${BUILDTOOL}_builtin_personality_file_tests" >/dev/null;
then
-"${BUILDTOOL}_builtin_personality_file_tests" "${filename}"
- elif declare -f builtin_personality_file_tests >/dev/null; then
-builtin_personality_file_tests "${filename}"
+ else
+# If we change our asciidoc, rebuild mvnsite
+if [[ ${BUILDTOOL} = maven ]]; then
+ if [[ ${filename} =~ src/site || ${filename} =~ src/main/asciidoc ]];
then
+yetus_debug "tests/mvnsite: ${filename}"
+add_test mvnsite
+ fi
+fi
+# If we change checkstyle configs, run checkstyle
+if [[ ${filename} =~ checkstyle.*\.xml ]]; then
+ yetus_debug "tests/checkstyle: ${filename}"
+ add_test checkstyle
+fi
+# fallback to checking which tests based on what yetus would do by default
+if declare -f "${BUILDTOOL}_builtin_personality_file_tests" >/dev/null;
then
+ "${BUILDTOOL}_builtin_personality_file_tests" "${filename}"
+elif declare -f builtin_personality_file_tests >/dev/null; then
+ builtin_personality_file_tests "${filename}"
+fi
fi
}
@@ -648,23 +670,6 @@ function hbaseanti_patchfile
return 0
}
-
-## @description hbase custom mvnsite file filter. See HBASE-15042
-## @audience private
-## @stabilityevolving
-## @paramfilename
-function mvnsite_filefilter
-{
- local filename=$1
-
- if [[ ${BUILDTOOL} = maven ]]; then
-if [[ ${filename} =~ src/site || ${filename} =~ src/main/asciidoc ]]; then
- yetus_debug "tests/mvnsite: ${filename}"
- add_test mvnsite
-fi
- fi
-}
-
## This is named so that yetus will check us right after running tests.
## Essentially, we check for normal failures and then we look for zombies.
#function hbase_unit_logfilter
[3/6] hbase git commit: HBASE-20733 QABot should run checkstyle tests if the checkstyle configs change
HBASE-20733 QABot should run checkstyle tests if the checkstyle configs change
Signed-off-by: Mike Drob
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/43b51a36
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/43b51a36
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/43b51a36
Branch: refs/heads/branch-1
Commit: 43b51a36dd72153866465630bda06f6cf68a78eb
Parents: b862641
Author: Sean Busbey
Authored: Thu Jun 14 13:00:08 2018 -0500
Committer: Sean Busbey
Committed: Thu Jun 14 20:26:59 2018 -0500
--
dev-support/hbase-personality.sh | 51 +++
1 file changed, 28 insertions(+), 23 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/hbase/blob/43b51a36/dev-support/hbase-personality.sh
--
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index 9828564..0b19690 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -67,10 +67,12 @@ function personality_globals
# Yetus 0.7.0 enforces limits. Default proclimit is 1000.
# Up it. See HBASE-19902 for how we arrived at this number.
+ #shellcheck disable=SC2034
PROCLIMIT=1
# Set docker container to run with 20g. Default is 4g in yetus.
# See HBASE-19902 for how we arrived at 20g.
+ #shellcheck disable=SC2034
DOCKERMEMLIMIT=20g
}
@@ -106,7 +108,7 @@ function personality_modules
local repostatus=$1
local testtype=$2
local extra=""
- local MODULES=(${CHANGED_MODULES[@]})
+ local MODULES=("${CHANGED_MODULES[@]}")
yetus_info "Personality: ${repostatus} ${testtype}"
@@ -129,6 +131,11 @@ function personality_modules
MODULES=(.)
fi
+ # If the checkstyle configs change, check everything.
+ if [[ "${testtype}" == checkstyle ]] && [[ "${MODULES[*]}" =~
hbase-checkstyle ]]; then
+MODULES=(.)
+ fi
+
if [[ ${testtype} == mvninstall ]]; then
# shellcheck disable=SC2086
personality_enqueue_module . ${extra}
@@ -187,16 +194,31 @@ function personality_modules
function personality_file_tests
{
local filename=$1
+ yetus_debug "HBase specific personality_file_tests"
# If the change is to the refguide, then we don't need any builtin yetus
tests
# the refguide test (below) will suffice for coverage.
if [[ ${filename} =~ src/main/asciidoc ]] ||
[[ ${filename} =~ src/main/xslt ]]; then
yetus_debug "Skipping builtin yetus checks for ${filename}. refguide test
should pick it up."
- # fallback to checking which tests based on what yetus would do by default
- elif declare -f "${BUILDTOOL}_builtin_personality_file_tests" >/dev/null;
then
-"${BUILDTOOL}_builtin_personality_file_tests" "${filename}"
- elif declare -f builtin_personality_file_tests >/dev/null; then
-builtin_personality_file_tests "${filename}"
+ else
+# If we change our asciidoc, rebuild mvnsite
+if [[ ${BUILDTOOL} = maven ]]; then
+ if [[ ${filename} =~ src/site || ${filename} =~ src/main/asciidoc ]];
then
+yetus_debug "tests/mvnsite: ${filename}"
+add_test mvnsite
+ fi
+fi
+# If we change checkstyle configs, run checkstyle
+if [[ ${filename} =~ checkstyle.*\.xml ]]; then
+ yetus_debug "tests/checkstyle: ${filename}"
+ add_test checkstyle
+fi
+# fallback to checking which tests based on what yetus would do by default
+if declare -f "${BUILDTOOL}_builtin_personality_file_tests" >/dev/null;
then
+ "${BUILDTOOL}_builtin_personality_file_tests" "${filename}"
+elif declare -f builtin_personality_file_tests >/dev/null; then
+ builtin_personality_file_tests "${filename}"
+fi
fi
}
@@ -653,23 +675,6 @@ function hbaseanti_patchfile
return 0
}
-
-## @description hbase custom mvnsite file filter. See HBASE-15042
-## @audience private
-## @stabilityevolving
-## @paramfilename
-function mvnsite_filefilter
-{
- local filename=$1
-
- if [[ ${BUILDTOOL} = maven ]]; then
-if [[ ${filename} =~ src/site || ${filename} =~ src/main/asciidoc ]]; then
- yetus_debug "tests/mvnsite: ${filename}"
- add_test mvnsite
-fi
- fi
-}
-
## This is named so that yetus will check us right after running tests.
## Essentially, we check for normal failures and then we look for zombies.
#function hbase_unit_logfilter
[1/6] hbase git commit: HBASE-20733 QABot should run checkstyle tests if the checkstyle configs change
Repository: hbase
Updated Branches:
refs/heads/branch-1 b86264156 -> 43b51a36d
refs/heads/branch-1.2 595307f25 -> 20772f139
refs/heads/branch-1.3 7d51f6077 -> b96cf3da5
refs/heads/branch-1.4 2a35205fd -> b4f463a5c
refs/heads/branch-2 bde9f08a8 -> a4cb98b1c
refs/heads/branch-2.0 987f7b6d3 -> cb2dfd117
HBASE-20733 QABot should run checkstyle tests if the checkstyle configs change
Signed-off-by: Mike Drob
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/a4cb98b1
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/a4cb98b1
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/a4cb98b1
Branch: refs/heads/branch-2
Commit: a4cb98b1cd482a419a164a8efef7e97f9f26ed11
Parents: bde9f08
Author: Sean Busbey
Authored: Thu Jun 14 13:00:08 2018 -0500
Committer: Sean Busbey
Committed: Thu Jun 14 20:26:42 2018 -0500
--
dev-support/hbase-personality.sh | 51 +++
1 file changed, 28 insertions(+), 23 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/hbase/blob/a4cb98b1/dev-support/hbase-personality.sh
--
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index 878f438..c3f5668 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -67,10 +67,12 @@ function personality_globals
# Yetus 0.7.0 enforces limits. Default proclimit is 1000.
# Up it. See HBASE-19902 for how we arrived at this number.
+ #shellcheck disable=SC2034
PROCLIMIT=1
# Set docker container to run with 20g. Default is 4g in yetus.
# See HBASE-19902 for how we arrived at 20g.
+ #shellcheck disable=SC2034
DOCKERMEMLIMIT=20g
}
@@ -106,7 +108,7 @@ function personality_modules
local repostatus=$1
local testtype=$2
local extra=""
- local MODULES=(${CHANGED_MODULES[@]})
+ local MODULES=("${CHANGED_MODULES[@]}")
yetus_info "Personality: ${repostatus} ${testtype}"
@@ -129,6 +131,11 @@ function personality_modules
MODULES=(.)
fi
+ # If the checkstyle configs change, check everything.
+ if [[ "${testtype}" == checkstyle ]] && [[ "${MODULES[*]}" =~
hbase-checkstyle ]]; then
+MODULES=(.)
+ fi
+
if [[ ${testtype} == mvninstall ]]; then
# shellcheck disable=SC2086
personality_enqueue_module . ${extra}
@@ -187,16 +194,31 @@ function personality_modules
function personality_file_tests
{
local filename=$1
+ yetus_debug "HBase specific personality_file_tests"
# If the change is to the refguide, then we don't need any builtin yetus
tests
# the refguide test (below) will suffice for coverage.
if [[ ${filename} =~ src/main/asciidoc ]] ||
[[ ${filename} =~ src/main/xslt ]]; then
yetus_debug "Skipping builtin yetus checks for ${filename}. refguide test
should pick it up."
- # fallback to checking which tests based on what yetus would do by default
- elif declare -f "${BUILDTOOL}_builtin_personality_file_tests" >/dev/null;
then
-"${BUILDTOOL}_builtin_personality_file_tests" "${filename}"
- elif declare -f builtin_personality_file_tests >/dev/null; then
-builtin_personality_file_tests "${filename}"
+ else
+# If we change our asciidoc, rebuild mvnsite
+if [[ ${BUILDTOOL} = maven ]]; then
+ if [[ ${filename} =~ src/site || ${filename} =~ src/main/asciidoc ]];
then
+yetus_debug "tests/mvnsite: ${filename}"
+add_test mvnsite
+ fi
+fi
+# If we change checkstyle configs, run checkstyle
+if [[ ${filename} =~ checkstyle.*\.xml ]]; then
+ yetus_debug "tests/checkstyle: ${filename}"
+ add_test checkstyle
+fi
+# fallback to checking which tests based on what yetus would do by default
+if declare -f "${BUILDTOOL}_builtin_personality_file_tests" >/dev/null;
then
+ "${BUILDTOOL}_builtin_personality_file_tests" "${filename}"
+elif declare -f builtin_personality_file_tests >/dev/null; then
+ builtin_personality_file_tests "${filename}"
+fi
fi
}
@@ -665,23 +687,6 @@ function hbaseanti_patchfile
return 0
}
-
-## @description hbase custom mvnsite file filter. See HBASE-15042
-## @audience private
-## @stabilityevolving
-## @paramfilename
-function mvnsite_filefilter
-{
- local filename=$1
-
- if [[ ${BUILDTOOL} = maven ]]; then
-if [[ ${filename} =~ src/site || ${filename} =~ src/main/asciidoc ]]; then
- yetus_debug "tests/mvnsite: ${filename}"
- add_test mvnsite
-fi
- fi
-}
-
## This is named so that yetus will check us right after running tests.
## Essentially, we check for normal failures and then we look for zombies.
#function hbase_unit_logfilter
[5/6] hbase git commit: HBASE-20733 QABot should run checkstyle tests if the checkstyle configs change
HBASE-20733 QABot should run checkstyle tests if the checkstyle configs change
Signed-off-by: Mike Drob
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/b96cf3da
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/b96cf3da
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/b96cf3da
Branch: refs/heads/branch-1.3
Commit: b96cf3da5c2253e2183cf31a2b20e0ab22d1dabd
Parents: 7d51f60
Author: Sean Busbey
Authored: Thu Jun 14 13:00:08 2018 -0500
Committer: Sean Busbey
Committed: Thu Jun 14 20:27:09 2018 -0500
--
dev-support/hbase-personality.sh | 51 +++
1 file changed, 28 insertions(+), 23 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/hbase/blob/b96cf3da/dev-support/hbase-personality.sh
--
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index 059d7c2..1b313f4 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -67,10 +67,12 @@ function personality_globals
# Yetus 0.7.0 enforces limits. Default proclimit is 1000.
# Up it. See HBASE-19902 for how we arrived at this number.
+ #shellcheck disable=SC2034
PROCLIMIT=1
# Set docker container to run with 20g. Default is 4g in yetus.
# See HBASE-19902 for how we arrived at 20g.
+ #shellcheck disable=SC2034
DOCKERMEMLIMIT=20g
}
@@ -106,7 +108,7 @@ function personality_modules
local repostatus=$1
local testtype=$2
local extra=""
- local MODULES=(${CHANGED_MODULES[@]})
+ local MODULES=("${CHANGED_MODULES[@]}")
yetus_info "Personality: ${repostatus} ${testtype}"
@@ -129,6 +131,11 @@ function personality_modules
MODULES=(.)
fi
+ # If the checkstyle configs change, check everything.
+ if [[ "${testtype}" == checkstyle ]] && [[ "${MODULES[*]}" =~
hbase-checkstyle ]]; then
+MODULES=(.)
+ fi
+
if [[ ${testtype} == mvninstall ]]; then
# shellcheck disable=SC2086
personality_enqueue_module . ${extra}
@@ -183,16 +190,31 @@ function personality_modules
function personality_file_tests
{
local filename=$1
+ yetus_debug "HBase specific personality_file_tests"
# If the change is to the refguide, then we don't need any builtin yetus
tests
# the refguide test (below) will suffice for coverage.
if [[ ${filename} =~ src/main/asciidoc ]] ||
[[ ${filename} =~ src/main/xslt ]]; then
yetus_debug "Skipping builtin yetus checks for ${filename}. refguide test
should pick it up."
- # fallback to checking which tests based on what yetus would do by default
- elif declare -f "${BUILDTOOL}_builtin_personality_file_tests" >/dev/null;
then
-"${BUILDTOOL}_builtin_personality_file_tests" "${filename}"
- elif declare -f builtin_personality_file_tests >/dev/null; then
-builtin_personality_file_tests "${filename}"
+ else
+# If we change our asciidoc, rebuild mvnsite
+if [[ ${BUILDTOOL} = maven ]]; then
+ if [[ ${filename} =~ src/site || ${filename} =~ src/main/asciidoc ]];
then
+yetus_debug "tests/mvnsite: ${filename}"
+add_test mvnsite
+ fi
+fi
+# If we change checkstyle configs, run checkstyle
+if [[ ${filename} =~ checkstyle.*\.xml ]]; then
+ yetus_debug "tests/checkstyle: ${filename}"
+ add_test checkstyle
+fi
+# fallback to checking which tests based on what yetus would do by default
+if declare -f "${BUILDTOOL}_builtin_personality_file_tests" >/dev/null;
then
+ "${BUILDTOOL}_builtin_personality_file_tests" "${filename}"
+elif declare -f builtin_personality_file_tests >/dev/null; then
+ builtin_personality_file_tests "${filename}"
+fi
fi
}
@@ -640,23 +662,6 @@ function hbaseanti_patchfile
return 0
}
-
-## @description hbase custom mvnsite file filter. See HBASE-15042
-## @audience private
-## @stabilityevolving
-## @paramfilename
-function mvnsite_filefilter
-{
- local filename=$1
-
- if [[ ${BUILDTOOL} = maven ]]; then
-if [[ ${filename} =~ src/site || ${filename} =~ src/main/asciidoc ]]; then
- yetus_debug "tests/mvnsite: ${filename}"
- add_test mvnsite
-fi
- fi
-}
-
## This is named so that yetus will check us right after running tests.
## Essentially, we check for normal failures and then we look for zombies.
#function hbase_unit_logfilter
[2/6] hbase git commit: HBASE-20733 QABot should run checkstyle tests if the checkstyle configs change
HBASE-20733 QABot should run checkstyle tests if the checkstyle configs change
Signed-off-by: Mike Drob
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/cb2dfd11
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/cb2dfd11
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/cb2dfd11
Branch: refs/heads/branch-2.0
Commit: cb2dfd117b1764c3719d184a5ffbf77a7c5949ec
Parents: 987f7b6
Author: Sean Busbey
Authored: Thu Jun 14 13:00:08 2018 -0500
Committer: Sean Busbey
Committed: Thu Jun 14 20:26:49 2018 -0500
--
dev-support/hbase-personality.sh | 51 +++
1 file changed, 28 insertions(+), 23 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/hbase/blob/cb2dfd11/dev-support/hbase-personality.sh
--
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index c616be2..9e10926 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -67,10 +67,12 @@ function personality_globals
# Yetus 0.7.0 enforces limits. Default proclimit is 1000.
# Up it. See HBASE-19902 for how we arrived at this number.
+ #shellcheck disable=SC2034
PROCLIMIT=1
# Set docker container to run with 20g. Default is 4g in yetus.
# See HBASE-19902 for how we arrived at 20g.
+ #shellcheck disable=SC2034
DOCKERMEMLIMIT=20g
}
@@ -106,7 +108,7 @@ function personality_modules
local repostatus=$1
local testtype=$2
local extra=""
- local MODULES=(${CHANGED_MODULES[@]})
+ local MODULES=("${CHANGED_MODULES[@]}")
yetus_info "Personality: ${repostatus} ${testtype}"
@@ -129,6 +131,11 @@ function personality_modules
MODULES=(.)
fi
+ # If the checkstyle configs change, check everything.
+ if [[ "${testtype}" == checkstyle ]] && [[ "${MODULES[*]}" =~
hbase-checkstyle ]]; then
+MODULES=(.)
+ fi
+
if [[ ${testtype} == mvninstall ]]; then
# shellcheck disable=SC2086
personality_enqueue_module . ${extra}
@@ -187,16 +194,31 @@ function personality_modules
function personality_file_tests
{
local filename=$1
+ yetus_debug "HBase specific personality_file_tests"
# If the change is to the refguide, then we don't need any builtin yetus
tests
# the refguide test (below) will suffice for coverage.
if [[ ${filename} =~ src/main/asciidoc ]] ||
[[ ${filename} =~ src/main/xslt ]]; then
yetus_debug "Skipping builtin yetus checks for ${filename}. refguide test
should pick it up."
- # fallback to checking which tests based on what yetus would do by default
- elif declare -f "${BUILDTOOL}_builtin_personality_file_tests" >/dev/null;
then
-"${BUILDTOOL}_builtin_personality_file_tests" "${filename}"
- elif declare -f builtin_personality_file_tests >/dev/null; then
-builtin_personality_file_tests "${filename}"
+ else
+# If we change our asciidoc, rebuild mvnsite
+if [[ ${BUILDTOOL} = maven ]]; then
+ if [[ ${filename} =~ src/site || ${filename} =~ src/main/asciidoc ]];
then
+yetus_debug "tests/mvnsite: ${filename}"
+add_test mvnsite
+ fi
+fi
+# If we change checkstyle configs, run checkstyle
+if [[ ${filename} =~ checkstyle.*\.xml ]]; then
+ yetus_debug "tests/checkstyle: ${filename}"
+ add_test checkstyle
+fi
+# fallback to checking which tests based on what yetus would do by default
+if declare -f "${BUILDTOOL}_builtin_personality_file_tests" >/dev/null;
then
+ "${BUILDTOOL}_builtin_personality_file_tests" "${filename}"
+elif declare -f builtin_personality_file_tests >/dev/null; then
+ builtin_personality_file_tests "${filename}"
+fi
fi
}
@@ -656,23 +678,6 @@ function hbaseanti_patchfile
return 0
}
-
-## @description hbase custom mvnsite file filter. See HBASE-15042
-## @audience private
-## @stabilityevolving
-## @paramfilename
-function mvnsite_filefilter
-{
- local filename=$1
-
- if [[ ${BUILDTOOL} = maven ]]; then
-if [[ ${filename} =~ src/site || ${filename} =~ src/main/asciidoc ]]; then
- yetus_debug "tests/mvnsite: ${filename}"
- add_test mvnsite
-fi
- fi
-}
-
## This is named so that yetus will check us right after running tests.
## Essentially, we check for normal failures and then we look for zombies.
#function hbase_unit_logfilter
[4/6] hbase git commit: HBASE-20733 QABot should run checkstyle tests if the checkstyle configs change
HBASE-20733 QABot should run checkstyle tests if the checkstyle configs change
Signed-off-by: Mike Drob
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/b4f463a5
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/b4f463a5
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/b4f463a5
Branch: refs/heads/branch-1.4
Commit: b4f463a5cd37fdbcb519effb6153ae06a70c9b7b
Parents: 2a35205
Author: Sean Busbey
Authored: Thu Jun 14 13:00:08 2018 -0500
Committer: Sean Busbey
Committed: Thu Jun 14 20:27:04 2018 -0500
--
dev-support/hbase-personality.sh | 51 +++
1 file changed, 28 insertions(+), 23 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/hbase/blob/b4f463a5/dev-support/hbase-personality.sh
--
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index bae7163..c1bd8e6 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -67,10 +67,12 @@ function personality_globals
# Yetus 0.7.0 enforces limits. Default proclimit is 1000.
# Up it. See HBASE-19902 for how we arrived at this number.
+ #shellcheck disable=SC2034
PROCLIMIT=1
# Set docker container to run with 20g. Default is 4g in yetus.
# See HBASE-19902 for how we arrived at 20g.
+ #shellcheck disable=SC2034
DOCKERMEMLIMIT=20g
}
@@ -106,7 +108,7 @@ function personality_modules
local repostatus=$1
local testtype=$2
local extra=""
- local MODULES=(${CHANGED_MODULES[@]})
+ local MODULES=("${CHANGED_MODULES[@]}")
yetus_info "Personality: ${repostatus} ${testtype}"
@@ -129,6 +131,11 @@ function personality_modules
MODULES=(.)
fi
+ # If the checkstyle configs change, check everything.
+ if [[ "${testtype}" == checkstyle ]] && [[ "${MODULES[*]}" =~
hbase-checkstyle ]]; then
+MODULES=(.)
+ fi
+
if [[ ${testtype} == mvninstall ]]; then
# shellcheck disable=SC2086
personality_enqueue_module . ${extra}
@@ -187,16 +194,31 @@ function personality_modules
function personality_file_tests
{
local filename=$1
+ yetus_debug "HBase specific personality_file_tests"
# If the change is to the refguide, then we don't need any builtin yetus
tests
# the refguide test (below) will suffice for coverage.
if [[ ${filename} =~ src/main/asciidoc ]] ||
[[ ${filename} =~ src/main/xslt ]]; then
yetus_debug "Skipping builtin yetus checks for ${filename}. refguide test
should pick it up."
- # fallback to checking which tests based on what yetus would do by default
- elif declare -f "${BUILDTOOL}_builtin_personality_file_tests" >/dev/null;
then
-"${BUILDTOOL}_builtin_personality_file_tests" "${filename}"
- elif declare -f builtin_personality_file_tests >/dev/null; then
-builtin_personality_file_tests "${filename}"
+ else
+# If we change our asciidoc, rebuild mvnsite
+if [[ ${BUILDTOOL} = maven ]]; then
+ if [[ ${filename} =~ src/site || ${filename} =~ src/main/asciidoc ]];
then
+yetus_debug "tests/mvnsite: ${filename}"
+add_test mvnsite
+ fi
+fi
+# If we change checkstyle configs, run checkstyle
+if [[ ${filename} =~ checkstyle.*\.xml ]]; then
+ yetus_debug "tests/checkstyle: ${filename}"
+ add_test checkstyle
+fi
+# fallback to checking which tests based on what yetus would do by default
+if declare -f "${BUILDTOOL}_builtin_personality_file_tests" >/dev/null;
then
+ "${BUILDTOOL}_builtin_personality_file_tests" "${filename}"
+elif declare -f builtin_personality_file_tests >/dev/null; then
+ builtin_personality_file_tests "${filename}"
+fi
fi
}
@@ -644,23 +666,6 @@ function hbaseanti_patchfile
return 0
}
-
-## @description hbase custom mvnsite file filter. See HBASE-15042
-## @audience private
-## @stabilityevolving
-## @paramfilename
-function mvnsite_filefilter
-{
- local filename=$1
-
- if [[ ${BUILDTOOL} = maven ]]; then
-if [[ ${filename} =~ src/site || ${filename} =~ src/main/asciidoc ]]; then
- yetus_debug "tests/mvnsite: ${filename}"
- add_test mvnsite
-fi
- fi
-}
-
## This is named so that yetus will check us right after running tests.
## Essentially, we check for normal failures and then we look for zombies.
#function hbase_unit_logfilter
[6/6] hbase git commit: HBASE-20733 QABot should run checkstyle tests if the checkstyle configs change
HBASE-20733 QABot should run checkstyle tests if the checkstyle configs change
Signed-off-by: Mike Drob
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/20772f13
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/20772f13
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/20772f13
Branch: refs/heads/branch-1.2
Commit: 20772f139d7d60ecbd9228f007c35547fa64a196
Parents: 595307f
Author: Sean Busbey
Authored: Thu Jun 14 13:00:08 2018 -0500
Committer: Sean Busbey
Committed: Thu Jun 14 20:27:14 2018 -0500
--
dev-support/hbase-personality.sh | 51 +++
1 file changed, 28 insertions(+), 23 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/hbase/blob/20772f13/dev-support/hbase-personality.sh
--
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index 059d7c2..1b313f4 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -67,10 +67,12 @@ function personality_globals
# Yetus 0.7.0 enforces limits. Default proclimit is 1000.
# Up it. See HBASE-19902 for how we arrived at this number.
+ #shellcheck disable=SC2034
PROCLIMIT=1
# Set docker container to run with 20g. Default is 4g in yetus.
# See HBASE-19902 for how we arrived at 20g.
+ #shellcheck disable=SC2034
DOCKERMEMLIMIT=20g
}
@@ -106,7 +108,7 @@ function personality_modules
local repostatus=$1
local testtype=$2
local extra=""
- local MODULES=(${CHANGED_MODULES[@]})
+ local MODULES=("${CHANGED_MODULES[@]}")
yetus_info "Personality: ${repostatus} ${testtype}"
@@ -129,6 +131,11 @@ function personality_modules
MODULES=(.)
fi
+ # If the checkstyle configs change, check everything.
+ if [[ "${testtype}" == checkstyle ]] && [[ "${MODULES[*]}" =~
hbase-checkstyle ]]; then
+MODULES=(.)
+ fi
+
if [[ ${testtype} == mvninstall ]]; then
# shellcheck disable=SC2086
personality_enqueue_module . ${extra}
@@ -183,16 +190,31 @@ function personality_modules
function personality_file_tests
{
local filename=$1
+ yetus_debug "HBase specific personality_file_tests"
# If the change is to the refguide, then we don't need any builtin yetus
tests
# the refguide test (below) will suffice for coverage.
if [[ ${filename} =~ src/main/asciidoc ]] ||
[[ ${filename} =~ src/main/xslt ]]; then
yetus_debug "Skipping builtin yetus checks for ${filename}. refguide test
should pick it up."
- # fallback to checking which tests based on what yetus would do by default
- elif declare -f "${BUILDTOOL}_builtin_personality_file_tests" >/dev/null;
then
-"${BUILDTOOL}_builtin_personality_file_tests" "${filename}"
- elif declare -f builtin_personality_file_tests >/dev/null; then
-builtin_personality_file_tests "${filename}"
+ else
+# If we change our asciidoc, rebuild mvnsite
+if [[ ${BUILDTOOL} = maven ]]; then
+ if [[ ${filename} =~ src/site || ${filename} =~ src/main/asciidoc ]];
then
+yetus_debug "tests/mvnsite: ${filename}"
+add_test mvnsite
+ fi
+fi
+# If we change checkstyle configs, run checkstyle
+if [[ ${filename} =~ checkstyle.*\.xml ]]; then
+ yetus_debug "tests/checkstyle: ${filename}"
+ add_test checkstyle
+fi
+# fallback to checking which tests based on what yetus would do by default
+if declare -f "${BUILDTOOL}_builtin_personality_file_tests" >/dev/null;
then
+ "${BUILDTOOL}_builtin_personality_file_tests" "${filename}"
+elif declare -f builtin_personality_file_tests >/dev/null; then
+ builtin_personality_file_tests "${filename}"
+fi
fi
}
@@ -640,23 +662,6 @@ function hbaseanti_patchfile
return 0
}
-
-## @description hbase custom mvnsite file filter. See HBASE-15042
-## @audience private
-## @stabilityevolving
-## @paramfilename
-function mvnsite_filefilter
-{
- local filename=$1
-
- if [[ ${BUILDTOOL} = maven ]]; then
-if [[ ${filename} =~ src/site || ${filename} =~ src/main/asciidoc ]]; then
- yetus_debug "tests/mvnsite: ${filename}"
- add_test mvnsite
-fi
- fi
-}
-
## This is named so that yetus will check us right after running tests.
## Essentially, we check for normal failures and then we look for zombies.
#function hbase_unit_logfilter
hbase git commit: HBASE-20733 QABot should run checkstyle tests if the checkstyle configs change
Repository: hbase
Updated Branches:
refs/heads/master 0b28155d2 -> 04db90077
HBASE-20733 QABot should run checkstyle tests if the checkstyle configs change
Signed-off-by: Mike Drob
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/04db9007
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/04db9007
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/04db9007
Branch: refs/heads/master
Commit: 04db900772889d70836dbd733f844782fb7adecd
Parents: 0b28155
Author: Sean Busbey
Authored: Thu Jun 14 13:00:08 2018 -0500
Committer: Sean Busbey
Committed: Thu Jun 14 20:24:29 2018 -0500
--
dev-support/hbase-personality.sh | 51 +++
1 file changed, 28 insertions(+), 23 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/hbase/blob/04db9007/dev-support/hbase-personality.sh
--
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index 2c6e4a8..8004167 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -67,10 +67,12 @@ function personality_globals
# Yetus 0.7.0 enforces limits. Default proclimit is 1000.
# Up it. See HBASE-19902 for how we arrived at this number.
+ #shellcheck disable=SC2034
PROCLIMIT=1
# Set docker container to run with 20g. Default is 4g in yetus.
# See HBASE-19902 for how we arrived at 20g.
+ #shellcheck disable=SC2034
DOCKERMEMLIMIT=20g
}
@@ -106,7 +108,7 @@ function personality_modules
local repostatus=$1
local testtype=$2
local extra=""
- local MODULES=(${CHANGED_MODULES[@]})
+ local MODULES=("${CHANGED_MODULES[@]}")
yetus_info "Personality: ${repostatus} ${testtype}"
@@ -130,6 +132,11 @@ function personality_modules
MODULES=(.)
fi
+ # If the checkstyle configs change, check everything.
+ if [[ "${testtype}" == checkstyle ]] && [[ "${MODULES[*]}" =~
hbase-checkstyle ]]; then
+MODULES=(.)
+ fi
+
if [[ ${testtype} == mvninstall ]]; then
# shellcheck disable=SC2086
personality_enqueue_module . ${extra}
@@ -188,16 +195,31 @@ function personality_modules
function personality_file_tests
{
local filename=$1
+ yetus_debug "HBase specific personality_file_tests"
# If the change is to the refguide, then we don't need any builtin yetus
tests
# the refguide test (below) will suffice for coverage.
if [[ ${filename} =~ src/main/asciidoc ]] ||
[[ ${filename} =~ src/main/xslt ]]; then
yetus_debug "Skipping builtin yetus checks for ${filename}. refguide test
should pick it up."
- # fallback to checking which tests based on what yetus would do by default
- elif declare -f "${BUILDTOOL}_builtin_personality_file_tests" >/dev/null;
then
-"${BUILDTOOL}_builtin_personality_file_tests" "${filename}"
- elif declare -f builtin_personality_file_tests >/dev/null; then
-builtin_personality_file_tests "${filename}"
+ else
+# If we change our asciidoc, rebuild mvnsite
+if [[ ${BUILDTOOL} = maven ]]; then
+ if [[ ${filename} =~ src/site || ${filename} =~ src/main/asciidoc ]];
then
+yetus_debug "tests/mvnsite: ${filename}"
+add_test mvnsite
+ fi
+fi
+# If we change checkstyle configs, run checkstyle
+if [[ ${filename} =~ checkstyle.*\.xml ]]; then
+ yetus_debug "tests/checkstyle: ${filename}"
+ add_test checkstyle
+fi
+# fallback to checking which tests based on what yetus would do by default
+if declare -f "${BUILDTOOL}_builtin_personality_file_tests" >/dev/null;
then
+ "${BUILDTOOL}_builtin_personality_file_tests" "${filename}"
+elif declare -f builtin_personality_file_tests >/dev/null; then
+ builtin_personality_file_tests "${filename}"
+fi
fi
}
@@ -648,23 +670,6 @@ function hbaseanti_patchfile
return 0
}
-
-## @description hbase custom mvnsite file filter. See HBASE-15042
-## @audience private
-## @stabilityevolving
-## @paramfilename
-function mvnsite_filefilter
-{
- local filename=$1
-
- if [[ ${BUILDTOOL} = maven ]]; then
-if [[ ${filename} =~ src/site || ${filename} =~ src/main/asciidoc ]]; then
- yetus_debug "tests/mvnsite: ${filename}"
- add_test mvnsite
-fi
- fi
-}
-
## This is named so that yetus will check us right after running tests.
## Essentially, we check for normal failures and then we look for zombies.
#function hbase_unit_logfilter
hbase git commit: HBASE-20733 QABot should run checkstyle tests if the checkstyle configs change
Repository: hbase
Updated Branches:
refs/heads/HBASE-20733 [created] 73366c862
HBASE-20733 QABot should run checkstyle tests if the checkstyle configs change
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/73366c86
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/73366c86
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/73366c86
Branch: refs/heads/HBASE-20733
Commit: 73366c8621e8dbe011ed3e3adc16eca61983c2d9
Parents: 0b28155
Author: Sean Busbey
Authored: Thu Jun 14 13:00:08 2018 -0500
Committer: Sean Busbey
Committed: Thu Jun 14 19:36:17 2018 -0500
--
dev-support/hbase-personality.sh | 51 +++
1 file changed, 28 insertions(+), 23 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/hbase/blob/73366c86/dev-support/hbase-personality.sh
--
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index 2c6e4a8..8004167 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -67,10 +67,12 @@ function personality_globals
# Yetus 0.7.0 enforces limits. Default proclimit is 1000.
# Up it. See HBASE-19902 for how we arrived at this number.
+ #shellcheck disable=SC2034
PROCLIMIT=1
# Set docker container to run with 20g. Default is 4g in yetus.
# See HBASE-19902 for how we arrived at 20g.
+ #shellcheck disable=SC2034
DOCKERMEMLIMIT=20g
}
@@ -106,7 +108,7 @@ function personality_modules
local repostatus=$1
local testtype=$2
local extra=""
- local MODULES=(${CHANGED_MODULES[@]})
+ local MODULES=("${CHANGED_MODULES[@]}")
yetus_info "Personality: ${repostatus} ${testtype}"
@@ -130,6 +132,11 @@ function personality_modules
MODULES=(.)
fi
+ # If the checkstyle configs change, check everything.
+ if [[ "${testtype}" == checkstyle ]] && [[ "${MODULES[*]}" =~
hbase-checkstyle ]]; then
+MODULES=(.)
+ fi
+
if [[ ${testtype} == mvninstall ]]; then
# shellcheck disable=SC2086
personality_enqueue_module . ${extra}
@@ -188,16 +195,31 @@ function personality_modules
function personality_file_tests
{
local filename=$1
+ yetus_debug "HBase specific personality_file_tests"
# If the change is to the refguide, then we don't need any builtin yetus
tests
# the refguide test (below) will suffice for coverage.
if [[ ${filename} =~ src/main/asciidoc ]] ||
[[ ${filename} =~ src/main/xslt ]]; then
yetus_debug "Skipping builtin yetus checks for ${filename}. refguide test
should pick it up."
- # fallback to checking which tests based on what yetus would do by default
- elif declare -f "${BUILDTOOL}_builtin_personality_file_tests" >/dev/null;
then
-"${BUILDTOOL}_builtin_personality_file_tests" "${filename}"
- elif declare -f builtin_personality_file_tests >/dev/null; then
-builtin_personality_file_tests "${filename}"
+ else
+# If we change our asciidoc, rebuild mvnsite
+if [[ ${BUILDTOOL} = maven ]]; then
+ if [[ ${filename} =~ src/site || ${filename} =~ src/main/asciidoc ]];
then
+yetus_debug "tests/mvnsite: ${filename}"
+add_test mvnsite
+ fi
+fi
+# If we change checkstyle configs, run checkstyle
+if [[ ${filename} =~ checkstyle.*\.xml ]]; then
+ yetus_debug "tests/checkstyle: ${filename}"
+ add_test checkstyle
+fi
+# fallback to checking which tests based on what yetus would do by default
+if declare -f "${BUILDTOOL}_builtin_personality_file_tests" >/dev/null;
then
+ "${BUILDTOOL}_builtin_personality_file_tests" "${filename}"
+elif declare -f builtin_personality_file_tests >/dev/null; then
+ builtin_personality_file_tests "${filename}"
+fi
fi
}
@@ -648,23 +670,6 @@ function hbaseanti_patchfile
return 0
}
-
-## @description hbase custom mvnsite file filter. See HBASE-15042
-## @audience private
-## @stabilityevolving
-## @paramfilename
-function mvnsite_filefilter
-{
- local filename=$1
-
- if [[ ${BUILDTOOL} = maven ]]; then
-if [[ ${filename} =~ src/site || ${filename} =~ src/main/asciidoc ]]; then
- yetus_debug "tests/mvnsite: ${filename}"
- add_test mvnsite
-fi
- fi
-}
-
## This is named so that yetus will check us right after running tests.
## Essentially, we check for normal failures and then we look for zombies.
#function hbase_unit_logfilter
