[GitHub] kramasamy commented on issue #2920: Correct dag to DAG
kramasamy commented on issue #2920: Correct dag to DAG URL: https://github.com/apache/incubator-heron/pull/2920#issuecomment-397932904 @Code0x58 - is this PR ready to merge? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Code0x58 commented on a change in pull request #2920: Correct dag to DAG
Code0x58 commented on a change in pull request #2920: Correct dag to DAG
URL: https://github.com/apache/incubator-heron/pull/2920#discussion_r195939946
##
File path:
heron/schedulers/src/java/org/apache/heron/scheduler/yarn/HeronMasterDriver.java
##
@@ -327,7 +327,7 @@ void requestContainerForWorker(int id, final HeronWorker
worker) {
int cpu = worker.cores;
ByteAmount mem = worker.mem;
EvaluatorRequest evaluatorRequest = createEvaluatorRequest(cpu, mem);
-LOG.info(String.format("Requesting container for worker: %d, mem: %s, cpu:
%d", id, mem, cpu));
Review comment:
Slipped in a `mem`→`RAM`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] kramasamy commented on issue #2920: Correct dag to DAG
kramasamy commented on issue #2920: Correct dag to DAG URL: https://github.com/apache/incubator-heron/pull/2920#issuecomment-397879667 Sure go for it! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Code0x58 opened a new pull request #2920: Correct dag to DAG
Code0x58 opened a new pull request #2920: Correct dag to DAG URL: https://github.com/apache/incubator-heron/pull/2920 [Do you like dags](https://www.youtube.com/watch?v=ZXILzUpVx7A)? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
