[GitHub] huijunw commented on issue #2907: stuck stmgr due to zk client destructor

2018-05-23 Thread GitBox
huijunw commented on issue #2907: stuck stmgr due to zk client destructor URL: https://github.com/apache/incubator-heron/issues/2907#issuecomment-391554957 @srkukarni another thought: for the pcqueue, https://github.com/apache/incubator-heron/blob/0.17.8/heron/common/src/cpp/threads/pcqueu

[GitHub] maosongfu commented on issue #2908: reorder operations in zk_client destructor

2018-05-23 Thread GitBox
maosongfu commented on issue #2908: reorder operations in zk_client destructor URL: https://github.com/apache/incubator-heron/pull/2908#issuecomment-391549027 Had a discussion with Huijun, and met some new concerns. Hold it for now until we better understand it. ---

[GitHub] huijunw commented on issue #2907: stuck stmgr due to zk client destructor

2018-05-23 Thread GitBox
huijunw commented on issue #2907: stuck stmgr due to zk client destructor URL: https://github.com/apache/incubator-heron/issues/2907#issuecomment-391546584 @srkukarni why is zookeeper not single thread ? libzookeeper_mt vs libzookeeper_st If I remember correctly, the stmgr should be sin

[GitHub] nlu90 commented on issue #2907: stuck stmgr due to zk client destructor

2018-05-23 Thread GitBox
nlu90 commented on issue #2907: stuck stmgr due to zk client destructor URL: https://github.com/apache/incubator-heron/issues/2907#issuecomment-391530890 [here](https://stackoverflow.com/questions/8248458/pthread-cond-signal-causing-deadlock) is some discussion about the `__lll_lock_wait

[GitHub] nlu90 commented on issue #2907: stuck stmgr due to zk client destructor

2018-05-23 Thread GitBox
nlu90 commented on issue #2907: stuck stmgr due to zk client destructor URL: https://github.com/apache/incubator-heron/issues/2907#issuecomment-391530890 The comment [here](https://github.com/apache/incubator-heron/blob/master/heron/statemgrs/src/cpp/statemgr/heron-zkstatemgr.cpp#L358) cl

[GitHub] huijunwu opened a new pull request #2908: reorder operations in zk_client destructor

2018-05-23 Thread GitBox
huijunwu opened a new pull request #2908: reorder operations in zk_client destructor URL: https://github.com/apache/incubator-heron/pull/2908 fix https://github.com/apache/incubator-heron/issues/2907 This is an automated mess

[incubator-heron] 01/01: reorder

2018-05-23 Thread huijun
This is an automated email from the ASF dual-hosted git repository. huijun pushed a commit to branch huijunw/reorderzkclientdestructor in repository https://gitbox.apache.org/repos/asf/incubator-heron.git commit c0b3856adc79eddd21d5903efb9aa4f31292d80a Author: Huijun Wu AuthorDate: Wed May 23 15

[incubator-heron] branch huijunw/reorderzkclientdestructor created (now c0b3856)

2018-05-23 Thread huijun
This is an automated email from the ASF dual-hosted git repository. huijun pushed a change to branch huijunw/reorderzkclientdestructor in repository https://gitbox.apache.org/repos/asf/incubator-heron.git. at c0b3856 reorder This branch includes the following new commits: new c0b38

[GitHub] huijunw commented on issue #2907: stuck stmgr due to zk client destructor

2018-05-23 Thread GitBox
huijunw commented on issue #2907: stuck stmgr due to zk client destructor URL: https://github.com/apache/incubator-heron/issues/2907#issuecomment-391510536 For the thread 0x7f616cc62700: It called the GetCompletionWatcher(), when a getting-zk-node operation is done. In the watcher, ZkAc

[GitHub] huijunw commented on issue #2907: stuck stmgr due to zk client destructor

2018-05-23 Thread GitBox
huijunw commented on issue #2907: stuck stmgr due to zk client destructor URL: https://github.com/apache/incubator-heron/issues/2907#issuecomment-391510536 For the thread 0x7f616cc62700: It called the GetCompletionWatcher(), when a getting-zk-node operation is done. In the watcher, ZkAc

[GitHub] huijunw commented on issue #2907: stuck stmgr due to zk client destructor

2018-05-23 Thread GitBox
huijunw commented on issue #2907: stuck stmgr due to zk client destructor URL: https://github.com/apache/incubator-heron/issues/2907#issuecomment-391489175 replace https://github.com/apache/incubator-heron/issues/2765 This is

[GitHub] huijunw commented on issue #2907: stuck stmgr due to zk client destructor

2018-05-23 Thread GitBox
huijunw commented on issue #2907: stuck stmgr due to zk client destructor URL: https://github.com/apache/incubator-heron/issues/2907#issuecomment-391482300 two questions: 1. why is zookeeper not single thread ? `libzookeeper_mt` vs `libzookeeper_st` 2. if multi thread zk client is ex

[GitHub] huijunw opened a new issue #2907: stuck stmgr due to zk client destructor

2018-05-23 Thread GitBox
huijunw opened a new issue #2907: stuck stmgr due to zk client destructor URL: https://github.com/apache/incubator-heron/issues/2907 This is an automated message from the Apache Git Service. To respond to the message, please