[GitHub] nwangtw commented on a change in pull request #2891: Refactor StatefulStorage API

2018-06-23 Thread GitBox
nwangtw commented on a change in pull request #2891: Refactor StatefulStorage API URL: https://github.com/apache/incubator-heron/pull/2891#discussion_r197624374 ## File path: heron/proto/ckptmgr.proto ## @@ -171,7 +175,23 @@ message CleanStatefulCheckpointResponse {

[GitHub] nwangtw commented on a change in pull request #2891: Refactor StatefulStorage API

2018-06-23 Thread GitBox
nwangtw commented on a change in pull request #2891: Refactor StatefulStorage API URL: https://github.com/apache/incubator-heron/pull/2891#discussion_r197624374 ## File path: heron/proto/ckptmgr.proto ## @@ -171,7 +175,23 @@ message CleanStatefulCheckpointResponse {

[GitHub] kramasamy commented on issue #2891: Refactor StatefulStorage API

2018-06-23 Thread GitBox
kramasamy commented on issue #2891: Refactor StatefulStorage API URL: https://github.com/apache/incubator-heron/pull/2891#issuecomment-399697948 @nwangtw - can you resolve conflicts if this is good to go. This is an automated

[GitHub] kramasamy commented on a change in pull request #2929: Make TopologyBuilder less permissive

2018-06-23 Thread GitBox
kramasamy commented on a change in pull request #2929: Make TopologyBuilder less permissive URL: https://github.com/apache/incubator-heron/pull/2929#discussion_r197618933 ## File path: heronpy/api/topology.py ## @@ -194,24 +194,25 @@ def get_heron_options_from_env():

[incubator-heron] branch master updated: make EvitionContext extend Serializable (#2935)

2018-06-23 Thread karthikz
This is an automated email from the ASF dual-hosted git repository. karthikz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-heron.git The following commit(s) were added to refs/heads/master by this push: new 805a401 make EvitionContext extend

[GitHub] Code0x58 edited a comment on issue #2924: Py3 heronpy

2018-06-23 Thread GitBox
Code0x58 edited a comment on issue #2924: Py3 heronpy URL: https://github.com/apache/incubator-heron/pull/2924#issuecomment-399665205 Once this does work locally, it'll need support on the schedulers, which I think is to update the executor image to include Python3.6. I will look

[GitHub] Code0x58 edited a comment on issue #2924: Py3 heronpy

2018-06-23 Thread GitBox
Code0x58 edited a comment on issue #2924: Py3 heronpy URL: https://github.com/apache/incubator-heron/pull/2924#issuecomment-399665205 Once this does work locally, it'll need support on the schedulers, which I think is to update the executor image to include Python3.6. I will look

[GitHub] Code0x58 commented on issue #2924: Py3 heronpy

2018-06-23 Thread GitBox
Code0x58 commented on issue #2924: Py3 heronpy URL: https://github.com/apache/incubator-heron/pull/2924#issuecomment-399665205 Once this does work locally, it'll need support on the schedulers, which I think is to update the executor image to include Python3. I will look into making

[GitHub] Code0x58 commented on issue #2928: Clean up website gen + website python docs

2018-06-23 Thread GitBox
Code0x58 commented on issue #2928: Clean up website gen + website python docs URL: https://github.com/apache/incubator-heron/pull/2928#issuecomment-399661032 This is failing for the same reason as master now, but should be good to merge

[GitHub] yaoliclshlmch opened a new pull request #2936: Yaoli/add integration topology test

2018-06-23 Thread GitBox
yaoliclshlmch opened a new pull request #2936: Yaoli/add integration topology test URL: https://github.com/apache/incubator-heron/pull/2936 This test aims to test the launched topology structure correctness. The previous integration tests are focusing on the data correctness by fetching