[GitHub] yaoliclshlmch closed pull request #2936: add integration topology test

yaoliclshlmch closed pull request #2936: add integration topology test URL: https://github.com/apache/incubator-heron/pull/2936 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] nwangtw commented on a change in pull request #2936: add integration topology test

nwangtw commented on a change in pull request #2936: add integration topology test URL: https://github.com/apache/incubator-heron/pull/2936#discussion_r197868599 ## File path: scripts/run_integration_topology_test.sh ## @@ -0,0 +1,51 @@ +#!/bin/bash +# +# Script to

[GitHub] nwangtw commented on a change in pull request #2936: add integration topology test

nwangtw commented on a change in pull request #2936: add integration topology test URL: https://github.com/apache/incubator-heron/pull/2936#discussion_r197867004 ## File path: integration_test/src/java/org/apache/heron/integration_topology_test/common/AbstractTestTopology.java

[GitHub] nwangtw commented on a change in pull request #2936: add integration topology test

nwangtw commented on a change in pull request #2936: add integration topology test URL: https://github.com/apache/incubator-heron/pull/2936#discussion_r197866159 ## File path: heron/tmaster/src/cpp/manager/tcontroller.cpp ## @@ -262,6 +268,44 @@ void

[GitHub] nwangtw commented on a change in pull request #2936: add integration topology test

nwangtw commented on a change in pull request #2936: add integration topology test URL: https://github.com/apache/incubator-heron/pull/2936#discussion_r197866698 ## File path: heron/tmaster/src/cpp/manager/tcontroller.cpp ## @@ -262,6 +268,44 @@ void

[GitHub] nwangtw commented on a change in pull request #2936: add integration topology test

nwangtw commented on a change in pull request #2936: add integration topology test URL: https://github.com/apache/incubator-heron/pull/2936#discussion_r197868438 ## File path: scripts/run_integration_topology_test.sh ## @@ -0,0 +1,51 @@ +#!/bin/bash +# +# Script to

[GitHub] Code0x58 commented on issue #2937: Use latest scala rules to fix tests

Code0x58 commented on issue #2937: Use latest scala rules to fix tests URL: https://github.com/apache/incubator-heron/pull/2937#issuecomment-39388 Yep, I think this was merged as a part of #2928 though This is an

[GitHub] kramasamy closed pull request #2928: Clean up website gen + website python docs

kramasamy closed pull request #2928: Clean up website gen + website python docs URL: https://github.com/apache/incubator-heron/pull/2928 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] kramasamy commented on issue #2937: Use latest scala rules to fix tests

kramasamy commented on issue #2937: Use latest scala rules to fix tests URL: https://github.com/apache/incubator-heron/pull/2937#issuecomment-399962684 @Code0x58 @erenavsarogullari - is this good to go? This is an automated

[GitHub] Code0x58 commented on issue #2928: Clean up website gen + website python docs

Code0x58 commented on issue #2928: Clean up website gen + website python docs URL: https://github.com/apache/incubator-heron/pull/2928#issuecomment-399860592 I pulled in #2937 so the tests pass, so this should probably be merged after it.

[GitHub] Code0x58 commented on a change in pull request #2924: Py3 heronpy

Code0x58 commented on a change in pull request #2924: Py3 heronpy URL: https://github.com/apache/incubator-heron/pull/2924#discussion_r197701632 ## File path: scripts/packages/BUILD ## @@ -474,9 +474,11 @@ genrule( 'rm setup.py.template', 'tree