[GitHub] nwangtw commented on issue #2860: Add component config in heron UI and Tracker

2018-06-26 Thread GitBox
nwangtw commented on issue #2860: Add component config in heron UI and Tracker URL: https://github.com/apache/incubator-heron/pull/2860#issuecomment-400501772 So quick. Thanks. :) This is an automated message from the Apache

[GitHub] kramasamy closed pull request #2860: Add component config in heron UI and Tracker

2018-06-26 Thread GitBox
kramasamy closed pull request #2860: Add component config in heron UI and Tracker URL: https://github.com/apache/incubator-heron/pull/2860 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[incubator-heron] branch master updated: Add component config in heron UI and Tracker (#2860)

2018-06-26 Thread karthikz
This is an automated email from the ASF dual-hosted git repository. karthikz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-heron.git The following commit(s) were added to refs/heads/master by this push: new 84737b0 Add component config in

[GitHub] nwangtw commented on issue #2860: Add component config in heron UI and Tracker

2018-06-26 Thread GitBox
nwangtw commented on issue #2860: Add component config in heron UI and Tracker URL: https://github.com/apache/incubator-heron/pull/2860#issuecomment-400499425 Verified that explore works ok with the change. This is an

[GitHub] huijunwu commented on issue #2938: add integration topology test

2018-06-26 Thread GitBox
huijunwu commented on issue #2938: add integration topology test URL: https://github.com/apache/incubator-heron/pull/2938#issuecomment-400484185 ship after ci pass This is an automated message from the Apache Git Service. To

[GitHub] yaoliclshlmch commented on a change in pull request #2938: add integration topology test

2018-06-26 Thread GitBox
yaoliclshlmch commented on a change in pull request #2938: add integration topology test URL: https://github.com/apache/incubator-heron/pull/2938#discussion_r198315190 ## File path: scripts/run_integration_topology_test.sh ## @@ -0,0 +1,51 @@ +#!/bin/bash +# +# Script to

[GitHub] nlu90 commented on a change in pull request #2938: add integration topology test

2018-06-26 Thread GitBox
nlu90 commented on a change in pull request #2938: add integration topology test URL: https://github.com/apache/incubator-heron/pull/2938#discussion_r198307955 ## File path: heron/common/src/cpp/basics/strutils.cpp ## @@ -44,3 +44,58 @@ StrUtils::split( return tokens;

[GitHub] kramasamy commented on issue #2860: Add component config in heron UI and Tracker

2018-06-26 Thread GitBox
kramasamy commented on issue #2860: Add component config in heron UI and Tracker URL: https://github.com/apache/incubator-heron/pull/2860#issuecomment-400334819 @nwangtw - is this ready to be merged? This is an automated

[incubator-heron] branch master updated: Make TopologyBuilder less permissive (#2929)

2018-06-26 Thread karthikz
This is an automated email from the ASF dual-hosted git repository. karthikz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-heron.git The following commit(s) were added to refs/heads/master by this push: new 5ee2490 Make TopologyBuilder less

[GitHub] kramasamy closed pull request #2929: Make TopologyBuilder less permissive

2018-06-26 Thread GitBox
kramasamy closed pull request #2929: Make TopologyBuilder less permissive URL: https://github.com/apache/incubator-heron/pull/2929 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] Code0x58 closed pull request #2937: Use latest scala rules to fix tests

2018-06-26 Thread GitBox
Code0x58 closed pull request #2937: Use latest scala rules to fix tests URL: https://github.com/apache/incubator-heron/pull/2937 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] Code0x58 commented on issue #2937: Use latest scala rules to fix tests

2018-06-26 Thread GitBox
Code0x58 commented on issue #2937: Use latest scala rules to fix tests URL: https://github.com/apache/incubator-heron/pull/2937#issuecomment-400233059 Yep, this is in. The build failure on master is down to #2925 now This is

[GitHub] nwangtw commented on a change in pull request #2938: add integration topology test

2018-06-26 Thread GitBox
nwangtw commented on a change in pull request #2938: add integration topology test URL: https://github.com/apache/incubator-heron/pull/2938#discussion_r198034971 ## File path: heron/common/src/cpp/basics/strutils.cpp ## @@ -44,3 +44,41 @@ StrUtils::split( return