[GitHub] [incubator-heron] thinker0 removed a comment on issue #3493: Support custom metrics rules for PrometheusSink

2020-03-22 Thread GitBox
thinker0 removed a comment on issue #3493: Support custom metrics rules for PrometheusSink URL: https://github.com/apache/incubator-heron/pull/3493#issuecomment-602230125 retest this please This is an automated message from

[GitHub] [incubator-heron] thinker0 commented on issue #3493: Support custom metrics rules for PrometheusSink

2020-03-22 Thread GitBox
thinker0 commented on issue #3493: Support custom metrics rules for PrometheusSink URL: https://github.com/apache/incubator-heron/pull/3493#issuecomment-602230125 retest this please This is an automated message from the

[GitHub] [incubator-heron] joshfischer1108 commented on issue #3483: updating docs for compiling

2020-03-22 Thread GitBox
joshfischer1108 commented on issue #3483: updating docs for compiling URL: https://github.com/apache/incubator-heron/pull/3483#issuecomment-602194096 I've updated the documentation a bit. Please give another review before we merge.

[GitHub] [incubator-heron] joshfischer1108 commented on a change in pull request #3483: updating docs for compiling

2020-03-22 Thread GitBox
joshfischer1108 commented on a change in pull request #3483: updating docs for compiling URL: https://github.com/apache/incubator-heron/pull/3483#discussion_r396089008 ## File path: website2/docs/compiling-docker.md ## @@ -130,8 +140,8 @@ After the commands, a new docker