huijunwu edited a comment on pull request #3588:
URL: https://github.com/apache/incubator-heron/pull/3588#issuecomment-667168233
tested on macos, several issues:
1. need to toggle verbose, see below
```
[tw-mbp-huijunw heron-github (explorer-cli)]$ ~/.heron/bin/heron-explorer
huijunwu edited a comment on pull request #3588:
URL: https://github.com/apache/incubator-heron/pull/3588#issuecomment-667168233
tested on macos, several issues:
1. need to toggle verbose, see below
```
[tw-mbp-huijunw heron-github (explorer-cli)]$ ~/.heron/bin/heron-explorer
huijunwu commented on pull request #3588:
URL: https://github.com/apache/incubator-heron/pull/3588#issuecomment-667168233
tested on macos, several issues:
1. need to toggle verbose, see below
```
[tw-mbp-huijunw heron-github (explorer-cli)]$ ~/.heron/bin/heron-explorer
windhamwong commented on pull request #3595:
URL: https://github.com/apache/incubator-heron/pull/3595#issuecomment-667061592
Docker build testing result:
ubuntu18.04 - success
ubuntu20.04 - success
ubuntu16.04 - success
debian9 - fail - python3.6 not supported (unrelated to
nicknezis merged pull request #3595:
URL: https://github.com/apache/incubator-heron/pull/3595
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nicknezis merged pull request #3596:
URL: https://github.com/apache/incubator-heron/pull/3596
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nicknezis commented on pull request #3596:
URL: https://github.com/apache/incubator-heron/pull/3596#issuecomment-666901866
@huijunw @windhamwong Is the underlying issue something that needs to be
documented for those not using Docker images?
windhamwong commented on pull request #3595:
URL: https://github.com/apache/incubator-heron/pull/3595#issuecomment-666502369
let me try out all docker builds tomorrow.
This is an automated message from the Apache Git
joshfischer1108 commented on pull request #3589:
URL: https://github.com/apache/incubator-heron/pull/3589#issuecomment-66637
> @joshfischer1108 The order that init containers run is sequentially. The
check for Zookeeper to be up and healthy was happening after the Bookkeeper
format
windhamwong commented on pull request #3595:
URL: https://github.com/apache/incubator-heron/pull/3595#issuecomment-666062598
https://zlib.net/pigz/
It is gzip format but with the parallel multi-core feature. The traditional
gzip command uses only one core but modern CPU/vCPU has more
windhamwong opened a new pull request #3596:
URL: https://github.com/apache/incubator-heron/pull/3596
https://github.com/apache/incubator-heron/commit/39cf3a76b143b5c491de88cfe40cd83f29d2c0be#commitcomment-41026206
This PR adds 2 lines of ENV for applying the fix of click under Py36
nicknezis commented on pull request #3595:
URL: https://github.com/apache/incubator-heron/pull/3595#issuecomment-665910932
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Code0x58 commented on pull request #3595:
URL: https://github.com/apache/incubator-heron/pull/3595#issuecomment-666023113
A couple of tests to show equivalence for consumers:
With gzip:
```
$ cat txt
oink
$ ls
txt
$ pigz txt
$ ls
txt.gz
$ gunzip txt.gz
$
windhamwong opened a new pull request #3595:
URL: https://github.com/apache/incubator-heron/pull/3595
pigz is a multi-core version of tar, which makes the docker build process
much faster.
This is an automated message from
windhamwong closed pull request #3594:
URL: https://github.com/apache/incubator-heron/pull/3594
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
huijunwu merged pull request #3591:
URL: https://github.com/apache/incubator-heron/pull/3591
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
huijunwu commented on pull request #3591:
URL: https://github.com/apache/incubator-heron/pull/3591#issuecomment-665564256
reference #1767 #1595 #1119
This is an automated message from the Apache Git Service.
To respond to
windhamwong commented on pull request #3594:
URL: https://github.com/apache/incubator-heron/pull/3594#issuecomment-665796887
Messed up with the code, i will create another PR
This is an automated message from the Apache Git
windhamwong opened a new pull request #3594:
URL: https://github.com/apache/incubator-heron/pull/3594
This helps to make the docker build faster with using multi-core/thread.
Ubuntu18 has pigz installed by default, but still need test on other distro.
huijunwu merged pull request #3592:
URL: https://github.com/apache/incubator-heron/pull/3592
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
nicknezis merged pull request #3590:
URL: https://github.com/apache/incubator-heron/pull/3590
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nicknezis closed issue #3516:
URL: https://github.com/apache/incubator-heron/issues/3516
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
nicknezis opened a new pull request #3592:
URL: https://github.com/apache/incubator-heron/pull/3592
When we updated the Distribution images to use JRE instead of JDK, we lost
the ability to run commands like `jmap` and `jstack`. This Pull Request updates
the images to use JDK as they did
nicknezis opened a new pull request #3593:
URL: https://github.com/apache/incubator-heron/pull/3593
Updating Kryo to a newer version. Currently 5.0.0-RC7 is the most recent
release.
This is an automated message from the
nwangtw opened a new pull request #3590:
URL: https://github.com/apache/incubator-heron/pull/3590
License is missing in a few files. And the license of a new font needs to be
listed.
This is an automated message from the
Code0x58 opened a new pull request #3588:
URL: https://github.com/apache/incubator-heron/pull/3588
* use click instead of argparse pattern
* list all topologies instead of just 20
This is an automated message from the
nicknezis merged pull request #3589:
URL: https://github.com/apache/incubator-heron/pull/3589
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nicknezis opened a new pull request #3589:
URL: https://github.com/apache/incubator-heron/pull/3589
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Code0x58 opened a new pull request #3591:
URL: https://github.com/apache/incubator-heron/pull/3591
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nicknezis commented on pull request #3589:
URL: https://github.com/apache/incubator-heron/pull/3589#issuecomment-665448238
@joshfischer1108 The order that init containers run is sequentially. The
check for Zookeeper to be up and healthy was happening after the Bookkeeper
format call.
nicknezis commented on issue #3516:
URL:
https://github.com/apache/incubator-heron/issues/3516#issuecomment-665480260
I believe the Javadoc issue was resolved. Closing this issue. Please let us
know if the issue persists. If so we will re-open this issue.
huijunwu commented on pull request #3587:
URL: https://github.com/apache/incubator-heron/pull/3587#issuecomment-664290210
instance may need similar refactoring
https://github.com/apache/incubator-heron/blob/master/heron/instance/src/python/instance/st_heron_instance.py#L328
Code0x58 opened a new pull request #3587:
URL: https://github.com/apache/incubator-heron/pull/3587
The usage was inaccurate/out of date for `heron-executor`, so this change
leaves the parsing and documentation to
[click](https://click.palletsprojects.com/) in a change that tried to be
huijunwu commented on issue #3545:
URL:
https://github.com/apache/incubator-heron/issues/3545#issuecomment-664004338
I tried ubuntu20.04+python3, looks good to me. Do you still see this issue?
This is an automated message
huijunwu commented on issue #3582:
URL:
https://github.com/apache/incubator-heron/issues/3582#issuecomment-664003979
My MacOs has several PEX environments, I used the following to force PEX on
py3
```
$ PY3=$(which python3)
$ echo "PEX_PYTHON_PATH=$(dirname ${PY3})" >
huijunwu merged pull request #3580:
URL: https://github.com/apache/incubator-heron/pull/3580
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
huijunwu closed pull request #3586:
URL: https://github.com/apache/incubator-heron/pull/3586
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
huijunwu commented on pull request #3586:
URL: https://github.com/apache/incubator-heron/pull/3586#issuecomment-663934276
close it, duplicate #3580
This is an automated message from the Apache Git Service.
To respond to the
huijunwu merged pull request #3579:
URL: https://github.com/apache/incubator-heron/pull/3579
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
huijunwu merged pull request #3581:
URL: https://github.com/apache/incubator-heron/pull/3581
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
huijunwu edited a comment on pull request #3585:
URL: https://github.com/apache/incubator-heron/pull/3585#issuecomment-663923208
> * remove heron-admin binary from release
> I am all for it. Hasn't had a chance to use it in the past 3 years.
@nlu90 @huijunw Is there any case
huijunwu commented on pull request #3585:
URL: https://github.com/apache/incubator-heron/pull/3585#issuecomment-663923208
> * remove heron-admin binary from release
> I am all for it. Hasn't had a chance to use it in the past 3 years.
@nlu90 @huijunw Is there any case heron-admin is
huijunwu opened a new pull request #3586:
URL: https://github.com/apache/incubator-heron/pull/3586
fix https://heronstreaming.slack.com/archives/C0VKQLKV0/p1595687004234500
The shell exception at str.decode
nwangtw commented on pull request #3585:
URL: https://github.com/apache/incubator-heron/pull/3585#issuecomment-663905226
- remove heron-admin binary from release
I am all for it. Hasn't had a chance to use it in the past 3 years. @nlu90
@huijunw Is there any case heron-admin is needed?
Code0x58 opened a new pull request #3585:
URL: https://github.com/apache/incubator-heron/pull/3585
* remove heron-admin binary from release
* remove nomad binary from release
* remove "standalone" cluster config from release and documentation
Code0x58 opened a new pull request #3584:
URL: https://github.com/apache/incubator-heron/pull/3584
I started cleaning up `heron-admin`'s code to make it a bit clearer, but
along the way found that it was broken (at least because it tried to find nomad
in the wrong place.
Given all
Code0x58 opened a new pull request #3583:
URL: https://github.com/apache/incubator-heron/pull/3583
replace the 4 year old version with the latest version (released today)
This is an automated message from the Apache Git
nicknezis opened a new issue #3582:
URL: https://github.com/apache/incubator-heron/issues/3582
**Describe the bug**
I can not run `bazel build --config=darwin_nostyle heron/...` without errors.
**To Reproduce**
Steps to reproduce the behavior:
1. `/.bazel_configure.py`
nicknezis merged pull request #3576:
URL: https://github.com/apache/incubator-heron/pull/3576
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Code0x58 commented on a change in pull request #3580:
URL: https://github.com/apache/incubator-heron/pull/3580#discussion_r459404375
##
File path: heron/shell/src/python/utils.py
##
@@ -135,21 +135,22 @@ def read_chunk(filename, offset=-1, length=-1,
escape_data=False):
if
thinker0 commented on a change in pull request #3580:
URL: https://github.com/apache/incubator-heron/pull/3580#discussion_r459189749
##
File path: heron/shell/src/python/utils.py
##
@@ -135,21 +135,22 @@ def read_chunk(filename, offset=-1, length=-1,
escape_data=False):
if
thinker0 commented on a change in pull request #3580:
URL: https://github.com/apache/incubator-heron/pull/3580#discussion_r459174401
##
File path: heron/shell/src/python/utils.py
##
@@ -135,21 +135,22 @@ def read_chunk(filename, offset=-1, length=-1,
escape_data=False):
if
thinker0 commented on a change in pull request #3580:
URL: https://github.com/apache/incubator-heron/pull/3580#discussion_r459174401
##
File path: heron/shell/src/python/utils.py
##
@@ -135,21 +135,22 @@ def read_chunk(filename, offset=-1, length=-1,
escape_data=False):
if
thinker0 commented on a change in pull request #3580:
URL: https://github.com/apache/incubator-heron/pull/3580#discussion_r459171310
##
File path: heron/shell/src/python/utils.py
##
@@ -135,21 +135,22 @@ def read_chunk(filename, offset=-1, length=-1,
escape_data=False):
if
Code0x58 commented on a change in pull request #3580:
URL: https://github.com/apache/incubator-heron/pull/3580#discussion_r459163401
##
File path: heron/shell/src/python/utils.py
##
@@ -135,21 +135,22 @@ def read_chunk(filename, offset=-1, length=-1,
escape_data=False):
if
Code0x58 commented on a change in pull request #3580:
URL: https://github.com/apache/incubator-heron/pull/3580#discussion_r459163401
##
File path: heron/shell/src/python/utils.py
##
@@ -135,21 +135,22 @@ def read_chunk(filename, offset=-1, length=-1,
escape_data=False):
if
Code0x58 closed issue #3559:
URL: https://github.com/apache/incubator-heron/issues/3559
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Code0x58 closed issue #3556:
URL: https://github.com/apache/incubator-heron/issues/3556
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Code0x58 closed issue #3575:
URL: https://github.com/apache/incubator-heron/issues/3575
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Code0x58 commented on a change in pull request #3580:
URL: https://github.com/apache/incubator-heron/pull/3580#discussion_r459152556
##
File path: heron/shell/src/python/utils.py
##
@@ -135,7 +135,7 @@ def read_chunk(filename, offset=-1, length=-1,
escape_data=False):
if
thinker0 opened a new pull request #3581:
URL: https://github.com/apache/incubator-heron/pull/3581
Support lifecycle for Mesos/Aurora
http://aurora.apache.org/documentation/latest/reference/configuration/#lifecycleconfig-objects
Code0x58 commented on a change in pull request #3580:
URL: https://github.com/apache/incubator-heron/pull/3580#discussion_r459154368
##
File path: heron/shell/src/python/utils.py
##
@@ -135,7 +135,7 @@ def read_chunk(filename, offset=-1, length=-1,
escape_data=False):
if
Code0x58 commented on a change in pull request #3580:
URL: https://github.com/apache/incubator-heron/pull/3580#discussion_r459154368
##
File path: heron/shell/src/python/utils.py
##
@@ -135,7 +135,7 @@ def read_chunk(filename, offset=-1, length=-1,
escape_data=False):
if
Code0x58 commented on a change in pull request #3580:
URL: https://github.com/apache/incubator-heron/pull/3580#discussion_r459154368
##
File path: heron/shell/src/python/utils.py
##
@@ -135,7 +135,7 @@ def read_chunk(filename, offset=-1, length=-1,
escape_data=False):
if
Code0x58 commented on a change in pull request #3580:
URL: https://github.com/apache/incubator-heron/pull/3580#discussion_r459152556
##
File path: heron/shell/src/python/utils.py
##
@@ -135,7 +135,7 @@ def read_chunk(filename, offset=-1, length=-1,
escape_data=False):
if
thinker0 opened a new pull request #3580:
URL: https://github.com/apache/incubator-heron/pull/3580
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Code0x58 opened a new pull request #3579:
URL: https://github.com/apache/incubator-heron/pull/3579
:broom: :dash:
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
nicknezis merged pull request #3574:
URL: https://github.com/apache/incubator-heron/pull/3574
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
thinker0 edited a comment on pull request #3574:
URL: https://github.com/apache/incubator-heron/pull/3574#issuecomment-662158049
+1
really good work.
Approved
This is an automated message from the Apache Git Service.
thinker0 commented on pull request #3574:
URL: https://github.com/apache/incubator-heron/pull/3574#issuecomment-662158049
+1
Approved
This is an automated message from the Apache Git Service.
To respond to the
Code0x58 commented on pull request #3574:
URL: https://github.com/apache/incubator-heron/pull/3574#issuecomment-662133945
an initial look into `convert_pb_kvs(...)` makes it me think it's a pretty
hairy thing, so I didn't try to do anything smart and pushed what might get
things running.
nicknezis merged pull request #3578:
URL: https://github.com/apache/incubator-heron/pull/3578
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nicknezis closed pull request #3512:
URL: https://github.com/apache/incubator-heron/pull/3512
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
joshfischer1108 opened a new pull request #3578:
URL: https://github.com/apache/incubator-heron/pull/3578
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
joshfischer1108 edited a comment on pull request #3512:
URL: https://github.com/apache/incubator-heron/pull/3512#issuecomment-661785928
I think this should be closed or modified. We are on java 11 now.
This is an automated
joshfischer1108 edited a comment on pull request #3512:
URL: https://github.com/apache/incubator-heron/pull/3512#issuecomment-661785928
I think this should be closed. We are on java 11 now.
This is an automated message from
joshfischer1108 commented on pull request #3512:
URL: https://github.com/apache/incubator-heron/pull/3512#issuecomment-661785928
I think this should be closed. We are java 11 now.
This is an automated message from the
nicknezis commented on pull request #3512:
URL: https://github.com/apache/incubator-heron/pull/3512#issuecomment-661605988
Do we want this merged in or closed?
This is an automated message from the Apache Git Service.
To
thinker0 edited a comment on pull request #3574:
URL: https://github.com/apache/incubator-heron/pull/3574#issuecomment-661433596
@Code0x58 sorry. The last one goes like this.
Other features seem to work fine.
```
[2020-07-21 08:21:52 +0900] [ERROR]: Failed to parse data as
thinker0 edited a comment on pull request #3574:
URL: https://github.com/apache/incubator-heron/pull/3574#issuecomment-661433596
@Code0x58 sorry. The last one goes like this.
```
[2020-07-21 08:21:52 +0900] [ERROR]: Failed to parse data as java object
Traceback (most recent call
Code0x58 commented on pull request #3574:
URL: https://github.com/apache/incubator-heron/pull/3574#issuecomment-661468879
Thanks again @thinker0! So much for hopes of a dumb upgrade. I'll have to
spend some time getting to understand the old and new `javaobj` modules to do a
proper
thinker0 commented on pull request #3574:
URL: https://github.com/apache/incubator-heron/pull/3574#issuecomment-661433596
@Code0x58 sorry. The last one goes like this.
```
[2020-07-21 08:21:52 +0900] [ERROR]: Failed to parse data as java object
Traceback (most recent call last):
Code0x58 commented on pull request #3574:
URL: https://github.com/apache/incubator-heron/pull/3574#issuecomment-661324466
CI passed on my machine, so hopefully the switch to the maintained version
of `pyobj` sorts things out!
nicknezis merged pull request #3568:
URL: https://github.com/apache/incubator-heron/pull/3568
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
joshfischer1108 commented on a change in pull request #3574:
URL: https://github.com/apache/incubator-heron/pull/3574#discussion_r457585129
##
File path: heron/statemgrs/src/python/zkstatemanager.py
##
@@ -170,7 +170,7 @@ def _get_topology_with_watch(self, topologyName,
Code0x58 commented on pull request #3574:
URL: https://github.com/apache/incubator-heron/pull/3574#issuecomment-661050567
humm, that error looks like it could be a deeper `pyobj` issue, so I should
probably stop trying to patch it, and just upgrade `pyobj` for
thinker0 commented on pull request #3574:
URL: https://github.com/apache/incubator-heron/pull/3574#issuecomment-661046491
@Code0x58 Another
```
[2020-07-20 22:40:03 +0900] [INFO]: Setting topology info for topology:
heron-ladp_oa_message_id_report-to-ladp-log-es
[2020-07-20
Code0x58 commented on pull request #3574:
URL: https://github.com/apache/incubator-heron/pull/3574#issuecomment-661031266
thanks again @thinker0, I pushed another amendment. The amendment isn't
1-to-1 with the python2 implementation, but it's probably saner. I don't know
if it will have a
thinker0 commented on pull request #3574:
URL: https://github.com/apache/incubator-heron/pull/3574#issuecomment-661021922
@Code0x58 another
```
[2020-07-20 21:33:24 +0900] [INFO]: Setting topology info for topology:
Code0x58 edited a comment on pull request #3574:
URL: https://github.com/apache/incubator-heron/pull/3574#issuecomment-661013477
thanks @thinker0, I just pushed a quick amendment that should resolve the
`/`→`//` issue. There is still be the separate seek issue which I think is
because the
Code0x58 edited a comment on pull request #3574:
URL: https://github.com/apache/incubator-heron/pull/3574#issuecomment-661013477
thanks @thinker0, I just pushed a quick amendment that should resolve the
`/`→`//` issue, but there'd still be the separate seek issue which I think is
because
Code0x58 commented on a change in pull request #3574:
URL: https://github.com/apache/incubator-heron/pull/3574#discussion_r457352071
##
File path: heron/statemgrs/src/python/zkstatemanager.py
##
@@ -170,7 +170,7 @@ def _get_topology_with_watch(self, topologyName, callback,
Code0x58 commented on a change in pull request #3574:
URL: https://github.com/apache/incubator-heron/pull/3574#discussion_r457352071
##
File path: heron/statemgrs/src/python/zkstatemanager.py
##
@@ -170,7 +170,7 @@ def _get_topology_with_watch(self, topologyName, callback,
Code0x58 commented on a change in pull request #3574:
URL: https://github.com/apache/incubator-heron/pull/3574#discussion_r457352071
##
File path: heron/statemgrs/src/python/zkstatemanager.py
##
@@ -170,7 +170,7 @@ def _get_topology_with_watch(self, topologyName, callback,
Code0x58 commented on a change in pull request #3574:
URL: https://github.com/apache/incubator-heron/pull/3574#discussion_r457352071
##
File path: heron/statemgrs/src/python/zkstatemanager.py
##
@@ -170,7 +170,7 @@ def _get_topology_with_watch(self, topologyName, callback,
Code0x58 commented on pull request #3574:
URL: https://github.com/apache/incubator-heron/pull/3574#issuecomment-661013477
thanks @thinker0, I just pushed a quick amendment that should resolve that
issue (`/`→`//`)
This is
thinker0 commented on pull request #3574:
URL: https://github.com/apache/incubator-heron/pull/3574#issuecomment-661002357
@Code0x58
```
TypeError: 'float' object cannot be interpreted as an integer
```
```
[2020-07-20 21:33:24 +0900] [INFO]: Setting topology info for
nwangtw commented on a change in pull request #3576:
URL: https://github.com/apache/incubator-heron/pull/3576#discussion_r457146473
##
File path: WORKSPACE
##
@@ -363,25 +363,27 @@ http_archive(
# end helm
# for docker image building
-DOCKER_RULES_VERSION = "0.14.1"
huijunwu merged pull request #3577:
URL: https://github.com/apache/incubator-heron/pull/3577
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
joshfischer1108 removed a comment on pull request #3568:
URL: https://github.com/apache/incubator-heron/pull/3568#issuecomment-660779925
@Code0x58 Could you rebase this branch from master and resolve the conflict
please?
1 - 100 of 2870 matches
Mail list logo
