[GitHub] [incubator-heron] nwangtw commented on a change in pull request #3492: revert the stmgr clientmgr

2020-03-18 Thread GitBox 
nwangtw commented on a change in pull request #3492: revert the stmgr clientmgr
URL: https://github.com/apache/incubator-heron/pull/3492#discussion_r394170123
 
 

 ##
 File path: heron/stmgr/src/cpp/manager/stmgr-clientmgr.cpp
 ##
 @@ -115,7 +115,7 @@ bool StMgrClientMgr::DidAnnounceBackPressure() {
   return stream_manager_->DidAnnounceBackPressure();
 }
 
-shared_ptr StMgrClientMgr::CreateClient(const sp_string& 
_other_stmgr_id,
+StMgrClient* StMgrClientMgr::CreateClient(const sp_string& _other_stmgr_id,
 
 Review comment:
   > cc @nwangtw
   
   Thanks.
   
   Yeah I think you are right. Shared ptr is reference based hence this crash 
is quite strange. The only possible way is a bad cast somewhere that cause the 
ref count messed up.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-heron] nwangtw commented on a change in pull request #3492: revert the stmgr clientmgr

2020-03-18 Thread GitBox 
nwangtw commented on a change in pull request #3492: revert the stmgr clientmgr
URL: https://github.com/apache/incubator-heron/pull/3492#discussion_r394135078
 
 

 ##
 File path: heron/stmgr/src/cpp/manager/stmgr-clientmgr.cpp
 ##
 @@ -115,7 +115,7 @@ bool StMgrClientMgr::DidAnnounceBackPressure() {
   return stream_manager_->DidAnnounceBackPressure();
 }
 
-shared_ptr StMgrClientMgr::CreateClient(const sp_string& 
_other_stmgr_id,
+StMgrClient* StMgrClientMgr::CreateClient(const sp_string& _other_stmgr_id,
 
 Review comment:
   Hmm. This is strange because shared_ptr<> should be safer and I can't tell 
what can be wrong in the original code. @dnrusakov should have better idea.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services