HIVE-16721 : Inconsistent behavior in dealing with Timestamp stats (Vaibhav Gumashta, reviewed by Vineet Garg)
Project: http://git-wip-us.apache.org/repos/asf/hive/repo Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/c369a5d0 Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/c369a5d0 Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/c369a5d0 Branch: refs/heads/hive-14535 Commit: c369a5d0d6dfa201daf7c6c5308301925e680b8a Parents: 5f4eaa9 Author: Vaibhav Gumashta <vgumas...@hortonworks.com> Authored: Sat May 20 19:09:15 2017 -0700 Committer: Thejas M Nair <the...@hortonworks.com> Committed: Sat May 20 19:09:23 2017 -0700 ---------------------------------------------------------------------- .../hadoop/hive/ql/exec/ColumnStatsUpdateTask.java | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hive/blob/c369a5d0/ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsUpdateTask.java ---------------------------------------------------------------------- diff --git a/ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsUpdateTask.java b/ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsUpdateTask.java index eb4488a..2acc777 100644 --- a/ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsUpdateTask.java +++ b/ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsUpdateTask.java @@ -93,14 +93,14 @@ public class ColumnStatsUpdateTask extends Task<ColumnStatsUpdateWork> { statsObj.setColName(colName.get(0)); statsObj.setColType(colType.get(0)); - + ColumnStatisticsData statsData = new ColumnStatisticsData(); - + String columnType = colType.get(0); if (columnType.equalsIgnoreCase("long") || columnType.equalsIgnoreCase("tinyint") - || columnType.equalsIgnoreCase("smallint") || columnType.equalsIgnoreCase("int") - || columnType.equalsIgnoreCase("bigint")) { + || columnType.equalsIgnoreCase("smallint") || columnType.equalsIgnoreCase("int") + || columnType.equalsIgnoreCase("bigint") || columnType.equalsIgnoreCase("timestamp")) { LongColumnStatsData longStats = new LongColumnStatsData(); longStats.setNumNullsIsSet(false); longStats.setNumDVsIsSet(false); @@ -121,7 +121,6 @@ public class ColumnStatsUpdateTask extends Task<ColumnStatsUpdateWork> { } else { throw new SemanticException("Unknown stat"); } - } statsData.setLongStats(longStats); statsObj.setStatsData(statsData); @@ -244,8 +243,7 @@ public class ColumnStatsUpdateTask extends Task<ColumnStatsUpdateWork> { } statsData.setDecimalStats(decimalStats); statsObj.setStatsData(statsData); - } else if (columnType.equalsIgnoreCase("date") - || columnType.equalsIgnoreCase("timestamp")) { + } else if (columnType.equalsIgnoreCase("date")) { DateColumnStatsData dateStats = new DateColumnStatsData(); Map<String, String> mapProp = work.getMapProp(); for (Entry<String, String> entry : mapProp.entrySet()) {