[GitHub] [incubator-hudi] zhedoubushishi commented on issue #1293: [HUDI-585] Optimize the steps of building with scala-2.12

2020-02-01 Thread GitBox
zhedoubushishi commented on issue #1293: [HUDI-585] Optimize the steps of building with scala-2.12 URL: https://github.com/apache/incubator-hudi/pull/1293#issuecomment-581104630 > @zhedoubushishi Did you also get the error [#1226

Build failed in Jenkins: hudi-snapshot-deployment-0.5 #177

2020-02-01 Thread Apache Jenkins Server
See Changes: -- [...truncated 2.02 KB...] /home/jenkins/tools/maven/apache-maven-3.5.4: bin boot conf lib LICENSE NOTICE README.txt

[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1237: [HUDI-583] Code Cleanup, remove redundant code, and other changes

2020-02-01 Thread GitBox
yanghua commented on a change in pull request #1237: [HUDI-583] Code Cleanup, remove redundant code, and other changes URL: https://github.com/apache/incubator-hudi/pull/1237#discussion_r373785185 ## File path:

[GitHub] [incubator-hudi] smarthi commented on a change in pull request #1237: [HUDI-583] Code Cleanup, remove redundant code, and other changes

2020-02-01 Thread GitBox
smarthi commented on a change in pull request #1237: [HUDI-583] Code Cleanup, remove redundant code, and other changes URL: https://github.com/apache/incubator-hudi/pull/1237#discussion_r373785081 ## File path:

[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1237: [HUDI-583] Code Cleanup, remove redundant code, and other changes

2020-02-01 Thread GitBox
yanghua commented on a change in pull request #1237: [HUDI-583] Code Cleanup, remove redundant code, and other changes URL: https://github.com/apache/incubator-hudi/pull/1237#discussion_r373784682 ## File path:

[GitHub] [incubator-hudi] smarthi commented on a change in pull request #1237: [HUDI-583] Code Cleanup, remove redundant code, and other changes

2020-02-01 Thread GitBox
smarthi commented on a change in pull request #1237: [HUDI-583] Code Cleanup, remove redundant code, and other changes URL: https://github.com/apache/incubator-hudi/pull/1237#discussion_r373781774 ## File path:

[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1237: [HUDI-583] Code Cleanup, remove redundant code, and other changes

2020-02-01 Thread GitBox
yanghua commented on a change in pull request #1237: [HUDI-583] Code Cleanup, remove redundant code, and other changes URL: https://github.com/apache/incubator-hudi/pull/1237#discussion_r373779086 ## File path:

[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1237: [HUDI-583] Code Cleanup, remove redundant code, and other changes

2020-02-01 Thread GitBox
yanghua commented on a change in pull request #1237: [HUDI-583] Code Cleanup, remove redundant code, and other changes URL: https://github.com/apache/incubator-hudi/pull/1237#discussion_r373778785 ## File path:

[GitHub] [incubator-hudi] smarthi removed a comment on issue #1237: [HUDI-583] Code Cleanup, remove redundant code, and other changes

2020-02-01 Thread GitBox
smarthi removed a comment on issue #1237: [HUDI-583] Code Cleanup, remove redundant code, and other changes URL: https://github.com/apache/incubator-hudi/pull/1237#issuecomment-575681740 > @smarthi Can you fix the conflicts firstly? done

[GitHub] [incubator-hudi] leesf commented on issue #1293: [HUDI-585] Optimize the steps of building with scala-2.12

2020-02-01 Thread GitBox
leesf commented on issue #1293: [HUDI-585] Optimize the steps of building with scala-2.12 URL: https://github.com/apache/incubator-hudi/pull/1293#issuecomment-581020515 > Hi @leesf, from [README](https://github.com/apache/incubator-hudi#building-apache-hudi-from-source) doc, should use

[GitHub] [incubator-hudi] lamber-ken commented on issue #1293: [HUDI-585] Optimize the steps of building with scala-2.12

2020-02-01 Thread GitBox
lamber-ken commented on issue #1293: [HUDI-585] Optimize the steps of building with scala-2.12 URL: https://github.com/apache/incubator-hudi/pull/1293#issuecomment-581009348 Hi @leesf, you're welcome, I need some information about your env, thanks :) - Maven version - Java version

[GitHub] [incubator-hudi] leesf commented on issue #1293: [HUDI-585] Optimize the steps of building with scala-2.12

2020-02-01 Thread GitBox
leesf commented on issue #1293: [HUDI-585] Optimize the steps of building with scala-2.12 URL: https://github.com/apache/incubator-hudi/pull/1293#issuecomment-581007728 Thanks for opening the PR @lamber-ken ! I compile in my local with scala-2.12, and got the following exception: