[GitHub] [hudi] SteNicholas commented on a diff in pull request #7669: [HUDI-5553] Prevent partition(s) from being dropped if there are pending…

2023-01-30 Thread via GitHub
SteNicholas commented on code in PR #7669: URL: https://github.com/apache/hudi/pull/7669#discussion_r1090345615 ## hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/commit/FlinkDeletePartitionCommitActionExecutor.java: ## @@ -98,4 +103,42 @@ private List

[GitHub] [hudi] SteNicholas commented on a diff in pull request #7669: [HUDI-5553] Prevent partition(s) from being dropped if there are pending…

2023-01-30 Thread via GitHub
SteNicholas commented on code in PR #7669: URL: https://github.com/apache/hudi/pull/7669#discussion_r1090345615 ## hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/commit/FlinkDeletePartitionCommitActionExecutor.java: ## @@ -98,4 +103,42 @@ private List

[GitHub] [hudi] SteNicholas commented on a diff in pull request #7669: [HUDI-5553] Prevent partition(s) from being dropped if there are pending…

2023-01-29 Thread via GitHub
SteNicholas commented on code in PR #7669: URL: https://github.com/apache/hudi/pull/7669#discussion_r1090275991 ## hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/commit/FlinkDeletePartitionCommitActionExecutor.java: ## @@ -98,4 +103,42 @@ private List

[GitHub] [hudi] SteNicholas commented on a diff in pull request #7669: [HUDI-5553] Prevent partition(s) from being dropped if there are pending…

2023-01-29 Thread via GitHub
SteNicholas commented on code in PR #7669: URL: https://github.com/apache/hudi/pull/7669#discussion_r1090269465 ## hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/commit/FlinkDeletePartitionCommitActionExecutor.java: ## @@ -98,4 +103,43 @@ private List

[GitHub] [hudi] SteNicholas commented on a diff in pull request #7669: [HUDI-5553] Prevent partition(s) from being dropped if there are pending…

2023-01-29 Thread via GitHub
SteNicholas commented on code in PR #7669: URL: https://github.com/apache/hudi/pull/7669#discussion_r1090250986 ## hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/commit/FlinkDeletePartitionCommitActionExecutor.java: ## @@ -98,4 +103,42 @@ private List

[GitHub] [hudi] SteNicholas commented on a diff in pull request #7669: [HUDI-5553] Prevent partition(s) from being dropped if there are pending…

2023-01-29 Thread via GitHub
SteNicholas commented on code in PR #7669: URL: https://github.com/apache/hudi/pull/7669#discussion_r1090246803 ## hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/commit/FlinkDeletePartitionCommitActionExecutor.java: ## @@ -98,4 +103,42 @@ private List

[GitHub] [hudi] SteNicholas commented on a diff in pull request #7669: [HUDI-5553] Prevent partition(s) from being dropped if there are pending…

2023-01-29 Thread via GitHub
SteNicholas commented on code in PR #7669: URL: https://github.com/apache/hudi/pull/7669#discussion_r1090241285 ## hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/commit/FlinkDeletePartitionCommitActionExecutor.java: ## @@ -98,4 +103,42 @@ private List

[GitHub] [hudi] SteNicholas commented on a diff in pull request #7669: [HUDI-5553] Prevent partition(s) from being dropped if there are pending…

2023-01-29 Thread via GitHub
SteNicholas commented on code in PR #7669: URL: https://github.com/apache/hudi/pull/7669#discussion_r1090241285 ## hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/commit/FlinkDeletePartitionCommitActionExecutor.java: ## @@ -98,4 +103,42 @@ private List

[GitHub] [hudi] SteNicholas commented on a diff in pull request #7669: [HUDI-5553] Prevent partition(s) from being dropped if there are pending…

2023-01-29 Thread via GitHub
SteNicholas commented on code in PR #7669: URL: https://github.com/apache/hudi/pull/7669#discussion_r1090241285 ## hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/commit/FlinkDeletePartitionCommitActionExecutor.java: ## @@ -98,4 +103,42 @@ private List

[GitHub] [hudi] SteNicholas commented on a diff in pull request #7669: [HUDI-5553] Prevent partition(s) from being dropped if there are pending…

2023-01-29 Thread via GitHub
SteNicholas commented on code in PR #7669: URL: https://github.com/apache/hudi/pull/7669#discussion_r1090231178 ## hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/commit/FlinkDeletePartitionCommitActionExecutor.java: ## @@ -98,4 +103,42 @@ private List

[GitHub] [hudi] SteNicholas commented on a diff in pull request #7669: [HUDI-5553] Prevent partition(s) from being dropped if there are pending…

2023-01-29 Thread via GitHub
SteNicholas commented on code in PR #7669: URL: https://github.com/apache/hudi/pull/7669#discussion_r1090231178 ## hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/commit/FlinkDeletePartitionCommitActionExecutor.java: ## @@ -98,4 +103,42 @@ private List

[GitHub] [hudi] SteNicholas commented on a diff in pull request #7669: [HUDI-5553] Prevent partition(s) from being dropped if there are pending…

2023-01-29 Thread via GitHub
SteNicholas commented on code in PR #7669: URL: https://github.com/apache/hudi/pull/7669#discussion_r1090227913 ## hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/commit/FlinkDeletePartitionCommitActionExecutor.java: ## @@ -98,4 +103,42 @@ private List

[GitHub] [hudi] SteNicholas commented on a diff in pull request #7669: [HUDI-5553] Prevent partition(s) from being dropped if there are pending…

2023-01-29 Thread via GitHub
SteNicholas commented on code in PR #7669: URL: https://github.com/apache/hudi/pull/7669#discussion_r1090226772 ## hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/commit/FlinkDeletePartitionCommitActionExecutor.java: ## @@ -98,4 +103,42 @@ private List

[GitHub] [hudi] SteNicholas commented on a diff in pull request #7669: [HUDI-5553] Prevent partition(s) from being dropped if there are pending…

2023-01-29 Thread via GitHub
SteNicholas commented on code in PR #7669: URL: https://github.com/apache/hudi/pull/7669#discussion_r1090225408 ## hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/commit/FlinkDeletePartitionCommitActionExecutor.java: ## @@ -98,4 +103,42 @@ private List

[GitHub] [hudi] SteNicholas commented on a diff in pull request #7669: [HUDI-5553] Prevent partition(s) from being dropped if there are pending…

2023-01-29 Thread via GitHub
SteNicholas commented on code in PR #7669: URL: https://github.com/apache/hudi/pull/7669#discussion_r1090216637 ## hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/commit/FlinkDeletePartitionCommitActionExecutor.java: ## @@ -98,4 +103,42 @@ private List

[GitHub] [hudi] SteNicholas commented on a diff in pull request #7669: [HUDI-5553] Prevent partition(s) from being dropped if there are pending…

2023-01-29 Thread via GitHub
SteNicholas commented on code in PR #7669: URL: https://github.com/apache/hudi/pull/7669#discussion_r1090198785 ## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/SparkDeletePartitionCommitActionExecutor.java: ## @@ -18,13 +18,17 @@ package

[GitHub] [hudi] SteNicholas commented on a diff in pull request #7669: [HUDI-5553] Prevent partition(s) from being dropped if there are pending…

2023-01-29 Thread via GitHub
SteNicholas commented on code in PR #7669: URL: https://github.com/apache/hudi/pull/7669#discussion_r1090198502 ## hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/commit/FlinkDeletePartitionCommitActionExecutor.java: ## @@ -18,6 +18,8 @@ package

[GitHub] [hudi] SteNicholas commented on a diff in pull request #7669: [HUDI-5553] Prevent partition(s) from being dropped if there are pending…

2023-01-19 Thread GitBox
SteNicholas commented on code in PR #7669: URL: https://github.com/apache/hudi/pull/7669#discussion_r1082189809 ## hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/commit/FlinkDeletePartitionCommitActionExecutor.java: ## @@ -98,4 +103,42 @@ private List