SteNicholas commented on pull request #2111:
URL: https://github.com/apache/hudi/pull/2111#issuecomment-756519212
@vinothchandar I didn't think the changes of @nsivabalan add different
IOHandle to `HoodieMergeHandle`. We should add `HoodieInsertHandle` inherited
from `HoodieIOHandle` to
SteNicholas commented on pull request #2111:
URL: https://github.com/apache/hudi/pull/2111#issuecomment-733426822
> @SteNicholas still interested in driving this forward?
@vinothchandar , yes, I have discussed with @leesf offline. This week would
be completed.
SteNicholas commented on pull request #2111:
URL: https://github.com/apache/hudi/pull/2111#issuecomment-716095388
> @SteNicholas Please ping me when this is ready again! If you can also
update PR description withe new approach that would be great.
@vinothchandar I'm trying to allow
SteNicholas commented on pull request #2111:
URL: https://github.com/apache/hudi/pull/2111#issuecomment-713335563
> > If user doesn't essentially care about duplicates, I agree that we need
to have same behavior w/o small file handling.
>
> I don't follow this actually. I understand
SteNicholas commented on pull request #2111:
URL: https://github.com/apache/hudi/pull/2111#issuecomment-712566489
> @SteNicholas @leesf : Does this essentially mean we no longer support
small file handling for "inserts" ?
> If user doesn't essentially care about duplicates, I agree that
SteNicholas commented on pull request #2111:
URL: https://github.com/apache/hudi/pull/2111#issuecomment-711103785
@vinothchandar @bvaradar Any concern?
This is an automated message from the Apache Git Service.
To respond to
SteNicholas commented on pull request #2111:
URL: https://github.com/apache/hudi/pull/2111#issuecomment-708985867
> @SteNicholas Thanks for your contribution, left some comments.
Thanks for your comments. I have already followed up with your comments.
Please feel free to review
SteNicholas commented on pull request #2111:
URL: https://github.com/apache/hudi/pull/2111#issuecomment-704795298
@bvaradar @vinothchandar Could you please help to review this pull request?
This is an automated message from
SteNicholas commented on pull request #2111:
URL: https://github.com/apache/hudi/pull/2111#issuecomment-703243458
> > > According to
this（[https://github.com/apache/hudi/issues/2051）](https://github.com/apache/hudi/issues/2051%EF%BC%89)
test。I can't get the results I want。When we set
SteNicholas commented on pull request #2111:
URL: https://github.com/apache/hudi/pull/2111#issuecomment-702550693
@linshan-ma You could use the current commit to check your test case again.
IMO, the current commit has already resolved your problem.
SteNicholas commented on pull request #2111:
URL: https://github.com/apache/hudi/pull/2111#issuecomment-701890658
> > > According to
this（[https://github.com/apache/hudi/issues/2051）](https://github.com/apache/hudi/issues/2051%EF%BC%89)
test。I can't get the results I want。When we set
SteNicholas commented on pull request #2111:
URL: https://github.com/apache/hudi/pull/2111#issuecomment-700524082
> According to
this（[https://github.com/apache/hudi/issues/2051）](https://github.com/apache/hudi/issues/2051%EF%BC%89)
test。I can't get the results I want。When we set
SteNicholas commented on pull request #2111:
URL: https://github.com/apache/hudi/pull/2111#issuecomment-698658606
@leesf @bvaradar Could you please review this pull request?
This is an automated message from the Apache Git
SteNicholas commented on pull request #2111:
URL: https://github.com/apache/hudi/pull/2111#issuecomment-698658606
@leesf @bvaradar Could you please review this pull request?
This is an automated message from the Apache Git
14 matches
Mail list logo
