[GitHub] [hudi] danny0405 commented on a change in pull request #3134: [HUDI-2052] Support load logFile in BootstrapFunction

2021-06-25 Thread GitBox
danny0405 commented on a change in pull request #3134: URL: https://github.com/apache/hudi/pull/3134#discussion_r658615870 ## File path: hudi-flink/src/main/java/org/apache/hudi/sink/bootstrap/BootstrapFunction.java ## @@ -168,32 +175,69 @@ private HoodieFlinkTable getTable()

[GitHub] [hudi] danny0405 commented on a change in pull request #3134: [HUDI-2052] Support load logFile in BootstrapFunction

2021-06-24 Thread GitBox
danny0405 commented on a change in pull request #3134: URL: https://github.com/apache/hudi/pull/3134#discussion_r657867608 ## File path: hudi-flink/src/test/java/org/apache/hudi/sink/TestWriteMergeOnRead.java ## @@ -46,6 +50,11 @@ import java.util.Map; import

[GitHub] [hudi] danny0405 commented on a change in pull request #3134: [HUDI-2052] Support load logFile in BootstrapFunction

2021-06-24 Thread GitBox
danny0405 commented on a change in pull request #3134: URL: https://github.com/apache/hudi/pull/3134#discussion_r657866899 ## File path: hudi-flink/src/test/java/org/apache/hudi/sink/TestWriteMergeOnRead.java ## @@ -83,10 +92,14 @@ protected void checkWrittenData(File

[GitHub] [hudi] danny0405 commented on a change in pull request #3134: [HUDI-2052] Support load logFile in BootstrapFunction

2021-06-24 Thread GitBox
danny0405 commented on a change in pull request #3134: URL: https://github.com/apache/hudi/pull/3134#discussion_r657866899 ## File path: hudi-flink/src/test/java/org/apache/hudi/sink/TestWriteMergeOnRead.java ## @@ -83,10 +92,14 @@ protected void checkWrittenData(File

[GitHub] [hudi] danny0405 commented on a change in pull request #3134: [HUDI-2052] Support load logFile in BootstrapFunction

2021-06-24 Thread GitBox
danny0405 commented on a change in pull request #3134: URL: https://github.com/apache/hudi/pull/3134#discussion_r657673459 ## File path: hudi-flink/src/test/java/org/apache/hudi/sink/TestWriteMergeOnRead.java ## @@ -83,10 +92,76 @@ protected void checkWrittenData(File

[GitHub] [hudi] danny0405 commented on a change in pull request #3134: [HUDI-2052] Support load logFile in BootstrapFunction

2021-06-24 Thread GitBox
danny0405 commented on a change in pull request #3134: URL: https://github.com/apache/hudi/pull/3134#discussion_r657657299 ## File path: hudi-flink/src/test/java/org/apache/hudi/sink/TestWriteMergeOnRead.java ## @@ -83,10 +92,76 @@ protected void checkWrittenData(File

[GitHub] [hudi] danny0405 commented on a change in pull request #3134: [HUDI-2052] Support load logFile in BootstrapFunction

2021-06-23 Thread GitBox
danny0405 commented on a change in pull request #3134: URL: https://github.com/apache/hudi/pull/3134#discussion_r657601079 ## File path: hudi-flink/src/main/java/org/apache/hudi/sink/bootstrap/BootstrapFunction.java ## @@ -168,33 +178,74 @@ private HoodieFlinkTable getTable()

[GitHub] [hudi] danny0405 commented on a change in pull request #3134: [HUDI-2052] Support load logFile in BootstrapFunction

2021-06-23 Thread GitBox
danny0405 commented on a change in pull request #3134: URL: https://github.com/apache/hudi/pull/3134#discussion_r657581213 ## File path: hudi-flink/src/main/java/org/apache/hudi/sink/bootstrap/BootstrapFunction.java ## @@ -197,10 +219,70 @@ private void loadRecords(String