[GitHub] [hudi] leesf commented on a change in pull request #1708: [hudi-1000] fix incremental query for COW non-partitioned table no data

Sat, 06 Jun 2020 02:54:20 -0700 


leesf commented on a change in pull request #1708:
URL: https://github.com/apache/hudi/pull/1708#discussion_r436255512



##########
File path: 
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieParquetInputFormat.java
##########
@@ -183,7 +183,7 @@ protected HoodieDefaultTimeline 
filterInstantsTimeline(HoodieDefaultTimeline tim
       return null;
     }
     String incrementalInputPaths = partitionsToList.stream()
-        .map(s -> tableMetaClient.getBasePath() + Path.SEPARATOR + s)
+        .map(s -> "".equals(s) ? tableMetaClient.getBasePath() : 
tableMetaClient.getBasePath() + Path.SEPARATOR + s)

Review comment:
       `"".equals(s)` would be changed to `StringUtils.isNullOrEmpty`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to