[GitHub] [hudi] lokeshj1703 commented on a diff in pull request #8041: [HUDI-5847] Add support for multiple metric reporters and metric labels

2023-03-02 Thread via GitHub
lokeshj1703 commented on code in PR #8041: URL: https://github.com/apache/hudi/pull/8041#discussion_r1122837033 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/MetricUtils.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [hudi] lokeshj1703 commented on a diff in pull request #8041: [HUDI-5847] Add support for multiple metric reporters and metric labels

2023-02-28 Thread via GitHub
lokeshj1703 commented on code in PR #8041: URL: https://github.com/apache/hudi/pull/8041#discussion_r1119787291 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/MetricUtils.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [hudi] lokeshj1703 commented on a diff in pull request #8041: [HUDI-5847] Add support for multiple metric reporters and metric labels

2023-02-28 Thread via GitHub
lokeshj1703 commented on code in PR #8041: URL: https://github.com/apache/hudi/pull/8041#discussion_r1119787547 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/metrics/HoodieMetricsConfig.java: ## @@ -95,6 +95,12 @@ public class HoodieMetricsConfig

[GitHub] [hudi] lokeshj1703 commented on a diff in pull request #8041: [HUDI-5847] Add support for multiple metric reporters and metric labels

2023-02-28 Thread via GitHub
lokeshj1703 commented on code in PR #8041: URL: https://github.com/apache/hudi/pull/8041#discussion_r1119786931 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/Metrics.java: ## @@ -40,27 +48,51 @@ public class Metrics { private static Metrics instance

[GitHub] [hudi] lokeshj1703 commented on a diff in pull request #8041: [HUDI-5847] Add support for multiple metric reporters and metric labels

2023-02-28 Thread via GitHub
lokeshj1703 commented on code in PR #8041: URL: https://github.com/apache/hudi/pull/8041#discussion_r1119786548 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/Metrics.java: ## @@ -40,27 +48,51 @@ public class Metrics { private static Metrics instance

[GitHub] [hudi] lokeshj1703 commented on a diff in pull request #8041: [HUDI-5847] Add support for multiple metric reporters and metric labels

2023-02-27 Thread via GitHub
lokeshj1703 commented on code in PR #8041: URL: https://github.com/apache/hudi/pull/8041#discussion_r1119632628 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/Metrics.java: ## @@ -40,27 +48,51 @@ public class Metrics { private static Metrics instance