[GitHub] [hudi] lw309637554 commented on pull request #2127: [HUDI-284] add more test for UpdateSchemaEvolution

2020-10-19 Thread GitBox
lw309637554 commented on pull request #2127: URL: https://github.com/apache/hudi/pull/2127#issuecomment-712536085 > @lw309637554 looks like comments from @pratyakshsharma were addressed. sorry about the delay. merging now. Thank you @lw309637554 for adding the cases! Thanks

[GitHub] [hudi] lw309637554 commented on pull request #2127: [HUDI-284] add more test for UpdateSchemaEvolution

2020-10-19 Thread GitBox
lw309637554 commented on pull request #2127: URL: https://github.com/apache/hudi/pull/2127#issuecomment-712104176 @pratyakshsharma @xushiyan @vinothchandar hello, Is there anything that needs to be fixed? This is an

[GitHub] [hudi] lw309637554 commented on pull request #2127: [HUDI-284] add more test for UpdateSchemaEvolution

2020-10-14 Thread GitBox
lw309637554 commented on pull request #2127: URL: https://github.com/apache/hudi/pull/2127#issuecomment-708205243 > Have left few minor comments. @lw309637554 > > Rest looks good. @pratyakshsharma thanks for you review. have resolved your suggestion.

[GitHub] [hudi] lw309637554 commented on pull request #2127: [HUDI-284] add more test for UpdateSchemaEvolution

2020-10-11 Thread GitBox
lw309637554 commented on pull request #2127: URL: https://github.com/apache/hudi/pull/2127#issuecomment-706813674 > lagging a bit. Will take a pass today and circle back. thanks,please help to review This is an

[GitHub] [hudi] lw309637554 commented on pull request #2127: [HUDI-284] add more test for UpdateSchemaEvolution

2020-10-05 Thread GitBox
lw309637554 commented on pull request #2127: URL: https://github.com/apache/hudi/pull/2127#issuecomment-703727376 @vinothchandar all the comments have resolved. 1. pulling the common structure 2. merge these two catch blocks, and simple log

[GitHub] [hudi] lw309637554 commented on pull request #2127: [HUDI-284] add more test for UpdateSchemaEvolution

2020-10-03 Thread GitBox
lw309637554 commented on pull request #2127: URL: https://github.com/apache/hudi/pull/2127#issuecomment-703109022 hello, @xushiyan @pratyakshsharma can you help to review? This is an automated message from the Apache Git

[GitHub] [hudi] lw309637554 commented on pull request #2127: [HUDI-284] add more test for UpdateSchemaEvolution

2020-09-28 Thread GitBox
lw309637554 commented on pull request #2127: URL: https://github.com/apache/hudi/pull/2127#issuecomment-700399285 @vinothchandar hello, can you help review ? This is an automated message from the Apache Git Service. To