[GitHub] [hudi] n3nash commented on pull request #2424: [HUDI-1509]: Reverting LinkedHashSet changes to fix performance degradation for large schemas

2021-01-13 Thread GitBox
n3nash commented on pull request #2424: URL: https://github.com/apache/hudi/pull/2424#issuecomment-759705330 @pratyakshsharma addressed your comments This is an automated message from the Apache Git Service. To respond to

[GitHub] [hudi] n3nash commented on pull request #2424: [HUDI-1509]: Reverting LinkedHashSet changes to fix performance degradation for large schemas

2021-01-11 Thread GitBox
n3nash commented on pull request #2424: URL: https://github.com/apache/hudi/pull/2424#issuecomment-758475039 @pratyakshsharma in that case, can you review this PR ? This is an automated message from the Apache Git Service.

[GitHub] [hudi] n3nash commented on pull request #2424: [HUDI-1509]: Reverting LinkedHashSet changes to fix performance degradation for large schemas

2021-01-11 Thread GitBox
n3nash commented on pull request #2424: URL: https://github.com/apache/hudi/pull/2424#issuecomment-758449461 @pratyakshsharma Do you have a use-case of deleting fields ? What is the reason for supporting deleting fields. Has deleting fields case been tested for all types of cases such as

[GitHub] [hudi] n3nash commented on pull request #2424: [HUDI-1509]: Reverting LinkedHashSet changes to fix performance degradation for large schemas

2021-01-10 Thread GitBox
n3nash commented on pull request #2424: URL: https://github.com/apache/hudi/pull/2424#issuecomment-757572581 @vinothchandar Removing the release blocker since this needs some more changes and the performance degradation is only for large schemas

[GitHub] [hudi] n3nash commented on pull request #2424: [HUDI-1509]: Reverting LinkedHashSet changes to fix performance degradation for large schemas

2021-01-09 Thread GitBox
n3nash commented on pull request #2424: URL: https://github.com/apache/hudi/pull/2424#issuecomment-757402997 @prashantwason can you review this ? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hudi] n3nash commented on pull request #2424: [HUDI-1509]: Reverting LinkedHashSet changes to fix performance degradation for large schemas

2021-01-09 Thread GitBox
n3nash commented on pull request #2424: URL: https://github.com/apache/hudi/pull/2424#issuecomment-757402997 @prashantwason can you review this ? This is an automated message from the Apache Git Service. To respond to the