[GitHub] [hudi] nsivabalan commented on a diff in pull request #7826: [HUDI-5675] fix lazy clean schedule rollback on completed instant

2023-05-07 Thread via GitHub
nsivabalan commented on code in PR #7826: URL: https://github.com/apache/hudi/pull/7826#discussion_r1186918090 ## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/TestHoodieClientMultiWriter.java: ## @@ -545,6 +546,116 @@ public void

[GitHub] [hudi] nsivabalan commented on a diff in pull request #7826: [HUDI-5675] fix lazy clean schedule rollback on completed instant

2023-04-30 Thread via GitHub
nsivabalan commented on code in PR #7826: URL: https://github.com/apache/hudi/pull/7826#discussion_r1181278240 ## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/functional/TestHoodieSparkMergeOnReadTableRollback.java: ## @@ -912,6 +914,62 @@ public void

[GitHub] [hudi] nsivabalan commented on a diff in pull request #7826: [HUDI-5675] fix lazy clean schedule rollback on completed instant

2023-03-17 Thread via GitHub
nsivabalan commented on code in PR #7826: URL: https://github.com/apache/hudi/pull/7826#discussion_r1139797072 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java: ## @@ -707,20 +709,37 @@ protected List

[GitHub] [hudi] nsivabalan commented on a diff in pull request #7826: [HUDI-5675] fix lazy clean schedule rollback on completed instant

2023-02-09 Thread via GitHub
nsivabalan commented on code in PR #7826: URL: https://github.com/apache/hudi/pull/7826#discussion_r1101898172 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java: ## @@ -707,20 +709,33 @@ protected List