[GitHub] [hudi] vaibhav-sinha commented on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-07-02 Thread GitBox
vaibhav-sinha commented on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-872778115 @n3nash Essentially we did two things in this PR. We changed the representation of `timestamp` based LogicalType and added the support for Data/Timestamp based objects in `Tm

[GitHub] [hudi] vaibhav-sinha commented on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-06-14 Thread GitBox
vaibhav-sinha commented on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-860174515 If we don't want to impact the memory footprint of `HoodieRecord`, we have two options: 1. We could convert the value from `timestamp` to `long` when setting `orderin

[GitHub] [hudi] vaibhav-sinha commented on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-05-25 Thread GitBox
vaibhav-sinha commented on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-848098918 The tests were clean except for one test case failing before which I had fixed. But after merging the latest changes from master, I see a lot of tests failing and the errors

[GitHub] [hudi] vaibhav-sinha commented on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-05-23 Thread GitBox
vaibhav-sinha commented on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-846743739 Flink testcase was failing because conversion to Flink TimestampData was not handled. Have pushed a fix for that as well. -- This is an automated message from the Apache Gi