[GitHub] [hudi] vinothchandar commented on a change in pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-08-01 Thread GitBox
vinothchandar commented on a change in pull request #3315: URL: https://github.com/apache/hudi/pull/3315#discussion_r680614863 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java ## @@ -157,6 +157,11 @@ .withDocumentation("When

[GitHub] [hudi] vinothchandar commented on a change in pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
vinothchandar commented on a change in pull request #3315: URL: https://github.com/apache/hudi/pull/3315#discussion_r678653856 ## File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/RealtimeSplit.java ## @@ -34,49 +36,73 @@ */ public interface

[GitHub] [hudi] vinothchandar commented on a change in pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
vinothchandar commented on a change in pull request #3315: URL: https://github.com/apache/hudi/pull/3315#discussion_r678651491 ## File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieRealtimeInputFormatUtils.java ## @@ -87,6 +93,20 @@

[GitHub] [hudi] vinothchandar commented on a change in pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-27 Thread GitBox
vinothchandar commented on a change in pull request #3315: URL: https://github.com/apache/hudi/pull/3315#discussion_r677886161 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/KeyGenUtils.java ## @@ -60,7 +60,7 @@ public static String

[GitHub] [hudi] vinothchandar commented on a change in pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-27 Thread GitBox
vinothchandar commented on a change in pull request #3315: URL: https://github.com/apache/hudi/pull/3315#discussion_r677872797 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/KeyGenUtils.java ## @@ -60,7 +60,7 @@ public static String