[GitHub] [hudi] vinothchandar commented on pull request #1760: [HUDI-1040] Update apis for spark3 compatibility

2020-10-19 Thread GitBox
vinothchandar commented on pull request #1760: URL: https://github.com/apache/hudi/pull/1760#issuecomment-712505539 >we want to make Hudi compile with spark 2 and then run with spark3? this was the intention. but as @bschell pointed out some classes have changed and we need to make

[GitHub] [hudi] vinothchandar commented on pull request #1760: [HUDI-1040] Update apis for spark3 compatibility

2020-10-11 Thread GitBox
vinothchandar commented on pull request #1760: URL: https://github.com/apache/hudi/pull/1760#issuecomment-706791396 @aniejo there are some known issues since some spark APIs have changed in 3. @bschell any updates for us? This is being requested heavily, love to do this sooner if

[GitHub] [hudi] vinothchandar commented on pull request #1760: [HUDI-1040] Update apis for spark3 compatibility

2020-09-30 Thread GitBox
vinothchandar commented on pull request #1760: URL: https://github.com/apache/hudi/pull/1760#issuecomment-701531946 @bschell if you could expand on them, we can hash out a solution. This is an automated message from the

[GitHub] [hudi] vinothchandar commented on pull request #1760: [HUDI-1040] Update apis for spark3 compatibility

2020-09-21 Thread GitBox
vinothchandar commented on pull request #1760: URL: https://github.com/apache/hudi/pull/1760#issuecomment-696264459 @bschell our spark install may be 2.11 on these images. As for hudi_spark_2.12 bundle, if we run integ-test with 2_12, I think it would happen automatically? @bvaradar

[GitHub] [hudi] vinothchandar commented on pull request #1760: [HUDI-1040] Update apis for spark3 compatibility

2020-09-21 Thread GitBox
vinothchandar commented on pull request #1760: URL: https://github.com/apache/hudi/pull/1760#issuecomment-696264459 @bschell our spark install may be 2.11 on these images. As for hudi_spark_2.12 bundle, if we run integ-test with 2_12, I think it would happen automatically? @bvaradar

[GitHub] [hudi] vinothchandar commented on pull request #1760: [HUDI-1040] Update apis for spark3 compatibility

2020-09-02 Thread GitBox
vinothchandar commented on pull request #1760: URL: https://github.com/apache/hudi/pull/1760#issuecomment-685998284 @bschell here's a path forward. - We can create an abstraction for deserializing : `RowDeserializer` and which implements row. deser differently based on spark 2 and

[GitHub] [hudi] vinothchandar commented on pull request #1760: [HUDI-1040] Update apis for spark3 compatibility

2020-09-02 Thread GitBox
vinothchandar commented on pull request #1760: URL: https://github.com/apache/hudi/pull/1760#issuecomment-685864029 May not work actually ``` class A { def doSomething(arg: Int) = { } } @Test def testReflectionPerformance(): Unit = { // warmup

[GitHub] [hudi] vinothchandar commented on pull request #1760: [HUDI-1040] Update apis for spark3 compatibility

2020-08-31 Thread GitBox
vinothchandar commented on pull request #1760: URL: https://github.com/apache/hudi/pull/1760#issuecomment-683872339 @bschell this is a heavily requested feature. are you still working on this? :) This is an automated

[GitHub] [hudi] vinothchandar commented on pull request #1760: [HUDI-1040] Update apis for spark3 compatibility

2020-08-11 Thread GitBox
vinothchandar commented on pull request #1760: URL: https://github.com/apache/hudi/pull/1760#issuecomment-672053354 @bschell is this tested and ready to go? would like to get it into the RC if possible This is an