[GitHub] [hudi] vinothchandar commented on pull request #4206: [HUDI-2923] Fixing metadata table reader when metadata compaction is inflight

2021-12-03 Thread GitBox
vinothchandar commented on pull request #4206: URL: https://github.com/apache/hudi/pull/4206#issuecomment-985973682 @manojpec please address @prashantwason 's comments in the PR you'd open against master. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hudi] vinothchandar commented on pull request #4206: [HUDI-2923] Fixing metadata table reader when metadata compaction is inflight

2021-12-03 Thread GitBox
vinothchandar commented on pull request #4206: URL: https://github.com/apache/hudi/pull/4206#issuecomment-985966269 >Please add a comment to reason the difference in logic between reader and writer code paths All of this logic we are hand rolling here is already take care of for

[GitHub] [hudi] vinothchandar commented on pull request #4206: [HUDI-2923] Fixing metadata table reader when metadata compaction is inflight

2021-12-03 Thread GitBox
vinothchandar commented on pull request #4206: URL: https://github.com/apache/hudi/pull/4206#issuecomment-985964620 >When there is a compaction.requested present, what does getLatestFileSlices return? it returns the a file slice with the compaction instant as the base instant, so