xiarixiaoyao commented on pull request #2722:
URL: https://github.com/apache/hudi/pull/2722#issuecomment-838529283
@vinothchandar ， i have rebased this pr pls check them， thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
xiarixiaoyao commented on pull request #2722:
URL: https://github.com/apache/hudi/pull/2722#issuecomment-837732845
@vinothchandar i will rebase this pr, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
xiarixiaoyao commented on pull request #2722:
URL: https://github.com/apache/hudi/pull/2722#issuecomment-823714627
@lw309637554 @nsivabalan thanks for your review. i will try
testHoodieRealtimeCombineHoodieInputFormat in another pr, since
it has nothing to do with this problem.
--
xiarixiaoyao commented on pull request #2722:
URL: https://github.com/apache/hudi/pull/2722#issuecomment-822129270
@lw309637554 thanks for your reviewer. i left comments for your questions.
Another question:
xiarixiaoyao commented on pull request #2722:
URL: https://github.com/apache/hudi/pull/2722#issuecomment-817071591
@garyli1019 unit test has added， pls review again， thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
xiarixiaoyao commented on pull request #2722:
URL: https://github.com/apache/hudi/pull/2722#issuecomment-811705289
thanks @garyli1019 . ok， i will try to add unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
xiarixiaoyao commented on pull request #2722:
URL: https://github.com/apache/hudi/pull/2722#issuecomment-806722454
@garyli1019 could you pls help me review this pr, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
xiarixiaoyao commented on pull request #2722:
URL: https://github.com/apache/hudi/pull/2722#issuecomment-806721657
test step:
before patch:
step1:
val df = spark.range(0, 10).toDF("keyid")
.withColumn("col3", expr("keyid"))
.withColumn("p", lit(0))
