[GitHub] [hudi] xushiyan commented on pull request #1647: [HUDI-867]: fixed IllegalArgumentException from graphite metrics in deltaStreamer continuous mode

2020-08-31 Thread GitBox
xushiyan commented on pull request #1647: URL: https://github.com/apache/hudi/pull/1647#issuecomment-683982976 yup closing. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hudi] xushiyan commented on pull request #1647: [HUDI-867]: fixed IllegalArgumentException from graphite metrics in deltaStreamer continuous mode

2020-07-11 Thread GitBox
xushiyan commented on pull request #1647: URL: https://github.com/apache/hudi/pull/1647#issuecomment-657116580 @pratyakshsharma yes I think so. Thanks for taking on this! This is an automated message from the Apache Git

[GitHub] [hudi] xushiyan commented on pull request #1647: [HUDI-867]: fixed IllegalArgumentException from graphite metrics in deltaStreamer continuous mode

2020-06-07 Thread GitBox
xushiyan commented on pull request #1647: URL: https://github.com/apache/hudi/pull/1647#issuecomment-640256360 > is it suitable to change to `...` @leesf This is also problematic as `_i` since the metric name is changed. Aggregation works on the same metric name.

[GitHub] [hudi] xushiyan commented on pull request #1647: [HUDI-867]: fixed IllegalArgumentException from graphite metrics in deltaStreamer continuous mode

2020-06-06 Thread GitBox
xushiyan commented on pull request #1647: URL: https://github.com/apache/hudi/pull/1647#issuecomment-640146574 @leesf There is some markdown format issue with your typings...not sure what is suggested. Just to clarify from user perspective. Say a user runs a delta streamer, he

[GitHub] [hudi] xushiyan commented on pull request #1647: [HUDI-867]: fixed IllegalArgumentException from graphite metrics in deltaStreamer continuous mode

2020-06-05 Thread GitBox
xushiyan commented on pull request #1647: URL: https://github.com/apache/hudi/pull/1647#issuecomment-639293627 @pratyakshsharma IIUC, this will introduce infinite number of metrics being sent to monitoring system in theory when it's set to continuous mode? Normally for a Hudi table, we'd