[GitHub] [hudi] xushiyan commented on pull request #1732: [HUDI-1004] Support update metrics in HoodieDeltaStreamerMetrics

2020-07-06 Thread GitBox
xushiyan commented on pull request #1732: URL: https://github.com/apache/hudi/pull/1732#issuecomment-654398864 @vinothchandar @shenh062326 @leesf Glad to see this change merged! This should also fix https://github.com/apache/hudi/pull/1647

[GitHub] [hudi] xushiyan commented on pull request #1732: [HUDI-1004] Support update metrics in HoodieDeltaStreamerMetrics

2020-06-24 Thread GitBox
xushiyan commented on pull request #1732: URL: https://github.com/apache/hudi/pull/1732#issuecomment-649085031 @shenh062326 would be nice to have this tested out in real setup..ignore if you already did it. thanks This is

[GitHub] [hudi] xushiyan commented on pull request #1732: [HUDI-1004] Support update metrics in HoodieDeltaStreamerMetrics

2020-06-19 Thread GitBox
xushiyan commented on pull request #1732: URL: https://github.com/apache/hudi/pull/1732#issuecomment-646856565 > > > Understand the issue originates from `MetricRegistry` not allowing update value for existing metric. By the class design, it does enforce the immutable nature of it. A

[GitHub] [hudi] xushiyan commented on pull request #1732: [HUDI-1004] Support update metrics in HoodieDeltaStreamerMetrics

2020-06-16 Thread GitBox
xushiyan commented on pull request #1732: URL: https://github.com/apache/hudi/pull/1732#issuecomment-644549743 To follow up on the change's ETA https://github.com/dropwizard/metrics/issues/1126#issuecomment-644549170 This