[GitHub] [hudi] xushiyan commented on pull request #1753: [HUDI-896] Report test coverage by modules

2020-06-22 Thread GitBox
xushiyan commented on pull request #1753: URL: https://github.com/apache/hudi/pull/1753#issuecomment-647802515 > is that the record size estimation commit, from gary? It seems so, but I don't think that change itself affected the coverage. it's more likely codecov itself reported

[GitHub] [hudi] xushiyan commented on pull request #1753: [HUDI-896] Report test coverage by modules

2020-06-22 Thread GitBox
xushiyan commented on pull request #1753: URL: https://github.com/apache/hudi/pull/1753#issuecomment-647792654 > > Merging #1753 into master will increase coverage by 42.55%. > > this does seem problematic? @vinothchandar I think the coverage dropped to ~18% at some point in

[GitHub] [hudi] xushiyan commented on pull request #1753: [HUDI-896] Report test coverage by modules

2020-06-21 Thread GitBox
xushiyan commented on pull request #1753: URL: https://github.com/apache/hudi/pull/1753#issuecomment-647142777 @vinothchandar The module split can be adjusted in later phases where we move more functional tests out of unit test tasks and split modules for functional test jobs. The overall