[GitHub] [hudi] yanghua commented on pull request #1779: [HUDI-1062]Remove unnecessary maxEvent check and add some log in KafkaOffsetGen

2020-07-07 Thread GitBox
yanghua commented on pull request #1779: URL: https://github.com/apache/hudi/pull/1779#issuecomment-655214863 > Hi @yanghua ,the test case have been added. Cc @wangxianghu Hi @Trevor-zhang Thanks for addressing my comment. Now, LGTM, let's wait and see if @vinothchandar still has

[GitHub] [hudi] yanghua commented on pull request #1779: [HUDI-1062]Remove unnecessary maxEvent check and add some log in KafkaOffsetGen

2020-07-06 Thread GitBox
yanghua commented on pull request #1779: URL: https://github.com/apache/hudi/pull/1779#issuecomment-654286631 @Trevor-zhang If you want to rebase with the `master` branch, you should invoke these commands: ``` git pull --rebase upstream master git push -f origin xxxbranch

[GitHub] [hudi] yanghua commented on pull request #1779: [HUDI-1062]Remove unnecessary maxEvent check and add some log in KafkaOffsetGen

2020-07-01 Thread GitBox
yanghua commented on pull request #1779: URL: https://github.com/apache/hudi/pull/1779#issuecomment-652767915 @Trevor-zhang pls check the reason why Travis is red. Will merge it, after it turns into green. This is an