[GitHub] [incubator-hudi] dengziming commented on issue #1185: [HUDI-500] Use enum method to replace switch case

2020-01-07 Thread GitBox
dengziming commented on issue #1185: [HUDI-500] Use enum method to replace switch case URL: https://github.com/apache/incubator-hudi/pull/1185#issuecomment-571851785 thank you @bvaradar , I thind you are right, it not a good design to bring to many abstraction layers.

[GitHub] [incubator-hudi] dengziming commented on issue #1185: [HUDI-500] Use enum method to replace switch case

2020-01-06 Thread GitBox
dengziming commented on issue #1185: [HUDI-500] Use enum method to replace switch case URL: https://github.com/apache/incubator-hudi/pull/1185#issuecomment-571409459 @vinothchandar u r right, this change is introducing too many layers to make code awful, maybe should consider more to make

[GitHub] [incubator-hudi] dengziming commented on issue #1185: [HUDI-500] Use enum method to replace switch case

2020-01-04 Thread GitBox
dengziming commented on issue #1185: [HUDI-500] Use enum method to replace switch case URL: https://github.com/apache/incubator-hudi/pull/1185#issuecomment-570886315 > I prefer to keep the code as-is and have this be in the TableMetaClient file. maybe `getCommitActionType` can be

[GitHub] [incubator-hudi] dengziming commented on issue #1185: [HUDI-500] Use enum method to replace switch case

2020-01-04 Thread GitBox
dengziming commented on issue #1185: [HUDI-500] Use enum method to replace switch case URL: https://github.com/apache/incubator-hudi/pull/1185#issuecomment-570883644 > hi @dengziming, WDYT? > > ``` > public enum HoodieTableType { > > COPY_ON_WRITE { >