hddong commented on issue #1157: [HUDI-332]Add operation type
(insert/upsert/bulkinsert/delete) to HoodieCommitMetadata
URL: https://github.com/apache/incubator-hudi/pull/1157#issuecomment-593433072
@bvaradar As you said keep operationType string here, and i had resolve all
conflict.
hddong commented on issue #1157: [HUDI-332]Add operation type
(insert/upsert/bulkinsert/delete) to HoodieCommitMetadata
URL: https://github.com/apache/incubator-hudi/pull/1157#issuecomment-580653102
@bvaradar @vinothchandar please review this again.
hddong commented on issue #1157: [HUDI-332]Add operation type
(insert/upsert/bulkinsert/delete) to HoodieCommitMetadata
URL: https://github.com/apache/incubator-hudi/pull/1157#issuecomment-575021883
@bvaradar I tried what you suggest, but there are some other problems. I
tried another way
hddong commented on issue #1157: [HUDI-332]Add operation type
(insert/upsert/bulkinsert/delete) to HoodieCommitMetadata
URL: https://github.com/apache/incubator-hudi/pull/1157#issuecomment-574938954
@bvaradar this was weird. In my side, this web page shows there are no
conflicts, it's all
hddong commented on issue #1157: [HUDI-332]Add operation type
(insert/upsert/bulkinsert/delete) to HoodieCommitMetadata
URL: https://github.com/apache/incubator-hudi/pull/1157#issuecomment-574427217
@bvaradar @vinothchandar Thanks. rebased this and there are no conflicts now.
hddong commented on issue #1157: [HUDI-332]Add operation type
(insert/upsert/bulkinsert/delete) to HoodieCommitMetadata
URL: https://github.com/apache/incubator-hudi/pull/1157#issuecomment-573482504
> Have some concerns on backwards compatibility.. We don't write commit
metadata as avro ,
hddong commented on issue #1157: [HUDI-332]Add operation type
(insert/upsert/bulkinsert/delete) to HoodieCommitMetadata
URL: https://github.com/apache/incubator-hudi/pull/1157#issuecomment-572918303
@bvaradar Thanks very much for your review, all of them be addressed.
hddong commented on issue #1157: [HUDI-332]Add operation type
(insert/upsert/bulkinsert/delete) to HoodieCommitMetadata
URL: https://github.com/apache/incubator-hudi/pull/1157#issuecomment-572830782
@bvaradar All has been fixed, please review again. And `operationType` now
be `String`,
hddong commented on issue #1157: [HUDI-332]Add operation type
(insert/upsert/bulkinsert/delete) to HoodieCommitMetadata
URL: https://github.com/apache/incubator-hudi/pull/1157#issuecomment-571921938
> @bvaradar Operation type is stored in the avro objects when archiving, but
there are a
hddong commented on issue #1157: [HUDI-332]Add operation type
(insert/upsert/bulkinsert/delete) to HoodieCommitMetadata
URL: https://github.com/apache/incubator-hudi/pull/1157#issuecomment-571521331
@bvaradar Operation type is stored in the avro objects when archiving, but
there are a
hddong commented on issue #1157: [HUDI-332]Add operation type
(insert/upsert/bulkinsert/delete) to HoodieCommitMetadata
URL: https://github.com/apache/incubator-hudi/pull/1157#issuecomment-570159839
@bvaradar please re-review this.
hddong commented on issue #1157: [HUDI-332]Add operation type
(insert/upsert/bulkinsert/delete) to HoodieCommitMetadata
URL: https://github.com/apache/incubator-hudi/pull/1157#issuecomment-569882681
@bvaradar thanks for your review and suggestion, I will modify later.
hddong commented on issue #1157: [HUDI-332]Add operation type
(insert/upsert/bulkinsert/delete) to HoodieCommitMetadata
URL: https://github.com/apache/incubator-hudi/pull/1157#issuecomment-569881431
> @hddong can you explain why add operation type to HoodieCommitMetadata?
thanks
13 matches
Mail list logo