[GitHub] [incubator-hudi] nbalajee commented on issue #1077: [HUDI-335] : Improvements to DiskbasedMap

2019-12-29 Thread GitBox
nbalajee commented on issue #1077: [HUDI-335] : Improvements to DiskbasedMap URL: https://github.com/apache/incubator-hudi/pull/1077#issuecomment-569528285 > @nbalajee But this seems simple enough that we can do ourselves right.. I am bit hesitant to reuse code as-is from Cassandra.. There

[GitHub] [incubator-hudi] nbalajee commented on issue #1077: [HUDI-335] : Improvements to DiskbasedMap

2019-12-23 Thread GitBox
nbalajee commented on issue #1077: [HUDI-335] : Improvements to DiskbasedMap URL: https://github.com/apache/incubator-hudi/pull/1077#issuecomment-568491020 > We already have a `BufferedFSInputStream` in the codebase. Can we see if this can be reused instead? We anyway just read bytes..

[GitHub] [incubator-hudi] nbalajee commented on issue #1077: [HUDI-335] : Improvements to DiskbasedMap

2019-12-16 Thread GitBox
nbalajee commented on issue #1077: [HUDI-335] : Improvements to DiskbasedMap URL: https://github.com/apache/incubator-hudi/pull/1077#issuecomment-566301347 > Is there a JIRA for this work? https://issues.apache.org/jira/browse/HUDI-335

[GitHub] [incubator-hudi] nbalajee commented on issue #1077: [HUDI-335] : Improvements to DiskbasedMap

2019-12-16 Thread GitBox
nbalajee commented on issue #1077: [HUDI-335] : Improvements to DiskbasedMap URL: https://github.com/apache/incubator-hudi/pull/1077#issuecomment-566294609 > Is there a JIRA for this work? Sorry. Missed your comment. Updated header with JIRA id.