[GitHub] [incubator-hudi] nsivabalan commented on pull request #1648: [HUDI-916]: added support for multiple input formats in TimestampBasedKeyGenerator

2020-05-22 Thread GitBox
nsivabalan commented on pull request #1648: URL: https://github.com/apache/incubator-hudi/pull/1648#issuecomment-632683547 Also, for book-keeping purposes, can you fix the description of this patch. I guess you missed to copy from the original.

[GitHub] [incubator-hudi] nsivabalan commented on pull request #1648: [HUDI-916]: added support for multiple input formats in TimestampBasedKeyGenerator

2020-05-21 Thread GitBox
nsivabalan commented on pull request #1648: URL: https://github.com/apache/incubator-hudi/pull/1648#issuecomment-632392315 @pratyakshsharma : was this patch already reviewed as part of[ #1597](https://github.com/apache/incubator-hudi/pull/1597)? or do I need to review it from scratch