Re: [PR] [HUDI-5911] SimpleTransactionDirectMarkerBasedDetectionStrategy can't work with none-partitioned table [hudi]

2023-10-10 Thread via GitHub
bvaradar merged PR #8143: URL: https://github.com/apache/hudi/pull/8143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [HUDI-5911] SimpleTransactionDirectMarkerBasedDetectionStrategy can't work with none-partitioned table [hudi]

2023-10-10 Thread via GitHub
bvaradar commented on PR #8143: URL: https://github.com/apache/hudi/pull/8143#issuecomment-1756611038 Code changes looks good. The test failures are due to flaky master which @codope is looking into. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [HUDI-5911] SimpleTransactionDirectMarkerBasedDetectionStrategy can't work with none-partitioned table [hudi]

2023-10-10 Thread via GitHub
hudi-bot commented on PR #8143: URL: https://github.com/apache/hudi/pull/8143#issuecomment-1754570849 ## CI report: * 6a22bee0577631ab24f55a89519a63c3859f2ead Azure:

Re: [PR] [HUDI-5911] SimpleTransactionDirectMarkerBasedDetectionStrategy can't work with none-partitioned table [hudi]

2023-10-09 Thread via GitHub
hudi-bot commented on PR #8143: URL: https://github.com/apache/hudi/pull/8143#issuecomment-1754337249 ## CI report: * 0bd1545bc12e727c30a08e689c05fcc59c1a Azure:

Re: [PR] [HUDI-5911] SimpleTransactionDirectMarkerBasedDetectionStrategy can't work with none-partitioned table [hudi]

2023-10-09 Thread via GitHub
hudi-bot commented on PR #8143: URL: https://github.com/apache/hudi/pull/8143#issuecomment-1754304659 ## CI report: * 0bd1545bc12e727c30a08e689c05fcc59c1a Azure:

Re: [PR] [HUDI-5911] SimpleTransactionDirectMarkerBasedDetectionStrategy can't work with none-partitioned table [hudi]

2023-10-09 Thread via GitHub
bvaradar commented on PR #8143: URL: https://github.com/apache/hudi/pull/8143#issuecomment-1754300940 @xicm : Doing rebase of this PR. Once the test passes, will land this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [HUDI-5911] SimpleTransactionDirectMarkerBasedDetectionStrategy can't work with none-partitioned table [hudi]

2023-10-09 Thread via GitHub
bvaradar commented on code in PR #8143: URL: https://github.com/apache/hudi/pull/8143#discussion_r1351340612 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/DirectMarkerTransactionManager.java: ## @@ -83,7 +83,7 @@ private static