Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-10 Thread via GitHub
codope merged PR #9581: URL: https://github.com/apache/hudi/pull/9581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-10 Thread via GitHub
codope commented on PR #9581: URL: https://github.com/apache/hudi/pull/9581#issuecomment-1754620283 The docker tests are flaky due to namenode shutting down. It has got nothing to do with the changes in this code. I am trying to fix that in HUDI-6917, #9825 -- This is an automated

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-09 Thread via GitHub
hudi-bot commented on PR #9581: URL: https://github.com/apache/hudi/pull/9581#issuecomment-1754305774 ## CI report: * 391fc1099c8b51221a0448d8ac9d74e3013c1cd1 Azure:

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-09 Thread via GitHub
hudi-bot commented on PR #9581: URL: https://github.com/apache/hudi/pull/9581#issuecomment-1754300024 ## CI report: * 391fc1099c8b51221a0448d8ac9d74e3013c1cd1 Azure:

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-09 Thread via GitHub
hudi-bot commented on PR #9581: URL: https://github.com/apache/hudi/pull/9581#issuecomment-1754287454 ## CI report: * 391fc1099c8b51221a0448d8ac9d74e3013c1cd1 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-09 Thread via GitHub
hudi-bot commented on PR #9581: URL: https://github.com/apache/hudi/pull/9581#issuecomment-1753211609 ## CI report: * 50e495ed1223eaf19ec6f0fd1f00ed13bb3c487f UNKNOWN * 391fc1099c8b51221a0448d8ac9d74e3013c1cd1 Azure:

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-09 Thread via GitHub
hudi-bot commented on PR #9581: URL: https://github.com/apache/hudi/pull/9581#issuecomment-1753135409 ## CI report: * 50e495ed1223eaf19ec6f0fd1f00ed13bb3c487f UNKNOWN * bda7b26fbc477b408e8658eb6e52badeb5c653e0 Azure:

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-09 Thread via GitHub
hudi-bot commented on PR #9581: URL: https://github.com/apache/hudi/pull/9581#issuecomment-1753117528 ## CI report: * 50e495ed1223eaf19ec6f0fd1f00ed13bb3c487f UNKNOWN * bda7b26fbc477b408e8658eb6e52badeb5c653e0 Azure:

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-09 Thread via GitHub
hudi-bot commented on PR #9581: URL: https://github.com/apache/hudi/pull/9581#issuecomment-1752646021 ## CI report: * 50e495ed1223eaf19ec6f0fd1f00ed13bb3c487f UNKNOWN * bda7b26fbc477b408e8658eb6e52badeb5c653e0 Azure:

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-09 Thread via GitHub
hudi-bot commented on PR #9581: URL: https://github.com/apache/hudi/pull/9581#issuecomment-1752568707 ## CI report: * 50e495ed1223eaf19ec6f0fd1f00ed13bb3c487f UNKNOWN * 4ce9d07dea4d5ab3088037461f9fa3b884b64eb6 Azure:

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-09 Thread via GitHub
hudi-bot commented on PR #9581: URL: https://github.com/apache/hudi/pull/9581#issuecomment-1752554282 ## CI report: * 50e495ed1223eaf19ec6f0fd1f00ed13bb3c487f UNKNOWN * 4ce9d07dea4d5ab3088037461f9fa3b884b64eb6 Azure:

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-09 Thread via GitHub
hudi-bot commented on PR #9581: URL: https://github.com/apache/hudi/pull/9581#issuecomment-1752540717 ## CI report: * 50e495ed1223eaf19ec6f0fd1f00ed13bb3c487f UNKNOWN * 4ce9d07dea4d5ab3088037461f9fa3b884b64eb6 Azure:

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-09 Thread via GitHub
codope commented on PR #9581: URL: https://github.com/apache/hudi/pull/9581#issuecomment-1752515071 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-09 Thread via GitHub
hudi-bot commented on PR #9581: URL: https://github.com/apache/hudi/pull/9581#issuecomment-1752481011 ## CI report: * 50e495ed1223eaf19ec6f0fd1f00ed13bb3c487f UNKNOWN * 1a11ff678d2345105879a6faa951c18d94dfa1ba Azure:

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-09 Thread via GitHub
codope commented on code in PR #9581: URL: https://github.com/apache/hudi/pull/9581#discussion_r1349937000 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java: ## @@ -2029,6 +2029,10 @@ public long getLogFileDataBlockMaxSize() {

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-09 Thread via GitHub
codope commented on code in PR #9581: URL: https://github.com/apache/hudi/pull/9581#discussion_r1349936513 ## hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieDeleteBlock.java: ## @@ -65,17 +69,44 @@ public class HoodieDeleteBlock extends HoodieLogBlock {

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-09 Thread via GitHub
codope commented on code in PR #9581: URL: https://github.com/apache/hudi/pull/9581#discussion_r1349935956 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndexUtils.java: ## @@ -173,18 +173,18 @@ public static HoodieRecord tagRecord(HoodieRecord

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-09 Thread via GitHub
codope commented on code in PR #9581: URL: https://github.com/apache/hudi/pull/9581#discussion_r1349935738 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java: ## @@ -752,6 +752,14 @@ public class HoodieWriteConfig extends HoodieConfig

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-09 Thread via GitHub
codope commented on code in PR #9581: URL: https://github.com/apache/hudi/pull/9581#discussion_r1349935195 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bloom/ListBasedHoodieBloomIndexHelper.java: ## @@ -64,22 +64,23 @@ public HoodiePairData

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-06 Thread via GitHub
linliu-code commented on PR #9581: URL: https://github.com/apache/hudi/pull/9581#issuecomment-1751335152 LGTM. The GH CI failure is pretty annoying though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-06 Thread via GitHub
linliu-code commented on code in PR #9581: URL: https://github.com/apache/hudi/pull/9581#discussion_r1349225544 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bloom/ListBasedHoodieBloomIndexHelper.java: ## @@ -64,22 +64,23 @@ public HoodiePairData

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-06 Thread via GitHub
linliu-code commented on code in PR #9581: URL: https://github.com/apache/hudi/pull/9581#discussion_r1349221039 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndexUtils.java: ## @@ -173,18 +173,18 @@ public static HoodieRecord

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-06 Thread via GitHub
linliu-code commented on code in PR #9581: URL: https://github.com/apache/hudi/pull/9581#discussion_r1349221039 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndexUtils.java: ## @@ -173,18 +173,18 @@ public static HoodieRecord

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-06 Thread via GitHub
linliu-code commented on code in PR #9581: URL: https://github.com/apache/hudi/pull/9581#discussion_r1349217024 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java: ## @@ -752,6 +752,14 @@ public class HoodieWriteConfig extends

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-03 Thread via GitHub
codope commented on code in PR #9581: URL: https://github.com/apache/hudi/pull/9581#discussion_r1344501029 ## hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieDeleteBlock.java: ## @@ -65,17 +69,44 @@ public class HoodieDeleteBlock extends HoodieLogBlock {

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-03 Thread via GitHub
hudi-bot commented on PR #9581: URL: https://github.com/apache/hudi/pull/9581#issuecomment-1745488652 ## CI report: * 50e495ed1223eaf19ec6f0fd1f00ed13bb3c487f UNKNOWN * 1a11ff678d2345105879a6faa951c18d94dfa1ba Azure:

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-03 Thread via GitHub
hudi-bot commented on PR #9581: URL: https://github.com/apache/hudi/pull/9581#issuecomment-1745398875 ## CI report: * 50e495ed1223eaf19ec6f0fd1f00ed13bb3c487f UNKNOWN * 20921d8e6034d38eaefb739c021f4324b94f6803 Azure:

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-03 Thread via GitHub
hudi-bot commented on PR #9581: URL: https://github.com/apache/hudi/pull/9581#issuecomment-1745336244 ## CI report: * 50e495ed1223eaf19ec6f0fd1f00ed13bb3c487f UNKNOWN * b1581950ca129d2753c53ec77c0bf046701b2c92 Azure:

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-03 Thread via GitHub
hudi-bot commented on PR #9581: URL: https://github.com/apache/hudi/pull/9581#issuecomment-1745317180 ## CI report: * 50e495ed1223eaf19ec6f0fd1f00ed13bb3c487f UNKNOWN * b1581950ca129d2753c53ec77c0bf046701b2c92 Azure:

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-03 Thread via GitHub
hudi-bot commented on PR #9581: URL: https://github.com/apache/hudi/pull/9581#issuecomment-1744751092 ## CI report: * 50e495ed1223eaf19ec6f0fd1f00ed13bb3c487f UNKNOWN * b1581950ca129d2753c53ec77c0bf046701b2c92 Azure:

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-03 Thread via GitHub
hudi-bot commented on PR #9581: URL: https://github.com/apache/hudi/pull/9581#issuecomment-1744672834 ## CI report: * 50e495ed1223eaf19ec6f0fd1f00ed13bb3c487f UNKNOWN * a3ece047efd3ef23736d5162211c4176f31468e1 Azure:

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-03 Thread via GitHub
hudi-bot commented on PR #9581: URL: https://github.com/apache/hudi/pull/9581#issuecomment-1744656800 ## CI report: * 50e495ed1223eaf19ec6f0fd1f00ed13bb3c487f UNKNOWN * a3ece047efd3ef23736d5162211c4176f31468e1 Azure:

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-03 Thread via GitHub
hudi-bot commented on PR #9581: URL: https://github.com/apache/hudi/pull/9581#issuecomment-1744573109 ## CI report: * 50e495ed1223eaf19ec6f0fd1f00ed13bb3c487f UNKNOWN * a3ece047efd3ef23736d5162211c4176f31468e1 Azure:

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-03 Thread via GitHub
hudi-bot commented on PR #9581: URL: https://github.com/apache/hudi/pull/9581#issuecomment-1744555123 ## CI report: * 50e495ed1223eaf19ec6f0fd1f00ed13bb3c487f UNKNOWN * b71be9bbde91fb6afeb52dfc102ba789963b66ff Azure:

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-03 Thread via GitHub
hudi-bot commented on PR #9581: URL: https://github.com/apache/hudi/pull/9581#issuecomment-1744462777 ## CI report: * 50e495ed1223eaf19ec6f0fd1f00ed13bb3c487f UNKNOWN * e286659cb1e1cb69126b8ec09d4e2a62969ce9d4 Azure:

Re: [PR] [HUDI-6795] Implement writing record_positions to log blocks for updates and deletes [hudi]

2023-10-03 Thread via GitHub
hudi-bot commented on PR #9581: URL: https://github.com/apache/hudi/pull/9581#issuecomment-173328 ## CI report: * 50e495ed1223eaf19ec6f0fd1f00ed13bb3c487f UNKNOWN * e286659cb1e1cb69126b8ec09d4e2a62969ce9d4 Azure: