[
https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16982050#comment-16982050
]
Gurudatt Kulkarni commented on HUDI-354:
[~lamber-ken] Awesome. Will rebase to master. Thanks.
>
[
https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16982033#comment-16982033
]
lamber-ken commented on HUDI-354:
-
Because of it's a big work to do for each new checkstyle rule, so I
[
https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16982020#comment-16982020
]
lamber-ken commented on HUDI-354:
-
hi, [~gurudatt], you can rebase the master branch, and you will see the
[
https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980153#comment-16980153
]
lamber-ken commented on HUDI-354:
-
Okay, I see.
> Introduce stricter comment and code style validation
[
https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980107#comment-16980107
]
Vinoth Chandar commented on HUDI-354:
-
FYI My only rule of thumb around these is to not make
[
https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980105#comment-16980105
]
lamber-ken commented on HUDI-354:
-
Hi, [~vinoth]
When using same checkstyle rule, [~xleesf] and I can go
[
https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980079#comment-16980079
]
lamber-ken commented on HUDI-354:
-
hi, [~gurudatt], the right way is choose between CustomImportOrder and
[
https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980075#comment-16980075
]
Gurudatt Kulkarni commented on HUDI-354:
[~lamber-ken] You don't have to apologize :) . I am new to
[
https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980074#comment-16980074
]
Vinoth Chandar commented on HUDI-354:
-
Took a cursory pass at what the maven-enforcer-plugin does.. Do
[
https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979899#comment-16979899
]
lamber-ken commented on HUDI-354:
-
Sorry, [~gurudatt], the value of option should set *top*, if so
[
https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979881#comment-16979881
]
vinoyang commented on HUDI-354:
---
{quote}I think we also should add maven-enforcer-plugin to limit the maven
[
https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979875#comment-16979875
]
lamber-ken commented on HUDI-354:
-
hi [~gurudatt].
from this official website
[
https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979861#comment-16979861
]
Gurudatt Kulkarni commented on HUDI-354:
[~yanghua] So which rule do we keep? CustomImportOrder /
[
https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979228#comment-16979228
]
lamber-ken commented on HUDI-354:
-
thanks, [~xleesf]
> Introduce stricter comment and code style
[
https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979227#comment-16979227
]
leesf commented on HUDI-354:
Also, when we fix the comment error, should we also fix some semantic errors of
[
https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979225#comment-16979225
]
leesf commented on HUDI-354:
I verified in my local dev. If set_ severity_ property to _info_, the
checkstyle
[
https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979178#comment-16979178
]
vinoyang commented on HUDI-354:
---
[~xleesf] Can you help to verify whether the check-style works fine?
>
[
https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979143#comment-16979143
]
lamber-ken commented on HUDI-354:
-
right
> Introduce stricter comment and code style validation rules
>
[
https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979142#comment-16979142
]
vinoyang commented on HUDI-354:
---
[~lamber-ken] It's strange. It takes effect in my local env. Did you add the
[
https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979133#comment-16979133
]
lamber-ken commented on HUDI-354:
-
hi, I test in my local env just now, it did affect the build process
[
https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979108#comment-16979108
]
vinoyang commented on HUDI-354:
---
[~lamber-ken] welcome to join the refactor work, if you want. It has a lot
[
https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979102#comment-16979102
]
vinoyang commented on HUDI-354:
---
I thought about the idea. However, if we merge the rules before refactoring.
[
https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979098#comment-16979098
]
lamber-ken commented on HUDI-354:
-
hi, [~yanghua]，how about creating a subtask that add the XML code
23 matches
Mail list logo
