[GitHub] [incubator-hudi] lamber-ken commented on issue #1128: [HUDI-453] Fix throw failed to archive commits error when writing data to MOR/COW table

lamber-ken commented on issue #1128: [HUDI-453] Fix throw failed to archive commits error when writing data to MOR/COW table URL: https://github.com/apache/incubator-hudi/pull/1128#issuecomment-602013976 @bwu2 got it, thanks. please track this pr to fix `Not an avro data file ...`

[jira] [Commented] (HUDI-719) Exception during clean phase: Found org.apache.hudi.avro.model.HoodieCleanMetadata, expecting org.apache.hudi.avro.model.HoodieCleanerPlan

[ https://issues.apache.org/jira/browse/HUDI-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063816#comment-17063816 ] lamber-ken commented on HUDI-719: - [~afilipchik] Thanks for reporting these issues during upgrade 0.5.0 to

[jira] [Updated] (HUDI-728) Support for complex record keys with TimestampBasedKeyGenerator

[ https://issues.apache.org/jira/browse/HUDI-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-728: Labels: pull-request-available (was: ) > Support for complex record keys with

[GitHub] [incubator-hudi] pratyakshsharma opened a new pull request #1433: [HUDI-728]: Implement custom key generator

pratyakshsharma opened a new pull request #1433: [HUDI-728]: Implement custom key generator URL: https://github.com/apache/incubator-hudi/pull/1433 ## *Tips* - *Thank you very much for contributing to Apache Hudi.* - *Please review https://hudi.apache.org/contributing.html before

[GitHub] [incubator-hudi] pratyakshsharma commented on issue #1433: [HUDI-728]: Implement custom key generator

pratyakshsharma commented on issue #1433: [HUDI-728]: Implement custom key generator URL: https://github.com/apache/incubator-hudi/pull/1433#issuecomment-602019694 @bvaradar @vinothchandar please have a look and let me know if this looks good.

[incubator-hudi] branch release-0.5.2 updated (3639241 -> 5029888)

This is an automated email from the ASF dual-hosted git repository. vinoyang pushed a change to branch release-0.5.2 in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git. from 3639241 [HUDI-676] Address issues towards removing use of WIP Disclaimer (#1386) add a355c76

[incubator-hudi] 01/02: [HUDI-720] NOTICE file needs to add more content based on the NOTICE files of the ASF projects that hudi bundles (#1417)

This is an automated email from the ASF dual-hosted git repository. vinoyang pushed a commit to branch release-0.5.2 in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git commit 71b5d92a15844ef1847721f2fac21b8a2956a8b7 Author: vinoyang AuthorDate: Sat Mar 21 10:54:04 2020 +0800

[incubator-hudi] 02/02: Bumping release candidate number 2

This is an automated email from the ASF dual-hosted git repository. vinoyang pushed a commit to branch release-0.5.2 in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git commit 5029888db024898e928bf301da2a78a7432ba198 Author: yanghua AuthorDate: Sat Mar 21 16:23:18 2020 +0800

[GitHub] [incubator-hudi] pratyakshsharma commented on issue #1433: [HUDI-728]: Implement custom key generator

pratyakshsharma commented on issue #1433: [HUDI-728]: Implement custom key generator URL: https://github.com/apache/incubator-hudi/pull/1433#issuecomment-602019148 This PR is a currently work in progress. Will be adding more test cases to ensure everything works fine.

[jira] [Assigned] (HUDI-401) Remove unnecessary use of spark in savepoint timeline

[ https://issues.apache.org/jira/browse/HUDI-401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lamber-ken reassigned HUDI-401: --- Assignee: hong dongdong > Remove unnecessary use of spark in savepoint timeline >

[jira] [Updated] (HUDI-728) Support for complex record keys with TimestampBasedKeyGenerator

[ https://issues.apache.org/jira/browse/HUDI-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pratyaksh Sharma updated HUDI-728: -- Status: In Progress (was: Open) > Support for complex record keys with

svn commit: r38576 - in /dev/incubator/hudi/hudi-0.5.2-incubating-rc2: ./ hudi-0.5.2-incubating-rc2.src.tgz hudi-0.5.2-incubating-rc2.src.tgz.asc hudi-0.5.2-incubating-rc2.src.tgz.sha512

Author: vinoyang Date: Sat Mar 21 09:04:21 2020 New Revision: 38576 Log: hudi 0.5.2 incubating rc2 Added: dev/incubator/hudi/hudi-0.5.2-incubating-rc2/ dev/incubator/hudi/hudi-0.5.2-incubating-rc2/hudi-0.5.2-incubating-rc2.src.tgz (with props)

[GitHub] [incubator-hudi] lsyldliu commented on issue #143: Tracking ticket for folks to be added to slack group

lsyldliu commented on issue #143: Tracking ticket for folks to be added to slack group URL: https://github.com/apache/incubator-hudi/issues/143#issuecomment-602024406 Please add: ldliu...@163.com Thanks! This is an automated

[GitHub] [incubator-hudi] lamber-ken edited a comment on issue #1432: [HUDI-716] Exception: Not an Avro data file when running HoodieCleanClient.runClean

lamber-ken edited a comment on issue #1432: [HUDI-716] Exception: Not an Avro data file when running HoodieCleanClient.runClean URL: https://github.com/apache/incubator-hudi/pull/1432#issuecomment-602005682 hi @bvaradar, just `LOG.warn` when met exception, we can't be sure if zero byte

[jira] [Updated] (HUDI-718) java.lang.ClassCastException during upsert

[ https://issues.apache.org/jira/browse/HUDI-718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lamber-ken updated HUDI-718: Attachment: image-2020-03-21-16-49-28-905.png > java.lang.ClassCastException during upsert >

[jira] [Updated] (HUDI-729) Replace JavaSparkContext/SQLContext with SparkSession

[ https://issues.apache.org/jira/browse/HUDI-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lamber-ken updated HUDI-729: Status: Open (was: New) > Replace JavaSparkContext/SQLContext with SparkSession >

[jira] [Created] (HUDI-729) Replace JavaSparkContext/SQLContext with SparkSession

lamber-ken created HUDI-729: --- Summary: Replace JavaSparkContext/SQLContext with SparkSession Key: HUDI-729 URL: https://issues.apache.org/jira/browse/HUDI-729 Project: Apache Hudi (incubating)

[jira] [Assigned] (HUDI-729) Replace JavaSparkContext/SQLContext with SparkSession

[ https://issues.apache.org/jira/browse/HUDI-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lamber-ken reassigned HUDI-729: --- Assignee: lamber-ken > Replace JavaSparkContext/SQLContext with SparkSession >

[GitHub] [incubator-hudi] vinothchandar commented on issue #1430: [hotfix] Improve code quality of HoodieAvroWriteSupport

vinothchandar commented on issue #1430: [hotfix] Improve code quality of HoodieAvroWriteSupport URL: https://github.com/apache/incubator-hudi/pull/1430#issuecomment-602001089 @TisonKun thanks! if you are looking for newbie bugs, there are some tagged on JIRA

[GitHub] [incubator-hudi] lamber-ken commented on issue #1432: [HUDI-716] Exception: Not an Avro data file when running HoodieCleanClient.runClean

lamber-ken commented on issue #1432: [HUDI-716] Exception: Not an Avro data file when running HoodieCleanClient.runClean URL: https://github.com/apache/incubator-hudi/pull/1432#issuecomment-602005682 hi @bvaradar, just `LOG.warn` when met exception, we can't be sure if zero byte files

[jira] [Commented] (HUDI-718) java.lang.ClassCastException during upsert

[ https://issues.apache.org/jira/browse/HUDI-718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063813#comment-17063813 ] lamber-ken commented on HUDI-718: - Hi [~afilipchik], the master version use spark-2.4.4 which dependes on

[jira] [Updated] (HUDI-716) Exception: Not an Avro data file when running HoodieCleanClient.runClean

[ https://issues.apache.org/jira/browse/HUDI-716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-716: Labels: pull-request-available (was: ) > Exception: Not an Avro data file when running

[GitHub] [incubator-hudi] lamber-ken opened a new pull request #1432: [HUDI-716] Exception: Not an Avro data file when running HoodieCleanClient.runClean

lamber-ken opened a new pull request #1432: [HUDI-716] Exception: Not an Avro data file when running HoodieCleanClient.runClean URL: https://github.com/apache/incubator-hudi/pull/1432 ## What is the purpose of the pull request More context, please go ahead with

[incubator-hudi] annotated tag release-0.5.2-incubating-rc2 updated (5029888 -> f9472f0)

This is an automated email from the ASF dual-hosted git repository. vinoyang pushed a change to annotated tag release-0.5.2-incubating-rc2 in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git. *** WARNING: tag release-0.5.2-incubating-rc2 was modified! *** from 5029888

[jira] [Updated] (HUDI-729) Replace JavaSparkContext/SQLContext with SparkSession

[ https://issues.apache.org/jira/browse/HUDI-729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lamber-ken updated HUDI-729: Status: In Progress (was: Open) > Replace JavaSparkContext/SQLContext with SparkSession >

[GitHub] [incubator-hudi] pratyakshsharma opened a new pull request #1434: [HUDI-616]: fixed parquet files getting created on local FS

pratyakshsharma opened a new pull request #1434: [HUDI-616]: fixed parquet files getting created on local FS URL: https://github.com/apache/incubator-hudi/pull/1434 ## *Tips* - *Thank you very much for contributing to Apache Hudi.* - *Please review

[jira] [Updated] (HUDI-616) Parquet files not getting created on DFS docker instance but on local FS in TestHoodieDeltaStreamer

[ https://issues.apache.org/jira/browse/HUDI-616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-616: Labels: pull-request-available (was: ) > Parquet files not getting created on DFS docker instance

[GitHub] [incubator-hudi] zhaomin1423 commented on issue #1435: [MINOR]cleanup redundant comment

zhaomin1423 commented on issue #1435: [MINOR]cleanup redundant comment URL: https://github.com/apache/incubator-hudi/pull/1435#issuecomment-602039602 There is a redundant comment. Please help me review, thanks. @leesf This

[GitHub] [incubator-hudi] pratyakshsharma commented on issue #1150: [HUDI-288]: Add support for ingesting multiple kafka streams in a single DeltaStreamer deployment

pratyakshsharma commented on issue #1150: [HUDI-288]: Add support for ingesting multiple kafka streams in a single DeltaStreamer deployment URL: https://github.com/apache/incubator-hudi/pull/1150#issuecomment-602030510 @bvaradar done. Please have a look.

[GitHub] [incubator-hudi] zhaomin1423 commented on a change in pull request #1435: [MINOR]cleanup redundant comment and code, and fix typo

zhaomin1423 commented on a change in pull request #1435: [MINOR]cleanup redundant comment and code, and fix typo URL: https://github.com/apache/incubator-hudi/pull/1435#discussion_r396001152 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/Source.java

[GitHub] [incubator-hudi] zhaomin1423 opened a new pull request #1435: [MINOR]cleanup redundant comment

zhaomin1423 opened a new pull request #1435: [MINOR]cleanup redundant comment URL: https://github.com/apache/incubator-hudi/pull/1435 ## What is the purpose of the pull request cleanup redundant comment ## Brief change log cleanup redundant comment in

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1435: [MINOR]cleanup redundant comment and code, and fix typo

vinothchandar commented on a change in pull request #1435: [MINOR]cleanup redundant comment and code, and fix typo URL: https://github.com/apache/incubator-hudi/pull/1435#discussion_r395999633 ## File path:

[jira] [Commented] (HUDI-686) Implement BloomIndexV2 that does not depend on memory caching

[ https://issues.apache.org/jira/browse/HUDI-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063938#comment-17063938 ] Vinoth Chandar commented on HUDI-686: - On second thoughts, I think its useful to have this for

[GitHub] [incubator-hudi] xushiyan commented on a change in pull request #1436: [HUDI-711] Refactor exporter main logic

xushiyan commented on a change in pull request #1436: [HUDI-711] Refactor exporter main logic URL: https://github.com/apache/incubator-hudi/pull/1436#discussion_r396038953 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieSnapshotExporter.java ##

[jira] [Updated] (HUDI-711) Exporter copy method gets passed wrong file list

[ https://issues.apache.org/jira/browse/HUDI-711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raymond Xu updated HUDI-711: Status: Open (was: New) > Exporter copy method gets passed wrong file list >

[jira] [Updated] (HUDI-711) Exporter copy method gets passed wrong file list

[ https://issues.apache.org/jira/browse/HUDI-711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raymond Xu updated HUDI-711: Status: In Progress (was: Open) > Exporter copy method gets passed wrong file list >

[jira] [Assigned] (HUDI-711) Exporter copy method gets passed wrong file list

[ https://issues.apache.org/jira/browse/HUDI-711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raymond Xu reassigned HUDI-711: --- Assignee: Raymond Xu > Exporter copy method gets passed wrong file list >

[GitHub] [incubator-hudi] xushiyan commented on a change in pull request #1436: [HUDI-711] Refactor exporter main logic

xushiyan commented on a change in pull request #1436: [HUDI-711] Refactor exporter main logic URL: https://github.com/apache/incubator-hudi/pull/1436#discussion_r396039169 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieSnapshotExporter.java ##

[jira] [Updated] (HUDI-711) Exporter copy method gets passed wrong file list

[ https://issues.apache.org/jira/browse/HUDI-711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-711: Labels: pull-request-available (was: ) > Exporter copy method gets passed wrong file list >

[GitHub] [incubator-hudi] xushiyan opened a new pull request #1436: [HUDI-711] Refactor exporter main logic

xushiyan opened a new pull request #1436: [HUDI-711] Refactor exporter main logic URL: https://github.com/apache/incubator-hudi/pull/1436 * break main method into multiple readable methods * fix bug of passing wrong file list ## Verify this pull request This pull request

[jira] [Assigned] (HUDI-730) Fix the ci error log message

[ https://issues.apache.org/jira/browse/HUDI-730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lamber-ken reassigned HUDI-730: --- Assignee: lamber-ken > Fix the ci error log message > > >

[jira] [Created] (HUDI-730) Fix the ci error log message

lamber-ken created HUDI-730: --- Summary: Fix the ci error log message Key: HUDI-730 URL: https://issues.apache.org/jira/browse/HUDI-730 Project: Apache Hudi (incubating) Issue Type: Bug

[jira] [Updated] (HUDI-730) Fix the ci error log message

[ https://issues.apache.org/jira/browse/HUDI-730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lamber-ken updated HUDI-730: Status: Open (was: New) > Fix the ci error log message > > >

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1436: [HUDI-711] Refactor exporter main logic

codecov-io edited a comment on issue #1436: [HUDI-711] Refactor exporter main logic URL: https://github.com/apache/incubator-hudi/pull/1436#issuecomment-602121990 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1436?src=pr=h1) Report > Merging

[GitHub] [incubator-hudi] xushiyan commented on a change in pull request #1436: [HUDI-711] Refactor exporter main logic

xushiyan commented on a change in pull request #1436: [HUDI-711] Refactor exporter main logic URL: https://github.com/apache/incubator-hudi/pull/1436#discussion_r396039049 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieSnapshotExporter.java ##

[GitHub] [incubator-hudi] xushiyan commented on a change in pull request #1436: [HUDI-711] Refactor exporter main logic

xushiyan commented on a change in pull request #1436: [HUDI-711] Refactor exporter main logic URL: https://github.com/apache/incubator-hudi/pull/1436#discussion_r396039049 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieSnapshotExporter.java ##

[GitHub] [incubator-hudi] hddong commented on a change in pull request #1424: [HUDI-697]Add unit test for ArchivedCommitsCommand

hddong commented on a change in pull request #1424: [HUDI-697]Add unit test for ArchivedCommitsCommand URL: https://github.com/apache/incubator-hudi/pull/1424#discussion_r396048962 ## File path: hudi-cli/src/test/java/org/apache/hudi/cli/common/HoodieTestCommitOperate.java

[GitHub] [incubator-hudi] hddong commented on a change in pull request #1424: [HUDI-697]Add unit test for ArchivedCommitsCommand

hddong commented on a change in pull request #1424: [HUDI-697]Add unit test for ArchivedCommitsCommand URL: https://github.com/apache/incubator-hudi/pull/1424#discussion_r396048962 ## File path: hudi-cli/src/test/java/org/apache/hudi/cli/common/HoodieTestCommitOperate.java

Build failed in Jenkins: hudi-snapshot-deployment-0.5 #224

See Changes: -- [...truncated 2.38 KB...] /home/jenkins/tools/maven/apache-maven-3.5.4/conf: logging settings.xml toolchains.xml

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1409: [HUDI-714]Add javadoc and comments to hudi write method link

codecov-io edited a comment on issue #1409: [HUDI-714]Add javadoc and comments to hudi write method link URL: https://github.com/apache/incubator-hudi/pull/1409#issuecomment-599323873 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1409?src=pr=h1) Report > Merging

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1409: [HUDI-714]Add javadoc and comments to hudi write method link

codecov-io edited a comment on issue #1409: [HUDI-714]Add javadoc and comments to hudi write method link URL: https://github.com/apache/incubator-hudi/pull/1409#issuecomment-599323873 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1409?src=pr=h1) Report > Merging

[GitHub] [incubator-hudi] wangxianghu commented on a change in pull request #1409: [HUDI-714]Add javadoc and comments to hudi write method link

wangxianghu commented on a change in pull request #1409: [HUDI-714]Add javadoc and comments to hudi write method link URL: https://github.com/apache/incubator-hudi/pull/1409#discussion_r396046670 ## File path:

[GitHub] [incubator-hudi] xushiyan commented on issue #1436: [HUDI-711] Refactor exporter main logic

xushiyan commented on issue #1436: [HUDI-711] Refactor exporter main logic URL: https://github.com/apache/incubator-hudi/pull/1436#issuecomment-602121223 @leesf @vinothchandar To align with other utility tools, I'd also like to pass `JavaSparkContext` instead of `SparkSession` to the main,

[GitHub] [incubator-hudi] xushiyan edited a comment on issue #1436: [HUDI-711] Refactor exporter main logic

xushiyan edited a comment on issue #1436: [HUDI-711] Refactor exporter main logic URL: https://github.com/apache/incubator-hudi/pull/1436#issuecomment-602121223 @leesf @vinothchandar To align with other utility tools, I'd also like to make another commit to pass `JavaSparkContext` instead

[GitHub] [incubator-hudi] wangxianghu commented on a change in pull request #1409: [HUDI-714]Add javadoc and comments to hudi write method link

wangxianghu commented on a change in pull request #1409: [HUDI-714]Add javadoc and comments to hudi write method link URL: https://github.com/apache/incubator-hudi/pull/1409#discussion_r396046670 ## File path:

[GitHub] [incubator-hudi] hddong commented on a change in pull request #1424: [HUDI-697]Add unit test for ArchivedCommitsCommand

hddong commented on a change in pull request #1424: [HUDI-697]Add unit test for ArchivedCommitsCommand URL: https://github.com/apache/incubator-hudi/pull/1424#discussion_r396047382 ## File path: hudi-cli/src/test/java/org/apache/hudi/cli/common/HoodieTestCommitOperate.java

[GitHub] [incubator-hudi] hddong commented on a change in pull request #1424: [HUDI-697]Add unit test for ArchivedCommitsCommand

hddong commented on a change in pull request #1424: [HUDI-697]Add unit test for ArchivedCommitsCommand URL: https://github.com/apache/incubator-hudi/pull/1424#discussion_r396047382 ## File path: hudi-cli/src/test/java/org/apache/hudi/cli/common/HoodieTestCommitOperate.java

[GitHub] [incubator-hudi] hddong commented on a change in pull request #1424: [HUDI-697]Add unit test for ArchivedCommitsCommand

hddong commented on a change in pull request #1424: [HUDI-697]Add unit test for ArchivedCommitsCommand URL: https://github.com/apache/incubator-hudi/pull/1424#discussion_r396047382 ## File path: hudi-cli/src/test/java/org/apache/hudi/cli/common/HoodieTestCommitOperate.java

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1409: [HUDI-714]Add javadoc and comments to hudi write method link

nsivabalan commented on a change in pull request #1409: [HUDI-714]Add javadoc and comments to hudi write method link URL: https://github.com/apache/incubator-hudi/pull/1409#discussion_r396041291 ## File path: hudi-spark/src/main/java/org/apache/hudi/DataSourceUtils.java ##

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1409: [HUDI-714]Add javadoc and comments to hudi write method link

nsivabalan commented on a change in pull request #1409: [HUDI-714]Add javadoc and comments to hudi write method link URL: https://github.com/apache/incubator-hudi/pull/1409#discussion_r396041376 ## File path: hudi-spark/src/main/java/org/apache/hudi/DataSourceUtils.java ##

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1409: [HUDI-714]Add javadoc and comments to hudi write method link

nsivabalan commented on a change in pull request #1409: [HUDI-714]Add javadoc and comments to hudi write method link URL: https://github.com/apache/incubator-hudi/pull/1409#discussion_r396041231 ## File path:

[GitHub] [incubator-hudi] hddong commented on a change in pull request #1424: [HUDI-697]Add unit test for ArchivedCommitsCommand

hddong commented on a change in pull request #1424: [HUDI-697]Add unit test for ArchivedCommitsCommand URL: https://github.com/apache/incubator-hudi/pull/1424#discussion_r396046914 ## File path: hudi-cli/src/test/java/org/apache/hudi/cli/common/HoodieTestCommitOperate.java

[GitHub] [incubator-hudi] wangxianghu commented on a change in pull request #1409: [HUDI-714]Add javadoc and comments to hudi write method link

wangxianghu commented on a change in pull request #1409: [HUDI-714]Add javadoc and comments to hudi write method link URL: https://github.com/apache/incubator-hudi/pull/1409#discussion_r396046995 ## File path: hudi-spark/src/main/java/org/apache/hudi/DataSourceUtils.java

[GitHub] [incubator-hudi] wangxianghu commented on a change in pull request #1409: [HUDI-714]Add javadoc and comments to hudi write method link

wangxianghu commented on a change in pull request #1409: [HUDI-714]Add javadoc and comments to hudi write method link URL: https://github.com/apache/incubator-hudi/pull/1409#discussion_r396046995 ## File path: hudi-spark/src/main/java/org/apache/hudi/DataSourceUtils.java

[GitHub] [incubator-hudi] hddong commented on a change in pull request #1424: [HUDI-697]Add unit test for ArchivedCommitsCommand

hddong commented on a change in pull request #1424: [HUDI-697]Add unit test for ArchivedCommitsCommand URL: https://github.com/apache/incubator-hudi/pull/1424#discussion_r396048302 ## File path: hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestArchivedCommitsCommand.java

[GitHub] [incubator-hudi] hddong commented on a change in pull request #1424: [HUDI-697]Add unit test for ArchivedCommitsCommand

hddong commented on a change in pull request #1424: [HUDI-697]Add unit test for ArchivedCommitsCommand URL: https://github.com/apache/incubator-hudi/pull/1424#discussion_r396048282 ## File path: hudi-cli/src/test/java/org/apache/hudi/cli/common/HoodieTestCommandDataGenerator.java

[GitHub] [incubator-hudi] vinothchandar commented on issue #1416: [HUDI-717] Fixed usage of HiveDriver for DDL statements for Hive 2.x

vinothchandar commented on issue #1416: [HUDI-717] Fixed usage of HiveDriver for DDL statements for Hive 2.x URL: https://github.com/apache/incubator-hudi/pull/1416#issuecomment-602140887 @umehrot2 and @zhedoubushishi as well, who have touched this area before.

[incubator-hudi] branch master updated: [MINOR] cleanup redundant comment and unused variable and fix typo (#1435)

This is an automated email from the ASF dual-hosted git repository. vinoth pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git The following commit(s) were added to refs/heads/master by this push: new 8b00791 [MINOR] cleanup redundant

[GitHub] [incubator-hudi] vinothchandar merged pull request #1435: [MINOR] cleanup redundant comment and unused variable, and fix typo

vinothchandar merged pull request #1435: [MINOR] cleanup redundant comment and unused variable, and fix typo URL: https://github.com/apache/incubator-hudi/pull/1435 This is an automated message from the Apache Git Service.

[GitHub] [incubator-hudi] wangxianghu commented on a change in pull request #1409: [HUDI-714]Add javadoc and comments to hudi write method link

wangxianghu commented on a change in pull request #1409: [HUDI-714]Add javadoc and comments to hudi write method link URL: https://github.com/apache/incubator-hudi/pull/1409#discussion_r396046670 ## File path:

[GitHub] [incubator-hudi] codecov-io commented on issue #1436: [HUDI-711] Refactor exporter main logic

codecov-io commented on issue #1436: [HUDI-711] Refactor exporter main logic URL: https://github.com/apache/incubator-hudi/pull/1436#issuecomment-602121990 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1436?src=pr=h1) Report > Merging

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1436: [HUDI-711] Refactor exporter main logic

codecov-io edited a comment on issue #1436: [HUDI-711] Refactor exporter main logic URL: https://github.com/apache/incubator-hudi/pull/1436#issuecomment-602121990 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1436?src=pr=h1) Report > Merging

[GitHub] [incubator-hudi] codecov-io commented on issue #1435: [MINOR]cleanup redundant comment and unused variable, and fix typo

codecov-io commented on issue #1435: [MINOR]cleanup redundant comment and unused variable, and fix typo URL: https://github.com/apache/incubator-hudi/pull/1435#issuecomment-602135055 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1435?src=pr=h1) Report > Merging

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1435: [MINOR]cleanup redundant comment and unused variable, and fix typo

codecov-io edited a comment on issue #1435: [MINOR]cleanup redundant comment and unused variable, and fix typo URL: https://github.com/apache/incubator-hudi/pull/1435#issuecomment-602135055 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1435?src=pr=h1) Report > Merging

[GitHub] [incubator-hudi] wangxianghu commented on a change in pull request #1409: [HUDI-714]Add javadoc and comments to hudi write method link

wangxianghu commented on a change in pull request #1409: [HUDI-714]Add javadoc and comments to hudi write method link URL: https://github.com/apache/incubator-hudi/pull/1409#discussion_r396046725 ## File path: hudi-spark/src/main/java/org/apache/hudi/DataSourceUtils.java

[GitHub] [incubator-hudi] hddong commented on a change in pull request #1424: [HUDI-697]Add unit test for ArchivedCommitsCommand

hddong commented on a change in pull request #1424: [HUDI-697]Add unit test for ArchivedCommitsCommand URL: https://github.com/apache/incubator-hudi/pull/1424#discussion_r396047382 ## File path: hudi-cli/src/test/java/org/apache/hudi/cli/common/HoodieTestCommitOperate.java

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java

vinothchandar commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java URL: https://github.com/apache/incubator-hudi/pull/1350#discussion_r396049715 ## File path:

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java

vinothchandar commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java URL: https://github.com/apache/incubator-hudi/pull/1350#discussion_r396049725 ## File path:

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1424: [HUDI-697]Add unit test for ArchivedCommitsCommand

codecov-io edited a comment on issue #1424: [HUDI-697]Add unit test for ArchivedCommitsCommand URL: https://github.com/apache/incubator-hudi/pull/1424#issuecomment-601586198 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1424?src=pr=h1) Report > Merging

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1424: [HUDI-697]Add unit test for ArchivedCommitsCommand

codecov-io edited a comment on issue #1424: [HUDI-697]Add unit test for ArchivedCommitsCommand URL: https://github.com/apache/incubator-hudi/pull/1424#issuecomment-601586198 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1424?src=pr=h1) Report > Merging

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1159: [HUDI-479] Eliminate or Minimize use of Guava if possible

codecov-io edited a comment on issue #1159: [HUDI-479] Eliminate or Minimize use of Guava if possible URL: https://github.com/apache/incubator-hudi/pull/1159#issuecomment-596089314 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1159?src=pr=h1) Report > Merging

[GitHub] [incubator-hudi] wangxianghu commented on a change in pull request #1409: [HUDI-714]Add javadoc and comments to hudi write method link

wangxianghu commented on a change in pull request #1409: [HUDI-714]Add javadoc and comments to hudi write method link URL: https://github.com/apache/incubator-hudi/pull/1409#discussion_r396046725 ## File path: hudi-spark/src/main/java/org/apache/hudi/DataSourceUtils.java

[GitHub] [incubator-hudi] wangxianghu commented on a change in pull request #1409: [HUDI-714]Add javadoc and comments to hudi write method link

wangxianghu commented on a change in pull request #1409: [HUDI-714]Add javadoc and comments to hudi write method link URL: https://github.com/apache/incubator-hudi/pull/1409#discussion_r396046670 ## File path: