[GitHub] [hudi] hudi-bot edited a comment on pull request #3120: [HUDI-2045] Support Read Hoodie As DataSource Table For Flink And Del…

2021-07-05 Thread GitBox
hudi-bot edited a comment on pull request #3120: URL: https://github.com/apache/hudi/pull/3120#issuecomment-864760893 ## CI report: * aaca30fffd1ea37f803f51ef3cf49c59ed79badc UNKNOWN * fcd06c8bccfc90b272b51d3511094e6617ec25bd UNKNOWN * 96947d0419df5f8bab10072eb64afecd29326e5

[GitHub] [hudi] hudi-bot edited a comment on pull request #3226: [HUDI-2135] Add compaction schedule option for flink

2021-07-05 Thread GitBox
hudi-bot edited a comment on pull request #3226: URL: https://github.com/apache/hudi/pull/3226#issuecomment-874418767 ## CI report: * 42cc9e664adb83ea2d9f34a622ba336334fe0611 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/res

[GitHub] [hudi] swuferhong closed pull request #3227: [HUDI-2136] Fix packet conflict when flink-sql-connector-hive and hud…

2021-07-05 Thread GitBox
swuferhong closed pull request #3227: URL: https://github.com/apache/hudi/pull/3227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [hudi] vinothchandar merged pull request #3194: [HUDI-2028] Implement RockDbBasedMap as an alternate to DiskBasedMap in ExternalSpillableMap

2021-07-05 Thread GitBox
vinothchandar merged pull request #3194: URL: https://github.com/apache/hudi/pull/3194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3227: [HUDI-2136] Fix packet conflict when flink-sql-connector-hive and hud…

2021-07-05 Thread GitBox
codecov-commenter edited a comment on pull request #3227: URL: https://github.com/apache/hudi/pull/3227#issuecomment-874434905 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3227?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The

[GitHub] [hudi] garyli1019 merged pull request #3226: [HUDI-2135] Add compaction schedule option for flink

2021-07-05 Thread GitBox
garyli1019 merged pull request #3226: URL: https://github.com/apache/hudi/pull/3226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [hudi] sbernauer commented on pull request #3129: [HUDI-2055] Added metric for time of lastSync

2021-07-05 Thread GitBox
sbernauer commented on pull request #3129: URL: https://github.com/apache/hudi/pull/3129#issuecomment-874491568 Hi together, it would be great if we could get this merged! Thanks in advance, Sebastian -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [hudi] yanghua merged pull request #3200: [HUDI-2111] [DOC] Update docs about bootstrap support configure KeyGenerato…

2021-07-05 Thread GitBox
yanghua merged pull request #3200: URL: https://github.com/apache/hudi/pull/3200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[GitHub] [hudi] vinothchandar commented on pull request #3122: [HUDI-2048] HoodieRealtimeInputFormatUtils#groupLogsByBaseFile throws…

2021-07-05 Thread GitBox
vinothchandar commented on pull request #3122: URL: https://github.com/apache/hudi/pull/3122#issuecomment-874493680 Does #3203 solve this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [hudi] sbernauer commented on pull request #3172: [HUDI-2069] Refactored String constants

2021-07-05 Thread GitBox
sbernauer commented on pull request #3172: URL: https://github.com/apache/hudi/pull/3172#issuecomment-874494071 I should have addressed all feedback. We have tested this patch again and have rolled it out to production. Can you please have a look if everything is fine? -- This is an a

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3227: [HUDI-2136] Fix packet conflict when flink-sql-connector-hive and hud…

2021-07-05 Thread GitBox
codecov-commenter edited a comment on pull request #3227: URL: https://github.com/apache/hudi/pull/3227#issuecomment-874434905 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3227?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The

[GitHub] [hudi] vinothchandar commented on a change in pull request #3122: [HUDI-2048] HoodieRealtimeInputFormatUtils#groupLogsByBaseFile throws…

2021-07-05 Thread GitBox
vinothchandar commented on a change in pull request #3122: URL: https://github.com/apache/hudi/pull/3122#discussion_r664267191 ## File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieParquetInputFormat.java ## @@ -209,6 +210,12 @@ public Configuration getConf()

[GitHub] [hudi] vinothchandar commented on a change in pull request #3129: [HUDI-2055] Added metric for time of lastSync

2021-07-05 Thread GitBox
vinothchandar commented on a change in pull request #3129: URL: https://github.com/apache/hudi/pull/3129#discussion_r664270772 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java ## @@ -289,6 +289,8 @@ public void refreshTimeline()

[GitHub] [hudi] vinothchandar merged pull request #3129: [HUDI-2055] Added metric for time of lastSync

2021-07-05 Thread GitBox
vinothchandar merged pull request #3129: URL: https://github.com/apache/hudi/pull/3129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [hudi] danny0405 commented on a change in pull request #3122: [HUDI-2048] HoodieRealtimeInputFormatUtils#groupLogsByBaseFile throws…

2021-07-05 Thread GitBox
danny0405 commented on a change in pull request #3122: URL: https://github.com/apache/hudi/pull/3122#discussion_r664272560 ## File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieRealtimeInputFormatUtils.java ## @@ -102,28 +105,37 @@ HoodieTi

[GitHub] [hudi] vinothchandar commented on pull request #3121: [HUDI-2046]Loaded too many classes like sun/reflect/GeneratedSerializationConstructorAccessor in JVM metaspace

2021-07-05 Thread GitBox
vinothchandar commented on pull request #3121: URL: https://github.com/apache/hudi/pull/3121#issuecomment-874499764 This is a refreshing jvm level fix after a while :) . Thanks @dwshmilyss for confirming! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [hudi] vinothchandar merged pull request #3121: [HUDI-2046]Loaded too many classes like sun/reflect/GeneratedSerializationConstructorAccessor in JVM metaspace

2021-07-05 Thread GitBox
vinothchandar merged pull request #3121: URL: https://github.com/apache/hudi/pull/3121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [hudi] vinothchandar merged pull request #3097: [HUDI-1996] Adding functionality to allow the providing of basic auth creds for confluent cloud schema registry

2021-07-05 Thread GitBox
vinothchandar merged pull request #3097: URL: https://github.com/apache/hudi/pull/3097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [hudi] vinothchandar commented on pull request #3204: [HUDI-2113] Fix integration testing failure caused by sql results out…

2021-07-05 Thread GitBox
vinothchandar commented on pull request #3204: URL: https://github.com/apache/hudi/pull/3204#issuecomment-874502095 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [hudi] vinothchandar commented on pull request #3204: [HUDI-2113] Fix integration testing failure caused by sql results out…

2021-07-05 Thread GitBox
vinothchandar commented on pull request #3204: URL: https://github.com/apache/hudi/pull/3204#issuecomment-874502352 seems related to https://issues.apache.org/jira/browse/HUDI-1989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [hudi] danny0405 commented on pull request #3122: [HUDI-2048] HoodieRealtimeInputFormatUtils#groupLogsByBaseFile throws…

2021-07-05 Thread GitBox
danny0405 commented on pull request #3122: URL: https://github.com/apache/hudi/pull/3122#issuecomment-874503060 > Does #3203 solve this? I think it should, would just close this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hudi] danny0405 closed pull request #3122: [HUDI-2048] HoodieRealtimeInputFormatUtils#groupLogsByBaseFile throws…

2021-07-05 Thread GitBox
danny0405 closed pull request #3122: URL: https://github.com/apache/hudi/pull/3122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [hudi] hudi-bot edited a comment on pull request #3204: [HUDI-2113] Fix integration testing failure caused by sql results out…

2021-07-05 Thread GitBox
hudi-bot edited a comment on pull request #3204: URL: https://github.com/apache/hudi/pull/3204#issuecomment-872103083 ## CI report: * 77b28cfdc6e32bbe814f7458eb550328b97536ac UNKNOWN * 294dce2a9f868f77dbd6749664ae6343ae42c739 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3227: [HUDI-2136] Fix packet conflict when flink-sql-connector-hive and hud…

2021-07-05 Thread GitBox
codecov-commenter edited a comment on pull request #3227: URL: https://github.com/apache/hudi/pull/3227#issuecomment-874434905 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3227?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The

[GitHub] [hudi] vinothchandar commented on pull request #3172: [HUDI-2069] Refactored String constants

2021-07-05 Thread GitBox
vinothchandar commented on pull request #3172: URL: https://github.com/apache/hudi/pull/3172#issuecomment-874507808 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [hudi] hudi-bot edited a comment on pull request #3172: [HUDI-2069] Refactored String constants

2021-07-05 Thread GitBox
hudi-bot edited a comment on pull request #3172: URL: https://github.com/apache/hudi/pull/3172#issuecomment-869593797 ## CI report: * f1adb6171b97230ab62ab79e5a37482fb2265d79 UNKNOWN * ccb58dbea708897cade27111bafffedf067f3e87 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-

[GitHub] [hudi] sbernauer commented on pull request #3172: [HUDI-2069] Refactored String constants

2021-07-05 Thread GitBox
sbernauer commented on pull request #3172: URL: https://github.com/apache/hudi/pull/3172#issuecomment-874509363 Thanks @vinothchandar! As the patch uses the ConfigProperty class the generation of the docs should work fine as my understanding -- This is an automated message from the Ap

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3227: [HUDI-2136] Fix packet conflict when flink-sql-connector-hive and hud…

2021-07-05 Thread GitBox
codecov-commenter edited a comment on pull request #3227: URL: https://github.com/apache/hudi/pull/3227#issuecomment-874434905 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3227?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The

[GitHub] [hudi] vinothchandar commented on a change in pull request #2206: [HUDI-1105] Adding dedup support for Bulk Insert w/ Rows

2021-07-06 Thread GitBox
vinothchandar commented on a change in pull request #2206: URL: https://github.com/apache/hudi/pull/2206#discussion_r664284205 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java ## @@ -98,6 +98,8 @@ public static final S

[GitHub] [hudi] vinothchandar commented on a change in pull request #3075: [HUDI-2009] Fixing extra commit metadata in row writer path

2021-07-06 Thread GitBox
vinothchandar commented on a change in pull request #3075: URL: https://github.com/apache/hudi/pull/3075#discussion_r660152303 ## File path: hudi-spark-datasource/hudi-spark-common/src/main/java/org/apache/hudi/DataSourceUtils.java ## @@ -111,6 +112,18 @@ public static HoodieR

[GitHub] [hudi] wangxianghu commented on pull request #2963: [HUDI-1904] Introduce SchemaProviderInterface to make SchemaProvider unified

2021-07-06 Thread GitBox
wangxianghu commented on pull request #2963: URL: https://github.com/apache/hudi/pull/2963#issuecomment-874518387 Hi, @vinothchandar, any thoughts on the pr? In this patch, I introduced a `SchemaProviderInterface ` as the base class of all `SchemaProvider`s and it is engine-free. it i

[GitHub] [hudi] sbernauer commented on a change in pull request #3129: [HUDI-2055] Added metric for time of lastSync

2021-07-06 Thread GitBox
sbernauer commented on a change in pull request #3129: URL: https://github.com/apache/hudi/pull/3129#discussion_r664294219 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java ## @@ -289,6 +289,8 @@ public void refreshTimeline() thr

[GitHub] [hudi] wangxianghu merged pull request #3177: [HUDI-2093] Fix empty avro schema path caused by duplicate parameters

2021-07-06 Thread GitBox
wangxianghu merged pull request #3177: URL: https://github.com/apache/hudi/pull/3177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [hudi] vinothchandar commented on a change in pull request #3075: [HUDI-2009] Fixing extra commit metadata in row writer path

2021-07-06 Thread GitBox
vinothchandar commented on a change in pull request #3075: URL: https://github.com/apache/hudi/pull/3075#discussion_r664291612 ## File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala ## @@ -337,6 +337,11 @@ object HoodieSparkSql

[GitHub] [hudi] rmahindra123 opened a new pull request #3228: [HUDI-2138] Add Parquest Log Formats

2021-07-06 Thread GitBox
rmahindra123 opened a new pull request #3228: URL: https://github.com/apache/hudi/pull/3228 WIP PR for Add Parquest Log Formats -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [hudi] hudi-bot commented on pull request #3228: [HUDI-2138] Add Parquest Log Formats

2021-07-06 Thread GitBox
hudi-bot commented on pull request #3228: URL: https://github.com/apache/hudi/pull/3228#issuecomment-874522164 ## CI report: * 169a9b4f401bfabd2c23ec2cf999a806f7cb5fe8 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis`

[GitHub] [hudi] hudi-bot edited a comment on pull request #3228: [HUDI-2138] Add Parquest Log Formats

2021-07-06 Thread GitBox
hudi-bot edited a comment on pull request #3228: URL: https://github.com/apache/hudi/pull/3228#issuecomment-874522164 ## CI report: * 169a9b4f401bfabd2c23ec2cf999a806f7cb5fe8 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/res

[GitHub] [hudi] wangxianghu opened a new pull request #3229: [HUDI-2120] Update docs about schema in flink sql configuration

2021-07-06 Thread GitBox
wangxianghu opened a new pull request #3229: URL: https://github.com/apache/hudi/pull/3229 ## *Tips* - *Thank you very much for contributing to Apache Hudi.* - *Please review https://hudi.apache.org/contributing.html before opening a pull request.* ## What is the purpose of the

[GitHub] [hudi] codecov-commenter commented on pull request #3228: [HUDI-2138] Add Parquest Log Formats

2021-07-06 Thread GitBox
codecov-commenter commented on pull request #3228: URL: https://github.com/apache/hudi/pull/3228#issuecomment-874525846 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3228?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache

[GitHub] [hudi] minihippo commented on a change in pull request #3193: [HUDI-2107] Support Read Log Only MOR Table For Spark

2021-07-06 Thread GitBox
minihippo commented on a change in pull request #3193: URL: https://github.com/apache/hudi/pull/3193#discussion_r664301524 ## File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieRealtimeInputFormatUtils.java ## @@ -161,29 +162,21 @@ .map(ins

[GitHub] [hudi] minihippo commented on a change in pull request #3193: [HUDI-2107] Support Read Log Only MOR Table For Spark

2021-07-06 Thread GitBox
minihippo commented on a change in pull request #3193: URL: https://github.com/apache/hudi/pull/3193#discussion_r664301735 ## File path: hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestMergeIntoTable2.scala ## @@ -0,0 +1,91 @@ +/* + * Licensed to

[GitHub] [hudi] minihippo commented on pull request #3193: [HUDI-2107] Support Read Log Only MOR Table For Spark

2021-07-06 Thread GitBox
minihippo commented on pull request #3193: URL: https://github.com/apache/hudi/pull/3193#issuecomment-874526750 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] vinothchandar commented on a change in pull request #3149: [HUDI-1104] Adding support for UserDefinedPartitioners and SortModes to BulkInsert with Rows

2021-07-06 Thread GitBox
vinothchandar commented on a change in pull request #3149: URL: https://github.com/apache/hudi/pull/3149#discussion_r664297381 ## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/BulkInsertInternalPartitionerWithRowsFactory.java ## @@

[GitHub] [hudi] hudi-bot edited a comment on pull request #3204: [HUDI-2113] Fix integration testing failure caused by sql results out…

2021-07-06 Thread GitBox
hudi-bot edited a comment on pull request #3204: URL: https://github.com/apache/hudi/pull/3204#issuecomment-872103083 ## CI report: * 77b28cfdc6e32bbe814f7458eb550328b97536ac UNKNOWN * 294dce2a9f868f77dbd6749664ae6343ae42c739 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3204: [HUDI-2113] Fix integration testing failure caused by sql results out…

2021-07-06 Thread GitBox
codecov-commenter edited a comment on pull request #3204: URL: https://github.com/apache/hudi/pull/3204#issuecomment-872321846 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3204?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The

[GitHub] [hudi] vinothchandar commented on pull request #3204: [HUDI-2113] Fix integration testing failure caused by sql results out…

2021-07-06 Thread GitBox
vinothchandar commented on pull request #3204: URL: https://github.com/apache/hudi/pull/3204#issuecomment-874531477 azure passes here. https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=732&view=results -- This is an automated message from the Apache Git Servi

[GitHub] [hudi] vinothchandar merged pull request #3204: [HUDI-2113] Fix integration testing failure caused by sql results out…

2021-07-06 Thread GitBox
vinothchandar merged pull request #3204: URL: https://github.com/apache/hudi/pull/3204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [hudi] vinothchandar commented on a change in pull request #3083: [HUDI-2016] Fixed bootstrap of Metadata Table when some actions are in progress.

2021-07-06 Thread GitBox
vinothchandar commented on a change in pull request #3083: URL: https://github.com/apache/hudi/pull/3083#discussion_r664311668 ## File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/metadata/TestHoodieBackedMetadata.java ## @@ -120,46 +120,63 @@ public void

[GitHub] [hudi] hudi-bot edited a comment on pull request #3172: [HUDI-2069] Refactored String constants

2021-07-06 Thread GitBox
hudi-bot edited a comment on pull request #3172: URL: https://github.com/apache/hudi/pull/3172#issuecomment-869593797 ## CI report: * f1adb6171b97230ab62ab79e5a37482fb2265d79 UNKNOWN * ccb58dbea708897cade27111bafffedf067f3e87 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-

[GitHub] [hudi] xiarixiaoyao commented on a change in pull request #3181: [HUDI-2059] When log exists in mor table, clustering is triggered. The query result shows that the update record in log is los

2021-07-06 Thread GitBox
xiarixiaoyao commented on a change in pull request #3181: URL: https://github.com/apache/hudi/pull/3181#discussion_r664316683 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieFileSliceReader.java ## @@ -41,11 +43,26 @@ while (baseIterator.has

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3228: [HUDI-2138] Add Parquet Log Block Formats

2021-07-06 Thread GitBox
codecov-commenter edited a comment on pull request #3228: URL: https://github.com/apache/hudi/pull/3228#issuecomment-874525846 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3228?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The

[GitHub] [hudi] codecov-commenter commented on pull request #3229: [HUDI-2120] [DOC] Update docs about schema in flink sql configuration

2021-07-06 Thread GitBox
codecov-commenter commented on pull request #3229: URL: https://github.com/apache/hudi/pull/3229#issuecomment-874552723 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3229?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3229: [HUDI-2120] [DOC] Update docs about schema in flink sql configuration

2021-07-06 Thread GitBox
codecov-commenter edited a comment on pull request #3229: URL: https://github.com/apache/hudi/pull/3229#issuecomment-874552723 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3229?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3228: [HUDI-2138] Add Parquet Log Block Formats

2021-07-06 Thread GitBox
codecov-commenter edited a comment on pull request #3228: URL: https://github.com/apache/hudi/pull/3228#issuecomment-874525846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [hudi] LiLiu88 commented on issue #1823: [SUPPORT] MOR trigger compaction from Hudi CLI

2021-07-06 Thread GitBox
LiLiu88 commented on issue #1823: URL: https://github.com/apache/hudi/issues/1823#issuecomment-874558679 > @RajasekarSribalan For your first question, unfortunately currently in Spark Streaming writes only support inline compaction is supported. So you have to enable that config. Good news

[GitHub] [hudi] garyli1019 commented on a change in pull request #3181: [HUDI-2059] When log exists in mor table, clustering is triggered. The query result shows that the update record in log is lost

2021-07-06 Thread GitBox
garyli1019 commented on a change in pull request #3181: URL: https://github.com/apache/hudi/pull/3181#discussion_r664342311 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieFileSliceReader.java ## @@ -41,11 +43,26 @@ while (baseIterator.hasNe

[GitHub] [hudi] hudi-bot edited a comment on pull request #3228: [HUDI-2138] Add Parquet Log Block Formats

2021-07-06 Thread GitBox
hudi-bot edited a comment on pull request #3228: URL: https://github.com/apache/hudi/pull/3228#issuecomment-874522164 ## CI report: * 169a9b4f401bfabd2c23ec2cf999a806f7cb5fe8 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/res

[GitHub] [hudi] xiarixiaoyao commented on a change in pull request #3193: [HUDI-2107] Support Read Log Only MOR Table For Spark

2021-07-06 Thread GitBox
xiarixiaoyao commented on a change in pull request #3193: URL: https://github.com/apache/hudi/pull/3193#discussion_r664363268 ## File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/MergeOnReadSnapshotRelation.scala ## @@ -137,11 +136,14 @@ class MergeOnR

[GitHub] [hudi] hudi-bot edited a comment on pull request #3183: [HUDI-2090] When hudi metadata is enabled, use different users to quer…

2021-07-06 Thread GitBox
hudi-bot edited a comment on pull request #3183: URL: https://github.com/apache/hudi/pull/3183#issuecomment-870395156 ## CI report: * b638e7aee4a4d39972fec2c29e6071ece6ab0c36 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/res

[GitHub] [hudi] hudi-bot edited a comment on pull request #3183: [HUDI-2090] When hudi metadata is enabled, use different users to quer…

2021-07-06 Thread GitBox
hudi-bot edited a comment on pull request #3183: URL: https://github.com/apache/hudi/pull/3183#issuecomment-870395156 ## CI report: * b638e7aee4a4d39972fec2c29e6071ece6ab0c36 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/res

[GitHub] [hudi] pengzhiwei2018 opened a new pull request #3230: [HUDI-2139] MergeInto MOR Table May Result InCorrect Result

2021-07-06 Thread GitBox
pengzhiwei2018 opened a new pull request #3230: URL: https://github.com/apache/hudi/pull/3230 ## What is the purpose of the pull request Currently we process all the update-action and inert-action in the ExpressionPayload# getInsertValue without know whether the record is

[GitHub] [hudi] wangxianghu commented on pull request #2445: [HUDI-1633] Make callback return HoodieWriteStat

2021-07-06 Thread GitBox
wangxianghu commented on pull request #2445: URL: https://github.com/apache/hudi/pull/2445#issuecomment-874604298 @yanghua any other concern? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hudi] veenaypatil commented on pull request #3222: [HUDI-2083] Support Hudi Cli to work with S3

2021-07-06 Thread GitBox
veenaypatil commented on pull request #3222: URL: https://github.com/apache/hudi/pull/3222#issuecomment-874605197 CI has failed as integration tests is failing because of excluding Hadoop dependencies, will check this out -- This is an automated message from the Apache Git Service. To re

[GitHub] [hudi] hudi-bot commented on pull request #3230: [HUDI-2139] MergeInto MOR Table May Result InCorrect Result

2021-07-06 Thread GitBox
hudi-bot commented on pull request #3230: URL: https://github.com/apache/hudi/pull/3230#issuecomment-874605269 ## CI report: * 410630ca9e81fc54ca91727abbb1c7b8f7f75f30 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis`

[GitHub] [hudi] hudi-bot edited a comment on pull request #3230: [HUDI-2139] MergeInto MOR Table May Result InCorrect Result

2021-07-06 Thread GitBox
hudi-bot edited a comment on pull request #3230: URL: https://github.com/apache/hudi/pull/3230#issuecomment-874605269 ## CI report: * 410630ca9e81fc54ca91727abbb1c7b8f7f75f30 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/res

[GitHub] [hudi] hudi-bot edited a comment on pull request #3183: [HUDI-2090] When hudi metadata is enabled, use different users to quer…

2021-07-06 Thread GitBox
hudi-bot edited a comment on pull request #3183: URL: https://github.com/apache/hudi/pull/3183#issuecomment-870395156 ## CI report: * b638e7aee4a4d39972fec2c29e6071ece6ab0c36 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/res

[GitHub] [hudi] hudi-bot edited a comment on pull request #3183: [HUDI-2090] When hudi metadata is enabled, use different users to quer…

2021-07-06 Thread GitBox
hudi-bot edited a comment on pull request #3183: URL: https://github.com/apache/hudi/pull/3183#issuecomment-870395156 ## CI report: * 07b13f858e54bbb79527376badaf7436b0c7c8df Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/re

[GitHub] [hudi] hudi-bot edited a comment on pull request #3230: [HUDI-2139] MergeInto MOR Table May Result InCorrect Result

2021-07-06 Thread GitBox
hudi-bot edited a comment on pull request #3230: URL: https://github.com/apache/hudi/pull/3230#issuecomment-874605269 ## CI report: * 410630ca9e81fc54ca91727abbb1c7b8f7f75f30 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/re

[GitHub] [hudi] pengzhiwei2018 commented on a change in pull request #3193: [HUDI-2107] Support Read Log Only MOR Table For Spark

2021-07-06 Thread GitBox
pengzhiwei2018 commented on a change in pull request #3193: URL: https://github.com/apache/hudi/pull/3193#discussion_r664402382 ## File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieRealtimeInputFormatUtils.java ## @@ -161,29 +162,21 @@ .ma

[GitHub] [hudi] hudi-bot edited a comment on pull request #3193: [HUDI-2107] Support Read Log Only MOR Table For Spark

2021-07-06 Thread GitBox
hudi-bot edited a comment on pull request #3193: URL: https://github.com/apache/hudi/pull/3193#issuecomment-871363205 ## CI report: * 864dff7a0cc4389905067abee96046d5f72b004f UNKNOWN * f8bac2f4e7133eb3f9cbe4c15a20da49e30dd6eb UNKNOWN * 2a1ce1b4b826344ec024bd51b8af5ee5543a098

[GitHub] [hudi] pengzhiwei2018 commented on a change in pull request #3193: [HUDI-2107] Support Read Log Only MOR Table For Spark

2021-07-06 Thread GitBox
pengzhiwei2018 commented on a change in pull request #3193: URL: https://github.com/apache/hudi/pull/3193#discussion_r664403979 ## File path: hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestMergeIntoTable2.scala ## @@ -0,0 +1,91 @@ +/* + * License

[GitHub] [hudi] hudi-bot edited a comment on pull request #3193: [HUDI-2107] Support Read Log Only MOR Table For Spark

2021-07-06 Thread GitBox
hudi-bot edited a comment on pull request #3193: URL: https://github.com/apache/hudi/pull/3193#issuecomment-871363205 ## CI report: * 864dff7a0cc4389905067abee96046d5f72b004f UNKNOWN * f8bac2f4e7133eb3f9cbe4c15a20da49e30dd6eb UNKNOWN * 2a1ce1b4b826344ec024bd51b8af5ee5543a098

[GitHub] [hudi] yanghua commented on pull request #2445: [HUDI-1633] Make callback return HoodieWriteStat

2021-07-06 Thread GitBox
yanghua commented on pull request #2445: URL: https://github.com/apache/hudi/pull/2445#issuecomment-874622996 > @yanghua any other concern? No, also wait to address vc's concern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [hudi] codecov-commenter commented on pull request #3230: [HUDI-2139] MergeInto MOR Table May Result InCorrect Result

2021-07-06 Thread GitBox
codecov-commenter commented on pull request #3230: URL: https://github.com/apache/hudi/pull/3230#issuecomment-874628171 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3230?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3183: [HUDI-2090] When hudi metadata is enabled, use different users to quer…

2021-07-06 Thread GitBox
codecov-commenter edited a comment on pull request #3183: URL: https://github.com/apache/hudi/pull/3183#issuecomment-870529423 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3183?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The

[GitHub] [hudi] hudi-bot edited a comment on pull request #3227: [HUDI-2136] Fix conflict when flink-sql-connector-hive and hudi-flink-bundle are both in flink lib

2021-07-06 Thread GitBox
hudi-bot edited a comment on pull request #3227: URL: https://github.com/apache/hudi/pull/3227#issuecomment-874432157 ## CI report: * 44e5d15b93bbd6082af9977796bc6309768f21dd Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/res

[GitHub] [hudi] hudi-bot edited a comment on pull request #3227: [HUDI-2136] Fix conflict when flink-sql-connector-hive and hudi-flink-bundle are both in flink lib

2021-07-06 Thread GitBox
hudi-bot edited a comment on pull request #3227: URL: https://github.com/apache/hudi/pull/3227#issuecomment-874432157 ## CI report: * 44e5d15b93bbd6082af9977796bc6309768f21dd Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/res

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3193: [HUDI-2107] Support Read Log Only MOR Table For Spark

2021-07-06 Thread GitBox
codecov-commenter edited a comment on pull request #3193: URL: https://github.com/apache/hudi/pull/3193#issuecomment-871511739 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3193?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3230: [HUDI-2139] MergeInto MOR Table May Result InCorrect Result

2021-07-06 Thread GitBox
codecov-commenter edited a comment on pull request #3230: URL: https://github.com/apache/hudi/pull/3230#issuecomment-874628171 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3230?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3183: [HUDI-2090] When hudi metadata is enabled, use different users to quer…

2021-07-06 Thread GitBox
codecov-commenter edited a comment on pull request #3183: URL: https://github.com/apache/hudi/pull/3183#issuecomment-870529423 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3183?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The

[GitHub] [hudi] hudi-bot edited a comment on pull request #3183: [HUDI-2090] When hudi metadata is enabled, use different users to quer…

2021-07-06 Thread GitBox
hudi-bot edited a comment on pull request #3183: URL: https://github.com/apache/hudi/pull/3183#issuecomment-870395156 ## CI report: * 07b13f858e54bbb79527376badaf7436b0c7c8df Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/re

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3183: [HUDI-2090] When hudi metadata is enabled, use different users to quer…

2021-07-06 Thread GitBox
codecov-commenter edited a comment on pull request #3183: URL: https://github.com/apache/hudi/pull/3183#issuecomment-870529423 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3183?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The

[GitHub] [hudi] hudi-bot edited a comment on pull request #3230: [HUDI-2139] MergeInto MOR Table May Result InCorrect Result

2021-07-06 Thread GitBox
hudi-bot edited a comment on pull request #3230: URL: https://github.com/apache/hudi/pull/3230#issuecomment-874605269 ## CI report: * 410630ca9e81fc54ca91727abbb1c7b8f7f75f30 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/re

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3193: [HUDI-2107] Support Read Log Only MOR Table For Spark

2021-07-06 Thread GitBox
codecov-commenter edited a comment on pull request #3193: URL: https://github.com/apache/hudi/pull/3193#issuecomment-871511739 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3193?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3193: [HUDI-2107] Support Read Log Only MOR Table For Spark

2021-07-06 Thread GitBox
codecov-commenter edited a comment on pull request #3193: URL: https://github.com/apache/hudi/pull/3193#issuecomment-871511739 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3193?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The

[GitHub] [hudi] hudi-bot edited a comment on pull request #3193: [HUDI-2107] Support Read Log Only MOR Table For Spark

2021-07-06 Thread GitBox
hudi-bot edited a comment on pull request #3193: URL: https://github.com/apache/hudi/pull/3193#issuecomment-871363205 ## CI report: * 864dff7a0cc4389905067abee96046d5f72b004f UNKNOWN * f8bac2f4e7133eb3f9cbe4c15a20da49e30dd6eb UNKNOWN * 2a1ce1b4b826344ec024bd51b8af5ee5543a098

[GitHub] [hudi] codecov-commenter commented on pull request #3195: [HUDI-2109] Update AvroConversionHelper to deal with NULLS

2021-07-06 Thread GitBox
codecov-commenter commented on pull request #3195: URL: https://github.com/apache/hudi/pull/3195#issuecomment-874662159 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3195?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache

[GitHub] [hudi] hudi-bot edited a comment on pull request #3154: [HUDI-1884] MergeInto Support Partial Update For COW

2021-07-06 Thread GitBox
hudi-bot edited a comment on pull request #3154: URL: https://github.com/apache/hudi/pull/3154#issuecomment-868360998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] codecov-commenter commented on pull request #3223: [HUDI-2132] Add default constructor to coordinator events for efficie…

2021-07-06 Thread GitBox
codecov-commenter commented on pull request #3223: URL: https://github.com/apache/hudi/pull/3223#issuecomment-873980133 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3223?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache

[GitHub] [hudi] yanghua commented on pull request #3223: [HUDI-2132] Add default constructor to coordinator events for efficie…

2021-07-06 Thread GitBox
yanghua commented on pull request #3223: URL: https://github.com/apache/hudi/pull/3223#issuecomment-874062133 The changes of this PR beyond the scope described via the title. IMO, it would be better to change the title of the PR. -- This is an automated message from the Apache Git Servic

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3223: [HUDI-2132] Add default constructor to coordinator events for efficie…

2021-07-06 Thread GitBox
codecov-commenter edited a comment on pull request #3223: URL: https://github.com/apache/hudi/pull/3223#issuecomment-873980133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [hudi] Samrat002 commented on pull request #3184: [HUDI-1860] Add INSERT_OVERWRITE and INSERT_OVERWRITE_TABLE support to DeltaStreamer

2021-07-06 Thread GitBox
Samrat002 commented on pull request #3184: URL: https://github.com/apache/hudi/pull/3184#issuecomment-874086074 @codope I have added the tests for both `INSER_OVERWRITE` and `INSERT_OVERWRITE_TABLE` . please review ^ -- This is an automated message from the Apache Git Service. To

[GitHub] [hudi] codope commented on issue #3218: [SUPPORT]Failed to cluster the hudi COW table using HoodieClusteringJob

2021-07-06 Thread GitBox
codope commented on issue #3218: URL: https://github.com/apache/hudi/issues/3218#issuecomment-874166812 @Tandoy The `HoodieClusteringJob` has two steps: 1. Schedule clustering (which is the `spark-submit` with `--schedule` option). As seen in the logs screenshot, this gives the insta

[GitHub] [hudi] xiarixiaoyao commented on a change in pull request #3139: [HUDI-2058]support incremental query for insert_overwrite_table/insert_overwrite operation on cow table

2021-07-06 Thread GitBox
xiarixiaoyao commented on a change in pull request #3139: URL: https://github.com/apache/hudi/pull/3139#discussion_r663752808 ## File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/IncrementalRelation.scala ## @@ -96,14 +100,31 @@ class IncrementalRelati

[GitHub] [hudi] danny0405 commented on pull request #3223: [HUDI-2132] Make coordinator events as POJO for efficient serialization

2021-07-06 Thread GitBox
danny0405 commented on pull request #3223: URL: https://github.com/apache/hudi/pull/3223#issuecomment-874086108 > The changes of this PR beyond the scope described via the title. IMO, it would be better to change the title of the PR. Agree, have changed the title. -- This is an au

[GitHub] [hudi] hudi-bot commented on pull request #2199: [HUDI-1264][WIP] spark incremental read support with replace

2021-07-06 Thread GitBox
hudi-bot commented on pull request #2199: URL: https://github.com/apache/hudi/pull/2199#issuecomment-874049537 ## CI report: * c39aaac4f94125ae8de331639ec3343c60463b8f UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis`

[GitHub] [hudi] danny0405 commented on pull request #3162: [HUDI-1872] Move HoodieFlinkStreamer to hudi-utilities module

2021-07-06 Thread GitBox
danny0405 commented on pull request #3162: URL: https://github.com/apache/hudi/pull/3162#issuecomment-873887560 Fine with the change, we may need to test the new jar in to make sure the dependencies. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3193: [HUDI-2107] Support Read Log Only MOR Table For Spark

2021-07-06 Thread GitBox
codecov-commenter edited a comment on pull request #3193: URL: https://github.com/apache/hudi/pull/3193#issuecomment-871511739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [hudi] hudi-bot commented on pull request #3224: [HUDI-2131] Exception Throw Out When MergeInto With Decimal Type Field

2021-07-06 Thread GitBox
hudi-bot commented on pull request #3224: URL: https://github.com/apache/hudi/pull/3224#issuecomment-873886456 ## CI report: * 55eca815dccd7d7cf46c7f833fdd88f26937fcb8 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis`

[GitHub] [hudi] veenaypatil commented on pull request #3162: [HUDI-1872] Move HoodieFlinkStreamer to hudi-utilities module

2021-07-06 Thread GitBox
veenaypatil commented on pull request #3162: URL: https://github.com/apache/hudi/pull/3162#issuecomment-873892345 @danny0405 @wangxianghu I have not tested this change yet on cluster, I have never tested FlinkStreamer earlier, will checkout and let you know -- This is an automated messa

<    2   3   4   5   6   7   8   9   10   11   >