[GitHub] [incubator-hudi] dengziming commented on a change in pull request #1151: [HUDI-476] Add hudi-examples module
dengziming commented on a change in pull request #1151:
URL: https://github.com/apache/incubator-hudi/pull/1151#discussion_r425577242
##
File path: hudi-examples/pom.xml
##
@@ -0,0 +1,198 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+
+hudi
+org.apache.hudi
+0.6.0-SNAPSHOT
+
+ 4.0.0
+
+ hudi-examples
+ jar
+
+
+${project.parent.basedir}
+
+
+
+
+
+src/main/resources
+
+
+
+
+
+org.apache.maven.plugins
+maven-dependency-plugin
+
+
+copy-dependencies
+prepare-package
+
+ copy-dependencies
+
+
+ ${project.build.directory}/lib
+ true
+ true
+ true
+
+
+
+
+
+net.alchim31.maven
+scala-maven-plugin
+
+
+scala-compile-first
+process-resources
+
+ add-source
+ compile
+
+
+
+
+
+org.apache.maven.plugins
+maven-compiler-plugin
+
+
+compile
+
+ compile
+
+
+
+
+
+org.apache.maven.plugins
+maven-jar-plugin
+
+
+
+ test-jar
+
+test-compile
+
+
+
+ false
+
+
+
+org.apache.rat
+apache-rat-plugin
+
+
+
+
+
+
+
+ org.scala-lang
+ scala-library
+ ${scala.version}
+
+
+
+ org.apache.hudi
+ hudi-common
+ ${project.version}
+
+
+
+ org.apache.hudi
+ hudi-cli
+ ${project.version}
+
+
+
+ org.apache.hudi
+ hudi-client
+ ${project.version}
+
+
+
+ org.apache.hudi
+ hudi-utilities_${scala.binary.version}
+ ${project.version}
+
+
+
+ org.apache.hudi
+ hudi-spark_${scala.binary.version}
+ ${project.version}
+
+
+
+ org.apache.hudi
+ hudi-hadoop-mr
+ ${project.version}
Review comment:
the build process will fail if versions are removed, and other module
also have `project.version` in the dependencies.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-hudi] dengziming commented on a change in pull request #1151: [HUDI-476] Add hudi-examples module
dengziming commented on a change in pull request #1151: [HUDI-476] Add
hudi-examples module
URL: https://github.com/apache/incubator-hudi/pull/1151#discussion_r390827545
##
File path:
hudi-examples/src/main/java/org/apache/hudi/examples/deltastreamer/HoodieDeltaStreamerDfsSourceExample.java
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.examples.deltastreamer;
+
+import org.apache.hudi.DataSourceWriteOptions;
+import org.apache.hudi.examples.common.HoodieExampleDataGenerator;
+import org.apache.hudi.examples.common.HoodieExampleSparkUtils;
+import org.apache.hudi.utilities.deltastreamer.HoodieDeltaStreamer;
+import org.apache.hudi.utilities.sources.JsonDFSSource;
+import org.apache.hudi.utilities.transform.IdentityTransformer;
+
+import com.beust.jcommander.JCommander;
+import org.apache.spark.SparkConf;
+import org.apache.spark.api.java.JavaSparkContext;
+
+
+/**
+ * Simple examples of #{@link HoodieDeltaStreamer} from #{@link JsonDFSSource}.
+ *
+ * To run this example, you should
+ * 1. prepare sample data as
`hudi-examples/src/main/resources/dfs-delta-streamer`
+ * 2. For running in IDE, set VM options `-Dspark.master=local[2]`
+ * 3. For running in shell, using `spark-submit`
+ *
+ * Usage: HoodieDeltaStreamerDfsSourceExample \
Review comment:
This is a good idea, I will try to extract the data prep part themselves.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] dengziming commented on a change in pull request #1151: [HUDI-476] Add hudi-examples module
dengziming commented on a change in pull request #1151: [HUDI-476] Add
hudi-examples module
URL: https://github.com/apache/incubator-hudi/pull/1151#discussion_r390818477
##
File path:
hudi-examples/src/main/java/org/apache/hudi/examples/deltastreamer/HoodieDeltaStreamerDfsSourceExample.java
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.examples.deltastreamer;
+
+import org.apache.hudi.DataSourceWriteOptions;
+import org.apache.hudi.examples.common.HoodieExampleDataGenerator;
+import org.apache.hudi.examples.common.HoodieExampleSparkUtils;
+import org.apache.hudi.utilities.deltastreamer.HoodieDeltaStreamer;
+import org.apache.hudi.utilities.sources.JsonDFSSource;
+import org.apache.hudi.utilities.transform.IdentityTransformer;
+
+import com.beust.jcommander.JCommander;
+import org.apache.spark.SparkConf;
+import org.apache.spark.api.java.JavaSparkContext;
+
+
+/**
+ * Simple examples of #{@link HoodieDeltaStreamer} from #{@link JsonDFSSource}.
+ *
+ * To run this example, you should
+ * 1. prepare sample data as
`hudi-examples/src/main/resources/dfs-delta-streamer`
+ * 2. For running in IDE, set VM options `-Dspark.master=local[2]`
+ * 3. For running in shell, using `spark-submit`
+ *
+ * Usage: HoodieDeltaStreamerDfsSourceExample \
+ *--target-base-path /tmp/hoodie/dfsdeltatable \
+ *--table-type MERGE_ON_READ \
+ *--target-table dfsdeltatable
+ *
+ */
+public class HoodieDeltaStreamerDfsSourceExample {
+
+ public static void main(String[] args) throws Exception {
+
+final HoodieDeltaStreamer.Config cfg = defaultDfsStreamerConfig();
Review comment:
The advantage of adding these configs in code is that developers and users
can execute them directly, and the main function of examples is just to give
users some tutorials, they will remove the hardcode when developing their own
application, so we can remain them.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] dengziming commented on a change in pull request #1151: [HUDI-476] Add hudi-examples module
dengziming commented on a change in pull request #1151: [HUDI-476] Add
hudi-examples module
URL: https://github.com/apache/incubator-hudi/pull/1151#discussion_r390802033
##
File path: hudi-examples/pom.xml
##
@@ -0,0 +1,206 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+
+hudi
+org.apache.hudi
+0.5.2-SNAPSHOT
+
+ 4.0.0
+
+ hudi-examples
+ jar
+
+
+${project.parent.basedir}
+
+
+
+
+
+src/main/resources
+
+
+
+
+
+org.apache.maven.plugins
Review comment:
I think it's better to not have a fat jar here and add a
`run_hudi_example.sh`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] dengziming commented on a change in pull request #1151: [HUDI-476] Add hudi-examples module
dengziming commented on a change in pull request #1151: [HUDI-476] Add
hudi-examples module
URL: https://github.com/apache/incubator-hudi/pull/1151#discussion_r390802033
##
File path: hudi-examples/pom.xml
##
@@ -0,0 +1,206 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+
+hudi
+org.apache.hudi
+0.5.2-SNAPSHOT
+
+ 4.0.0
+
+ hudi-examples
+ jar
+
+
+${project.parent.basedir}
+
+
+
+
+
+src/main/resources
+
+
+
+
+
+org.apache.maven.plugins
Review comment:
I think it's better to not have a fat jar here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] dengziming commented on a change in pull request #1151: [HUDI-476] Add hudi-examples module
dengziming commented on a change in pull request #1151: [HUDI-476] Add
hudi-examples module
URL: https://github.com/apache/incubator-hudi/pull/1151#discussion_r379895663
##
File path:
hudi-examples/src/main/java/org/apache/hudi/examples/deltastreamer/HoodieDeltaStreamerDfsSourceExample.java
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.examples.deltastreamer;
+
+import org.apache.hudi.DataSourceWriteOptions;
+import org.apache.hudi.examples.common.HoodieExampleDataGenerator;
+import org.apache.hudi.examples.common.HoodieExampleSparkUtils;
+import org.apache.hudi.utilities.deltastreamer.HoodieDeltaStreamer;
+import org.apache.hudi.utilities.sources.JsonDFSSource;
+import org.apache.hudi.utilities.transform.IdentityTransformer;
+
+import com.beust.jcommander.JCommander;
+import org.apache.spark.SparkConf;
+import org.apache.spark.api.java.JavaSparkContext;
+
+
+/**
+ * Simple examples of #{@link HoodieDeltaStreamer} from #{@link JsonDFSSource}.
+ *
+ * To run this example, you should
+ * 1. prepare sample data as
`hudi-examples/src/main/resources/dfs-delta-streamer`
+ * 2. For running in IDE, set VM options `-Dspark.master=local[2]`
+ * 3. For running in shell, using `spark-submit`
+ *
+ * Usage: HoodieDeltaStreamerDfsSourceExample \
Review comment:
You mean, we just add a shell script file to run all these examples?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] dengziming commented on a change in pull request #1151: [HUDI-476] Add hudi-examples module
dengziming commented on a change in pull request #1151: [HUDI-476] Add
hudi-examples module
URL: https://github.com/apache/incubator-hudi/pull/1151#discussion_r379895474
##
File path:
hudi-examples/src/main/java/org/apache/hudi/examples/deltastreamer/HoodieDeltaStreamerDfsSourceExample.java
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.examples.deltastreamer;
+
+import org.apache.hudi.DataSourceWriteOptions;
+import org.apache.hudi.examples.common.HoodieExampleDataGenerator;
+import org.apache.hudi.examples.common.HoodieExampleSparkUtils;
+import org.apache.hudi.utilities.deltastreamer.HoodieDeltaStreamer;
+import org.apache.hudi.utilities.sources.JsonDFSSource;
+import org.apache.hudi.utilities.transform.IdentityTransformer;
+
+import com.beust.jcommander.JCommander;
+import org.apache.spark.SparkConf;
+import org.apache.spark.api.java.JavaSparkContext;
+
+
+/**
+ * Simple examples of #{@link HoodieDeltaStreamer} from #{@link JsonDFSSource}.
+ *
+ * To run this example, you should
+ * 1. prepare sample data as
`hudi-examples/src/main/resources/dfs-delta-streamer`
+ * 2. For running in IDE, set VM options `-Dspark.master=local[2]`
+ * 3. For running in shell, using `spark-submit`
+ *
+ * Usage: HoodieDeltaStreamerDfsSourceExample \
+ *--target-base-path /tmp/hoodie/dfsdeltatable \
+ *--table-type MERGE_ON_READ \
+ *--target-table dfsdeltatable
+ *
+ */
+public class HoodieDeltaStreamerDfsSourceExample {
+
+ public static void main(String[] args) throws Exception {
+
+final HoodieDeltaStreamer.Config cfg = defaultDfsStreamerConfig();
Review comment:
some config is indispensable to run the code, for example we hard code
`configs.put("spark.serializer", "org.apache.spark.serializer.KryoSerializer")`
in every example. So I just hard code some of the required configs and they can
be overwritten by property files or command line. We can just remove the hard
code and add them in the javadocs descriptions, which one do you prefer?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] dengziming commented on a change in pull request #1151: [HUDI-476] Add hudi-examples module
dengziming commented on a change in pull request #1151: [HUDI-476] Add
hudi-examples module
URL: https://github.com/apache/incubator-hudi/pull/1151#discussion_r379895098
##
File path:
hudi-examples/src/main/java/org/apache/hudi/examples/deltastreamer/HoodieDeltaStreamerKafkaSourceExample.java
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.examples.deltastreamer;
+
+import org.apache.hudi.DataSourceWriteOptions;
+import org.apache.hudi.examples.common.HoodieExampleDataGenerator;
+import org.apache.hudi.examples.common.HoodieExampleSparkUtils;
+import org.apache.hudi.utilities.deltastreamer.HoodieDeltaStreamer;
+import org.apache.hudi.utilities.sources.JsonKafkaSource;
+import org.apache.hudi.utilities.transform.IdentityTransformer;
+
+import com.beust.jcommander.JCommander;
+import org.apache.spark.SparkConf;
+import org.apache.spark.api.java.JavaSparkContext;
+
+
+/**
+ * Simple examples of #{@link HoodieDeltaStreamer} from #{@link
JsonKafkaSource}.
+ *
+ * To run this example, you should
+ *1. Start Zookeeper and the Kafka demo server
+ *2. For running in IDE, set VM options `-Dspark.master=local[2]`
+ *3. For running in shell, using `spark-submit`
+ *4. produce some data to hoodie-source-topic configured by
`hoodie.deltastreamer.source.kafka.topic`
+ *
+ * Usage: HoodieDeltaStreamerKafkaSourceExample \
+ *--target-base-path /tmp/hoodie/kafkadeltatable \
+ *--table-type MERGE_ON_READ \
+ *--target-table kafkadeltatable
+ */
+public class HoodieDeltaStreamerKafkaSourceExample {
+
+ public static void main(String[] args) throws Exception {
+
+final HoodieDeltaStreamer.Config cfg = defaultKafkaDeltaStreamerConfig();
+new JCommander(cfg).parse(args);
+
+SparkConf sparkConf =
HoodieExampleSparkUtils.defaultSparkConf("hoodie-delta-streamer-kafka-source-example");
+JavaSparkContext jsc = new JavaSparkContext(sparkConf);
+
+try {
+ new HoodieDeltaStreamer(cfg, jsc).sync();
+} finally {
+ jsc.stop();
+}
+ }
+
+ /**
+ * also see #{@link HoodieDeltaStreamer.Config} for more params.
+ * @return default params for Kafka DeltaStreamer
+ */
+ private static HoodieDeltaStreamer.Config defaultKafkaDeltaStreamerConfig() {
+
+HoodieDeltaStreamer.Config cfg = new HoodieDeltaStreamer.Config();
+
+cfg.configs.add(String.format("%s=uuid",
DataSourceWriteOptions.RECORDKEY_FIELD_OPT_KEY()));
Review comment:
ok, good.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] dengziming commented on a change in pull request #1151: [HUDI-476] Add hudi-examples module
dengziming commented on a change in pull request #1151: [HUDI-476] Add
hudi-examples module
URL: https://github.com/apache/incubator-hudi/pull/1151#discussion_r379894990
##
File path: hudi-examples/pom.xml
##
@@ -0,0 +1,206 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+
+hudi
+org.apache.hudi
+0.5.2-SNAPSHOT
+
+ 4.0.0
+
+ hudi-examples
+ jar
+
+
+${project.parent.basedir}
+
+
+
+
+
+src/main/resources
+
+
+
+
+
+org.apache.maven.plugins
Review comment:
this is just a copy from hudi-spark, do you have a better solution?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] dengziming commented on a change in pull request #1151: [HUDI-476] Add hudi-examples module
dengziming commented on a change in pull request #1151: [HUDI-476] Add
hudi-examples module
URL: https://github.com/apache/incubator-hudi/pull/1151#discussion_r379894998
##
File path: hudi-examples/pom.xml
##
@@ -0,0 +1,206 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+
+hudi
+org.apache.hudi
+0.5.2-SNAPSHOT
+
+ 4.0.0
+
+ hudi-examples
+ jar
+
+
+${project.parent.basedir}
+
+
+
+
+
+src/main/resources
+
+
+
+
+
+org.apache.maven.plugins
+maven-dependency-plugin
+
+
+copy-dependencies
+prepare-package
+
+ copy-dependencies
+
+
+ ${project.build.directory}/lib
+ true
+ true
+ true
+
+
+
+
+
+net.alchim31.maven
+scala-maven-plugin
+
+
+scala-compile-first
+process-resources
+
+ add-source
+ compile
+
+
+
+
+
+org.apache.maven.plugins
+maven-compiler-plugin
+
+
+compile
+
+ compile
+
+
+
+
+
+org.apache.maven.plugins
+maven-jar-plugin
+
+
+
+ test-jar
+
+test-compile
+
+
+
+ false
+
+
+
+org.apache.rat
+apache-rat-plugin
+
+
+
+
+
+
+
+ org.scala-lang
+ scala-library
+ ${scala.version}
+
+
+
+ org.apache.hudi
+ hudi-common
+ ${project.version}
+
+
+
+ org.apache.hudi
+ hudi-cli
+ ${project.version}
+
+
+
+ org.apache.hudi
+ hudi-client
+ ${project.version}
+
+
+
+ org.apache.hudi
+ hudi-utilities_${scala.binary.version}
+ ${project.version}
+
+
+
+ org.apache.hudi
+ hudi-spark_${scala.binary.version}
+ ${project.version}
+
+
+
+ org.apache.hudi
+ hudi-hadoop-mr
+ ${project.version}
+
+
+
+ org.apache.hudi
+ hudi-hive
+ ${project.version}
+
+
+
+ org.apache.hudi
+ hudi-timeline-service
+ ${project.version}
+
+
+
+
+ org.apache.spark
+ spark-core_${scala.binary.version}
+
+
+ org.apache.spark
+ spark-sql_${scala.binary.version}
+
+
+ org.apache.spark
+ spark-avro_${scala.binary.version}
+ provided
Review comment:
fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
