[GitHub] [hudi] liujinhui1994 commented on pull request #2666: [HUDI-1160] Support update partial fields for CoW table

2021-07-21 Thread GitBox
liujinhui1994 commented on pull request #2666: URL: https://github.com/apache/hudi/pull/2666#issuecomment-884002932 @vinothchandar Please take the time to look at @nsivabalan idea of using some of the fields in COW to update. Your guidance and approval would be much appreciated --

[GitHub] [hudi] liujinhui1994 commented on pull request #2666: [HUDI-1160] Support update partial fields for CoW table

2021-07-16 Thread GitBox
liujinhui1994 commented on pull request #2666: URL: https://github.com/apache/hudi/pull/2666#issuecomment-881826299 @nsivabalan hello, I see that some partners have already suggested this idea. [HUDI-1884] MergeInto Support Partial Update For COW Are we still necessary to

[GitHub] [hudi] liujinhui1994 commented on pull request #2666: [HUDI-1160] Support update partial fields for CoW table

2021-04-19 Thread GitBox
liujinhui1994 commented on pull request #2666: URL: https://github.com/apache/hudi/pull/2666#issuecomment-822930145 > > we should still use the old schema with full fields there, for new records with partial values, we can patch them up with a builtin placeholder values > > agree.

[GitHub] [hudi] liujinhui1994 commented on pull request #2666: [HUDI-1160] Support update partial fields for CoW table

2021-04-16 Thread GitBox
liujinhui1994 commented on pull request #2666: URL: https://github.com/apache/hudi/pull/2666#issuecomment-820931906 > > sorry for late turn around on reviewing this. We should definitely get this before next release. > > I am yet to review tests. but few high level thoughts on reviewing

[GitHub] [hudi] liujinhui1994 commented on pull request #2666: [HUDI-1160] Support update partial fields for CoW table

2021-04-01 Thread GitBox
liujinhui1994 commented on pull request #2666: URL: https://github.com/apache/hudi/pull/2666#issuecomment-812290646 Your suggestion is very good, please let me think about it @nsivabalan -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hudi] liujinhui1994 commented on pull request #2666: [HUDI-1160] Support update partial fields for CoW table

2021-04-01 Thread GitBox
liujinhui1994 commented on pull request #2666: URL: https://github.com/apache/hudi/pull/2666#issuecomment-811861142 > @liujinhui1994 : Can you please update the description with an example. 1、old data id nameage 1 liujinhui 26 2 sam 25 3 madeline

[GitHub] [hudi] liujinhui1994 commented on pull request #2666: [HUDI-1160] Support update partial fields for CoW table

2021-04-01 Thread GitBox
liujinhui1994 commented on pull request #2666: URL: https://github.com/apache/hudi/pull/2666#issuecomment-811860789 > @liujinhui1994 : Can you please update the description with an example. 一、old data id nameage 1 liujinhui 26 2 sam 25 3 madeline

[GitHub] [hudi] liujinhui1994 commented on pull request #2666: [HUDI-1160] Support update partial fields for CoW table

2021-03-24 Thread GitBox
liujinhui1994 commented on pull request #2666: URL: https://github.com/apache/hudi/pull/2666#issuecomment-805667943 Maybe after 0.8 is released --原始邮件-- 发件人:

[GitHub] [hudi] liujinhui1994 commented on pull request #2666: [HUDI-1160] Support update partial fields for CoW table

2021-03-24 Thread GitBox
liujinhui1994 commented on pull request #2666: URL: https://github.com/apache/hudi/pull/2666#issuecomment-805655005 @Sugamber This branch should be available -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hudi] liujinhui1994 commented on pull request #2666: [HUDI-1160] Support update partial fields for CoW table

2021-03-16 Thread GitBox
liujinhui1994 commented on pull request #2666: URL: https://github.com/apache/hudi/pull/2666#issuecomment-800745638 There does not seem to be the same function as this PR at the moment @nsivabalan This PR inherits from here, this one https://github.com/apache/hudi/pull/1929

[GitHub] [hudi] liujinhui1994 commented on pull request #2666: [HUDI-1160] Support update partial fields for CoW table

2021-03-15 Thread GitBox
liujinhui1994 commented on pull request #2666: URL: https://github.com/apache/hudi/pull/2666#issuecomment-799193666 @n3nash @satishkotha @yanghua This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hudi] liujinhui1994 commented on pull request #2666: [HUDI-1160] Support update partial fields for CoW table

2021-03-15 Thread GitBox
liujinhui1994 commented on pull request #2666: URL: https://github.com/apache/hudi/pull/2666#issuecomment-799193044 The content in this pr https://github.com/apache/hudi/pull/1929 comment is resolved here, please review