[GitHub] [hudi] nsivabalan commented on pull request #2111: [HUDI-1234] Insert new records regardless of small file when using insert operation

2021-01-18 Thread GitBox
nsivabalan commented on pull request #2111: URL: https://github.com/apache/hudi/pull/2111#issuecomment-762613728 @vinothchandar @SteNicholas : Patch is ready to be reviewed. This is an automated message from the Apache Git

[GitHub] [hudi] nsivabalan commented on pull request #2111: [HUDI-1234] Insert new records regardless of small file when using insert operation

2021-01-15 Thread GitBox
nsivabalan commented on pull request #2111: URL: https://github.com/apache/hudi/pull/2111#issuecomment-761115228 my bad. had to fix the config naming. do not do line by line review for now. This is an automated message from

[GitHub] [hudi] nsivabalan commented on pull request #2111: [HUDI-1234] Insert new records regardless of small file when using insert operation

2021-01-07 Thread GitBox
nsivabalan commented on pull request #2111: URL: https://github.com/apache/hudi/pull/2111#issuecomment-756127108 @vinothchandar : have fixed tests as well. you are good to review. This is an automated message from the

[GitHub] [hudi] nsivabalan commented on pull request #2111: [HUDI-1234] Insert new records regardless of small file when using insert operation

2021-01-06 Thread GitBox
nsivabalan commented on pull request #2111: URL: https://github.com/apache/hudi/pull/2111#issuecomment-755879362 @vinothchandar : I have updated the patch as requested. Mid way in fixing tests(fixed some and ensured that both old and new code path works as expected though). But in the