[GitHub] [incubator-hudi] XuQianJin-Stars commented on a change in pull request #1152: [HUDI-454] Redo hudi-cli log statements using SLF4J

2019-12-30 Thread GitBox 
XuQianJin-Stars commented on a change in pull request #1152: [HUDI-454] Redo 
hudi-cli log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1152#discussion_r361928359
 
 

 ##
 File path: 
hudi-cli/src/main/java/org/apache/hudi/cli/utils/InputStreamConsumer.java
 ##
 @@ -46,7 +47,7 @@ public void run() {
 LOG.info(line);
   }
 } catch (IOException ioe) {
-  LOG.severe(ioe.toString());
+  LOG.error(ioe.toString());
 
 Review comment:
   yes, you are right, The method `ToString()` can remove.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] XuQianJin-Stars commented on a change in pull request #1152: [HUDI-454] Redo hudi-cli log statements using SLF4J

2019-12-29 Thread GitBox 
XuQianJin-Stars commented on a change in pull request #1152: [HUDI-454] Redo 
hudi-cli log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1152#discussion_r361916113
 
 

 ##
 File path: 
hudi-cli/src/main/java/org/apache/hudi/cli/utils/InputStreamConsumer.java
 ##
 @@ -46,7 +47,7 @@ public void run() {
 LOG.info(line);
   }
 } catch (IOException ioe) {
-  LOG.severe(ioe.toString());
+  LOG.error(ioe.toString());
 
 Review comment:
   > Can we simplify it with `LOG.error(ioe);`?
   
   logging  -> SLF4J
   FINEST  -> TRACE
   FINER   -> DEBUG
   FINE-> DEBUG
   CONFIG  -> INFO
   INFO-> INFO
   WARNING -> WARN
   SEVERE  -> ERROR


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services